Re: Some pending pathches for review/commit

2004-09-19 Thread Max Khon
Hi! On Sun, Sep 19, 2004 at 05:47:48PM +0200, Mladen Turk wrote: APR_DECLARE(apr_status_t) apr_thread_join(apr_status_t *retval, apr_thread_t *thd) { -apr_status_t rv; - +apr_status_t rv = APR_SUCCESS; + +if (!thd-td) { +

Re: 1.0

2004-08-09 Thread Max Khon
Hi! On Mon, Aug 09, 2004 at 08:57:09PM +0400, malc wrote: Perhaps im way off on this and please do correct me if i am wrong. Condition variables on Win32 are broken, if you are going to label APR with 1.0 mark and release it right now, without mentioning this fact in big red letters, this

Re: apr win32 bug [PATCH]

2004-08-02 Thread Max Khon
be an overkill. Please look here as well: http://issues.apache.org/bugzilla/show_bug.cgi?id=28460 Bill At 04:52 PM 7/31/2004, Max Khon wrote: Hi! apr_thread_join for win32 is implemented incorrectly: thread handle is destroyed too early (in apr_thread_exit). If apr_thread_exit

apr win32 bug [PATCH]

2004-08-01 Thread Max Khon
Hi! apr_thread_join for win32 is implemented incorrectly: thread handle is destroyed too early (in apr_thread_exit). If apr_thread_exit() is called before apr_thread_join() and new object is created (thread handle is reused) before calling apr_thread_join(), apr_thread_join() will possibly wait