Branko, or one of the root access folks,

  please revert all binary tags apr tags, now.  I've received three reports 
this morning that the files are corrupt when checked out on win32.

  Text files on Win32 have CR/LF endings.  Text files on Unix have LF endings.

  Applications, such as CVS, are responsible for making the appropriate
transformations.

  Text files are not binary.  There are no characters in .dsp files.

  Attached in the correspondence on this issue, if anyone else cares about
the gory details.  more details.
--- Begin Message ---
NO NO NO

Please, use cvs from a win32 machine to assure your non-binary files are
---ALWAYS--- checked out without CR's.  We would no longer be able to follow
changes to the projects from the cvs commit messages.

Bill

----- Original Message -----
From: "Branko Čibej" <[EMAIL PROTECTED]>
To: <dev@apr.apache.org>
Sent: Friday, February 02, 2001 2:12 PM
Subject: MSVC projects should be marked -kb


> I noticed that the APR project files apr.dsp, libapr.dsp,
> test/aprtest.dsp and test/aprtest.dsw are stored in CVS as ordinary text
> files. This is not right: MSVC *requires* \r\n line endings, and
> accidental keyword expansion would be a bad thing.
>
> Could somebody with cvsadmin access please put a "-kb" on those files,
> and make sure they're in DOS format (I can do that after the -kb
> applied). This would also help people (like me) who compile the Win32
> stuff on a Samba share, and those who use the cvs from cygwin.
>
>
> --
> Brane Čibej
>     home:   <[EMAIL PROTECTED]>             http://www.xbc.nu/brane/
>     work:   <[EMAIL PROTECTED]>   http://www.hermes-softlab.com/
>      ACM:   <[EMAIL PROTECTED]>            http://www.acm.org/
>
>

--- End Message ---
--- Begin Message ---
William A. Rowe, Jr. wrote:

NO NO NO

Please, use cvs from a win32 machine to assure your non-binary files are
---ALWAYS--- checked out without CR's.  We would no longer be able to follow
changes to the projects from the cvs commit messages.

No, cvs diff handles these files just fine. Normal text diffs work nicely. It's true though that changing the line-endings format produces one huge diff for the whole file, but otherwise there's no problem.


-kb only means there will be no magic conversions, it doesn't mean a text diff won't work. CVS has other ways to determine whether a file is truly binary (by checking for zero bytes and other strange codes, IIRC).

--
Brane Čibej
   home:   <[EMAIL PROTECTED]>             http://www.xbc.nu/brane/
   work:   <[EMAIL PROTECTED]>   http://www.hermes-softlab.com/
    ACM:   <[EMAIL PROTECTED]>            http://www.acm.org/



--- End Message ---

Reply via email to