Re: Some pending pathches for review/commit

2004-09-22 Thread Ben Laurie
William A. Rowe, Jr. wrote: At 10:47 AM 9/19/2004, Mladen Turk wrote: Actually, it inhibits discussion to do that :( I would like to see Ben Laurie feedback to 2. and 5. since he understand these better than most, and they implicate some unspoken assumptions that he should review. Ben? For your

Some pending pathches for review/commit

2004-09-19 Thread Mladen Turk
Hi, Trying for a third week :). I've posted couple of patches for apr that seems to be lost somewhere. There has been some discussion on some of them, so I'm sending them all at once with brief explanation for each. 1. test_makefile_win.patch The apr/test/Makefile.win is missing a target to build

Re: Some pending pathches for review/commit

2004-09-19 Thread Graham Leggett
Mladen Turk wrote: Trying for a third week :). I've posted couple of patches for apr that seems to be lost somewhere. There has been some discussion on some of them, so I'm sending them all at once with brief explanation for each. I assume the silence represents a lack of disagreement :) I will

Re: Some pending pathches for review/commit

2004-09-19 Thread Max Khon
Hi! On Sun, Sep 19, 2004 at 05:47:48PM +0200, Mladen Turk wrote: APR_DECLARE(apr_status_t) apr_thread_join(apr_status_t *retval, apr_thread_t *thd) { -apr_status_t rv; - +apr_status_t rv = APR_SUCCESS; + +if (!thd-td) { +

Re: Some pending pathches for review/commit

2004-09-19 Thread William A. Rowe, Jr.
At 10:47 AM 9/19/2004, Mladen Turk wrote: Trying for a third week :). Keep trying :) Several project releases distracted a number of users of this list... so I'm sending them all at once with brief explanation for each. Actually, it inhibits discussion to do that :( I would like to see Ben

Some pending pathches for review/commit

2004-09-12 Thread Mladen Turk
Hi, I've posted couple of patches for apr that seems to be lost somewhere. There has been some discussion on some of them, so I'm sending them all at once with brief explanation for each. 1. test_makefile_win.patch The apr/test/Makefile.win is missing a target to build a readchild.exe that test is