Re: [PR] Extract interface and extend TypeData with RawTypeString [aries-typedevent]

2025-02-19 Thread via GitHub
timothyjward merged PR #24: URL: https://github.com/apache/aries-typedevent/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@arie

Re: [PR] Extract interface and extend TypeData with RawTypeString [aries-typedevent]

2025-02-18 Thread via GitHub
timothyjward commented on code in PR #24: URL: https://github.com/apache/aries-typedevent/pull/24#discussion_r1959932665 ## org.apache.aries.typedevent.bus/src/main/java/org/apache/aries/typedevent/bus/impl/EventConverter.java: ## @@ -296,35 +297,41 @@ public Map toUntypedEvent(

Re: [PR] Extract interface and extend TypeData with RawTypeString [aries-typedevent]

2025-02-18 Thread via GitHub
timothyjward commented on code in PR #24: URL: https://github.com/apache/aries-typedevent/pull/24#discussion_r1959932665 ## org.apache.aries.typedevent.bus/src/main/java/org/apache/aries/typedevent/bus/impl/EventConverter.java: ## @@ -296,35 +297,41 @@ public Map toUntypedEvent(

Re: [PR] Extract interface and extend TypeData with RawTypeString [aries-typedevent]

2025-02-18 Thread via GitHub
timothyjward commented on code in PR #24: URL: https://github.com/apache/aries-typedevent/pull/24#discussion_r1959908437 ## org.apache.aries.typedevent.bus/src/main/java/org/apache/aries/typedevent/bus/spi/TypeData.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] Extract interface and extend TypeData with RawTypeString [aries-typedevent]

2025-02-18 Thread via GitHub
timothyjward commented on code in PR #24: URL: https://github.com/apache/aries-typedevent/pull/24#discussion_r1959903460 ## org.apache.aries.typedevent.bus/src/main/java/org/apache/aries/typedevent/bus/impl/EventConverter.java: ## @@ -296,35 +297,41 @@ public Map toUntypedEvent(

Re: [PR] Extract interface and extend TypeData with RawTypeString [aries-typedevent]

2025-02-18 Thread via GitHub
gg-dim commented on PR #24: URL: https://github.com/apache/aries-typedevent/pull/24#issuecomment-2665162619 I have talk with Mark and with Jürgen about the custom converter type topic and I now have two variants of an implementation: 1. variant extracts an interface from the TypeData

[PR] Extract interface and extend TypeData with RawTypeString [aries-typedevent]

2025-02-05 Thread via GitHub
gg-dim opened a new pull request, #24: URL: https://github.com/apache/aries-typedevent/pull/24 After this change we get enough type information in the CustomEventConverter without any EMF dependency. -- This is an automated message from the Apache Git Service. To respond to the message,