[jax-rs-whiteboard] First review

2016-11-29 Thread Christian Schneider
I took some time to look into the jax-rs whiteboard code and noted some findings below. Formatting: * The code is formatted with tabs. I propose to use spaces like in the other aries modules * In some java files there is a empty line between each line of code. I think empty lines

Re: [jax-rs-whiteboard] First review

2016-11-29 Thread Carlos Sierra Andrés
Hi Christian, thanks for looking into this. For me it's fine to use whichever conventions are appropiate. I just commited the source with the conventions we had in our code. where is the formatter you mention and how can it be used? I can adapt the sources to the conventions it enforces.

Re: [jax-rs-whiteboard] First review

2016-11-29 Thread Carlos Sierra Andrés
Hi again, for the moment I have changed tabs for spaces and removed the author tag in the classes. For the rest I understood there exist some coding conventions or formatter? Best. Carlos. El 29/11/16 a las 12:05, Christian Schneider escribió: I took some time to look into the jax-rs