[jira] [Commented] (ARIES-1617) Hikari pools are not closed by the JPA Resource Providers
[ https://issues.apache.org/jira/browse/ARIES-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562582#comment-15562582 ] ASF subversion and git services commented on ARIES-1617: Commit 1764120 from [~timothyjward] in branch 'aries/trunk' [ https://svn.apache.org/r1764120 ] ARIES-1617 Ensure type safety for configuration driven JPA resource providers > Hikari pools are not closed by the JPA Resource Providers > - > > Key: ARIES-1617 > URL: https://issues.apache.org/jira/browse/ARIES-1617 > Project: Aries > Issue Type: Bug > Components: tx-control >Affects Versions: tx-control-0.0.1 >Reporter: Timothy Ward > Fix For: tx-control-0.0.2 > > > When shutting down the Aries JPA Resource Provider (both XA and non XA) the > Hikari pool (if created) does not get closed. This leads to Hikari > maintenance threads being left running, which leaks class loaders and may > prevent framework shutdown. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1616) Transaction Recovery Log does not shut down properly
[ https://issues.apache.org/jira/browse/ARIES-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562573#comment-15562573 ] Timothy Ward commented on ARIES-1616: - More mislabelled commits... ARIES-1617 > Transaction Recovery Log does not shut down properly > > > Key: ARIES-1616 > URL: https://issues.apache.org/jira/browse/ARIES-1616 > Project: Aries > Issue Type: Bug > Components: tx-control >Affects Versions: tx-control-0.0.1 >Reporter: Timothy Ward >Assignee: Timothy Ward > Fix For: tx-control-0.0.2 > > > After shutting down or reconfiguring the XA Transaction Control > implementation a daemon thread is left running from the HOWL Flush manager. > This never seems to get closed... > This is likely a bug in HOWL, but that project hasn't been updated in a > decade so Aries will have to work around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1616) Transaction Recovery Log does not shut down properly
[ https://issues.apache.org/jira/browse/ARIES-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562575#comment-15562575 ] Timothy Ward commented on ARIES-1616: - More mislabelled commits... ARIES-1617 > Transaction Recovery Log does not shut down properly > > > Key: ARIES-1616 > URL: https://issues.apache.org/jira/browse/ARIES-1616 > Project: Aries > Issue Type: Bug > Components: tx-control >Affects Versions: tx-control-0.0.1 >Reporter: Timothy Ward >Assignee: Timothy Ward > Fix For: tx-control-0.0.2 > > > After shutting down or reconfiguring the XA Transaction Control > implementation a daemon thread is left running from the HOWL Flush manager. > This never seems to get closed... > This is likely a bug in HOWL, but that project hasn't been updated in a > decade so Aries will have to work around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1616) Transaction Recovery Log does not shut down properly
[ https://issues.apache.org/jira/browse/ARIES-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562578#comment-15562578 ] Timothy Ward commented on ARIES-1616: - More mislabelled commits... ARIES-1617 > Transaction Recovery Log does not shut down properly > > > Key: ARIES-1616 > URL: https://issues.apache.org/jira/browse/ARIES-1616 > Project: Aries > Issue Type: Bug > Components: tx-control >Affects Versions: tx-control-0.0.1 >Reporter: Timothy Ward >Assignee: Timothy Ward > Fix For: tx-control-0.0.2 > > > After shutting down or reconfiguring the XA Transaction Control > implementation a daemon thread is left running from the HOWL Flush manager. > This never seems to get closed... > This is likely a bug in HOWL, but that project hasn't been updated in a > decade so Aries will have to work around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1616) Transaction Recovery Log does not shut down properly
[ https://issues.apache.org/jira/browse/ARIES-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562572#comment-15562572 ] Timothy Ward commented on ARIES-1616: - More mislabelled commits... ARIES-1617 > Transaction Recovery Log does not shut down properly > > > Key: ARIES-1616 > URL: https://issues.apache.org/jira/browse/ARIES-1616 > Project: Aries > Issue Type: Bug > Components: tx-control >Affects Versions: tx-control-0.0.1 >Reporter: Timothy Ward >Assignee: Timothy Ward > Fix For: tx-control-0.0.2 > > > After shutting down or reconfiguring the XA Transaction Control > implementation a daemon thread is left running from the HOWL Flush manager. > This never seems to get closed... > This is likely a bug in HOWL, but that project hasn't been updated in a > decade so Aries will have to work around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1616) Transaction Recovery Log does not shut down properly
[ https://issues.apache.org/jira/browse/ARIES-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562492#comment-15562492 ] ASF subversion and git services commented on ARIES-1616: Commit 1764111 from [~timothyjward] in branch 'aries/trunk' [ https://svn.apache.org/r1764111 ] ARIES-1616 Further refactoring to remove duplicate code in the JPA resource providers > Transaction Recovery Log does not shut down properly > > > Key: ARIES-1616 > URL: https://issues.apache.org/jira/browse/ARIES-1616 > Project: Aries > Issue Type: Bug > Components: tx-control >Affects Versions: tx-control-0.0.1 >Reporter: Timothy Ward >Assignee: Timothy Ward > Fix For: tx-control-0.0.2 > > > After shutting down or reconfiguring the XA Transaction Control > implementation a daemon thread is left running from the HOWL Flush manager. > This never seems to get closed... > This is likely a bug in HOWL, but that project hasn't been updated in a > decade so Aries will have to work around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1616) Transaction Recovery Log does not shut down properly
[ https://issues.apache.org/jira/browse/ARIES-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562490#comment-15562490 ] ASF subversion and git services commented on ARIES-1616: Commit 1764109 from [~timothyjward] in branch 'aries/trunk' [ https://svn.apache.org/r1764109 ] ARIES-1616 Factor out JPA resource provider common code from Local JPA > Transaction Recovery Log does not shut down properly > > > Key: ARIES-1616 > URL: https://issues.apache.org/jira/browse/ARIES-1616 > Project: Aries > Issue Type: Bug > Components: tx-control >Affects Versions: tx-control-0.0.1 >Reporter: Timothy Ward >Assignee: Timothy Ward > Fix For: tx-control-0.0.2 > > > After shutting down or reconfiguring the XA Transaction Control > implementation a daemon thread is left running from the HOWL Flush manager. > This never seems to get closed... > This is likely a bug in HOWL, but that project hasn't been updated in a > decade so Aries will have to work around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1616) Transaction Recovery Log does not shut down properly
[ https://issues.apache.org/jira/browse/ARIES-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562485#comment-15562485 ] ASF subversion and git services commented on ARIES-1616: Commit 1764108 from [~timothyjward] in branch 'aries/trunk' [ https://svn.apache.org/r1764108 ] ARIES-1616 Factor out resource provider independent common code > Transaction Recovery Log does not shut down properly > > > Key: ARIES-1616 > URL: https://issues.apache.org/jira/browse/ARIES-1616 > Project: Aries > Issue Type: Bug > Components: tx-control >Affects Versions: tx-control-0.0.1 >Reporter: Timothy Ward >Assignee: Timothy Ward > Fix For: tx-control-0.0.2 > > > After shutting down or reconfiguring the XA Transaction Control > implementation a daemon thread is left running from the HOWL Flush manager. > This never seems to get closed... > This is likely a bug in HOWL, but that project hasn't been updated in a > decade so Aries will have to work around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1616) Transaction Recovery Log does not shut down properly
[ https://issues.apache.org/jira/browse/ARIES-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562491#comment-15562491 ] ASF subversion and git services commented on ARIES-1616: Commit 1764110 from [~timothyjward] in branch 'aries/trunk' [ https://svn.apache.org/r1764110 ] ARIES-1616 Clean up XA JPA resources properly > Transaction Recovery Log does not shut down properly > > > Key: ARIES-1616 > URL: https://issues.apache.org/jira/browse/ARIES-1616 > Project: Aries > Issue Type: Bug > Components: tx-control >Affects Versions: tx-control-0.0.1 >Reporter: Timothy Ward >Assignee: Timothy Ward > Fix For: tx-control-0.0.2 > > > After shutting down or reconfiguring the XA Transaction Control > implementation a daemon thread is left running from the HOWL Flush manager. > This never seems to get closed... > This is likely a bug in HOWL, but that project hasn't been updated in a > decade so Aries will have to work around it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562261#comment-15562261 ] metatech commented on ARIES-1407: - What I meant was : we started using ServiceMix 4.3.0 in 2011 (Blueprint 0.2-incubating), then migrated to 4.4.2 (Blueprint 0.3.1) in 2012, and to 4.5.3 (Blueprint 0.3.2) in 2014, and to 5.4.1 (Blueprint 1.4.3) in 2015. The behaviour changed only in the last Blueprint version. But please rest assured that we did not stay on 0.2 for all those years... BTW, we do those kind of small enhancements to avoid inaccuracies in the status or monitoring of ServiceMix, because this simplifies the support of our mission-critical environment. > Service (un)registration listener not called anymore > > > Key: ARIES-1407 > URL: https://issues.apache.org/jira/browse/ARIES-1407 > Project: Aries > Issue Type: Bug > Components: Blueprint > Environment: Servicemix 5.4.1 >Reporter: metatech > Attachments: blueprint_registration_listener_fix_v2.patch > > > Service (un)registration listeners are not called anymore since Blueprint > 1.4.0. > There are 2 booleans in the "ServiceRecipe" class which are tested against > the wrong values. > Please find a patch which makes them work again with Blueprint 1.4.3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562249#comment-15562249 ] Grzegorz Grzybek commented on ARIES-1407: - bq. But that was with Blueprint 0.2-incubating shouldn't you have update it last century? :) > Service (un)registration listener not called anymore > > > Key: ARIES-1407 > URL: https://issues.apache.org/jira/browse/ARIES-1407 > Project: Aries > Issue Type: Bug > Components: Blueprint > Environment: Servicemix 5.4.1 >Reporter: metatech > Attachments: blueprint_registration_listener_fix_v2.patch > > > Service (un)registration listeners are not called anymore since Blueprint > 1.4.0. > There are 2 booleans in the "ServiceRecipe" class which are tested against > the wrong values. > Please find a patch which makes them work again with Blueprint 1.4.3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562217#comment-15562217 ] metatech commented on ARIES-1407: - Yes Grzegorz, I understand why it behaves this way now, thanks for the explanations. I remember I tried several solutions to avoid the slave ActiveMQ broker to slave in "GracePeriod" forever (including using "depends-on" attributes), but, for some reason which I forgot, it is was working as expected... But that was with Blueprint 0.2-incubating at the time, so I will try again to do it straighter when I have time... Thanks anyway... > Service (un)registration listener not called anymore > > > Key: ARIES-1407 > URL: https://issues.apache.org/jira/browse/ARIES-1407 > Project: Aries > Issue Type: Bug > Components: Blueprint > Environment: Servicemix 5.4.1 >Reporter: metatech > Attachments: blueprint_registration_listener_fix_v2.patch > > > Service (un)registration listeners are not called anymore since Blueprint > 1.4.0. > There are 2 booleans in the "ServiceRecipe" class which are tested against > the wrong values. > Please find a patch which makes them work again with Blueprint 1.4.3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562182#comment-15562182 ] Grzegorz Grzybek commented on ARIES-1407: - So I'm afraid everything is fine. Registration Listener triggers when service is created in OSGi registry. in case of ServiceFactory, the moment is when ServiceFactory.getService() is called. If you reference your service in some singleton, eager bean or use it in some SCR component via {{@Reference}}, your listener whould have been called. If you want to simulate something that I'm thinking you want to achieve, try creating ordinary {{}} with reference to e.g., event admin and publish some event there. > Service (un)registration listener not called anymore > > > Key: ARIES-1407 > URL: https://issues.apache.org/jira/browse/ARIES-1407 > Project: Aries > Issue Type: Bug > Components: Blueprint > Environment: Servicemix 5.4.1 >Reporter: metatech > Attachments: blueprint_registration_listener_fix_v2.patch > > > Service (un)registration listeners are not called anymore since Blueprint > 1.4.0. > There are 2 booleans in the "ServiceRecipe" class which are tested against > the wrong values. > Please find a patch which makes them work again with Blueprint 1.4.3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562179#comment-15562179 ] metatech commented on ARIES-1407: - It was working in Blueprint 0.3.2 (within ServiceMix 4.5.3), but this was probably not compliant with spec (?) and only working by chance (?)... BTW, all call stacks are from the same Blueprint Extender threads. > Service (un)registration listener not called anymore > > > Key: ARIES-1407 > URL: https://issues.apache.org/jira/browse/ARIES-1407 > Project: Aries > Issue Type: Bug > Components: Blueprint > Environment: Servicemix 5.4.1 >Reporter: metatech > Attachments: blueprint_registration_listener_fix_v2.patch > > > Service (un)registration listeners are not called anymore since Blueprint > 1.4.0. > There are 2 booleans in the "ServiceRecipe" class which are tested against > the wrong values. > Please find a patch which makes them work again with Blueprint 1.4.3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562161#comment-15562161 ] metatech commented on ARIES-1407: - Thanks Grzegorz. No, my bean is not actually deferenced anywhere. The sole purpose of the registration listener was to execute code after all Blueprint beans are created, (which is not a typical use...). > Service (un)registration listener not called anymore > > > Key: ARIES-1407 > URL: https://issues.apache.org/jira/browse/ARIES-1407 > Project: Aries > Issue Type: Bug > Components: Blueprint > Environment: Servicemix 5.4.1 >Reporter: metatech > Attachments: blueprint_registration_listener_fix_v2.patch > > > Service (un)registration listeners are not called anymore since Blueprint > 1.4.0. > There are 2 booleans in the "ServiceRecipe" class which are tested against > the wrong values. > Please find a patch which makes them work again with Blueprint 1.4.3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562151#comment-15562151 ] Grzegorz Grzybek commented on ARIES-1407: - btw - I'm on freenode, #apache-aries channel. > Service (un)registration listener not called anymore > > > Key: ARIES-1407 > URL: https://issues.apache.org/jira/browse/ARIES-1407 > Project: Aries > Issue Type: Bug > Components: Blueprint > Environment: Servicemix 5.4.1 >Reporter: metatech > Attachments: blueprint_registration_listener_fix_v2.patch > > > Service (un)registration listeners are not called anymore since Blueprint > 1.4.0. > There are 2 booleans in the "ServiceRecipe" class which are tested against > the wrong values. > Please find a patch which makes them work again with Blueprint 1.4.3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562148#comment-15562148 ] Grzegorz Grzybek commented on ARIES-1407: - Are stack A and B from different threads (race condition?). > Service (un)registration listener not called anymore > > > Key: ARIES-1407 > URL: https://issues.apache.org/jira/browse/ARIES-1407 > Project: Aries > Issue Type: Bug > Components: Blueprint > Environment: Servicemix 5.4.1 >Reporter: metatech > Attachments: blueprint_registration_listener_fix_v2.patch > > > Service (un)registration listeners are not called anymore since Blueprint > 1.4.0. > There are 2 booleans in the "ServiceRecipe" class which are tested against > the wrong values. > Please find a patch which makes them work again with Blueprint 1.4.3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562142#comment-15562142 ] Grzegorz Grzybek commented on ARIES-1407: - [~metatech], what ServiceRecipe registers in OSGi is actually {{org.apache.aries.blueprint.container.ServiceRecipe.TriggerServiceFactory}}, which is {{org.osgi.framework.ServiceFactory}}. When its {{getService()}} listeners are notified. Are you sure your connectionFactoryService is actually dereferenced/used somewhere? > Service (un)registration listener not called anymore > > > Key: ARIES-1407 > URL: https://issues.apache.org/jira/browse/ARIES-1407 > Project: Aries > Issue Type: Bug > Components: Blueprint > Environment: Servicemix 5.4.1 >Reporter: metatech > Attachments: blueprint_registration_listener_fix_v2.patch > > > Service (un)registration listeners are not called anymore since Blueprint > 1.4.0. > There are 2 booleans in the "ServiceRecipe" class which are tested against > the wrong values. > Please find a patch which makes them work again with Blueprint 1.4.3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562138#comment-15562138 ] metatech commented on ARIES-1407: - Unless the method "createService" is called multiple times (which is not the case in my Blueprint beans), including one invocation after a call to the "register" method, the registration listener is not being invoked. > Service (un)registration listener not called anymore > > > Key: ARIES-1407 > URL: https://issues.apache.org/jira/browse/ARIES-1407 > Project: Aries > Issue Type: Bug > Components: Blueprint > Environment: Servicemix 5.4.1 >Reporter: metatech > Attachments: blueprint_registration_listener_fix_v2.patch > > > Service (un)registration listeners are not called anymore since Blueprint > 1.4.0. > There are 2 booleans in the "ServiceRecipe" class which are tested against > the wrong values. > Please find a patch which makes them work again with Blueprint 1.4.3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562121#comment-15562121 ] metatech commented on ARIES-1407: - Hi Grzegorz, I debugged into the class ServiceRecipe and here is the timeline of the called methods (in pseudo/abbreviated code) : 1. {code} static { // static initialization initialServiceRegistration = true; } {code} 2. {code} private void createService() { assert(initialServiceRegistration=true); // Stack trace A ... // When the service is first requested, we need to create listeners and call them if (!initialServiceRegistration && listeners == null) { // Never executed } } {code} 3. {code} public void register() { ... initialServiceRegistration = false; // Patch : add call to listener // Stack trace B } {code} Stack trace A {code} at org.apache.aries.blueprint.container.ServiceRecipe.invokeListeners(ServiceRecipe.java:345) at org.apache.aries.blueprint.container.ServiceRecipe.createService(ServiceRecipe.java:315) at org.apache.aries.blueprint.container.ServiceRecipe.internalGetService(ServiceRecipe.java:252) at org.apache.aries.blueprint.container.ServiceRecipe.internalCreate(ServiceRecipe.java:148) at org.apache.aries.blueprint.di.AbstractRecipe$1.call(AbstractRecipe.java:79) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at org.apache.aries.blueprint.di.AbstractRecipe.create(AbstractRecipe.java:88) at org.apache.aries.blueprint.container.BlueprintRepository.createInstances(BlueprintRepository.java:245) at org.apache.aries.blueprint.container.BlueprintRepository.createAll(BlueprintRepository.java:183) at org.apache.aries.blueprint.container.BlueprintContainerImpl.instantiateEagerComponents(BlueprintContainerImpl.java:688) at org.apache.aries.blueprint.container.BlueprintContainerImpl.doRun(BlueprintContainerImpl.java:383) at org.apache.aries.blueprint.container.BlueprintContainerImpl.run(BlueprintContainerImpl.java:269) {code} Stack trace B {code} at com.mycompany.blueprint.ExitGracePeriodNotifier.register(ExitGracePeriodNotifier.java:41) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.aries.blueprint.utils.ReflectionUtils.invoke(ReflectionUtils.java:297) at org.apache.aries.blueprint.utils.ServiceListener.invokeMethod(ServiceListener.java:97) at org.apache.aries.blueprint.utils.ServiceListener.register(ServiceListener.java:59) at org.apache.aries.blueprint.container.ServiceRecipe.invokeListeners(ServiceRecipe.java:336) at org.apache.aries.blueprint.container.ServiceRecipe.register(ServiceRecipe.java:198) at org.apache.aries.blueprint.container.BlueprintContainerImpl.registerServices(BlueprintContainerImpl.java:710) at org.apache.aries.blueprint.container.BlueprintContainerImpl.doRun(BlueprintContainerImpl.java:385) at org.apache.aries.blueprint.container.BlueprintContainerImpl.run(BlueprintContainerImpl.java:269) {code} > Service (un)registration listener not called anymore > > > Key: ARIES-1407 > URL: https://issues.apache.org/jira/browse/ARIES-1407 > Project: Aries > Issue Type: Bug > Components: Blueprint > Environment: Servicemix 5.4.1 >Reporter: metatech > Attachments: blueprint_registration_listener_fix_v2.patch > > > Service (un)registration listeners are not called anymore since Blueprint > 1.4.0. > There are 2 booleans in the "ServiceRecipe" class which are tested against > the wrong values. > Please find a patch which makes them work again with Blueprint 1.4.3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562098#comment-15562098 ] metatech commented on ARIES-1407: - Hi Grzegorz, Thanks for looking into this. Unfortunately, it has been long since I debugged this code, and I forgot the inner workings of it. I added the registration listener in the ActiveMQ Blueprint bundle of ServiceMix 5.4.1 : {code} {code} I use the ExitGracePeriodNotifier contributed in ARIES-805 > Service (un)registration listener not called anymore > > > Key: ARIES-1407 > URL: https://issues.apache.org/jira/browse/ARIES-1407 > Project: Aries > Issue Type: Bug > Components: Blueprint > Environment: Servicemix 5.4.1 >Reporter: metatech > Attachments: blueprint_registration_listener_fix_v2.patch > > > Service (un)registration listeners are not called anymore since Blueprint > 1.4.0. > There are 2 booleans in the "ServiceRecipe" class which are tested against > the wrong values. > Please find a patch which makes them work again with Blueprint 1.4.3. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1407) Service (un)registration listener not called anymore
[ https://issues.apache.org/jira/browse/ARIES-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561777#comment-15561777 ] Grzegorz Grzybek commented on ARIES-1407: - If you run {{org.apache.aries.blueprint.itests.BlueprintContainerTest#test()}} you should see: {noformat} ... Bundle start Initializing Foo = Service registration notification: 5 10 4474039: Hello FooBar org.eclipse.osgi.framework.internal.core.BundleContextImpl@7cf1c94e [a list element, 5] PLN Fri Apr 17 00:00:00 CEST 2009 {osgi.service.blueprint.compname=foo, key=value} [main] INFO org.apache.aries.blueprint.container.BlueprintExtender - Destroying BlueprintContainer for bundle org.apache.aries.blueprint.sample/1.0.1.SNAPSHOT Service unregistration notification: 5 10 4474039: Hello FooBar org.eclipse.osgi.framework.internal.core.BundleContextImpl@7cf1c94e [a list element, 5] PLN Fri Apr 17 00:00:00 CEST 2009 {osgi.service.blueprint.compname=foo, key=value} Destroying Foo = Bundle stop ... {noformat} Registration listener is called at this point: {noformat} "main@1" prio=5 tid=0x1 nid=NA runnable java.lang.Thread.State: RUNNABLE at org.apache.aries.blueprint.sample.FooRegistrationListener.serviceRegistered(FooRegistrationListener.java:29) at sun.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-1) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.aries.blueprint.utils.ReflectionUtils.invoke(ReflectionUtils.java:299) at org.apache.aries.blueprint.utils.ServiceListener.invokeMethod(ServiceListener.java:97) at org.apache.aries.blueprint.utils.ServiceListener.register(ServiceListener.java:59) at org.apache.aries.blueprint.container.ServiceRecipe.createService(ServiceRecipe.java:329) at org.apache.aries.blueprint.container.ServiceRecipe.internalGetService(ServiceRecipe.java:252) at org.apache.aries.blueprint.container.ServiceRecipe.getService(ServiceRecipe.java:365) at org.apache.aries.blueprint.container.ServiceRecipe$TriggerServiceFactory.getService(ServiceRecipe.java:541) at org.eclipse.osgi.internal.serviceregistry.ServiceUse$1.run(ServiceUse.java:141) at java.security.AccessController.doPrivileged(AccessController.java:-1) at org.eclipse.osgi.internal.serviceregistry.ServiceUse.getService(ServiceUse.java:139) at org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:468) - locked <0xcc0> (a org.eclipse.osgi.internal.serviceregistry.ServiceUse) at org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.getService(ServiceRegistry.java:467) at org.eclipse.osgi.framework.internal.core.BundleContextImpl.getService(BundleContextImpl.java:594) at org.osgi.util.tracker.ServiceTracker.addingService(ServiceTracker.java:411) at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:932) at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:1) at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256) at org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183) at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:317) at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:261) at org.apache.aries.itest.RichBundleContext.getService(RichBundleContext.java:81) at org.apache.aries.itest.RichBundleContext.getService(RichBundleContext.java:55) at org.apache.aries.blueprint.itests.Helper.testBlueprintContainer(Helper.java:104) at org.apache.aries.blueprint.itests.BlueprintContainerTest.test(BlueprintContainerTest.java:38) at sun.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-1) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at