Re: Add SPIFly support for InitialContextFactory

[Thusitha Thilina Dayaratne]

Kind reminder on this. Could someone have a look on this if possible?

Thanks
Thusitha



 Sent with Mailtrack


On Fri, Oct 6, 2017 at 11:00 AM, Thusitha Thilina Dayaratne <
thusithathil...@gmail.com> wrote:

> Hi Devs,
>
> I'm trying to use Aries SPYFly with one of our projects. According to the
> OSGi spec when we register an InitialContextFactory, we need to register
> that for both implementation and InitialContextFactory classes.
> IMHO it would be great if we can support that with SPY-Fly. I've created
> JIRA[1] and send a PR[2] to implement that. Would you able to consider this
> request?
>
> [1] - https://issues.apache.org/jira/browse/ARIES-1746
> [2] - https://github.com/apache/aries/pull/75
>
> Thanks
> --
>
>
>
>
>  Sent with Mailtrack
> 
> <#m_-2159321232658442676_>
>



--

[GitHub] aries pull request #80: Consider returning a zero length array of String rat...

[BruceKuiLiu]

GitHub user BruceKuiLiu opened a pull request:

https://github.com/apache/aries/pull/80

Consider returning a zero length array of String rather than null.

It is often a better design to return a length zero array rather than a 
null reference to indicate that there are no results (i.e., an empty list of 
results).
This way, no explicit check for null is needed by clients of the method.
On the other hand, using null to indicate that "there is no answer to this 
question" is probably appropriate.

http://findbugs.sourceforge.net/bugDescriptions.html#PZLA_PREFER_ZERO_LENGTH_ARRAYS

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BruceKuiLiu/aries trunk-request

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/aries/pull/80.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #80


commit e2b3388df7f37bc518a6aeb1db415eba9ea26ff5
Author: Kui LIU 
Date:   2017-10-09T21:47:08Z

Consider returning a zero length array of String rather than null.

It is often a better design to return a length zero array rather than a 
null reference to indicate that there are no results (i.e., an empty list of 
results).
This way, no explicit check for null is needed by clients of the method.
On the other hand, using null to indicate that "there is no answer to this 
question" is probably appropriate.

http://findbugs.sourceforge.net/bugDescriptions.html#PZLA_PREFER_ZERO_LENGTH_ARRAYS




---

[GitHub] aries pull request #79: Remove the redundant null check expression of a non-...

[BruceKuiLiu]

GitHub user BruceKuiLiu opened a pull request:

https://github.com/apache/aries/pull/79

Remove the redundant null check expression of a non-null value 
this.appVersion


The expression "this.appVersion == null" is a redundant check of a known 
non-null value because this.appVersion is created by a constructor method.

http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BruceKuiLiu/aries trunk4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/aries/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit 42070c4568ceaa47bc585812ba91000af34d3d90
Author: Kui LIU 
Date:   2017-10-09T21:26:06Z

Remove the redundant null check expression of a non-null value 
this.appVersion.

The expression "this.appVersion == null" is a redundant check of a known 
non-null value because this.appVersion is created by a constructor method.

http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE




---

[GitHub] aries pull request #78: Add an IfStatement to check the return value of temp...

[BruceKuiLiu]

GitHub user BruceKuiLiu opened a pull request:

https://github.com/apache/aries/pull/78

Add an IfStatement to check the return value of temp.delete().

This statement returns a value that is not checked.
The return value should be checked since it can indicate an unusual or 
unexpected function execution.
The statement returns false if the file could not be successfully deleted 
(rather than throwing an Exception).
If the result was not checked, developers would not notice if the statement 
signals an unexpected behavior by returning an atypical return value.

http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BruceKuiLiu/aries trunk3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/aries/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit 00a84d35614212d016134a3895bf95e5546ea7ed
Author: Kui LIU 
Date:   2017-10-09T20:47:36Z

Add an IfStatement to check the return value of temp.delete().

This statement returns a value that is not checked.
The return value should be checked since it can indicate an unusual or 
unexpected function execution.
The statement returns false if the file could not be successfully deleted 
(rather than throwing an Exception).
If the result was not checked, developers would not notice if the statement 
signals an unexpected behavior by returning an atypical return value.

http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE




---

[GitHub] aries pull request #77: Fix the problem of using '+' and '+=' operators to c...

[BruceKuiLiu]

GitHub user BruceKuiLiu opened a pull request:

https://github.com/apache/aries/pull/77

Fix the problem of using '+' and '+=' operators to concatenate string…

…s in a loop.

The method is building a String using concatenation in a loop.
In each iteration, the String is converted to a StringBuilder, appended to, 
and converted back to a String.
This can lead to a cost quadratic in the number of iterations, as the 
growing string is recopied in each iteration.
Better performance can be obtained by using a StringBuilder explicitly.

http://findbugs.sourceforge.net/bugDescriptions.html#SBSC_USE_STRINGBUFFER_CONCATENATION

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BruceKuiLiu/aries trunk2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/aries/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #77


commit 5e8bb88a2b1df7e7372fdebd563fb47f421d5e80
Author: Kui LIU 
Date:   2017-10-09T20:15:04Z

Fix the problem of using '+' and '+=' operators to concatenate strings in a 
loop.

The method is building a String using concatenation in a loop.
In each iteration, the String is converted to a StringBuilder, appended to, 
and converted back to a String.
This can lead to a cost quadratic in the number of iterations, as the 
growing string is recopied in each iteration.
Better performance can be obtained by using a StringBuilder explicitly.

http://findbugs.sourceforge.net/bugDescriptions.html#SBSC_USE_STRINGBUFFER_CONCATENATION




---

Re: [VOTE] Blueprint maven plugin 1.9.0

[Christian Schneider]

+1

Christian

2017-10-07 9:08 GMT+02:00 Dominik Przybysz :

> Hi,
>
> I have release artifacts:
>
> - blueprint-maven-plugin-annotation-1.3.0
> - blueprint-maven-plugin-pax-cdi-handlers-1.0.0
> - blueprint-maven-plugin-1.9.0
>
> Release notes:
>
> [ARIES-1740] - blueprint-maven-plugin should generate 
> instead of  for a
> @OsgiService List ?
> [ARIES-1741] - Move handlers for pax-cdi-api annotations to separate module
> in BMP
> [ARIES-1742] - Create annotation and handler for reference generation in
> BMP
> [ARIES-1743] - Create annotation and handler for service generation in BMP
> [ARIES-1745] - Name beans from factories after method name in BMP
>
> Version on jira:
>
> https://issues.apache.org/jira/projects/ARIES/versions/12341362
>
> Staging repo:
>
> https://repository.apache.org/content/repositories/orgapachearies-1117/
>
> Please review and vote
>
> --
> Pozdrawiam / Regards,
> Dominik Przybysz
>



-- 
-- 
Christian Schneider
http://www.liquid-reality.de


Computer Scientist
http://www.adobe.com

Re: [VOTE] Blueprint maven plugin 1.9.0

[David Bosschaert]

+1

David

On 7 October 2017 at 08:08, Dominik Przybysz  wrote:

> Hi,
>
> I have release artifacts:
>
> - blueprint-maven-plugin-annotation-1.3.0
> - blueprint-maven-plugin-pax-cdi-handlers-1.0.0
> - blueprint-maven-plugin-1.9.0
>
> Release notes:
>
> [ARIES-1740] - blueprint-maven-plugin should generate 
> instead of  for a
> @OsgiService List ?
> [ARIES-1741] - Move handlers for pax-cdi-api annotations to separate module
> in BMP
> [ARIES-1742] - Create annotation and handler for reference generation in
> BMP
> [ARIES-1743] - Create annotation and handler for service generation in BMP
> [ARIES-1745] - Name beans from factories after method name in BMP
>
> Version on jira:
>
> https://issues.apache.org/jira/projects/ARIES/versions/12341362
>
> Staging repo:
>
> https://repository.apache.org/content/repositories/orgapachearies-1117/
>
> Please review and vote
>
> --
> Pozdrawiam / Regards,
> Dominik Przybysz
>

[GitHub] aries pull request #76: Remove the useless conditional sub-expression.

[BruceKuiLiu]

GitHub user BruceKuiLiu opened a pull request:

https://github.com/apache/aries/pull/76

Remove the useless conditional sub-expression.

This statement contains a useless conditional expression, where this 
conditional expression returns a false value regardless of what the value of 
isValid is.

http://findbugs.sourceforge.net/bugDescriptions.html#UCF_USELESS_CONTROL_FLOW

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/BruceKuiLiu/aries trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/aries/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #76


commit 1c4387018fa18d9cc81ef8395430e42ce1de4671
Author: Kui LIU 
Date:   2017-10-09T08:25:47Z

Remove the useless conditional sub-expression.

This statement contains a useless conditional expression, where this 
conditional expression returns a false value regardless of what the value of 
isValid is.

http://findbugs.sourceforge.net/bugDescriptions.html#UCF_USELESS_CONTROL_FLOW




---