Re: [VOTE] Apache Aries Transaction Blueprint 2.3.0 release

2021-07-28 Thread Grzegorz Grzybek 
+1 (binding)

I've checked 2.3.0 with https://github.com/apache/aries-jpa/pull/10
(updating it first) and it works exactly as I wanted.

regards
Grzegorz Grzybek

pon., 26 lip 2021 o 18:58 Dominik Przybysz 
napisał(a):

> Yeah, this is the problem of some even very old files in Aries repo and
> because of that some artifacts do not satisfy rules described in
>
> https://aries.apache.org/documentation/development/verifyingrelease.html#_rat_check
>
> pon., 26 lip 2021 o 18:44 Grzegorz Grzybek 
> napisał(a):
>
> > Hi
> >
> > pon., 26 lip 2021 o 17:06 Dominik Przybysz 
> > napisał(a):
> >
> > > Hi, some of the files do not have the license comment:
> > >
> > > !? src/main/java/org/apache/aries/transaction/ComponentTxData.java
> > > !?
> > >
> > >
> >
> src/main/java/org/apache/aries/transaction/TransactionalAnnotationAttributes.java
> > >
> > > !? src/test/java/org/apache/aries/transaction/pojo/BaseClass.java
> > > !?
> src/test/java/org/apache/aries/transaction/pojo/ExtendedPojo.java
> > > !?
> src/test/java/org/apache/aries/transaction/pojo/ExtendedPojo2.java
> > > !?
> src/test/java/org/apache/aries/transaction/pojo/ExtendedPojo3.java
> > > !?
> > src/test/java/org/apache/aries/transaction/pojo/OnRollbackPojo.java
> > >
> >
> > Hmm, BaseClass.java was created in 2015... I just checked that my change
> > related to ARIES-2050 didn't mess with the licenses...
> >
> > regards
> > Grzegorz Grzybek
> >
> >
> > >
> > >
> > > pon., 26 lip 2021 o 16:57 Romain Manni-Bucau 
> > > napisał(a):
> > >
> > > > +1
> > > >
> > > > Le lun. 26 juil. 2021 à 16:35, Grzegorz Grzybek <
> gr.grzy...@gmail.com>
> > a
> > > > écrit :
> > > >
> > > > > Hi
> > > > >
> > > > > The release notes doesn't mention
> > > > > https://issues.apache.org/jira/browse/ARIES-2050, but I see that
> > > > > https://github.com/apache/aries/pull/129 is merged... Could you
> set
> > > the
> > > > > version for the issue? I'll verify the release tomorrow.
> > > > >
> > > > > regards
> > > > > Grzegorz Grzybek
> > > > >
> > > > > pon., 26 lip 2021 o 16:25 Jean-Baptiste Onofré 
> > > > > napisał(a):
> > > > >
> > > > > > Hi everyone,
> > > > > >
> > > > > > I submit Aries Transaction Blueprint 2.3.0 release to your vote.
> > > > > >
> > > > > > This release includes a fix about transaction.xml schemaLocation
> > and
> > > a
> > > > > > fix about thread.
> > > > > >
> > > > > > Release Notes:
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310981=12343293
> > > > > >
> > > > > > Staging Repository:
> > > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapachearies-1199/
> > > > > >
> > > > > > Staging Dist Repository:
> > > > > >
> > https://dist.apache.org/repos/dist/dev/aries/transaction-blueprint/
> > > > > >
> > > > > > Git tag:
> > > > > > org.apache.aries.transaction.blueprint-2.3.0
> > > > > >
> > > > > >
> > > > > > Please vote to approve this release:
> > > > > >
> > > > > > [ ] +1 Approve the release
> > > > > > [ ] -1 Don't approve the release (please provide specific
> comments)
> > > > > >
> > > > > > This vote will be open for at least 72 hours.
> > > > > >
> > > > > > Thanks,
> > > > > > Regards
> > > > > > JB
> > > > > > --
> > > > > > Jean-Baptiste Onofré
> > > > > > jbono...@apache.org
> > > > > > http://blog.nanthrax.net
> > > > > > Talend - http://www.talend.com
> > > > > >
> > > > >
> > > >
> > >
> > >
> > > --
> > > Pozdrawiam / Regards,
> > > Dominik Przybysz
> > >
> >
>
>
> --
> Pozdrawiam / Regards,
> Dominik Przybysz
>

[jira] [Commented] (ARIES-2050) Aries JPA 2.7 shouldn't always reuse EM instance from previous coordinations

2021-07-28 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ARIES-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389254#comment-17389254
 ] 

ASF subversion and git services commented on ARIES-2050:


Commit 125a4aef647d7356768854883f7b3d8e040ce2bb in aries-jpa's branch 
refs/heads/ARIES-2050 from Grzegorz Grzybek
[ https://gitbox.apache.org/repos/asf?p=aries-jpa.git;h=125a4ae ]

[ARIES-2050] Use org.apache.aries.transaction.blueprint-2.3.0


> Aries JPA 2.7 shouldn't always reuse EM instance from previous coordinations
> 
>
> Key: ARIES-2050
> URL: https://issues.apache.org/jira/browse/ARIES-2050
> Project: Aries
>  Issue Type: Bug
>Affects Versions: jpa-2.7.2
>Reporter: Grzegorz Grzybek
>Assignee: Grzegorz Grzybek
>Priority: Major
> Fix For: jpa-2.7.3
>
>
> I have a scenario consisting of the following call graph:
> {noformat}
> testService.performTest() [ @Transactional(TxType.REQUIRED) ]
> +-- List cars = carDao.getAllCars()
> |   +-- return em.createQuery("select c from Car c", 
> Car.class).getResultList()
> |   (em is injected using @PersistenceContext(unitName = "xa-test-unit"))
> |
> +-- carDao.createNew(car);
> |   +-- em.persist(car);
> |
> +-- newTxTestService.testNewTransaction(transactionManager.getTransaction()) 
> [ @Transactional(TxType.REQUIRES_NEW) ]
> +-- List cars = carDao.getAllCars();
> +-- return em.createQuery("select c from Car c", 
> Car.class).getResultList()
> {noformat}
> The problem is that inside the method marked with 
> {{@Transactional(TxType.REQUIRES_NEW)}} the {{em}} proxy uses the same 
> underlying {{em}} instance because of:
> {code:java}
> Coordination getTopCoordination() {
> Coordination coordination = coordinator.peek();
> while (coordination != null && coordination.getEnclosingCoordination() != 
> null) {
> coordination = coordination.getEnclosingCoordination();
> }
> return coordination;
> }
> {code}
> And even if the suspended transaction is not yet committed, the em returns 
> the persisted (but not yet committed) cars.
> The coordination stack consists of (names of coordination objects):
> * 
> txInterceptor.org.apache.aries.jpa.container.itest.bundle.blueprint.impl.TestServiceImpl.performTest
> * 
> txInterceptor.org.apache.aries.jpa.container.itest.bundle.blueprint.impl.NewTxTestServiceImpl.testNewTransaction
> * jpa
> the top coordination contains {{em}} variable associated with suspended 
> transaction.
> I'm working on a solution that properly assigns _current_ em respecting 
> tx-demarcated coordinations.
> [~cschneider], [~gnodet], [~jbonofre] if you have an idea about the best 
> solution, please share.
> For now I think both aries-jpa and aries-blueprint-transaction have to be 
> fixed (the latter one should put some magical variable to the coordination 
> objects pushed inside {{org.apache.aries.transaction.TxInterceptorImpl}})



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[Website] Putting the docs in the code repos

2021-07-28 Thread David Jencks 
When I set up the new Antora based website, IIRC, Raymond indicated that it 
would be a lot more convenient if the subproject documentation was in the same 
repo as the java code.  I’ve set up a preview for the SCR docs over at Felix 
showing how I’d like to set this up.

The preview is at  https://felix.staged.apache.org/ 
.  Scr is now in the nav under subprojects 
and linked from the table of subprojects.

The minimal README.adoc is visible at 
https://github.com/djencks/felix-dev/tree/adoc-preview/scr 
. Note that here 
GitHub is rendering AsciiDoc.  The source scr website content is at 
https://github.com/djencks/felix-dev/blob/adoc-preview/scr/docs/modules/ROOT/pages/subprojects/scr.adoc
 


The principle is that for each subproject, subproject-related website content 
would be in the code repo under /docs/modules/ROOT/pages/… There 
are some possible refinements, but if this seems like a good idea I’d suggest 
starting with a simple move of the existing content.

Thoughts?

David Jencks