Re: [VOTE] Release Apache Arrow 16.1.0 - RC1

2024-05-09 Thread Ruoxi Sun
+1 (non-binding) On my M1 Mac, OS version Sonoma 14.4.1 (23E224), compiler Apple clang version 15.0.0, verified cpp and go: TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 ./verify-release-candidate.sh 16.1.0 1 I also tried to verify python: TEST_DEFAULT=0 TEST_PYTHON=1 ./verify-release-candidate.sh

Re: [ANNOUNCE] New Arrow committer: Dane Pitkin

2024-05-07 Thread Ruoxi Sun
Congrats Dane! *Regards,* *Rossi SUN* On Tue, May 7, 2024 at 10:31 PM Weston Pace wrote: > Congrats Dane! > > On Tue, May 7, 2024, 7:30 AM Nic Crane wrote: > > > Congrats Dane, well deserved! > > > > On Tue, 7 May 2024 at 15:16, Gang Wu wrote: > > > > > > Congratulations Dane! > > > > > >

Re: [VOTE] Release Apache Arrow 16.0.0 - RC0

2024-04-17 Thread Ruoxi Sun
+1 (non-binding) On my Intel Mac, OS version Sonoma 14.2.1 (23C71), verified cpp and go: TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 ./verify-release-candidate.sh 16.0.0 0 I also tried to verify python: TEST_DEFAULT=0 TEST_PYTHON=1 ./verify-release-candidate.sh 16.0.0 0 It succeeded except for [1]

Re: [ANNOUNCE] New Arrow committer: Sarah Gilmore

2024-04-11 Thread Ruoxi Sun
Congrats! *Regards,* *Rossi SUN* Weston Pace 于2024年4月12日周五 00:13写道: > Congratulations! > > On Thu, Apr 11, 2024 at 9:12 AM wish maple wrote: > > > Congrats! > > > > Best, > > Xuwei Fu > > > > Kevin Gurney 于2024年4月11日周四 23:22写道: > > > > > Congratulations, Sarah!! Well deserved! > > >

Re: [ANNOUNCE] New Committer Joel Lubinitsky

2024-04-01 Thread Ruoxi Sun
Congratulations Joel! *Regards,* *Rossi SUN* Jason Z 于2024年4月1日周一 23:14写道: > Congrats Joel! > > > Thanks, > Jiashen > > > On Mon, Apr 1, 2024 at 8:10 AM Ian Cook wrote: > > > Congratulations Joel! > > > > On Mon, Apr 1, 2024 at 11:08 AM wish maple > wrote: > > > > > Congrats Joel! > > > > >

Re: [ANNOUNCE] New Arrow committer: Bryce Mecum

2024-03-17 Thread Ruoxi Sun
Congrats! *Regards,* *Rossi SUN* Matt Topol 于2024年3月18日 周一11:21写道: > Congrats!!! Well deserved!! > > On Sun, Mar 17, 2024, 11:19 PM Weston Pace wrote: > > > Congratulations! > > > > On Sun, Mar 17, 2024, 8:01 PM Jacob Wujciak > wrote: > > > > > Congrats, well deserved! > > > > > > Nic Crane

Re: [VOTE] Release Apache Arrow 15.0.2 - RC3

2024-03-16 Thread Ruoxi Sun
+1 (non-binding) On my Intel Mac, OS version Sonoma 14.2.1 (23C71). TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 ./verify-release-candidate.sh 15.0.2 3 I also tried to verify Python TEST_DEFAULT=0 TEST_PYTHON=1 ./verify-release-candidate.sh 15.0.2 3 It succeeded except for [1] (as for 15.0.0 and

Re: [VOTE] Release Apache Arrow 15.0.1 - RC0

2024-03-04 Thread Ruoxi Sun
+1 (non-binding) TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 ./verify-release-candidate.sh 15.0.1 0 On my M1 Mac, OS version Sonoma 14.1.1 (23B81). I also tried to verify Python, it succeeded except for [1], which I met the last time of verifying 15.0.0 (and again, should be trivial). [1]

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Ruoxi Sun
> > On Wed, Jan 17, 2024 at 2:15 PM Ruoxi Sun wrote: > > > My guts feeling is this has something to do with timezone, I'm in UTC+8. > > > > If I change this line [1] to: > > testTime := time.Now().UTC() > > test passed. > > > > So for a

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Ruoxi Sun
gt; > I'll take a look at that Go test failure in a bit. > > > > As for the ubuntu 22.04 verification failure, I'll double check that > we're > > installing Go 1.19 for the verification and using the right PATH to it, I > > thought we addressed this but I guess something must hav

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Ruoxi Sun
l mié, 17 ene 2024 a las 19:07, Ruoxi Sun () > escribió: > > > > Tried: > > > > TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 TEST_PYTHON=1 > > ./verify-release-candidate.sh 15.0.0 0 > > > > But one of go test failed: > > > > ok github.com/apache/arro

Re: [VOTE] Release Apache Arrow 15.0.0 - RC1

2024-01-17 Thread Ruoxi Sun
Tried: TEST_DEFAULT=0 TEST_GO=1 TEST_CPP=1 TEST_PYTHON=1 ./verify-release-candidate.sh 15.0.0 0 But one of go test failed: ok github.com/apache/arrow/go/v15/arrow/flight/flightsql 4.990s 1970-01-01 12:00:00 + UTC --- FAIL: Test_fromArrowType (0.00s) --- FAIL:

Re: [C++][Acero] Request for early review of PR on adding residual filter support to swiss join

2024-01-09 Thread Ruoxi Sun
Great! Thank you Vibhatha, really appreciate it. *Regards,* *Rossi* Vibhatha Abeykoon 于2024年1月9日周二 14:46写道: > Hi Ruoxi, > > I am taking a look at the PR, and will continue the discussion on Github. > > With Regards, > Vibhatha Abeykoon >

[C++][Acero] Request for early review of PR on adding residual filter support to swiss join

2024-01-08 Thread Ruoxi Sun
Hi, I'm taking the task [1] of adding residual filter support to swiss join of acero and came up with this PR [2]. While this PR is currently in draft status, as I am working on adding more specialized tests and benchmarks, all the fundamental code and comments are complete, and it passes all

Re: [ANNOUNCE] New Arrow PMC member: Raúl Cumplido

2023-11-13 Thread Ruoxi Sun
Congratulations! *Rossi* Gang Wu 于2023年11月14日周二 13:09写道: > Congratulations! > > Best, > Gang > > On Tue, Nov 14, 2023 at 7:31 AM Jonathan Keane wrote: > > > Congratulations and welcome! > > > > -Jon > > >

Re: [ANNOUNCE] New Arrow committer: Xuwei Fu

2023-10-23 Thread Ruoxi Sun
Congrats Xuwei! *Rossi* Yibo Cai 于2023年10月23日周一 14:18写道: > Congrats Xuwei! > > -Original Message- > From: Gang Wu > Sent: Monday, October 23, 2023 13:29 > To: dev@arrow.apache.org > Subject: Re: [ANNOUNCE] New Arrow committer: Xuwei Fu > > Congrats Xuwei! > > Best, > Gang > > On Mon,

Re: Question about large exec batch in acero

2023-07-03 Thread Ruoxi Sun
> https://github.com/apache/arrow/blob/6af660f48472b8b45a5e01b7136b9b040b185eb1/cpp/src/arrow/acero/source_node.cc#L120 > > On Mon, Jul 3, 2023 at 6:50 AM Ruoxi Sun wrote: > > > Hi folks, > > > > I've encountered a bug when doing swiss join using a big exec batch, say,

Question about large exec batch in acero

2023-07-03 Thread Ruoxi Sun
Hi folks, I've encountered a bug when doing swiss join using a big exec batch, say, larger than 65535 rows, on the probe side. It turns out to be that in the algorithm, it is using `uint16_t` to represent the index within the probe exec batch (the materialize_batch_ids_buf

Re: Question about `minibatch`

2023-06-20 Thread Ruoxi Sun
fit of using small loops to increase the chances of encountering > special cases (e.g. all values null or no values null) which can sometimes > save you from more complex logic. > > On Tue, Jun 20, 2023 at 7:32 PM Ruoxi Sun wrote: > > > Hi, > > > > By looking at ac

Question about `minibatch`

2023-06-20 Thread Ruoxi Sun
Hi, By looking at acero code, I'm curious about the concept `minibatch` being used in swiss join and grouper. I wonder if its purpose is to proactively limit the memory size of the working set? Or is it the consequence of that the temp vector should be fix-sized (to avoid costly memory

Re: Probably an unnecessary copy when outputting join result?

2023-04-13 Thread Ruoxi Sun
6e182917-4a54-4a5c-8ccd-ac440cb8c...@gmail.com> > "Re: Probably an unnecessary copy when outputting join result?" on Thu, > 13 Apr 2023 10:57:59 -0700, > Sasha Krassovsky wrote: > > > Hi Rossi, > > I think for small PRs like this it is fine to just prefix your PR

Re: Probably an unnecessary copy when outputting join result?

2023-04-13 Thread Ruoxi Sun
ted issue. > > Sasha > > > On Apr 13, 2023, at 10:48 AM, Ruoxi Sun wrote: > > > > Hi Sasha, thanks for confirming. Wondering if I should file a github > issue for this kind of trivial fix? > > > > Rossi > > > > > > Sasha Krassovsky krassovs

Re: Probably an unnecessary copy when outputting join result?

2023-04-13 Thread Ruoxi Sun
r.com/2020/02/17/move-simply/> > [image: 4554b8d24c7f200dc5e2e1b18db1893f.png] > <https://herbsutter.com/2020/02/17/move-simply/> > <https://herbsutter.com/2020/02/17/move-simply/> > > > 13 апр. 2023 г., в 10:17, Ruoxi Sun написал(а): > > Hi folks, when reading the swiss j

Probably an unnecessary copy when outputting join result?

2023-04-13 Thread Ruoxi Sun
Hi folks, when reading the swiss join code, I just noticed a small piece probably missing a `std::move()` call. See here: https://github.com/zanmato1984/arrow/commit/10f43c357db7a0287c642a23e78027cb9cde6f25 If so, I think I can proceed to PR it. Thanks. *Rossi Sun*

Re: Question about thread local data in `QueryContext`

2023-03-09 Thread Ruoxi Sun
a > > > 9 марта 2023 г., в 21:57, Ruoxi Sun написал(а): > > > > Hi Sasha, thanks for the kind reply. Yeah, that makes sense for using > > thread local data to reduce the vector allocation/deallocation overhead. > > However I'm still wondering if this thread local

Re: Question about thread local data in `QueryContext`

2023-03-09 Thread Ruoxi Sun
e as a preparation to > refactor other nodes to use TempVectorStack when they need a temporary > block of memory. > > Hope this helps, > Sasha > > > 9 марта 2023 г., в 09:11, Ruoxi Sun написал(а): > > > > Hi folks, > > > > I see

Question about thread local data in `QueryContext`

2023-03-09 Thread Ruoxi Sun
Hi folks, I see that the member `tld_ ` in class `QueryContext` is used by `BloomFilterPushdownContext