Re: [DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?

2023-06-26 Thread Sutou Kouhei
In <20230621.095201.2105941307978780754@clear-code.com> "Re: [DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?" on Wed, 21 Jun 2023 09:52:01 +0900 (JST), Sutou Kouhei wrote: > Hi, > >> FYI3: We'll support Amazon Linux 2023 in Apache Arrow C++ >> 13.0.0: >> >> https://

Re: [DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?

2023-06-20 Thread Sutou Kouhei
@clear-code.com> "[DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?" on Fri, 16 Jun 2023 06:19:04 +0900 (JST), Sutou Kouhei wrote: > Hi, > > We require CMake 3.5+ now because Ubuntu 18.04 ships 3.5. > We dropped support for Ubuntu 18.04 because it reached EOL. > &

Re: [DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?

2023-06-17 Thread Sutou Kouhei
Hi, No. The required glibc version isn't changed. Thanks, -- kou In "Re: [DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?" on Fri, 16 Jun 2023 21:55:03 -0400, Rusty Conover wrote: > Does this imply increasing the required glibc version for the manylinux > wh

Re: [DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?

2023-06-17 Thread Rusty Conover
Does this imply increasing the required glibc version for the manylinux wheels? Rusty On Thu, Jun 15, 2023 at 5:19 PM Sutou Kouhei wrote: > > Hi, > > We require CMake 3.5+ now because Ubuntu 18.04 ships 3.5. > We dropped support for Ubuntu 18.04 because it reached EOL. > > Can we require CMake

Re: [DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?

2023-06-16 Thread Antoine Pitrou
Well, precompiled headers do not necessarily work well with ccache: https://github.com/apache/arrow/issues/35641#issuecomment-1551775293 But agreed with the rest. Le 16/06/2023 à 02:15, Sutou Kouhei a écrit : Hi, Ah, sorry. I should have written it in the original e-mail. If we can

Re: [DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?

2023-06-15 Thread Sutou Kouhei
-5cdc95f4e1b618f2f3ef10d370ce05a1ac05d9d401aecff3ccbb3d76bd366b6aL1203 * Jacob wants to use FetchContent related features: https://github.com/apache/arrow/pull/35921#issuecomment-1585428356 Thanks, -- kou In "Re: [DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?" on Thu, 15 Jun 2023 23:36:10 +0200, Antoine Pitrou wrote

Re: [DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?

2023-06-15 Thread Jacob Wujciak-Jens
+1 on 3.16 and dropping amazon linux 2 (as that is recommended by aws). @antonie 3.14+ has a number of improvements to FetchContent that we could use to vastly improve our bundled dependency system. There are also improvements to precompiled headers etc. an overview of some of the changes in each

Re: [DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?

2023-06-15 Thread Antoine Pitrou
Hi, I'd ask the question differently: what do we gain from requiring 3.16 rather than 3.13? Le 15/06/2023 à 23:19, Sutou Kouhei a écrit : Hi, We require CMake 3.5+ now because Ubuntu 18.04 ships 3.5. We dropped support for Ubuntu 18.04 because it reached EOL. Can we require CMake 3.16+

[DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?

2023-06-15 Thread Sutou Kouhei
Hi, We require CMake 3.5+ now because Ubuntu 18.04 ships 3.5. We dropped support for Ubuntu 18.04 because it reached EOL. Can we require CMake 3.16+ in Apache Arrow C++ 13.0.0? Here are CMake versions of our supported platforms: * Ubuntu 20.04: CMake 3.16 * CentOS 7: CMake 3.17 * Debian