Re: [DISCUSS][Format][C++] Improvement of sparse tensor format and implementation

2019-09-02 Thread Kenta Murata
2019年8月28日(水) 8:57 Rok Mihevc : > > On Wed, Aug 28, 2019 at 1:18 AM Wes McKinney wrote: > > > null/NA. But, as far as I'm aware, this component of pandas is > > relatively unique and was never intended as an alternatives to sparse > > matrix libraries. > > > > Another example is >

Re: [DISCUSS][Format][C++] Improvement of sparse tensor format and implementation

2019-09-02 Thread Kenta Murata
2019年8月28日(水) 6:05 Wes McKinney : > I'm also OK with these changes. Since we have not established a > versioning or compatibility policy with regards to "Other" data > structures like Tensor and SparseTensor, I don't know that a vote is > needed, just a pull request. I didn't understand that

Re: [DISCUSS][Format][C++] Improvement of sparse tensor format and implementation

2019-08-27 Thread Rok Mihevc
On Wed, Aug 28, 2019 at 1:18 AM Wes McKinney wrote: > null/NA. But, as far as I'm aware, this component of pandas is > relatively unique and was never intended as an alternatives to sparse > matrix libraries. > Another example is

Re: [DISCUSS][Format][C++] Improvement of sparse tensor format and implementation

2019-08-27 Thread Wes McKinney
On Tue, Aug 27, 2019 at 6:07 PM Neal Richardson wrote: > > Forgive me if this is off topic; I haven't been following this closely > and I haven't used scipy.sparse. But there are some very reasonable > cases where you might want to fill sparse data with a value other than > 0: > > * The

Re: [DISCUSS][Format][C++] Improvement of sparse tensor format and implementation

2019-08-27 Thread Neal Richardson
Forgive me if this is off topic; I haven't been following this closely and I haven't used scipy.sparse. But there are some very reasonable cases where you might want to fill sparse data with a value other than 0: * The sparseness is missing data, and 0 is not the same as NA * Better compression:

Re: [DISCUSS][Format][C++] Improvement of sparse tensor format and implementation

2019-08-27 Thread Rok Mihevc
On Tue, Aug 27, 2019 at 11:05 PM Wes McKinney wrote: > I don't think this has been discussed. I think the SparseTensor > discussions have been intended to reach compatibility with "sparse > matrix" projects like scipy.sparse. pandas's "SparseArray" objects are > a distinct thing -- I don't know

Re: [DISCUSS][Format][C++] Improvement of sparse tensor format and implementation

2019-08-27 Thread Wes McKinney
I'm also OK with these changes. Since we have not established a versioning or compatibility policy with regards to "Other" data structures like Tensor and SparseTensor, I don't know that a vote is needed, just a pull request. On Wed, Aug 21, 2019 at 1:11 PM Rok Mihevc wrote: > > Hi, > > On Mon,

Re: [DISCUSS][Format][C++] Improvement of sparse tensor format and implementation

2019-08-21 Thread Rok Mihevc
Hi, On Mon, Aug 19, 2019 at 11:30 AM Kenta Murata wrote: > (3) Adding SparseCSCIndex > I'd be interested to help with (Python) part of this SparseCSCIndex. I’d appreciate any comments or suggestions. > I missed previous discussion, so this might have already been discussed, but did we ever

Re: [DISCUSS][Format][C++] Improvement of sparse tensor format and implementation

2019-08-19 Thread Antoine Pitrou
Hi, This sounds fine on the principle. I'll let other comment on the details. Regards Antoine. Le 19/08/2019 à 11:29, Kenta Murata a écrit : > Hi, > > I’d like to propose the following improvement of the sparse tensor > format and implementation. > > (1) To make variable bit-width

[DISCUSS][Format][C++] Improvement of sparse tensor format and implementation

2019-08-19 Thread Kenta Murata
Hi, I’d like to propose the following improvement of the sparse tensor format and implementation. (1) To make variable bit-width indices available. The main purpose of the first part of the proposal is making 32-bit indices available. It allows us to serialize scipy.sparse.csr_matrix objects