Re: [DISCUSS] Reviewing Arrow commit/code review policy

2019-10-14 Thread Uwe L. Korn
Hello all, I also think we should stay with CTR for the moment. If we wanted to enforce RTC or at least a bit better notification for reviewers of certain parts of Arrow, we could setup a CODEOWNERS file[1] to add experts of a certain file/folder as a reviewer on PRs on Github. Cheers Uwe

Re: [DISCUSS] Reviewing Arrow commit/code review policy

2019-10-12 Thread Andy Grove
Wes, Thanks for clarifying this. This will be very helpful for me while I work on the Rust DataFusion crate since we have a small number of committers today. I will still generally make PRs available for review (unless they are trivial changes) but being able to merge without review when the

[DISCUSS] Reviewing Arrow commit/code review policy

2019-10-12 Thread Wes McKinney
hi folks, We've added many new committers to Apache Arrow over the last 3+ years, so I thought it would be worthwhile to review our commit and code review policy for everyone's benefit. Since the beginning of the project, Arrow has been in "Commit Then Review" mode (aka CTR).