Re: [Rust] move parquet into a separate sub-crate

2018-12-31 Thread Chao Sun
Thanks Krisztian, I think you are right at the beginning. I was concerned about the crate dependency but didn't know this can be solved by cargo workspace + path dependency. I've filed ARROW-4137 with a PR. Chao On Sun, Dec 30, 2018 at 4:32 AM Krisztián Szűcs wrote: > Hi! > > I support the

Re: [Rust] move parquet into a separate sub-crate

2018-12-30 Thread Krisztián Szűcs
Hi! I support the idea[1]! Cheers, Krisztian [1] https://github.com/apache/arrow/pull/3050#discussion_r237412529 On Thu, Dec 27, 2018 at 9:10 PM Chao Sun wrote: > Hi, > > It just occurs to me that it may be a better idea to move the parquet > module into a separate sub-crate by using cargo

Re: [Rust] move parquet into a separate sub-crate

2018-12-29 Thread paddy horan
Ok, thanks Chao. Sounds good to me then. P From: Chao Sun Sent: Saturday, December 29, 2018 2:20 AM To: dev@arrow.apache.org Subject: Re: [Rust] move parquet into a separate sub-crate Thanks Paddy. Similarly, I can't see a reason for arrow to reference parquet

Re: [Rust] move parquet into a separate sub-crate

2018-12-28 Thread Chao Sun
t; Sent: Thursday, December 27, 2018 10:09 PM > To: dev@arrow.apache.org<mailto:dev@arrow.apache.org> > Subject: Re: [Rust] move parquet into a separate sub-crate > > Cool. It may also be worthy to put adapters into a separate crate. > > On Fri, Dec 28, 2018 at 4:10 AM Chao Sun

RE: [Rust] move parquet into a separate sub-crate

2018-12-28 Thread paddy horan
crates to flow up? i.e. that arrow would be allowed to reference the parquet sub-crate. P From: Renjie Liu<mailto:liurenjie2...@gmail.com> Sent: Thursday, December 27, 2018 10:09 PM To: dev@arrow.apache.org<mailto:dev@arrow.apache.org> Subject: Re: [Rust] move parquet into a separa

Re: [Rust] move parquet into a separate sub-crate

2018-12-27 Thread Renjie Liu
Cool. It may also be worthy to put adapters into a separate crate. On Fri, Dec 28, 2018 at 4:10 AM Chao Sun wrote: > Hi, > > It just occurs to me that it may be a better idea to move the parquet > module into a separate sub-crate by using cargo workspaces >

[Rust] move parquet into a separate sub-crate

2018-12-27 Thread Chao Sun
Hi, It just occurs to me that it may be a better idea to move the parquet module into a separate sub-crate by using cargo workspaces . The advantage is that we can make the project more modular (in future, we may want to add more