[jira] [Commented] (ARROW-23) C++: Add logical "Column" container for chunked data

[ https://issues.apache.org/jira/browse/ARROW-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179232#comment-15179232 ] Wes McKinney commented on ARROW-23: --- See patch https://github.com/apache/arrow/pull/15 > C++: Add logical

[jira] [Assigned] (ARROW-23) C++: Add logical "Column" container for chunked data

[ https://issues.apache.org/jira/browse/ARROW-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wes McKinney reassigned ARROW-23: - Assignee: Wes McKinney > C++: Add logical "Column" container for chunked data >

Re: Format: storing null count + required/non-nullable types

Returning to this discussion. I did some C++ prototyping https://github.com/apache/arrow/pull/9 https://github.com/apache/arrow/pull/10 A handful of thoughts: 1) It is most useful for compatibility with other systems (e.g. Parquet -- see ARROW-22) to have required/optional in the type metadata,

Re: Code reviews / commit-then-review?

sounds good. On Thu, Mar 3, 2016 at 1:17 PM, Jason Altekruse wrote: > +1 > > On Thu, Mar 3, 2016 at 12:58 PM, Jacques Nadeau > wrote: > > > +1. Sounds good to me. > > > > On Thu, Mar 3, 2016 at 12:35 PM, P. Taylor Goetz > >

Re: Code reviews / commit-then-review?

+1 On Thu, Mar 3, 2016 at 12:58 PM, Jacques Nadeau wrote: > +1. Sounds good to me. > > On Thu, Mar 3, 2016 at 12:35 PM, P. Taylor Goetz > wrote: > > > +1 > > > > I think CTR makes sense at this stage. RTC would slow things down > > considerably. > > > >

Re: Code reviews / commit-then-review?

+1 I think CTR makes sense at this stage. RTC would slow things down considerably. -Taylor > On Mar 3, 2016, at 3:00 PM, Julian Hyde wrote: > > +1 > > Thanks for asking. > > >> On Mar 3, 2016, at 11:22 AM, Wes McKinney wrote: >> >> hi folks, >> >>

Code reviews / commit-then-review?

hi folks, I'm going to have many C++ and Python patches the next few weeks, any objections to proceeding in commit-then-review mode (particularly on the Python side) for the time being in the interest of expediency? I will be more than happy to collect feedback from merged patches into new JIRAs