I always thought it was confusing that the ReplicatePOperator used the
SPLIT tag. I think making the name consistent would be nice.
On Tue, Sep 27, 2016 at 5:08 PM, Yingyi Bu wrote:
> Taewoo,
>
> I agree with you.
> However, can you have two separate changes:
> 1. Your
Looks good, ready to merge.
Cheers,
Till
On 27 Sep 2016, at 17:11, Taewoo Kim wrote:
> @Yingyi: Thanks for the suggestion. Actually, I have crated a separate
> patch for this change only: https://asterix-gerrit.ics.uci.edu/#/c/1219/.
> Once this is merged, the review for the second step would
All right, that also works, thanks!
Best,
Yingyi
On Tue, Sep 27, 2016 at 5:11 PM, Taewoo Kim wrote:
> @Yingyi: Thanks for the suggestion. Actually, I have crated a separate
> patch for this change only: https://asterix-gerrit.ics.uci.edu/#/c/1219/.
> Once this is merged,
@Yingyi: Thanks for the suggestion. Actually, I have crated a separate
patch for this change only: https://asterix-gerrit.ics.uci.edu/#/c/1219/.
Once this is merged, the review for the second step would be much easier.
Best,
Taewoo
On Tue, Sep 27, 2016 at 5:08 PM, Yingyi Bu
Taewoo,
I agree with you.
However, can you have two separate changes:
1. Your current change https://asterix-gerrit.ics.uci.edu/#/c/1196/. Call
your "Split" "PartitionSplit" for now.
2. Do what you proposed in the next change which only does the renaming.
That makes reviews less overwhelming