I see. I think this is related to isomorphism. As the comment says, we need
to find a way to resolve "complication of figuring out whether the firstOp
in an equivalence class is within a subplan".
Best,
Taewoo
On Sat, Oct 19, 2019 at 12:40 PM Wail Alkowaileet
wrote:
> Hi Taewoo,
>
> I might
Hi Taewoo,
I might be got confused by the comment. But still did not get why it
is commented?
Sub-plans are missing a few optimizations. For example after
uncommenting this code and fixing InlineSingleReferenceVariableRule
for sub-plans we get:
Before:
subplan {
Hi Wail,
I think that's what the comment implies (I could not produce an expression
where it used in a sub-plan and not visible to upper operators?). If you
want to make it happen, a workaround might be introducing a project
operator within the subplan of the subplan operator? Actually, if a
Hi Dev,
I'm not sure about the commented code in [1]. I could not produce an
expression where it used in a sub-plan and not visible to upper operators?
Also, all SQL++ runtime integration tests seem to work just fine.
[1] ExtractCommonExpressionsRule.java#L192
