Re: OptimizedHybridHashJoinOperatorDescriptor vs. HybridHashJoinOperatorDescriptor

2018-11-08 Thread Xikui Wang
Hi Yingyi, Thanks for your reply. I think you are right. The two seem to serve the same purpose except that the unoptimized one has less documentation and no memory management. I will propose a patch later to remove that. Best, Xikui On Thu, Nov 8, 2018 at 9:54 PM Yingyi Bu wrote: > I'm not su

Re: OptimizedHybridHashJoinOperatorDescriptor vs. HybridHashJoinOperatorDescriptor

2018-11-08 Thread Yingyi Bu
I'm not sure if it's still correct, but based on my understanding, OptimizedHybridHashJoinOperatorDescriptor does the role reversal optimization which was done by Pouria, while HybridHashJoinOperatorDescriptor was the old implementation before Pouria's work and probably could be deleted. Best, Yin

OptimizedHybridHashJoinOperatorDescriptor vs. HybridHashJoinOperatorDescriptor

2018-11-08 Thread Xikui Wang
Hi Devs, Does anyone know what's the difference between the OptimizedHybridHashJoinOperatorDescriptor and the HybridHashJoinOperatorDescriptor? I was going over part of the join codes and found both of these classes there. It seems the only difference between the two is when there is a hashFuncti