-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74939/
-----------------------------------------------------------

(Updated March 21, 2024, 8:59 a.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah.


Bugs: ATLAS-4842
    https://issues.apache.org/jira/browse/ATLAS-4842


Repository: atlas


Description (updated)
-------

Steps:

create two hive_tables in same database:

1. create table hive1(id int);
2. create table hive2(name string);
3. Perform incremental export of hive1 with changeMarker provided by previous 
export.
4. Import the zip.

Expectations:

a) Expectation is only the requested hive_table hive1 should be exported.

Problem:

hive2 is also imported.

Solution:

1. Earlier, the implementation for fetchType as INCREMENTAL was getting 
satisfied only if the value of skipLineage was "true" otherwise it was 
implementing the default fetchType i.e FULL fetch and hence, all the unrelated 
entities was also getting fetched.

2. Now, the problem is fixed by adding additional condition which will handle 
INCREMENTAL fetchType even if the value for skipLineage is false.


Diffs
-----

  
repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java
 da5cf37c4 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
65d7a1872 


Diff: https://reviews.apache.org/r/74939/diff/1/


Testing
-------

Manual testing has been done for the same.

PC Link : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1573/


Thanks,

Priyanshi Shah

Reply via email to