[GitHub] [atlas] mneethiraj commented on issue #54: ATLAS-3219: New REST APIs for serviceType.

2019-06-01 Thread GitBox
mneethiraj commented on issue #54: ATLAS-3219: New REST APIs for serviceType. URL: https://github.com/apache/atlas/pull/54#issuecomment-497962025 @ZepHakase22 - yes, you are right. The changes in pull request for ATLAS-3180 (https://github.com/apache/atlas/pull/49/) looks good. I will merge

[GitHub] [atlas] mneethiraj commented on issue #54: ATLAS-3219: New REST APIs for serviceType.

2019-05-31 Thread GitBox
mneethiraj commented on issue #54: ATLAS-3219: New REST APIs for serviceType. URL: https://github.com/apache/atlas/pull/54#issuecomment-497836978 > I didn't understand if you propose to add new REST APIs by type /enumdef /servicetype/hive for example) I propose no new APIs. Simply enha

[GitHub] [atlas] mneethiraj commented on issue #54: ATLAS-3219: New REST APIs for serviceType.

2019-05-31 Thread GitBox
mneethiraj commented on issue #54: ATLAS-3219: New REST APIs for serviceType. URL: https://github.com/apache/atlas/pull/54#issuecomment-497835036 bq. moving the work on the client only works if you use the ATLAS API. If for example I use json scripts and curl I have to do all the work from

[GitHub] [atlas] mneethiraj commented on issue #54: ATLAS-3219: New REST APIs for serviceType.

2019-05-31 Thread GitBox
mneethiraj commented on issue #54: ATLAS-3219: New REST APIs for serviceType. URL: https://github.com/apache/atlas/pull/54#issuecomment-497806267 bq. Furthermore, DELETE, obviously needs a separate code. For DELETE by service-type, I would suggest to have the client to perform the follow

[GitHub] [atlas] mneethiraj commented on issue #54: ATLAS-3219: New REST APIs for serviceType.

2019-05-28 Thread GitBox
mneethiraj commented on issue #54: ATLAS-3219: New REST APIs for serviceType. URL: https://github.com/apache/atlas/pull/54#issuecomment-496745311 @ZepHakase22 - instead of adding new REST endpoints (for /servicetype/{serviceType}), I suggest to recognize "serviceType" parameter in FilterU