Re: Review Request 60272: ATLAS-1891 Additional Validation checks for RelationshipDefs

2017-06-26 Thread Sarath Subramanian
> On June 25, 2017, 11:24 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java > > Lines 413 (patched) > > > > > > should we add

Re: Review Request 60272: ATLAS-1891 Additional Validation checks for RelationshipDefs

2017-06-26 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60272/ --- (Updated June 26, 2017, 4:18 p.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 60272: ATLAS-1891 Additional Validation checks for RelationshipDefs

2017-06-26 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60272/#review178890 --- Ship it! Ship It! - Madhan Neethiraj On June 26, 2017,

Re: Review Request 60272: ATLAS-1891 Additional Validation checks for RelationshipDefs

2017-06-26 Thread David Radley
> On June 26, 2017, 6:24 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java > > Lines 84 (patched) > > > > > > line 84 and 86

Re: Review Request 60272: ATLAS-1891 Additional Validation checks for RelationshipDefs

2017-06-26 Thread David Radley
> On June 25, 2017, 10:41 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java > > Line 269 (original) > > > > > > When would the