Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 5:06 p.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Endpoint.java > > Lines 60 (patched) > > > > > > The field name encrypted implies that it is a boolean.

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 5:06 p.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Meaning.java > > Lines 31 (patched) > > > > > > should be include the guid of the term here. That would

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 5:06 p.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/License.java > > Lines 251 (patched) > > > > > > I am wondering why the license conditions is plural

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 5:27 p.m., Madhan Neethiraj wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java > > Lines 41 (patched) > > > > > > >> These properties are not used in

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review192307 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review192295 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 29, 2017, 4 p.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java > > Lines 38 (patched) > > > > > > I am unsure what the thinking is here - the super

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 13, 2017, 9:07 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java > > Lines 44 (patched) > > > > > > this part is not consistent with the ConnectorBroker code.

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 14, 2017, 12:25 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java > > Lines 27 (patched) > > > > > > model 0101 does not exist in this > >

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 14, 2017, 10:06 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java > > Lines 134 (patched) > > > > > > Do you mean in the ConnectorProvider class, it doesn't > >

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 10:29 a.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java > > Lines 36 (patched) > > > > > > would it not be better to say > > > >

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 11:08 a.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java > > Lines 39 (patched) > > > > > > I think you mean annotaiotn not enumeration here.

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 10:59 a.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java > > Lines 35 (patched) > > > > > > I suggest only having a constructor that supplies

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 10:59 a.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java > > Lines 33 (patched) > > > > > > I suggest that we could remove this count logic - I

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 11:08 a.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java > > Lines 44 (patched) > > > > > > I think we can make this and other enum

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 10:59 a.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java > > Lines 141 (patched) > > > > > > Maybe I have missed it - I am wondering how a user needs

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 29, 2017, 4 p.m., David Radley wrote: > > om-fwk-ocf/src/test/java/org/apache/atlas/ocf/test/QuickTest.java > > Lines 45 (patched) > > > > > > I suggest moving these tests into junits so they can be run as

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 14, 2017, 10:06 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java > > Lines 164 (patched) > > > > > > I didn't find this class's definiation in the patch

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review192260 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review192254 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review192180 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review192123 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 6, 2017, 12:50 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java > > Lines 164 (patched) > > > > > > I'm a little bit confused, when do you use

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review190936 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review190924 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 13, 2017, 9:07 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java > > Lines 44 (patched) > > > > > > this part is not consistent with the ConnectorBroker code.

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review190803 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/ --- (Updated Nov. 10, 2017, 12:48 p.m.) Review request for atlas and Madhan

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/ --- (Updated Nov. 10, 2017, 12:45 p.m.) Review request for atlas and Madhan

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 1:27 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaAttribute.java > > Lines 67 (patched) > > > > > > is that necessary to check whether

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 1:27 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Schema.java > > Lines 49 (patched) > > > > > > this is class is not included in the patch, I can't find it.

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 2:55 p.m., Yao Li wrote: > > based on your OCF document, Connector Instance Adapter and Connector > > Provider Adapter are not in the patch Agreed - With the base classes for connector and connector provider, I do not think we need this - Mandy

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 5:55 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedAssetProperties.java > > Lines 45 (patched) > > > > > > AssetUniverse extends AssetDetail which extends

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 5:55 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/OperationalStatus.java > > Lines 23 (patched) > > > > > > should here be the explanation of OperationalStatus?

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 5:55 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/MapSchemaElement.java > > Lines 20 (patched) > > > > > > Would you mind adding an explanation for this Class? I

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 6, 2017, 2:38 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java > > Lines 47 (patched) > > > > > > AssetUniverse extends AssetDetail which

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 7, 2017, 5:55 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Feedback.java > > Lines 23 (patched) > > > > > > if the client wants to add one comment/tag to an asset, which

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 6, 2017, 12:50 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java > > Lines 164 (patched) > > > > > > I'm a little bit confused, when do you use

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 3, 2017, 9:26 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java > > Lines 91 (patched) > > > > > > lack ">" on "

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review190294 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review190269 --- - Yao Li On Nov. 2, 2017, 12:27 p.m., Mandy Chessell wrote: >

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review190164 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review190146 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review190020 ---

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/ --- (Updated Nov. 2, 2017, 12:27 p.m.) Review request for atlas and Madhan

<    1   2