Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 7, 2019, 2:47 a.m., Aadarsh Jajodia wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/events/CreateImpalaProcess.java > > Lines 236 (patched) > > > > > > Add comment for method

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 9, 2019, 12:32 a.m., Sarath Subramanian wrote: > > Ship It! Let us hold on ship it. I need some clarity on this? - Sridhar --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/#review215151 ---

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/#review215152 ---

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/#review215151 ---

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/#review215151 ---

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/#review215145 --- Ship it! Ship It! - Sarath Subramanian On May 8, 2019, 2:36

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 8, 2019, 7:35 p.m., Xinran Tinney wrote: > > addons/impala-bridge/src/main/resources/import-impala.sh > > Lines 88 (patched) > > > > > > should we remove this since it is printing too much information in

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/ --- (Updated May 8, 2019, 9:36 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/#review215135 --- addons/impala-bridge/src/main/resources/import-impala.sh Lines

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/ --- (Updated May 8, 2019, 7:20 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 7, 2019, 11:37 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/resources/import-impala.sh > > Lines 60 (patched) > > > > > > why do we hardcode ATLAS lib path here? changed to relative

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 7, 2019, 11:37 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/ImpalaLineageTool.java > > Lines 48 (patched) > > > > > > we don't need 'args' to be stored as

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 7, 2019, 2:47 a.m., Aadarsh Jajodia wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/ImpalaLineageTool.java > > Lines 64 (patched) > > > > > > Replace with > > LOG.info("Importing:

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 7, 2019, 12:54 a.m., Sridhar K wrote: > > addons/impala-bridge/pom.xml > > Lines 65 (patched) > > > > > > Can we please move this version to a variable? done > On May 7, 2019, 12:54 a.m., Sridhar K

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/#review215106 ---

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/#review215078 ---

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/#review215076 --- My review is still pending. thanks, -Sridhar

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/ --- (Updated May 4, 2019, 9:23 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 2:01 a.m., Madhan Neethiraj wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/ImpalaLineageTool.java > > Lines 54 (patched) > > > > > > It may not be useful to designate a

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 2:01 a.m., Madhan Neethiraj wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/LineageQuery.java > > Lines 35 (patched) > > > > > > Consider renaming LineageQuery to

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 7:41 a.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/events/CreateImpalaProcess.java > > Lines 193 (patched) > > > > > > consider registering

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 7:38 a.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/LineageVertex.java > > Lines 39 (patched) > > > > > > make vertexType as enum done - Na

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 7:38 a.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/events/CreateImpalaProcess.java > > Lines 204 (patched) > > > > > > dependencyType can not

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 7:38 a.m., Sarath Subramanian wrote: > > addons/impala-bridge-shim/pom.xml > > Lines 28 (patched) > > > > > > shim is not needed; since this will be used as a standalone utility. removed > On

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 2:01 a.m., Madhan Neethiraj wrote: > > addons/impala-bridge-shim/src/main/java/org.apache.atlas.impala/ImpalaLineageTool.java > > Lines 35 (patched) > > > > > > Shim is not needed for

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/#review215013 --- addons/impala-bridge-shim/pom.xml Lines 28 (patched)

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/#review215016 ---

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/#review215010 ---

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/ --- (Updated May 2, 2019, 8:31 p.m.) Review request for atlas, Ashutosh Mestry,