Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222501 --- Ship it! Ship It! - Madhan Neethiraj On Jan. 20, 2021, 6:49

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

> On Jan. 20, 2021, 12:54 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/query/DSLVisitor.java > > Line 232 (original), 247 (patched) > > > > > > Shouldn't a new GremlinQueryComposer be

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

> On Jan. 16, 2021, 7:54 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java > > Lines 108 (patched) > > > > > > Can you review how thi

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 20, 2021, 6:49 p.m.) Review request for atlas, Apoorv Naik, Madha

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222498 --- repository/src/main/java/org/apache/atlas/query/DSLVisitor.java L

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 19, 2021, 4:52 a.m.) Review request for atlas, Apoorv Naik, Madha

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

> On Jan. 15, 2021, 9:59 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java > > Lines 65 (patched) > > > > > > trLists and collected po

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222483 --- repository/src/main/java/org/apache/atlas/query/GremlinQueryCompo

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 16, 2021, 7:06 a.m.) Review request for atlas, Apoorv Naik, Nikhi

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222481 --- repository/src/main/java/org/apache/atlas/query/AtlasDSL.java Lin

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

> On Jan. 14, 2021, 3:58 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java > > Lines 88 (patched) > > > > > > subTraversals could be an

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 15, 2021, 9:22 p.m.) Review request for atlas, Apoorv Naik, Nikhi

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222472 --- repository/src/main/java/org/apache/atlas/query/GremlinQueryCompo

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

> On Jan. 14, 2021, 5:12 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/query/executors/SelectClauseProjections.java > > Lines 145 (patched) > > > > > > if vertex doesn't have the propert

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 14, 2021, 6:46 a.m.) Review request for atlas, Apoorv Naik, Nikhi

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222470 --- repository/src/main/java/org/apache/atlas/query/SelectClauseCompo

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

> On Jan. 13, 2021, 8:46 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > > Line 120 (original), 142 (patched) > > > > > > - for readability, and to

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 14, 2021, 1:04 a.m.) Review request for atlas, Apoorv Naik, Nikhi

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222466 --- repository/src/main/java/org/apache/atlas/discovery/EntityDiscove

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

- Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222455 --- On Jan. 13, 2021, 8:26 p.m., Ashutosh Mestry wrote: >

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

> On Jan. 13, 2021, 5:12 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java > > Lines 51 (patched) > > > > > > subTraversals is used onl

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 13, 2021, 8:26 p.m.) Review request for atlas, Apoorv Naik, Nikhi

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

> On Jan. 13, 2021, 6:15 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/query/executors/TraversalBasedExecutor.java > > Lines 103 (patched) > > > > > > can there be a case where query c

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222455 --- repository/src/main/java/org/apache/atlas/query/AtlasDSL.java Lin

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222457 --- graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/j

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 12, 2021, 11:49 p.m.) Review request for atlas, Apoorv Naik, Nikh

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 12, 2021, 10:41 p.m.) Review request for atlas, Apoorv Naik, Nikh

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 12, 2021, 9:01 p.m.) Review request for atlas, Apoorv Naik, Nikhi

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222441 --- repository/src/main/java/org/apache/atlas/query/executors/Travers

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222442 --- repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.ja

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222440 --- repository/src/main/java/org/apache/atlas/query/executors/Travers