Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70789/ --- (Updated June 7, 2019, 10:28 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

> On June 7, 2019, 1:55 p.m., Sridhar K wrote: > > intg/src/main/java/org/apache/atlas/ApplicationProperties.java > > Lines 52 (patched) > > > > > > It is confusing herewhy two properties? > > Madhan Neethiraj

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

> On June 7, 2019, 1:55 p.m., Sridhar K wrote: > > intg/src/main/java/org/apache/atlas/ApplicationProperties.java > > Lines 52 (patched) > > > > > > It is confusing herewhy two properties?

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70789/#review215745 --- Review is not yet complete.

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70789/ --- (Updated June 7, 2019, 8 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70789/#review215726 --- Ship it! Ship It! - Sridhar K On June 6, 2019, 8:18 p.m.,

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70789/#review215724 --- Ship it! Ship It! - Sridhar K On June 6, 2019, 8:18 p.m.,

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

> On June 6, 2019, 4:50 p.m., Sridhar K wrote: > > repository/src/main/java/org/apache/atlas/repository/patches/FreeTextRequestHandlerPatch.java > > Lines 27 (patched) > > > > > > Can we remove this class initialize

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

> On June 6, 2019, 4:50 p.m., Sridhar K wrote: > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphSolrIndexClient.java > > Line 38 (original), 38 (patched) > > > > > > I liked

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70789/ --- (Updated June 6, 2019, 8:18 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70789/#review215718 --- Thanks for doing this so quickly. I do have some suggestions.

Re: Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70789/#review215717 --- Found testcase failure, I guess its related to this fix.

Review Request 70789: ATLAS-3262: disabled full-text index population when free-text is enabled i.e. for Solr index store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70789/ --- Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt,