Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review217098 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 6, 2019, 12:24

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/ --- (Updated Aug. 6, 2019, 12:24 a.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review217093 --- Fix it, then Ship it!

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review217091 --- Ship it! Ship It! - Sarath Subramanian On Aug. 5, 2019,

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

> On Aug. 5, 2019, 10:01 p.m., Ashutosh Mestry wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > > Lines 1040 (patched) > > > > > > What is the penalty imposed on current entity creation

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/ --- (Updated Aug. 5, 2019, 10:19 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review217086 --- intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/ --- (Updated Aug. 5, 2019, 4:35 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review217069 --- Fix it, then Ship it! nice work on the topological sorting!

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review216871 --- Ship it! LGTM!! - Aadarsh Jajodia On July 25, 2019, 8:20

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/ --- (Updated July 25, 2019, 8:20 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review216865 --- intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review216838 --- Looks good to me. Nice done! - Le Ma On July 23, 2019, 11:22

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/ --- (Updated July 23, 2019, 11:22 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

> On July 23, 2019, 8:17 p.m., Aadarsh Jajodia wrote: > > Can we use a simple adjacency list to represent the graph. Something like a > > Map > to represent the graph. And also I feel we can > > just use a visited set and stack to maintain the topological order? Maybe > > that's simpler?

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review216815 --- Hello Merryle, the toplogical sort algo is very nice done. I just

Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review216812 --- Can we use a simple adjacency list to represent the graph.

Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/ --- Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma,