Re: Review Request 72527: Refactoring Kafka JAAS Configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/#review220879 --- Ship it! Ship It! - Nixon Rodrigues On May 27, 2020, 6:10

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/ --- (Updated May 27, 2020, 6:10 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/#review220866 --- Fix it, then Ship it!

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/#review220867 --- Ship it! Ship It! - Nixon Rodrigues On May 25, 2020, 9:04

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

> On May 19, 2020, 4:26 p.m., Ashutosh Mestry wrote: > > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > > Lines 510 (patched) > > > > > > Refactor: Extract constant. This statement

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/ --- (Updated May 25, 2020, 9:04 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/#review220830 ---

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/#review220829 --- Please add some unit tests - Sarath Subramanian On May 19,

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/#review220828 --- Ship it! Ship It! - Sarath Subramanian On May 19, 2020,

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/#review220827 --- Ship it! Ship It! - Madhan Neethiraj On May 19, 2020, 11:25

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/ --- (Updated May 19, 2020, 11:25 a.m.) Review request for atlas, Madhan Neethiraj,