[jira] [Updated] (ATLAS-1894) UI : Search using entity and trait attributes
[ https://issues.apache.org/jira/browse/ATLAS-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-1894: --- Attachment: ATLAS-1894.3.patch > UI : Search using entity and trait attributes > - > > Key: ATLAS-1894 > URL: https://issues.apache.org/jira/browse/ATLAS-1894 > Project: Atlas > Issue Type: Bug >Reporter: Keval Bhatt >Assignee: Keval Bhatt > Attachments: ATLAS-1894.1.patch, ATLAS-1894.2.patch, > ATLAS-1894.3.patch, ATLAS-1894.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60159/#review179336 --- Ship it! Ship It! - Madhan Neethiraj On June 30, 2017, 6:27 a.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60159/ > --- > > (Updated June 30, 2017, 6:27 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Suma Shivaprasad. > > > Bugs: ATLAS-1880 > https://issues.apache.org/jira/browse/ATLAS-1880 > > > Repository: atlas > > > Description > --- > > See JIRA > > > Sample Request structure > > ```json > { > "typeName": "hive_table", > "excludeDeletedEntities": false, > "limit": 25, > "offset": 0, > "entityFilters": { > "condition": "AND", > "criterion": [{ > "attributeName": "retention", > "operator": "=", > "attributeValue": "10" > }, { > "condition": "OR", > "criterion": [{ > "attributeName": "createTime", > "operator": ">", > "attributeValue": "11" > }, { > "attributeName": "lastAccessTime", > "operator": "<=", > "attributeValue": "22" > }] > }] > } > } > ``` > > > Diffs > - > > client/src/main/java/org/apache/atlas/AtlasClientV2.java 61413428 > common/src/main/java/org/apache/atlas/repository/Constants.java ac022528 > distro/src/conf/atlas-log4j.xml e6c0d9f6 > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java > 841edf71 > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java > 1ff9d5ed > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java > 53f490f5 > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java > 0211ff05 > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java > 0077a21f > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/AndCondition.java > 68f0eb28 > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/HasPredicate.java > 24e4f5bc > > graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java > 54ff7cb7 > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java > 1ed1734f > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java > bd8b897f > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java > 7ec6ffeb > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java > 4073dd2a > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java > 4452bcdd > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java > 1ca900d8 > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java > a402c628 > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java > 21b64273 > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java > 923a198b > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 128cdbf9 > > repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java > b07091a0 > repository/src/main/java/org/apache/atlas/discovery/GremlinStep.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/discovery/SolrStep.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > 35dbf6c4 > > repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java > 3411f8de > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > 42bd58fb > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 9a8695af >
[jira] [Commented] (ATLAS-1863) Set default value for primitive types attributes in entity based on attributeDef in Typedef
[ https://issues.apache.org/jira/browse/ATLAS-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070121#comment-16070121 ] David Radley commented on ATLAS-1863: - I am not sure about this approach. - in principle I would have thought an optional attribute that is not specified means that it is not present and should not appear in a get. If we have a default value for an optional attribute - this is modelling in the style of an RDB schema, where all a tables columns are specified in the schema and need to exist in columns in the table, I would think we want to be looser than this. Json is flexible enough not to insist on attribute values being specified in the instances. - if we add defaultvalue to attributeDef it should have a meaning for all attributeDefs, including those of type struc or enum. I think it would be unintuitive to have a default structure when it was optional. Can you share the use cases you are thinking of that drive the need for this change please? > Set default value for primitive types attributes in entity based on > attributeDef in Typedef > --- > > Key: ATLAS-1863 > URL: https://issues.apache.org/jira/browse/ATLAS-1863 > Project: Atlas > Issue Type: Improvement > Components: atlas-intg >Reporter: Nixon Rodrigues >Assignee: Ruchi Solani >Priority: Critical > Fix For: 0.9-incubating > > Attachments: ATLAS-1863.2.patch, ATLAS-1863.3.patch, ATLAS-1863.patch > > > While creating entity if attribute value are not set explicitly for primitive > type which are optional, then default value should be set from attributedef. > eg of typedef attributeDef > {code} > "attributeDefs": [{ > "name": "sourceCode", > "typeName": "string", > "isOptional": true, > "cardinality": "SINGLE", > "valuesMinCount": 0, > "valuesMaxCount": 1, > "isUnique": false, > "isIndexable": true, > "defaultValue": "xyz" > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas
[ https://issues.apache.org/jira/browse/ATLAS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruchi Solani updated ATLAS-1896: Attachment: ATLAS-1896.patch > Add Cross Origin [CORS] headers for Atlas > -- > > Key: ATLAS-1896 > URL: https://issues.apache.org/jira/browse/ATLAS-1896 > Project: Atlas > Issue Type: Bug >Reporter: Nixon Rodrigues >Assignee: Ruchi Solani > Attachments: ATLAS-1896.patch > > > Add Cross Origin [CORS] headers for Atlas, make it configurable from > atlas-application properties -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas
[ https://issues.apache.org/jira/browse/ATLAS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruchi Solani updated ATLAS-1896: Attachment: (was: ATLAS-1896.patch) > Add Cross Origin [CORS] headers for Atlas > -- > > Key: ATLAS-1896 > URL: https://issues.apache.org/jira/browse/ATLAS-1896 > Project: Atlas > Issue Type: Bug >Reporter: Nixon Rodrigues >Assignee: Ruchi Solani > > Add Cross Origin [CORS] headers for Atlas, make it configurable from > atlas-application properties -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (ATLAS-1907) Create RelationshipDefs for all base models and use this definitions when creating edges for entities
[ https://issues.apache.org/jira/browse/ATLAS-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-1907: -- Summary: Create RelationshipDefs for all base models and use this definitions when creating edges for entities (was: Create RelationshipDefs for all base models and use the definitions in graph edges when creating entities) > Create RelationshipDefs for all base models and use this definitions when > creating edges for entities > - > > Key: ATLAS-1907 > URL: https://issues.apache.org/jira/browse/ATLAS-1907 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: trunk, 0.9-incubating, 0.8.1-incubating >Reporter: Sarath Subramanian >Assignee: Sarath Subramanian > > Create relationshipDefs for all out of the box models. Use relationshipDef > information when creating edges for composite attributes in entities. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60578/ --- Review request for atlas, David Radley and Madhan Neethiraj. Bugs: ATLAS-1907 https://issues.apache.org/jira/browse/ATLAS-1907 Repository: atlas Description --- Create relationshipDefs for all out of the box models. Use relationshipDef information when creating edges for composite attributes in entities. Diffs - addons/models/0010-base_model.json 7f64d85e addons/models/0030-hive_model.json b359ea82 addons/models/0050-falcon_model.json b7398ef4 addons/models/0060-hbase_model.json 42fe00c4 addons/models/0080-storm_model.json 095936e0 intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e3 intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 8d2e7ec5 intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 70e3067a intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java f85cf35c intg/src/main/java/org/apache/atlas/type/AtlasStructType.java c2e0be50 intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 29fae1c8 repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java 4530f51b repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 5ea4ff20 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 7b3f1e6e repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 86212338 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java ebf6a201 repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java PRE-CREATION Diff: https://reviews.apache.org/r/60578/diff/1/ Testing --- Tested using Postman REST client. Validated all hive_table creation works fine and lineage is rendered right. UTs/ITs in progress. Thanks, Sarath Subramanian