Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities

2017-06-30 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60578/
---

Review request for atlas, David Radley and Madhan Neethiraj.


Bugs: ATLAS-1907
https://issues.apache.org/jira/browse/ATLAS-1907


Repository: atlas


Description
---

Create relationshipDefs for all out of the box models. Use relationshipDef 
information when creating edges for composite attributes in entities.


Diffs
-

  addons/models/0010-base_model.json 7f64d85e 
  addons/models/0030-hive_model.json b359ea82 
  addons/models/0050-falcon_model.json b7398ef4 
  addons/models/0060-hbase_model.json 42fe00c4 
  addons/models/0080-storm_model.json 095936e0 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e3 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
8d2e7ec5 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 70e3067a 
  intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java f85cf35c 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java c2e0be50 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 29fae1c8 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 4530f51b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 5ea4ff20 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
 7b3f1e6e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
 86212338 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
 ebf6a201 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60578/diff/1/


Testing
---

Tested using Postman REST client.
Validated all hive_table creation works fine and lineage is rendered right.

UTs/ITs in progress.


Thanks,

Sarath Subramanian



[jira] [Updated] (ATLAS-1907) Create RelationshipDefs for all base models and use this definitions when creating edges for entities

2017-06-30 Thread Sarath Subramanian (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-1907:
--
Summary: Create RelationshipDefs for all base models and use this 
definitions when creating edges for entities  (was: Create RelationshipDefs for 
all base models and use the definitions in graph edges when creating entities)

> Create RelationshipDefs for all base models and use this definitions when 
> creating edges for entities
> -
>
> Key: ATLAS-1907
> URL: https://issues.apache.org/jira/browse/ATLAS-1907
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: trunk, 0.9-incubating, 0.8.1-incubating
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>
> Create relationshipDefs for all out of the box models. Use relationshipDef 
> information when creating edges for composite attributes in entities.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ATLAS-1863) Set default value for primitive types attributes in entity based on attributeDef in Typedef

2017-06-30 Thread David Radley (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070121#comment-16070121
 ] 

David Radley commented on ATLAS-1863:
-

I am not sure about this approach. 
- in principle I would have thought an optional attribute that is not specified 
means that it is not present and should not appear in a get. If we have a 
default value for an optional attribute - this is modelling in the style of an 
RDB schema, where all a tables columns are specified in the schema and need to 
exist in columns in the table, I would think we want to be looser than this. 
Json is flexible enough not to insist on attribute values being specified in 
the instances.
- if we add defaultvalue to attributeDef it should have a meaning for all 
attributeDefs, including those of type struc or enum. I think it would be 
unintuitive to have a default structure when it was optional. 

Can you share the use cases you are thinking of that drive the need for this 
change please?
 

> Set default value for primitive types attributes in entity based on 
> attributeDef in Typedef
> ---
>
> Key: ATLAS-1863
> URL: https://issues.apache.org/jira/browse/ATLAS-1863
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-intg
>Reporter: Nixon Rodrigues
>Assignee: Ruchi Solani
>Priority: Critical
> Fix For: 0.9-incubating
>
> Attachments: ATLAS-1863.2.patch, ATLAS-1863.3.patch, ATLAS-1863.patch
>
>
> While creating entity if attribute value are not set explicitly for primitive 
> type which are optional, then default value should be set from attributedef.
> eg of typedef attributeDef
> {code}
> "attributeDefs": [{
>   "name": "sourceCode",
>   "typeName": "string",
>   "isOptional": true,
>   "cardinality": "SINGLE",
>   "valuesMinCount": 0,
>   "valuesMaxCount": 1,
>   "isUnique": false,
>   "isIndexable": true,
>   "defaultValue": "xyz"
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas

2017-06-30 Thread Ruchi Solani (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ruchi Solani updated ATLAS-1896:

Attachment: (was: ATLAS-1896.patch)

> Add Cross Origin [CORS] headers for Atlas 
> --
>
> Key: ATLAS-1896
> URL: https://issues.apache.org/jira/browse/ATLAS-1896
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Ruchi Solani
>
> Add Cross Origin [CORS] headers for Atlas, make it configurable from 
> atlas-application properties   



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas

2017-06-30 Thread Ruchi Solani (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ruchi Solani updated ATLAS-1896:

Attachment: ATLAS-1896.patch

> Add Cross Origin [CORS] headers for Atlas 
> --
>
> Key: ATLAS-1896
> URL: https://issues.apache.org/jira/browse/ATLAS-1896
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Ruchi Solani
> Attachments: ATLAS-1896.patch
>
>
> Add Cross Origin [CORS] headers for Atlas, make it configurable from 
> atlas-application properties   



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (ATLAS-1888) UI - While Update Entity the data of type Long is not updating in entity from UI.

2017-06-30 Thread Keval Bhatt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt resolved ATLAS-1888.

Resolution: Fixed

Committed to master 
(http://git-wip-us.apache.org/repos/asf/incubator-atlas/commit/9a4ed469)

> UI - While Update Entity the data of type Long is not updating in entity from 
> UI.
> -
>
> Key: ATLAS-1888
> URL: https://issues.apache.org/jira/browse/ATLAS-1888
> Project: Atlas
>  Issue Type: Bug
>Reporter: Kalyani Kashikar
>Assignee: Kalyani Kashikar
> Attachments: ATLAS-1888.patch
>
>
> Step to reproduce :-
> * Search for the Table.
> * Go to sales_fact_monthly_mv, and update CreateTime, LastAccessTime
> * Click on update button
> * CreateTime and LastAccessTime are not updating properly.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Build failed in Jenkins: apache-atlas-nightly #788

2017-06-30 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-1880: search API with support for entity/tag attribute filters

[madhan] ATLAS-1894: Search using entity/tag attribute filters

--
[...truncated 542.63 KB...]
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST 
/api/atlas/entities/ca0199ba-f6a4-46fe-aa77-9564ec611fa2/traits HTTP/1.1" 201 - 
"-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "GET 
/api/atlas/entities/ca0199ba-f6a4-46fe-aa77-9564ec611fa2/traitDefinitions/PII_Traitsh3nc2oMid
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "GET 
/api/atlas/entities/ca0199ba-f6a4-46fe-aa77-9564ec611fa2/traitDefinitions 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "GET 
/api/atlas/entities/5304959d-91ca-4b85-bc5f-60a5d22ad7e4/traits HTTP/1.1" 200 - 
"-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST 
/api/atlas/entities/731194bb-1cbf-44e9-945f-273da162b97f HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "GET 
/api/atlas/entities/731194bb-1cbf-44e9-945f-273da162b97f HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST 
/api/atlas/entities/qualifiedName?type=hive_table=qualifiedName=tableqLy64iRvrt
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "GET 
/api/atlas/entities/731194bb-1cbf-44e9-945f-273da162b97f HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "GET 
/api/atlas/entities/aa389e50-ff98-485c-89f0-6edb6dce5a04/audit?count=10 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
400 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "GET 
/api/atlas/v2/types/typedef/name/qtBaZsODA1 HTTP/1.1" 404 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "GET 
/api/atlas/entities/3fdf7beb-85b6-4b02-a4e6-b27f8954795b HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "GET 
/api/atlas/v2/entity/guid/d3b752ef-2923-4315-a86b-2e154ee4c7dc HTTP/1.1" 200 - 
"-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/v2/entity/ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "POST 
/api/atlas/v2/entity/guid/random/classifications HTTP/1.1" 404 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "POST /api/atlas/v2/entity/bulk/ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "POST /api/atlas/v2/entity/ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "POST /api/atlas/v2/entity/ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "DELETE 
/api/atlas/v2/entity/bulk/?guid=41e51fdd-065e-43cf-853b-aefc818f7b65=43157ad5-ccfe-4116-8070-3e88debaf971
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "POST /api/atlas/v2/entity/ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "DELETE 
/api/atlas/v2/entity/uniqueAttribute/type/hive_db_v2?attr:name=dbcClyg9eFJG%EF%A0%AE%E6%82%BD%E4%8D%A5%E6%AF%9A%E1%BC%A1%EB%91%B8%E6%84%AA%E6%B2%B8%E5%A2%A8%E5%BE%81
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "DELETE 
/api/atlas/v2/entity/guid/random/classification/blah_trait HTTP/1.1" 400 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db_v2+where+name%3D'dbcClyg9eFJG'=10=0
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:24 +] 

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-30 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60159/#review179336
---


Ship it!




Ship It!

- Madhan Neethiraj


On June 30, 2017, 6:27 a.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60159/
> ---
> 
> (Updated June 30, 2017, 6:27 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1880
> https://issues.apache.org/jira/browse/ATLAS-1880
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> See JIRA
> 
> 
> Sample Request structure
> 
> ```json
> {
>   "typeName": "hive_table",
>   "excludeDeletedEntities": false,
>   "limit": 25,
>   "offset": 0,
>   "entityFilters": {
>   "condition": "AND",
>   "criterion": [{
>   "attributeName": "retention",
>   "operator": "=",
>   "attributeValue": "10"
>   }, {
>   "condition": "OR",
>   "criterion": [{
>   "attributeName": "createTime",
>   "operator": ">",
>   "attributeValue": "11"
>   }, {
>   "attributeName": "lastAccessTime",
>   "operator": "<=",
>   "attributeValue": "22"
>   }]
>   }]
>   }
> }
> ```
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClientV2.java 61413428 
>   common/src/main/java/org/apache/atlas/repository/Constants.java ac022528 
>   distro/src/conf/atlas-log4j.xml e6c0d9f6 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  841edf71 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  1ff9d5ed 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
>  53f490f5 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java
>  0211ff05 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
>  0077a21f 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/AndCondition.java
>  68f0eb28 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/HasPredicate.java
>  24e4f5bc 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java
>  54ff7cb7 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java
>  1ed1734f 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java
>  bd8b897f 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java
>  7ec6ffeb 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java
>  4073dd2a 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java
>  4452bcdd 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
>  1ca900d8 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
> a402c628 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
> 21b64273 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  923a198b 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  128cdbf9 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
> b07091a0 
>   repository/src/main/java/org/apache/atlas/discovery/GremlinStep.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/SolrStep.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  35dbf6c4 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java
>  3411f8de 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
>  42bd58fb 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  9a8695af 
>   

[jira] [Updated] (ATLAS-1894) UI : Search using entity and trait attributes

2017-06-30 Thread Keval Bhatt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-1894:
---
Attachment: ATLAS-1894.3.patch

> UI : Search using entity and trait attributes
> -
>
> Key: ATLAS-1894
> URL: https://issues.apache.org/jira/browse/ATLAS-1894
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Attachments: ATLAS-1894.1.patch, ATLAS-1894.2.patch, 
> ATLAS-1894.3.patch, ATLAS-1894.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)