date:20170809

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

2017-08-09 Thread Apoorv Naik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61502/
---

(Updated Aug. 9, 2017, 5:51 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Changes
---

Added one more check for all three search parameters missing


Bugs: ATLAS-2025
https://issues.apache.org/jira/browse/ATLAS-2025


Repository: atlas


Description
---

Right now there's no such validation and as a (unwanted) side-effect the 
following happens

1. Internal error when type name is invalid (NPE)
2. Type is valid but classification is invalid - the result contains entities 
which don't have the tag (exactly opposite behavior)


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java b24f99f6 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
66dd7484 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
929f8d00 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 71860a17 


Diff: https://reviews.apache.org/r/61502/diff/3/

Changes: https://reviews.apache.org/r/61502/diff/2-3/


Testing
---

Validated the correctness of results using curl/postman calls, any invalid type 
name / classification throws 400 now.

mvn clean package -Pdist,berkeley-elasticsearch executes successfully


Thanks,

Apoorv Naik

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

2017-08-09 Thread Apoorv Naik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61502/
---

(Updated Aug. 9, 2017, 5:26 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Changes
---

Added error code for the validation


Bugs: ATLAS-2025
https://issues.apache.org/jira/browse/ATLAS-2025


Repository: atlas


Description
---

Right now there's no such validation and as a (unwanted) side-effect the 
following happens

1. Internal error when type name is invalid (NPE)
2. Type is valid but classification is invalid - the result contains entities 
which don't have the tag (exactly opposite behavior)


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java b24f99f6 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
66dd7484 
  repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
929f8d00 


Diff: https://reviews.apache.org/r/61502/diff/2/

Changes: https://reviews.apache.org/r/61502/diff/1-2/


Testing
---

Validated the correctness of results using curl/postman calls, any invalid type 
name / classification throws 400 now.

mvn clean package -Pdist,berkeley-elasticsearch executes successfully


Thanks,

Apoorv Naik

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

2017-08-09 Thread Apoorv Naik



> On Aug. 9, 2017, 10:53 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java
> > Lines 61 (patched)
> > 
> >
> > I am not sure Apoorv is quite right. The code seems to be saying if 
> > there is a supplied type then it needs to exist. If there is a supplied 
> > classification it needs to exist. Is it valid to not supply a 
> > classification type or an entity type? Should we test for this as an error 
> > case?   
> > 
> > I also suggest we do not put text as a message insert . The text should 
> > be in the message template and have unique message numbers. Ideally the 
> > message should put out the search request that is being issued - so the 
> > user has the context of what type is missing / invalid.

Yes the code does exactly what you stated above. It's a valid use-case to not 
supply typename or the classification, the search request MUST contain atleast 
one of the following 

1. TypeName
2. Classification
3. FreeText (lucene style query text)

It can also contain any combination of the above parameters. Does that clarify 
your concern ?

Thanks for catching the error code mistake, I've updated the code to reflect 
the changes. One thing that's not doable right now is adding details regarding 
the error, ideally we'd want the error JSON to have a details field which can 
capture more information if needed.


- Apoorv


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61502/#review182477
---


On Aug. 9, 2017, 5:26 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61502/
> ---
> 
> (Updated Aug. 9, 2017, 5:26 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2025
> https://issues.apache.org/jira/browse/ATLAS-2025
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Right now there's no such validation and as a (unwanted) side-effect the 
> following happens
> 
> 1. Internal error when type name is invalid (NPE)
> 2. Type is valid but classification is invalid - the result contains entities 
> which don't have the tag (exactly opposite behavior)
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java b24f99f6 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  66dd7484 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> 929f8d00 
> 
> 
> Diff: https://reviews.apache.org/r/61502/diff/2/
> 
> 
> Testing
> ---
> 
> Validated the correctness of results using curl/postman calls, any invalid 
> type name / classification throws 400 now.
> 
> mvn clean package -Pdist,berkeley-elasticsearch executes successfully
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 61518: ATLAS-2033: Changed Pretty JSON Generation to Ugly for v1 Entity Serializers

2017-08-09 Thread Ashutosh Mestry


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61518/
---

(Updated Aug. 9, 2017, 6:25 p.m.)


Review request for atlas and Nixon Rodrigues.


Changes
---

Updates include:
- _Ugly_ & _Pretty_ files.


Bugs: ATLAS-2033
https://issues.apache.org/jira/browse/ATLAS-2033


Repository: atlas


Description
---

**Implementation**

Changed _writePretty_ to _write_ for GSON serializer for v1 entities.


Diffs
-

  
typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala
 3354d7c 


Diff: https://reviews.apache.org/r/61518/diff/1/


Testing
---

**Unit tests**
Existing suite.


File Attachments (updated)


Ugly
  
https://reviews.apache.org/media/uploaded/files/2017/08/09/440a989c-81ea-4653-b896-9d0d51465de4__ugly.json
Pretty
  
https://reviews.apache.org/media/uploaded/files/2017/08/09/1cf92e66-2dc6-4ded-a546-f1eaa7dcba36__pretty.json


Thanks,

Ashutosh Mestry

Build failed in Jenkins: apache-atlas-nightly #828

2017-08-09 Thread Apache Jenkins Server

See 

--
[...truncated 446.24 KB...]
[INFO] Exclude: dev-support/**
[INFO] Exclude: **/users-credentials.properties
[INFO] Exclude: **/public/css/animate.min.css
[INFO] Exclude: **/public/css/bootstrap-sidebar.css
[INFO] Exclude: **/public/js/external_lib/**
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/public/js/libs/**
[INFO] Exclude: **/atlas.data/**
[INFO] Exclude: **/${sys:atlas.data}/**
[INFO] Exclude: **/policy-store.txt
[INFO] Exclude: **/*rebel*.xml
[INFO] Exclude: **/*rebel*.xml.bak
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.9.1:check (checkstyle-check) @ 
atlas-dashboardv2 ---
[INFO] 
[INFO] 
[INFO] >>> findbugs-maven-plugin:3.0.1:check (findbugs-check) > :findbugs @ 
atlas-dashboardv2 >>>
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ atlas-dashboardv2 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (findbugs-check) < :findbugs @ 
atlas-dashboardv2 <<<
[INFO] 
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (findbugs-check) @ 
atlas-dashboardv2 ---
[INFO] 
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
atlas-dashboardv2 ---
[INFO] Installing 

 to 
/home/jenkins/.m2/repository/org/apache/atlas/atlas-dashboardv2/0.9-SNAPSHOT/atlas-dashboardv2-0.9-SNAPSHOT.war
[INFO] Installing 
 to 
/home/jenkins/.m2/repository/org/apache/atlas/atlas-dashboardv2/0.9-SNAPSHOT/atlas-dashboardv2-0.9-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/.m2/repository/org/apache/atlas/atlas-dashboardv2/0.9-SNAPSHOT/atlas-dashboardv2-0.9-SNAPSHOT-sources.jar
[INFO] Installing 

 to 
/home/jenkins/.m2/repository/org/apache/atlas/atlas-dashboardv2/0.9-SNAPSHOT/atlas-dashboardv2-0.9-SNAPSHOT-test-sources.jar
[INFO] 
[INFO] 
[INFO] Building Apache Atlas Web Application 0.9-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ atlas-webapp ---
[INFO] Deleting 

[INFO] Deleting  
(includes = [**/*.pyc], excludes = [])
[INFO] 
[INFO] --- buildnumber-maven-plugin:1.4:create (default) @ atlas-webapp ---
[INFO] Executing: /bin/sh -c cd 
' && 'git' 
'rev-parse' '--verify' 'HEAD'
[INFO] Working directory: 

[INFO] Storing buildNumber: d0beadf2e4a83bce17b8c42e7a584a035cf416c2 at 
timestamp: 1502304864720
[WARNING] Cannot get the branch information from the git repository: 
Detecting the current branch failed: fatal: ref HEAD is not a symbolic ref

[INFO] Executing: /bin/sh -c cd 
' && 'git' 
'rev-parse' '--verify' 'HEAD'
[INFO] Working directory: 

[INFO] Storing buildScmBranch: UNKNOWN
[INFO] 
[INFO] --- maven-resources-plugin:2.7:copy-resources (copy-resources) @ 
atlas-webapp ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 11 resources
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ atlas-webapp 
---
[INFO] 
[INFO] --- keytool-maven-plugin:1.5:clean (clean) @ atlas-webapp ---
[WARNING] Keystore file 
'
 doesn't exist.
[INFO] 
[INFO] --- keytool-maven-plugin:1.5:generateKeyPair (generateKeyPair) @ 
atlas-webapp ---
[INFO] 
[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ 
atlas-webapp ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 2 resources to META-INF
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ atlas-webapp 
---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 71 source files to 

[WARNING] 
:
 Some input files use or override a deprecated API.
[WARNING] 
:
 Recompile with

[jira] [Assigned] (ATLAS-202) Entity Updates - allow deletion of optional attribute values

2017-08-09 Thread Keval Bhatt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt reassigned ATLAS-202:
-

Assignee: Keval Bhatt

> Entity Updates - allow deletion of optional attribute values
> 
>
> Key: ATLAS-202
> URL: https://issues.apache.org/jira/browse/ATLAS-202
> Project: Atlas
>  Issue Type: Bug
>Reporter: Suma Shivaprasad
>Assignee: Keval Bhatt
>
> Support deleteAttribute(propertyName) on entity ?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (ATLAS-202) Entity Updates - allow deletion of optional attribute values

2017-08-09 Thread Keval Bhatt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt reassigned ATLAS-202:
-

Assignee: (was: Keval Bhatt)

> Entity Updates - allow deletion of optional attribute values
> 
>
> Key: ATLAS-202
> URL: https://issues.apache.org/jira/browse/ATLAS-202
> Project: Atlas
>  Issue Type: Bug
>Reporter: Suma Shivaprasad
>
> Support deleteAttribute(propertyName) on entity ?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61496: ATLAS-2027 : UI : Add type-name with attribute name in query-builder

2017-08-09 Thread Nixon Rodrigues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61496/#review182472
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 8, 2017, 11:34 a.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61496/
> ---
> 
> (Updated Aug. 8, 2017, 11:34 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2027
> https://issues.apache.org/jira/browse/ATLAS-2027
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add type-name with attribute name in query-builder attribute dropdown.
> 
> Example:
> 
> Description = > Description (String)
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/search/QueryBuilderView.js 6cdbeb3 
> 
> 
> Diff: https://reviews.apache.org/r/61496/diff/1/
> 
> 
> Testing
> ---
> 
> Done one round on sanity test.
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

[jira] [Commented] (ATLAS-2027) UI : Add type-name with attribute name in query-builder

2017-08-09 Thread Nixon Rodrigues (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119565#comment-16119565
 ] 

Nixon Rodrigues commented on ATLAS-2027:


+1 for the patch

> UI : Add type-name with attribute name in query-builder 
> 
>
> Key: ATLAS-2027
> URL: https://issues.apache.org/jira/browse/ATLAS-2027
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-webui
>Affects Versions: 0.9-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.8-incubating, 0.9-incubating
>
> Attachments: ATLAS-2027.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation

2017-08-09 Thread David Radley



> On July 24, 2017, 7:15 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
> > Lines 128 (patched)
> > 
> >
> > consider using vertex.getEdges(direction, edgeLabel), instead of 
> > iterating through edges to find the one with the expected label.

Hi Madhan, 
I can't see how to use this method as I am looking for edges with the 
relationship prefix - so I am iterating and them checking for a substring of 
the label. This method would match the complete label. If I have misunderstood, 
let me know.  
   David.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61085/#review181253
---


On July 24, 2017, 5:18 p.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61085/
> ---
> 
> (Updated July 24, 2017, 5:18 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1983: Add relationship cardinality validation
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 
> b24f99f6f9337aa10f40e9f10024fe5a345c3540 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java 
> c17e875d10169753b76fcdb483e2ca85195104b2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
>  49e08a070a803a36253b502666947ab92ffe39d3 
> 
> 
> Diff: https://reviews.apache.org/r/61085/diff/1/
> 
> 
> Testing
> ---
> 
> ran Junits 
> Successfully added one relationship, then added a second which resulted in 
> the error.
> 
> 
> Thanks,
> 
> David Radley
> 
>

[jira] [Updated] (ATLAS-2027) UI : Add type-name with attribute name in query-builder

2017-08-09 Thread Keval Bhatt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-2027:
---
Fix Version/s: (was: 0.8.1-incubating)
   0.8-incubating

> UI : Add type-name with attribute name in query-builder 
> 
>
> Key: ATLAS-2027
> URL: https://issues.apache.org/jira/browse/ATLAS-2027
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-webui
>Affects Versions: 0.9-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.8-incubating, 0.9-incubating
>
> Attachments: ATLAS-2027.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ATLAS-2024) Update Atlas Twiki

2017-08-09 Thread Nixon Rodrigues (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119569#comment-16119569
 ] 

Nixon Rodrigues commented on ATLAS-2024:


+1 for the patch.

> Update Atlas Twiki
> --
>
> Key: ATLAS-2024
> URL: https://issues.apache.org/jira/browse/ATLAS-2024
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ATLAS-2033) AbstractNotification Message Serializer Uses Pretty JSON

2017-08-09 Thread Madhan Neethiraj (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119481#comment-16119481
 ] 

Madhan Neethiraj commented on ATLAS-2033:
-

Good find [~ashutoshm]!

+1 for the patch.


> AbstractNotification Message Serializer Uses Pretty JSON
> 
>
> Key: ATLAS-2033
> URL: https://issues.apache.org/jira/browse/ATLAS-2033
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: trunk, 0.8-incubating
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Minor
> Fix For: trunk
>
> Attachments: ATLAS-2033.patch
>
>
> _InstanceSerialization.scala_ uses _writePretty_ instead of _write_. This 
> causes prettified JSON to be generated.
> Pretty JSON is about 30% larger than ugly JSON.
> This change will help in dealing Kafa's message threshold of 1MB.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61518: ATLAS-2033: Changed Pretty JSON Generation to Ugly for v1 Entity Serializers

2017-08-09 Thread Madhan Neethiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61518/#review182471
---


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 9, 2017, 4:43 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61518/
> ---
> 
> (Updated Aug. 9, 2017, 4:43 a.m.)
> 
> 
> Review request for atlas and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2033
> https://issues.apache.org/jira/browse/ATLAS-2033
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Implementation**
> 
> Changed _writePretty_ to _write_ for GSON serializer for v1 entities.
> 
> 
> Diffs
> -
> 
>   
> typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala
>  3354d7c 
> 
> 
> Diff: https://reviews.apache.org/r/61518/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> Existing suite.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

[jira] [Resolved] (ATLAS-2024) Update Atlas Twiki

2017-08-09 Thread Nixon Rodrigues (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-2024.

   Resolution: Fixed
Fix Version/s: 0.8.1-incubating
   0.9-incubating

Thanks [~apoorvnaik] for the patch
Committed the patch on the following branches 

* master -> http://git-wip-us.apache.org/repos/asf/atlas/commit/fb28760a
* 0.8-incubating -> http://git-wip-us.apache.org/repos/asf/atlas/commit/bb4b98b5


> Update Atlas Twiki
> --
>
> Key: ATLAS-2024
> URL: https://issues.apache.org/jira/browse/ATLAS-2024
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
> Fix For: 0.9-incubating, 0.8.1-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ATLAS-2020) Result Table Column Filter : Filtering using Columns in Result table always sets excludeDeletedEntities to True

2017-08-09 Thread Keval Bhatt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-2020:
---
Attachment: ATLAS-2020.patch

> Result Table Column Filter : Filtering using Columns in Result table always 
> sets excludeDeletedEntities to True
> ---
>
> Key: ATLAS-2020
> URL: https://issues.apache.org/jira/browse/ATLAS-2020
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Sharmadha Sainath
>Assignee: Keval Bhatt
> Attachments: ATLAS-2020.patch
>
>
> 1. Searched hive_table in basic search.
> 2. Checked "Include historical entities" check box - Result table had DELETED 
> entities.
> 3. Added Columns filter "columns" - This fired a new query with 
> excludeDeletedEntities set to True and fetched only the ACTIVE entities and 
> reset (unchecked)  "Include historical entities" .
> Expected that the current value of excludeDeletedEntities would be used when 
> Column filtering.
> After Column filtering , explicitly had to check "Include historical 
> entities" to list the DELETED entities.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

2017-08-09 Thread David Radley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61502/#review182477
---




repository/src/main/java/org/apache/atlas/discovery/SearchContext.java
Lines 61 (patched)


I am not sure Apoorv is quite right. The code seems to be saying if there 
is a supplied type then it needs to exist. If there is a supplied 
classification it needs to exist. Is it valid to not supply a classification 
type or an entity type? Should we test for this as an error case?   

I also suggest we do not put text as a message insert . The text should be 
in the message template and have unique message numbers. Ideally the message 
should put out the search request that is being issued - so the user has the 
context of what type is missing / invalid.


- David Radley


On Aug. 8, 2017, 5:16 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61502/
> ---
> 
> (Updated Aug. 8, 2017, 5:16 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2025
> https://issues.apache.org/jira/browse/ATLAS-2025
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Right now there's no such validation and as a (unwanted) side-effect the 
> following happens
> 
> 1. Internal error when type name is invalid (NPE)
> 2. Type is valid but classification is invalid - the result contains entities 
> which don't have the tag (exactly opposite behavior)
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  66dd7484 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> 929f8d00 
> 
> 
> Diff: https://reviews.apache.org/r/61502/diff/1/
> 
> 
> Testing
> ---
> 
> Validated the correctness of results using curl/postman calls, any invalid 
> type name / classification throws 400 now.
> 
> mvn clean package -Pdist,berkeley-elasticsearch executes successfully
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Review Request 61523: ATLAS-2020 : Result Table Column Filter : Filtering using Columns in Result table always sets excludeDeletedEntities to True

2017-08-09 Thread keval bhatt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61523/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon 
Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-2020
https://issues.apache.org/jira/browse/ATLAS-2020


Repository: atlas


Description
---

1. Searched hive_table in basic search.
2. Checked "Include historical entities" check box - Result table had DELETED 
entities.
3. Added Columns filter "columns" - This fired a new query with 
excludeDeletedEntities set to True and fetched only the ACTIVE entities and 
reset (unchecked)  "Include historical entities" .

Expected that the current value of excludeDeletedEntities would be used when 
Column filtering.

After Column filtering , explicitly had to check "Include historical entities" 
to list the DELETED entities.


Diffs
-

  dashboardv2/package.json e2e3d8c 
  dashboardv2/public/css/scss/loader.scss 7d461c8 
  dashboardv2/public/css/scss/override.scss d2a4bec 
  dashboardv2/public/css/scss/panel.scss d1c2961 
  dashboardv2/public/js/router/Router.js f858ee2 
  dashboardv2/public/js/templates/common/TableLayout_tmpl.html e2b8a86 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
3177c7e 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
91f1a67 
  dashboardv2/public/js/utils/CommonViewFunction.js 4abec08 
  dashboardv2/public/js/utils/TableLayout.js 3c9ff3b 
  dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js da42554 
  dashboardv2/public/js/views/common/aboutAtlas.js 9561b83 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 56379a4 
  dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js e27edf4 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 6f9b6e3 
  dashboardv2/public/js/views/search/SearchDetailLayoutView.js b22fae8 
  dashboardv2/public/js/views/search/SearchLayoutView.js 0c39b02 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js d1b1a02 


Diff: https://reviews.apache.org/r/61523/diff/1/


Testing
---


Thanks,

keval bhatt

[jira] [Created] (ATLAS-2035) Search using entity and trait attributes - Issue with Case insensitive search in entity attributes and tag

2017-08-09 Thread Sharmadha Sainath (JIRA)

Sharmadha Sainath created ATLAS-2035:


 Summary: Search using entity and trait attributes - Issue with 
Case insensitive search in entity attributes and tag 
 Key: ATLAS-2035
 URL: https://issues.apache.org/jira/browse/ATLAS-2035
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 0.9-incubating
Reporter: Sharmadha Sainath
Priority: Critical


1. Created an hdfs_path entity with description "hdfs_path"
2. Created a tag "tag1" and associated the tag to hdfs_path entity
3. In Basic Search
a) Typename = hdfs_path , filter : description = hdfs_path returned the 
hdfs_path entity
b) Typename = hdfs_path , filter : description = HDFS_PATH returned the 
hdfs_path entity (to verify case insensitivity)
   c) Typename = hdfs_path , filter : description = hdfs_path , tag = tag1 
returned the hdfs_path entity.
  d) But , Typename = hdfs_path , filter : description = HDFS_PATH , tag = tag1 
did not fetch the entity.

Therefore , any search with tag and case insensitive search in entityFilters 
does not fetch expected results.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ATLAS-2035) Search using entity and trait attributes - Issue with Case insensitive search in entity attributes and tag

2017-08-09 Thread Sharmadha Sainath (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharmadha Sainath updated ATLAS-2035:
-
Description: 
1. Created an hdfs_path entity with description "hdfs_path"
2. Created a tag "tag1" and associated the tag to hdfs_path entity
3. In Basic Search
a) Typename = hdfs_path , filter : description = hdfs_path returned the 
hdfs_path entity
b) Typename = hdfs_path , filter : description = HDFS_PATH returned the 
hdfs_path entity (to verify case insensitivity)
   c) Typename = hdfs_path , filter : description = hdfs_path , tag = tag1 
returned the hdfs_path entity.
  d) But , Typename = hdfs_path , filter : description = HDFS_PATH , tag = tag1 
did not fetch the entity.

Therefore , any search with tag and case insensitive search in entityFilters 
does not fetch expected results.


Logs from EntitySearchProcessor:
{code}
2017-08-09 12:30:06,761 DEBUG - [pool-2-thread-10 - 
56d0fb40-683d-48bb-8cf7-8d2dee690379:] ~ ==> 
EntitySearchProcessor.execute(searchParameters={query='null', 
typeName='hdfs_path', classification='tag1', excludeDeletedEntities=true, 
limit=25, offset=0, entityFilters={attributeName='null', operator=null, 
attributeValue='null', condition=AND, criterion=[{attributeName='description', 
operator=eq, attributeValue='HDFS_PATH', condition=null, criterion=null}]}, 
tagFilters=null, attributes=null}) (EntitySearchProcessor:129)
2017-08-09 12:30:06,788 DEBUG - [pool-2-thread-10 - 
56d0fb40-683d-48bb-8cf7-8d2dee690379:] ~ <== 
EntitySearchProcessor.execute(searchParameters={query='null', 
typeName='hdfs_path', classification='tag1', excludeDeletedEntities=true, 
limit=25, offset=0, entityFilters={attributeName='null', operator=null, 
attributeValue='null', condition=AND, criterion=[{attributeName='description', 
operator=eq, attributeValue='HDFS_PATH', condition=null, criterion=null}]}, 
tagFilters=null, attributes=null}): ret.size()=0 (EntitySearchProcessor:213)
{code}

  was:
1. Created an hdfs_path entity with description "hdfs_path"
2. Created a tag "tag1" and associated the tag to hdfs_path entity
3. In Basic Search
a) Typename = hdfs_path , filter : description = hdfs_path returned the 
hdfs_path entity
b) Typename = hdfs_path , filter : description = HDFS_PATH returned the 
hdfs_path entity (to verify case insensitivity)
   c) Typename = hdfs_path , filter : description = hdfs_path , tag = tag1 
returned the hdfs_path entity.
  d) But , Typename = hdfs_path , filter : description = HDFS_PATH , tag = tag1 
did not fetch the entity.

Therefore , any search with tag and case insensitive search in entityFilters 
does not fetch expected results.


> Search using entity and trait attributes - Issue with Case insensitive search 
> in entity attributes and tag 
> ---
>
> Key: ATLAS-2035
> URL: https://issues.apache.org/jira/browse/ATLAS-2035
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Sharmadha Sainath
>Priority: Critical
>
> 1. Created an hdfs_path entity with description "hdfs_path"
> 2. Created a tag "tag1" and associated the tag to hdfs_path entity
> 3. In Basic Search
> a) Typename = hdfs_path , filter : description = hdfs_path returned the 
> hdfs_path entity
> b) Typename = hdfs_path , filter : description = HDFS_PATH returned the 
> hdfs_path entity (to verify case insensitivity)
>c) Typename = hdfs_path , filter : description = hdfs_path , tag = tag1 
> returned the hdfs_path entity.
>   d) But , Typename = hdfs_path , filter : description = HDFS_PATH , tag = 
> tag1 did not fetch the entity.
> Therefore , any search with tag and case insensitive search in entityFilters 
> does not fetch expected results.
> Logs from EntitySearchProcessor:
> {code}
> 2017-08-09 12:30:06,761 DEBUG - [pool-2-thread-10 - 
> 56d0fb40-683d-48bb-8cf7-8d2dee690379:] ~ ==> 
> EntitySearchProcessor.execute(searchParameters={query='null', 
> typeName='hdfs_path', classification='tag1', excludeDeletedEntities=true, 
> limit=25, offset=0, entityFilters={attributeName='null', operator=null, 
> attributeValue='null', condition=AND, 
> criterion=[{attributeName='description', operator=eq, 
> attributeValue='HDFS_PATH', condition=null, criterion=null}]}, 
> tagFilters=null, attributes=null}) (EntitySearchProcessor:129)
> 2017-08-09 12:30:06,788 DEBUG - [pool-2-thread-10 - 
> 56d0fb40-683d-48bb-8cf7-8d2dee690379:] ~ <== 
> EntitySearchProcessor.execute(searchParameters={query='null', 
> typeName='hdfs_path', classification='tag1', excludeDeletedEntities=true, 
> limit=25, offset=0, entityFilters={attributeName='null', operator=null, 
> attributeValue='null', condition=AND, 
> criterion=[{attributeName='description', operator=eq,

[jira] [Updated] (ATLAS-2037) Unit Test Failure: NotificationHookConsumerTest.testConsumersAreStoppedWhenInstanceBecomesPassive

2017-08-09 Thread Ashutosh Mestry (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-2037:
---
Attachment: ATLAS-2037-HookConsumer.patch

> Unit Test Failure: 
> NotificationHookConsumerTest.testConsumersAreStoppedWhenInstanceBecomesPassive
> -
>
> Key: ATLAS-2037
> URL: https://issues.apache.org/jira/browse/ATLAS-2037
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Minor
> Fix For: trunk, 0.8.1-incubating
>
> Attachments: ATLAS-2037-HookConsumer.patch
>
>
> *Analysis*
> - The test has few mocks, but we don’t mock _HookConsumer_ (derived from 
> _ShutdownableThread_). Hence, the object needs be in line with its usage 
> pattern.
> - The _ShutdownableThread_ has a _CountdownLatch_ that is checked during 
> shutdown.
> In the test, the _HookConsumer_ was not being started at all. This caused 
> _shutdownLatch_ (of type _CountdownLatch_) not to decrement, since no work 
> was performed, but anticipating work is going to be done. The test thus ended 
> up not getting completed, since the thread was in perpetual wait.
> *Solution*
> The _HookConsumer_ should be used such that it is started and shutdown. So 
> the test passes.
> _HookConsumer_ should check for _shouldRun_ in _shutdown_ method, so that the 
> case where _shutdown_ is called without _start_ is handled.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ATLAS-2037) Unit Test Failure: NotificationHookConsumerTest.testConsumersAreStoppedWhenInstanceBecomesPassive

2017-08-09 Thread Ashutosh Mestry (JIRA)

Ashutosh Mestry created ATLAS-2037:
--

 Summary: Unit Test Failure: 
NotificationHookConsumerTest.testConsumersAreStoppedWhenInstanceBecomesPassive
 Key: ATLAS-2037
 URL: https://issues.apache.org/jira/browse/ATLAS-2037
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: trunk
Reporter: Ashutosh Mestry
Assignee: Ashutosh Mestry
Priority: Minor
 Fix For: trunk, 0.8.1-incubating


*Analysis*
- The test has few mocks, but we don’t mock _HookConsumer_ (derived from 
_ShutdownableThread_). Hence, the object needs be in line with its usage 
pattern.
- The _ShutdownableThread_ has a _CountdownLatch_ that is checked during 
shutdown.

In the test, the _HookConsumer_ was not being started at all. This caused 
_shutdownLatch_ (of type _CountdownLatch_) not to decrement, since no work was 
performed, but anticipating work is going to be done. The test thus ended up 
not getting completed, since the thread was in perpetual wait.

*Solution*
The _HookConsumer_ should be used such that it is started and shutdown. So the 
test passes.

_HookConsumer_ should check for _shouldRun_ in _shutdown_ method, so that the 
case where _shutdown_ is called without _start_ is handled.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ATLAS-2036) Search using entity and trait attributes - Issue with Boolean attributes of tag and case insensitive search

2017-08-09 Thread Sharmadha Sainath (JIRA)

Sharmadha Sainath created ATLAS-2036:


 Summary: Search using entity and trait attributes - Issue with 
Boolean attributes of tag and case insensitive search
 Key: ATLAS-2036
 URL: https://issues.apache.org/jira/browse/ATLAS-2036
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 0.9-incubating
Reporter: Sharmadha Sainath


1. Created a tag tag1 with attributes 
   1. strAttr of type string ,
   2. boolAttr  of type boolean , 
   3. intAttr of type integer

2. Associated an entity to the tag with values  =  
strAttr : value 
boolAttr : false 
intAttr : 5

3. In Basic search :
 a)  tag = tag1 ,
   tagfilters :
 strAttr = valuefetched the entity
 b)  tag = tag1 ,
  tagfilters : 
 strAttr= VALUE  fetched the entity 
 c)  tag = tag1 ,
  tagfilters : 
  strAttr = value , 
  boolAttr = false ,
  intAttr = 5 fetched the entity
 d)  tag = tag1 , 
  tagfilters : 
  strAttr = VALUE , 
  intAttr = 5 fetched any entity
 e) tag = tag1 , 
  tagfilters : 
  boolAttr = falsefetched any entity
 e) But tag = tag1 ,
  tagfilters: 
 strAttr = VALUE ,
 boolAttr = false didn't fetch any entity . (to be noted : strAttr's 
value is in CAPS)

Logs when searching for tag filters : strAttr : VALUE , intAttr:5
{code}

2017-08-09 13:47:55,474 INFO  - [pool-2-thread-9 - 
5b8ea24d-0708-4571-b55d-a345d2997ed4:] ~ Converted query string with 3 
replacements: [v."__typeName":(tag1) AND v."tag1.intAttr": 5 AND 
v."tag1.strAttr": VALUE] => [iyt_t:(tag1) AND 870ud_i: 5 AND 86rd1_t: VALUE] 
(IndexSerializer:648)
2017-08-09 13:47:55,484 INFO  - [pool-2-thread-9 - 
5b8ea24d-0708-4571-b55d-a345d2997ed4:] ~ Converted query string with 3 
replacements: [v."__typeName":(tag1) AND v."tag1.intAttr": 5 AND 
v."tag1.strAttr": VALUE] => [iyt_t:(tag1) AND 870ud_i: 5 AND 86rd1_t: VALUE] 
(IndexSerializer:648)

{code}


Logs when searching for tag filters : strAttr : VALUE , boolAttr : false (Note 
: no INFO logs from IndexSerializer regrading query conversion are found in 
this search )
{code}
 WARN  - [pool-2-thread-9 - 4c272ca0-4853-4d24-b2d0-f10934516889:] ~ search 
includes non-indexed attribute 'tag1.boolAttr'; might cause poor performance 
(SearchProcessor:120)
{code}





Thus , any case insensitive string search with boolean attribute in tag search 
fails to fetch the entity. Other datatypes (including enum) when combined with 
case insensitive search fetches the expected entity.

Also , this behavior is not observed on entity filters.
For example , an  hdfs_path entity with description - hdfs_path , isSymLink = 
false ,
both the following search fetch the entity :
1. description = hdfs_path ,  isSymLink = false 
2.  description = Hdfs_path ,  isSymLink = false




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ATLAS-2036) Search using entity and trait attributes - Issue with Boolean attributes of tag and case insensitive search

2017-08-09 Thread Sharmadha Sainath (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sharmadha Sainath updated ATLAS-2036:
-
Description: 
1. Created a tag tag1 with attributes 
  strAttr of type string ,
  boolAttr  of type boolean , 
  intAttr of type integer

2. Associated an entity to the tag with values  =  
strAttr : value 
boolAttr : false 
intAttr : 5

3. In Basic search :
 a)  tag = tag1 ,
   tagfilters :
 strAttr = valuefetched the entity
 b)  tag = tag1 ,
  tagfilters : 
 strAttr= VALUE  fetched the entity 
 c)  tag = tag1 ,
  tagfilters : 
  strAttr = value , 
  boolAttr = false ,
  intAttr = 5 fetched the entity
 d)  tag = tag1 , 
  tagfilters : 
  strAttr = VALUE , 
  intAttr = 5 fetched any entity
 e) tag = tag1 , 
  tagfilters : 
  boolAttr = falsefetched any entity
 e) But tag = tag1 ,
  tagfilters: 
 strAttr = VALUE ,
 boolAttr = false didn't fetch any entity . (to be noted : strAttr's 
value is in CAPS)

Logs when searching for tag filters : strAttr : VALUE , intAttr:5
{code}

2017-08-09 13:47:55,474 INFO  - [pool-2-thread-9 - 
5b8ea24d-0708-4571-b55d-a345d2997ed4:] ~ Converted query string with 3 
replacements: [v."__typeName":(tag1) AND v."tag1.intAttr": 5 AND 
v."tag1.strAttr": VALUE] => [iyt_t:(tag1) AND 870ud_i: 5 AND 86rd1_t: VALUE] 
(IndexSerializer:648)
2017-08-09 13:47:55,484 INFO  - [pool-2-thread-9 - 
5b8ea24d-0708-4571-b55d-a345d2997ed4:] ~ Converted query string with 3 
replacements: [v."__typeName":(tag1) AND v."tag1.intAttr": 5 AND 
v."tag1.strAttr": VALUE] => [iyt_t:(tag1) AND 870ud_i: 5 AND 86rd1_t: VALUE] 
(IndexSerializer:648)

{code}


Logs when searching for tag filters : strAttr : VALUE , boolAttr : false (Note 
: no INFO logs from IndexSerializer regrading query conversion are found in 
this search )
{code}
 WARN  - [pool-2-thread-9 - 4c272ca0-4853-4d24-b2d0-f10934516889:] ~ search 
includes non-indexed attribute 'tag1.boolAttr'; might cause poor performance 
(SearchProcessor:120)
{code}





Thus , any case insensitive string search with boolean attribute in tag search 
fails to fetch the entity. Other datatypes (including enum) when combined with 
case insensitive search fetches the expected entity.

Also , this behavior is not observed on entity filters.
For example , an  hdfs_path entity with description - hdfs_path , isSymLink = 
false ,
both the following search fetch the entity :
1. description = hdfs_path ,  isSymLink = false 
2.  description = Hdfs_path ,  isSymLink = false


  was:
1. Created a tag tag1 with attributes 
   1. strAttr of type string ,
   2. boolAttr  of type boolean , 
   3. intAttr of type integer

2. Associated an entity to the tag with values  =  
strAttr : value 
boolAttr : false 
intAttr : 5

3. In Basic search :
 a)  tag = tag1 ,
   tagfilters :
 strAttr = valuefetched the entity
 b)  tag = tag1 ,
  tagfilters : 
 strAttr= VALUE  fetched the entity 
 c)  tag = tag1 ,
  tagfilters : 
  strAttr = value , 
  boolAttr = false ,
  intAttr = 5 fetched the entity
 d)  tag = tag1 , 
  tagfilters : 
  strAttr = VALUE , 
  intAttr = 5 fetched any entity
 e) tag = tag1 , 
  tagfilters : 
  boolAttr = falsefetched any entity
 e) But tag = tag1 ,
  tagfilters: 
 strAttr = VALUE ,
 boolAttr = false didn't fetch any entity . (to be noted : strAttr's 
value is in CAPS)

Logs when searching for tag filters : strAttr : VALUE , intAttr:5
{code}

2017-08-09 13:47:55,474 INFO  - [pool-2-thread-9 - 
5b8ea24d-0708-4571-b55d-a345d2997ed4:] ~ Converted query string with 3 
replacements: [v."__typeName":(tag1) AND v."tag1.intAttr": 5 AND 
v."tag1.strAttr": VALUE] => [iyt_t:(tag1) AND 870ud_i: 5 AND 86rd1_t: VALUE] 
(IndexSerializer:648)
2017-08-09 13:47:55,484 INFO  - [pool-2-thread-9 - 
5b8ea24d-0708-4571-b55d-a345d2997ed4:] ~ Converted query string with 3 
replacements: [v."__typeName":(tag1) AND v."tag1.intAttr": 5 AND 
v."tag1.strAttr": VALUE] => [iyt_t:(tag1) AND 870ud_i: 5 AND 86rd1_t: VALUE] 
(IndexSerializer:648)

{code}


Logs when searching for tag filters : strAttr : VALUE , boolAttr : false (Note 
: no INFO logs from IndexSerializer regrading query conversion are found in 
this search )
{code}
 WARN  - [pool-2-thread-9 - 4c272ca0-4853-4d24-b2d0-f10934516889:] ~ search 
includes non-indexed attribute 'tag1.boolAttr'; might cause poor performance 
(SearchProcessor:120)
{code}





Thus , any case insensitive string search with boolean attribute in tag search 
fails to fetch the entity. Other datatypes (including

Re: Review Request 61523: ATLAS-2020 : Result Table Column Filter : Filtering using Columns in Result table always sets excludeDeletedEntities to True

2017-08-09 Thread keval bhatt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61523/
---

(Updated Aug. 9, 2017, 1:21 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon 
Rodrigues, and Sarath Subramanian.


Changes
---

Bug fix


Bugs: ATLAS-2020
https://issues.apache.org/jira/browse/ATLAS-2020


Repository: atlas


Description
---

1. Searched hive_table in basic search.
2. Checked "Include historical entities" check box - Result table had DELETED 
entities.
3. Added Columns filter "columns" - This fired a new query with 
excludeDeletedEntities set to True and fetched only the ACTIVE entities and 
reset (unchecked)  "Include historical entities" .

Expected that the current value of excludeDeletedEntities would be used when 
Column filtering.

After Column filtering , explicitly had to check "Include historical entities" 
to list the DELETED entities.


Diffs (updated)
-

  dashboardv2/package.json e2e3d8c 
  dashboardv2/public/css/scss/loader.scss 7d461c8 
  dashboardv2/public/css/scss/override.scss d2a4bec 
  dashboardv2/public/css/scss/panel.scss d1c2961 
  dashboardv2/public/js/router/Router.js f858ee2 
  dashboardv2/public/js/templates/common/TableLayout_tmpl.html e2b8a86 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
3177c7e 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
91f1a67 
  dashboardv2/public/js/utils/CommonViewFunction.js 4abec08 
  dashboardv2/public/js/utils/TableLayout.js 3c9ff3b 
  dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js da42554 
  dashboardv2/public/js/views/common/aboutAtlas.js 9561b83 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 56379a4 
  dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js e27edf4 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 6f9b6e3 
  dashboardv2/public/js/views/search/SearchDetailLayoutView.js b22fae8 
  dashboardv2/public/js/views/search/SearchLayoutView.js 0c39b02 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js d1b1a02 


Diff: https://reviews.apache.org/r/61523/diff/2/

Changes: https://reviews.apache.org/r/61523/diff/1-2/


Testing (updated)
---

Done one round of sanity testing


Thanks,

keval bhatt

[jira] [Updated] (ATLAS-2020) Result Table Column Filter : Filtering using Columns in Result table always sets excludeDeletedEntities to True

2017-08-09 Thread Keval Bhatt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-2020:
---
Attachment: ATLAS-2020.1.patch

> Result Table Column Filter : Filtering using Columns in Result table always 
> sets excludeDeletedEntities to True
> ---
>
> Key: ATLAS-2020
> URL: https://issues.apache.org/jira/browse/ATLAS-2020
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Sharmadha Sainath
>Assignee: Keval Bhatt
> Attachments: ATLAS-2020.1.patch, ATLAS-2020.patch
>
>
> 1. Searched hive_table in basic search.
> 2. Checked "Include historical entities" check box - Result table had DELETED 
> entities.
> 3. Added Columns filter "columns" - This fired a new query with 
> excludeDeletedEntities set to True and fetched only the ACTIVE entities and 
> reset (unchecked)  "Include historical entities" .
> Expected that the current value of excludeDeletedEntities would be used when 
> Column filtering.
> After Column filtering , explicitly had to check "Include historical 
> entities" to list the DELETED entities.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

Re: Review Request 61518: ATLAS-2033: Changed Pretty JSON Generation to Ugly for v1 Entity Serializers

Build failed in Jenkins: apache-atlas-nightly #828

[jira] [Assigned] (ATLAS-202) Entity Updates - allow deletion of optional attribute values

[jira] [Assigned] (ATLAS-202) Entity Updates - allow deletion of optional attribute values

Re: Review Request 61496: ATLAS-2027 : UI : Add type-name with attribute name in query-builder

[jira] [Commented] (ATLAS-2027) UI : Add type-name with attribute name in query-builder

Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation

[jira] [Updated] (ATLAS-2027) UI : Add type-name with attribute name in query-builder

[jira] [Commented] (ATLAS-2024) Update Atlas Twiki

[jira] [Commented] (ATLAS-2033) AbstractNotification Message Serializer Uses Pretty JSON

Re: Review Request 61518: ATLAS-2033: Changed Pretty JSON Generation to Ugly for v1 Entity Serializers

[jira] [Resolved] (ATLAS-2024) Update Atlas Twiki

[jira] [Updated] (ATLAS-2020) Result Table Column Filter : Filtering using Columns in Result table always sets excludeDeletedEntities to True

Re: Review Request 61502: ATLAS-2025: Validation on type name and classification

Review Request 61523: ATLAS-2020 : Result Table Column Filter : Filtering using Columns in Result table always sets excludeDeletedEntities to True

[jira] [Created] (ATLAS-2035) Search using entity and trait attributes - Issue with Case insensitive search in entity attributes and tag

[jira] [Updated] (ATLAS-2035) Search using entity and trait attributes - Issue with Case insensitive search in entity attributes and tag

[jira] [Updated] (ATLAS-2037) Unit Test Failure: NotificationHookConsumerTest.testConsumersAreStoppedWhenInstanceBecomesPassive

[jira] [Created] (ATLAS-2037) Unit Test Failure: NotificationHookConsumerTest.testConsumersAreStoppedWhenInstanceBecomesPassive

[jira] [Created] (ATLAS-2036) Search using entity and trait attributes - Issue with Boolean attributes of tag and case insensitive search

[jira] [Updated] (ATLAS-2036) Search using entity and trait attributes - Issue with Boolean attributes of tag and case insensitive search

Re: Review Request 61523: ATLAS-2020 : Result Table Column Filter : Filtering using Columns in Result table always sets excludeDeletedEntities to True

[jira] [Updated] (ATLAS-2020) Result Table Column Filter : Filtering using Columns in Result table always sets excludeDeletedEntities to True

26 matches

Site Navigation

Mail list logo

Footer information