Re: Review Request 61568: ATLAS-2003: Add Javadoc format to class summaries

2017-08-11 Thread Richard Ding via Review Board


> On Aug. 11, 2017, 9:22 a.m., David Radley wrote:
> > common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java
> > Lines 54 (patched)
> > 
> >
> > Hi Richard, this looks good - please could you generate the swagger and 
> > make sure that it tolerates the markup you have added.

The following mvn command runs successfully after applying the patch: 
>mvn -DskipTests -DskipEnunciate=false clean package 

The swagger docs are generated in the directory:
>webapp/target/api/v2/apidocs


- Richard


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61568/#review182672
---


On Aug. 10, 2017, 6:15 p.m., Richard Ding wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61568/
> ---
> 
> (Updated Aug. 10, 2017, 6:15 p.m.)
> 
> 
> Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2003
> https://issues.apache.org/jira/browse/ATLAS-2003
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch added Javadoc format to the following class summaries: 
> ```
> InMemoryJAASConfiguration.java 
> TitanGraphQuery.java   
> AtlasRelationshipDef.java  
> NotificationInterface.java 
> ExpandAndsOptimization.java 
> HBaseBasedAuditRepository.java   
> ```
> 
> 
> Diffs
> -
> 
>   
> common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java 
> c65048fa 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
>  c38f6cc8 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java 
> c17e875d 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java
>  ef8ee275 
>   
> repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpandAndsOptimization.java
>  7cf97110 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  06e518ee 
> 
> 
> Diff: https://reviews.apache.org/r/61568/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with Javadoc build.
> 
> 
> Thanks,
> 
> Richard Ding
> 
>



Re: Review Request 61552: ATLAS-2038 : Unit Test cases for AtlasAuthentication and Authorization Filter

2017-08-11 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61552/
---

(Updated Aug. 11, 2017, 4:25 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

This patch handles  review comment from Apoorv to make it IT instead UT.


Bugs: ATLAS-2038
https://issues.apache.org/jira/browse/ATLAS-2038


Repository: atlas


Description
---

This patch enable the Unittest from this testclass and includes unit test cases 
for testing Authentication and Authorization Filters which can fail if any 
regression is introduced in this Filters and authentication/authorization 
process. ( eg bugs ATLAS-2009).


Diffs (updated)
-

  
webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterIT.java
 PRE-CREATION 
  
webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java
 389eefe 


Diff: https://reviews.apache.org/r/61552/diff/2/

Changes: https://reviews.apache.org/r/61552/diff/1-2/


Testing
---

Excecuted unit and Integration test from mvn clean install


Thanks,

Nixon Rodrigues



[jira] [Updated] (ATLAS-1836) Area 0 of the open metadata model

2017-08-11 Thread David Radley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley updated ATLAS-1836:

Attachment: 0005LinkedMediaTypes.json

> Area 0 of the open metadata model
> -
>
> Key: ATLAS-1836
> URL: https://issues.apache.org/jira/browse/ATLAS-1836
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Reporter: Mandy Chessell
>Assignee: Mandy Chessell
>  Labels: OpenMetadata, VirtualDataConnector
> Attachments: 0005LinkedMediaTypes.json
>
>
> This task delivers the JSON files for the new models that describe types for 
> Area 0 in the open metadata model.  This area covers base types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (ATLAS-1839) Area 2 of the open metadata model

2017-08-11 Thread David Radley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley updated ATLAS-1839:

Attachment: (was: 0260Contexts.json)

> Area 2 of the open metadata model
> -
>
> Key: ATLAS-1839
> URL: https://issues.apache.org/jira/browse/ATLAS-1839
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Mandy Chessell
>Assignee: David Radley
>  Labels: OpenMetadata, VirtualDataConnector
> Attachments: 0210Glossary.json, 0220CategoryHierarchy.json, 
> 0230Terms.json, 0240Dictionary.json, 0250RelatedTerms.json, 
> 0260Contexts.json, 0270SemanticAssignment.json, 0280SpineObjects.json
>
>
> This task delivers the JSON files for the new models that describe types for 
> Area 2 in the open metadata model. This area covers the glossary.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (ATLAS-1839) Area 2 of the open metadata model

2017-08-11 Thread David Radley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley updated ATLAS-1839:

Attachment: (was: 0240Dictionary.json)

> Area 2 of the open metadata model
> -
>
> Key: ATLAS-1839
> URL: https://issues.apache.org/jira/browse/ATLAS-1839
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Mandy Chessell
>Assignee: David Radley
>  Labels: OpenMetadata, VirtualDataConnector
> Attachments: 0210Glossary.json, 0220CategoryHierarchy.json, 
> 0230Terms.json, 0240Dictionary.json, 0250RelatedTerms.json, 
> 0260Contexts.json, 0270SemanticAssignment.json, 0280SpineObjects.json
>
>
> This task delivers the JSON files for the new models that describe types for 
> Area 2 in the open metadata model. This area covers the glossary.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (ATLAS-1839) Area 2 of the open metadata model

2017-08-11 Thread David Radley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley updated ATLAS-1839:

Attachment: (was: 0280SpineObjects.json)

> Area 2 of the open metadata model
> -
>
> Key: ATLAS-1839
> URL: https://issues.apache.org/jira/browse/ATLAS-1839
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Mandy Chessell
>Assignee: David Radley
>  Labels: OpenMetadata, VirtualDataConnector
> Attachments: 0210Glossary.json, 0220CategoryHierarchy.json, 
> 0230Terms.json, 0240Dictionary.json, 0250RelatedTerms.json, 
> 0260Contexts.json, 0270SemanticAssignment.json, 0280SpineObjects.json
>
>
> This task delivers the JSON files for the new models that describe types for 
> Area 2 in the open metadata model. This area covers the glossary.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (ATLAS-1839) Area 2 of the open metadata model

2017-08-11 Thread David Radley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley updated ATLAS-1839:

Attachment: (was: 0210Glossary.json)

> Area 2 of the open metadata model
> -
>
> Key: ATLAS-1839
> URL: https://issues.apache.org/jira/browse/ATLAS-1839
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Mandy Chessell
>Assignee: David Radley
>  Labels: OpenMetadata, VirtualDataConnector
> Attachments: 0210Glossary.json, 0220CategoryHierarchy.json, 
> 0230Terms.json, 0240Dictionary.json, 0250RelatedTerms.json, 
> 0260Contexts.json, 0270SemanticAssignment.json, 0280SpineObjects.json
>
>
> This task delivers the JSON files for the new models that describe types for 
> Area 2 in the open metadata model. This area covers the glossary.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (ATLAS-1839) Area 2 of the open metadata model

2017-08-11 Thread David Radley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley updated ATLAS-1839:

Attachment: (was: 0220CategoryHierarchy.json)

> Area 2 of the open metadata model
> -
>
> Key: ATLAS-1839
> URL: https://issues.apache.org/jira/browse/ATLAS-1839
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Mandy Chessell
>Assignee: David Radley
>  Labels: OpenMetadata, VirtualDataConnector
> Attachments: 0210Glossary.json, 0220CategoryHierarchy.json, 
> 0230Terms.json, 0240Dictionary.json, 0250RelatedTerms.json, 
> 0260Contexts.json, 0270SemanticAssignment.json, 0280SpineObjects.json
>
>
> This task delivers the JSON files for the new models that describe types for 
> Area 2 in the open metadata model. This area covers the glossary.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (ATLAS-1839) Area 2 of the open metadata model

2017-08-11 Thread David Radley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley updated ATLAS-1839:

Attachment: (was: 0005LinkedMediaTypes.json)

> Area 2 of the open metadata model
> -
>
> Key: ATLAS-1839
> URL: https://issues.apache.org/jira/browse/ATLAS-1839
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 0.9-incubating
>Reporter: Mandy Chessell
>Assignee: David Radley
>  Labels: OpenMetadata, VirtualDataConnector
> Attachments: 0210Glossary.json, 0220CategoryHierarchy.json, 
> 0230Terms.json, 0240Dictionary.json, 0250RelatedTerms.json, 
> 0260Contexts.json, 0270SemanticAssignment.json, 0280SpineObjects.json
>
>
> This task delivers the JSON files for the new models that describe types for 
> Area 2 in the open metadata model. This area covers the glossary.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many cardinality gives incorrect relationship attribute value

2017-08-11 Thread David Radley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/#review182702
---



- David Radley


On Aug. 11, 2017, 7:33 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61589/
> ---
> 
> (Updated Aug. 11, 2017, 7:33 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2040
> https://issues.apache.org/jira/browse/ATLAS-2040
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Relationship with many-to-many cardinality gives incorrect relationship 
> attribute value when same attribute name and same type specified at both ends
> When same attribute name and same type is mentioned in both ends of 
> relationship definition. Creating new relationships fails to retireve the 
> right value.
> For e.g. employee-friends type: same attribute name 'friends' in type 
> 'Employee' specified at both ends
> Add more unit tests to test these cases
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 
> 934dffce 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2 
>   intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 1ec5a72e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  42713763 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  b8fd70e5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  667c61bd 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java
>  2c311403 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java
>  33ef8c0f 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
>  a35647dc 
> 
> 
> Diff: https://reviews.apache.org/r/61589/diff/2/
> 
> 
> Testing
> ---
> 
> * added new  UTs to test many-to-many relationships on same attribute 
> name/same type
> * added new  UTs to test one-to-one relationships on same attribute name/same 
> type
> * mvn clean install -DskipITs=true suceeded without any failures
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>



Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many cardinality gives incorrect relationship attribute value

2017-08-11 Thread David Radley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/#review182700
---




repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java
Line 18 (original), 18 (patched)


The testing indicated that buuild works with skipIts. Does this means that 
it breaks some tests asis ?


- David Radley


On Aug. 11, 2017, 7:33 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61589/
> ---
> 
> (Updated Aug. 11, 2017, 7:33 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2040
> https://issues.apache.org/jira/browse/ATLAS-2040
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Relationship with many-to-many cardinality gives incorrect relationship 
> attribute value when same attribute name and same type specified at both ends
> When same attribute name and same type is mentioned in both ends of 
> relationship definition. Creating new relationships fails to retireve the 
> right value.
> For e.g. employee-friends type: same attribute name 'friends' in type 
> 'Employee' specified at both ends
> Add more unit tests to test these cases
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 
> 934dffce 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2 
>   intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 1ec5a72e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  42713763 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  b8fd70e5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  667c61bd 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java
>  2c311403 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java
>  33ef8c0f 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
>  a35647dc 
> 
> 
> Diff: https://reviews.apache.org/r/61589/diff/2/
> 
> 
> Testing
> ---
> 
> * added new  UTs to test many-to-many relationships on same attribute 
> name/same type
> * added new  UTs to test one-to-one relationships on same attribute name/same 
> type
> * mvn clean install -DskipITs=true suceeded without any failures
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>



Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many cardinality gives incorrect relationship attribute value

2017-08-11 Thread David Radley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/#review182690
---




intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java
Lines 130 (patched)


It should be BOTH for associations with different names on each end as well



intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java
Line 126 (original), 135 (patched)


I suggest the default is BOTH. We give it a direction for specific cases.



intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java
Line 127 (original), 136 (patched)


We should support BOTH for association relationships.



repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Line 386 (original), 392 (patched)


this has lost its indentation


- David Radley


On Aug. 11, 2017, 7:33 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61589/
> ---
> 
> (Updated Aug. 11, 2017, 7:33 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2040
> https://issues.apache.org/jira/browse/ATLAS-2040
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Relationship with many-to-many cardinality gives incorrect relationship 
> attribute value when same attribute name and same type specified at both ends
> When same attribute name and same type is mentioned in both ends of 
> relationship definition. Creating new relationships fails to retireve the 
> right value.
> For e.g. employee-friends type: same attribute name 'friends' in type 
> 'Employee' specified at both ends
> Add more unit tests to test these cases
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 
> 934dffce 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2 
>   intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 1ec5a72e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  42713763 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  b8fd70e5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  667c61bd 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java
>  2c311403 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java
>  33ef8c0f 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
>  a35647dc 
> 
> 
> Diff: https://reviews.apache.org/r/61589/diff/2/
> 
> 
> Testing
> ---
> 
> * added new  UTs to test many-to-many relationships on same attribute 
> name/same type
> * added new  UTs to test one-to-one relationships on same attribute name/same 
> type
> * mvn clean install -DskipITs=true suceeded without any failures
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>



[jira] [Created] (ATLAS-2042) Add instance level junits

2017-08-11 Thread David Radley (JIRA)
David Radley created ATLAS-2042:
---

 Summary: Add instance level junits
 Key: ATLAS-2042
 URL: https://issues.apache.org/jira/browse/ATLAS-2042
 Project: Atlas
  Issue Type: Sub-task
Reporter: David Radley






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (ATLAS-2032) classificationDef update

2017-08-11 Thread David Radley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley resolved ATLAS-2032.
-
Resolution: Fixed

> classificationDef update
> 
>
> Key: ATLAS-2032
> URL: https://issues.apache.org/jira/browse/ATLAS-2032
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: David Radley
>Assignee: David Radley
>
> Ensure that ClassificationDef update can remove and add entityTypes



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (ATLAS-2042) Add instance level junits

2017-08-11 Thread David Radley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley reassigned ATLAS-2042:
---

Assignee: David Radley

> Add instance level junits
> -
>
> Key: ATLAS-2042
> URL: https://issues.apache.org/jira/browse/ATLAS-2042
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: David Radley
>Assignee: David Radley
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (ATLAS-2030) Enhance graph to link ClassificationDefs and entityDefs

2017-08-11 Thread David Radley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley resolved ATLAS-2030.
-
Resolution: Fixed

> Enhance graph to link ClassificationDefs and entityDefs  
> -
>
> Key: ATLAS-2030
> URL: https://issues.apache.org/jira/browse/ATLAS-2030
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: David Radley
>Assignee: David Radley
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (ATLAS-2029) Enhance classificationDef create to include a list of entities it supports

2017-08-11 Thread David Radley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley updated ATLAS-2029:

Attachment: ATLAS-2029.patch

> Enhance classificationDef create to include a list of entities it supports
> --
>
> Key: ATLAS-2029
> URL: https://issues.apache.org/jira/browse/ATLAS-2029
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: David Radley
>Assignee: David Radley
>  Labels: VirtualDataConnector
> Attachments: ATLAS-2029.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ATLAS-2029) Enhance classificationDef create to include a list of entities it supports

2017-08-11 Thread David Radley (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123363#comment-16123363
 ] 

David Radley commented on ATLAS-2029:
-

review board [https://reviews.apache.org/r/61526/]

> Enhance classificationDef create to include a list of entities it supports
> --
>
> Key: ATLAS-2029
> URL: https://issues.apache.org/jira/browse/ATLAS-2029
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: David Radley
>Assignee: David Radley
>  Labels: VirtualDataConnector
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Review Request 61526: ATLAS-2029: Restrict entities, classifications can be applied to

2017-08-11 Thread David Radley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61526/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS-2029: Restrict entities, classifications can be applied to


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 
36fcc03c13ae8bee14815e11497e0ae3a6d6e2d2 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 
eeaf71413a56c08db8170fd3323b8e8245ae44fe 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
56c3ed38392d2d2c8882861373cd42a549b5670d 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 
427439ca97d496f02de2d38329c582ded239c04c 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 
fc65af057255b4c17378080ee4fb7cbfc780c3fe 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
 89445048c69555b86a5347b21dde5a21dae9b2a1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 1c168b4cff0d105c7a0d4a9fbdb50871388c917e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
 227f7cd12a9b23c3bbc1cfdc40d06616ea775ca4 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
 50a421662b9a58ea3daf45e57d21626b5f2c6c44 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java
 8638a7f17e8a17d3a6e0bfb94879b5c5406be1a3 


Diff: https://reviews.apache.org/r/61526/diff/1/


Testing
---

Testing
performed unit tests

Using postman
1) create an entityDef  aaa
2) create a classificationDef with an entitytype   - checked that it is in 
the response
3) Create a entity instance of aaa
4) add the classification to it
5) Create an entity instance with a different type 
6) Attempt to add the classification to . this fails with an informative 
message
7) Attempt to update the ClassificationDef to remove the entity type - this 
fails with an informative message
8) Attempt to update the classificationdef to add . this update works. 
9) Attempt to add an entity type that does not exist to the ClassificationDef. 
this should fail.  
9) Attempt to update an entity type that does not exist to the 
ClassificationDef. this should fail.
10) Create a ClassificationDef with no entitytypes as a subtype of another 
ClassificationDef. Ensure that the sub classification can be applied to 
entities specifed in the parent.


Thanks,

David Radley



Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-11 Thread David Radley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61561/#review182676
---




distro/src/bin/atlas_config.py
Lines 71 (patched)


I am uncomfortable duplicating the default port values here. I suggest 
moving this logic to the java class that already has the default port values



distro/src/bin/atlas_config.py
Lines 454 (patched)


is this going to work if -port was specified on the atlas_start command?



distro/src/bin/atlas_config.py
Lines 473 (patched)


I was hoping we would be able to be notified when Atlas was started or the 
startup time reduced, by understanding why there is a delay and minimizing it.

Once we understand that and decide that polling is the appropriate 
resolution - I suggest a 1 second poll - as we can do nothing with Atlas until 
it is  started.



distro/src/bin/atlas_config.py
Lines 475 (patched)


I am not expert on all the ways Atlas can be started, does this work with 
OAuth and does Knox work with this?



distro/src/bin/atlas_config.py
Lines 477 (patched)


If we have failures during startup, how can we tell  the polling to cease?


- David Radley


On Aug. 10, 2017, 5:47 p.m., Richard Ding wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61561/
> ---
> 
> (Updated Aug. 10, 2017, 5:47 p.m.)
> 
> 
> Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-1218
> https://issues.apache.org/jira/browse/ATLAS-1218
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch implements a wait_for_startup function modeled after 
> wait_for_shutdown function.
> 
> 
> Diffs
> -
> 
>   distro/src/bin/atlas_config.py 1be9ca2b 
>   distro/src/bin/atlas_start.py a6a3455c 
> 
> 
> Diff: https://reviews.apache.org/r/61561/diff/1/
> 
> 
> Testing
> ---
> 
> Here are the output of atlas_start and atlas_stop script:
> ```
> starting atlas on port 21000
> 
> Apache Atlas Server started!!!
> ```
> and
> ```
> stopping atlas
> Apache Atlas Server stopped!!!
> ```
> 
> 
> Thanks,
> 
> Richard Ding
> 
>



Re: Review Request 61566: ATLAS-1867: org.apache.atlas.AtlasClientV2.deleteAtlasTypeDefs gives an exception

2017-08-11 Thread David Radley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61566/#review182673
---


Ship it!




Ship It!

- David Radley


On Aug. 10, 2017, 5:56 p.m., Richard Ding wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61566/
> ---
> 
> (Updated Aug. 10, 2017, 5:56 p.m.)
> 
> 
> Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-1867
> https://issues.apache.org/jira/browse/ATLAS-1867
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch returns the correct HTTP code ""204 No Content" instead of "200 OK"
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClientV2.java 13533571 
> 
> 
> Diff: https://reviews.apache.org/r/61566/diff/1/
> 
> 
> Testing
> ---
> 
> All unit tests pass after applying the patch.
> 
> 
> Thanks,
> 
> Richard Ding
> 
>



Re: Review Request 61568: ATLAS-2003: Add Javadoc format to class summaries

2017-08-11 Thread David Radley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61568/#review182672
---




common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java
Lines 54 (patched)


Hi Richard, this looks good - please could you generate the swagger and 
make sure that it tolerates the markup you have added.


- David Radley


On Aug. 10, 2017, 6:15 p.m., Richard Ding wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61568/
> ---
> 
> (Updated Aug. 10, 2017, 6:15 p.m.)
> 
> 
> Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2003
> https://issues.apache.org/jira/browse/ATLAS-2003
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch added Javadoc format to the following class summaries: 
> ```
> InMemoryJAASConfiguration.java 
> TitanGraphQuery.java   
> AtlasRelationshipDef.java  
> NotificationInterface.java 
> ExpandAndsOptimization.java 
> HBaseBasedAuditRepository.java   
> ```
> 
> 
> Diffs
> -
> 
>   
> common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java 
> c65048fa 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
>  c38f6cc8 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java 
> c17e875d 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java
>  ef8ee275 
>   
> repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpandAndsOptimization.java
>  7cf97110 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  06e518ee 
> 
> 
> Diff: https://reviews.apache.org/r/61568/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with Javadoc build.
> 
> 
> Thanks,
> 
> Richard Ding
> 
>



Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many cardinality gives incorrect relationship attribute value

2017-08-11 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/
---

(Updated Aug. 11, 2017, 12:33 a.m.)


Review request for atlas, David Radley and Madhan Neethiraj.


Changes
---

addressed review comments.


Bugs: ATLAS-2040
https://issues.apache.org/jira/browse/ATLAS-2040


Repository: atlas


Description
---

Relationship with many-to-many cardinality gives incorrect relationship 
attribute value when same attribute name and same type specified at both ends
When same attribute name and same type is mentioned in both ends of 
relationship definition. Creating new relationships fails to retireve the right 
value.
For e.g. employee-friends type: same attribute name 'friends' in type 
'Employee' specified at both ends
Add more unit tests to test these cases


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2 
  intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
1ec5a72e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 42713763 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
 b8fd70e5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
 667c61bd 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java
 2c311403 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java
 33ef8c0f 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
 a35647dc 


Diff: https://reviews.apache.org/r/61589/diff/2/

Changes: https://reviews.apache.org/r/61589/diff/1-2/


Testing
---

* added new  UTs to test many-to-many relationships on same attribute name/same 
type
* added new  UTs to test one-to-one relationships on same attribute name/same 
type
* mvn clean install -DskipITs=true suceeded without any failures


Thanks,

Sarath Subramanian



[jira] [Updated] (ATLAS-2041) UI: Show tag names with dot, when taxonomy is disabled

2017-08-11 Thread Keval Bhatt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-2041:
---
Attachment: ATLAS-2041.patch

> UI: Show tag names with dot, when taxonomy is disabled
> --
>
> Key: ATLAS-2041
> URL: https://issues.apache.org/jira/browse/ATLAS-2041
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 0.9-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.8-incubating, 0.9-incubating
>
> Attachments: ATLAS-2041.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Review Request 61567: ATLAS-2004: Move Apache license header to the beginning of file

2017-08-11 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61567/#review182662
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 10, 2017, 6:08 p.m., Richard Ding wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61567/
> ---
> 
> (Updated Aug. 10, 2017, 6:08 p.m.)
> 
> 
> Review request for atlas and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2004
> https://issues.apache.org/jira/browse/ATLAS-2004
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> The Apache license header is not at the beginning of AtlasKafkaMessage.java 
> and the header shows up in the generated Javadoc.
> 
> 
> Diffs
> -
> 
>   notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaMessage.java 
> cdbf57f7 
> 
> 
> Diff: https://reviews.apache.org/r/61567/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Richard Ding
> 
>