Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java > > Lines 28 (patched) > > > > > > I suggest adding a

[VOTE] Release Apache Atlas version 1.0.0-alpha release candidate 2

Atlas team, Apache Atlas 1.0.0-alpha release candidate #2 is now available for a vote within dev community. Links to the release artifacts are given below. Please review and vote. The vote will be open for at least 72 hours or until the required number of votes are obtained. [ ] +1 approve

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 45 (original), 45 (patched) > > > > > > can you add java doc

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 9:27 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java > > Lines 66 (patched) > > > > > > is it possible to

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 18, 2018, 1:45 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSConnection.java > > Lines 33 (patched) > > > > > > why do we also need below > >

Re: [VOTE] Release Apache Atlas version 1.0.0-alpha release candidate 2

Thanks Keval for putting Atlas version atlas-1.0.0-alpha for release. I verified and tested following with the source provided at https://dist.apache.org/repos/dist/dev/atlas/1.0.0-alpha-rc2/apache-atlas-1.0.0-alpha-sources.tar.gz Verified the signature and md5 hash keys Build is going fine.

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 56 (original), 51 (patched) > > > > > > should change to

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java > > Lines 41 (patched) > > > > > > Do we need

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195822 ---

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 91 (original), 86 (patched) > > > > > > based on the comments

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195818 ---

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 2:54 p.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/PrimitivePropertyValue.java > > Lines 102 (patched) > > > > > > I suggest we

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 18, 2018, 1:45 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSConnection.java > > Lines 33 (patched) > > > > > > why do we also need below > >

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 45 (original), 45 (patched) > > > > > > can you add java doc

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 9:27 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java > > Lines 66 (patched) > > > > > > is it possible to

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 91 (original), 86 (patched) > > > > > > based on the comments

Re: [VOTE] Release Apache Atlas version 1.0.0-alpha release candidate 2

+1 for 1.0.0-alpha-rc2 Did the following to validate the release: - verified signature & hash - built Atlas from tag release-1.0.0-alpha-rc2 - deployed and brought up Atlas in embedded HBase & Solr mode - ran quick_start and performed few searches via UI Thanks, Madhan On 1/19/18, 7:19

Re: Review Request 65220: Import: Support for Types with Relationship Attributes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65220/ --- (Updated Jan. 19, 2018, 5:29 p.m.) Review request for atlas, Madhan Neethiraj

Build failed in Jenkins: Atlas-master-UnitTests #274

See -- [...truncated 164.27 KB...] --- T E S T S --- Running

Jenkins build is back to normal : Atlas-master-UnitTests #275

See

Re: [VOTE] Release Apache Atlas version 1.0.0-alpha release candidate 2

I did the following testing with the Alpha release Signature and MD5 look good Embedded hbase with solr looks good Performed couple of imports and basic search seems to be working ok Tested some DSL functionality, looks good as well + 1 on the release Thanks for compiling the release

Re: Breaking builds

David, Good point. All pending patches from contributors must be throughly tested and not break any existing UTs and ITs: "mvn clean install" - should succeed successfully. I have created a *PreCommit-ATLAS-Build-Test job* in Jenkins to validate patches.

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 9:27 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java > > Lines 66 (patched) > > > > > > is it possible to

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/CohortConnectionStatus.java > > Lines 38 (patched) > > > > > > Presumably the cohort could just be

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 9:27 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java > > Lines 31 (patched) > > > > > > in ConnectorBase we

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 8:54 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSConnectorProperties.java > > Lines 30 (patched) > > > > > > do we have to call

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 18, 2018, 1:45 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSConnection.java > > Lines 33 (patched) > > > > > > why do we also need below > >

Re: [VOTE] Release Apache Atlas version 1.0.0-alpha release candidate 1

Hi Madhan, Assuming the readme change does in.I am +1. all the best, David. From: Madhan Neethiraj To: "dev@atlas.apache.org" Date: 18/01/2018 21:37 Subject:Re: [VOTE] Release Apache Atlas version 1.0.0-alpha release candidate 1

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195794 ---

Breaking builds

Hi all, It is concerning that the master build is pretty much always unsuccessful on the nightly build. It would appear that contributors are not running the tests - which is understandable as they have been unable to run due to the maven build not being set up to run them after Janus came in.

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/ --- (Updated Jan. 19, 2018, 9:30 a.m.) Review request for atlas and Madhan

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 8:54 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSConnectorProperties.java > > Lines 24 (patched) > > > > > > should you add java

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195808 ---

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 8:54 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSRepositoryConnector.java > > Lines 43 (patched) > > > > > > not necessary to

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195728 ---

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSCohortManager.java > > Lines 111 (patched) > > > > > > I wonder whether it would be better to set

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSMetadataHighwayManager.java > > Lines 47 (patched) > > > > > > I am wondering whether the cohort

Build failed in Jenkins: Atlas-master-snapshot-publish #43

See Changes: [ssubramanian] ATLAS-2372: Export-Import: Support for Relationship Attributes Missing -- Started by timer [EnvInject] - Loading node environment

Jenkins build is back to normal : Atlas-master-snapshot-publish #44

See