[GitHub] [atlas] HeartSaVioR closed pull request #64: [ATLAS-3314] Loosen the relationship between spark_table and spark_storagedesc

2020-03-26 Thread GitBox
HeartSaVioR closed pull request #64: [ATLAS-3314] Loosen the relationship 
between spark_table and spark_storagedesc
URL: https://github.com/apache/atlas/pull/64
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [atlas] HeartSaVioR commented on issue #64: [ATLAS-3314] Loosen the relationship between spark_table and spark_storagedesc

2020-03-26 Thread GitBox
HeartSaVioR commented on issue #64: [ATLAS-3314] Loosen the relationship 
between spark_table and spark_storagedesc
URL: https://github.com/apache/atlas/pull/64#issuecomment-604815594
 
 
   Resolved via 
https://github.com/apache/atlas/commit/2c375b08a52ac8d1039abb4b612a41cb9d89b420


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Fwd: Review Request 72104: ATLAS-3610 Enable logging to STDOUT in Atlas startup scripts

2020-03-26 Thread Bolke de Bruin
Can this be merged please?

Sent from my iPhone

Begin forwarded message:

> From: Bolke de Bruin 
> Date: 26 March 2020 at 14:38:51 CET
> To: Madhan Neethiraj , Sarath Subramanian 
> , Ashutosh Mestry , Nixon Rodrigues 
> , Bolke de Bruin 
> Cc: atlas , Mariusz Górski 
> 
> Subject: Re:  Review Request 72104: ATLAS-3610 Enable logging to STDOUT in 
> Atlas startup scripts
> Reply-To: Bolke de Bruin 
> 
> 
> This is an automatically generated e-mail. To reply, visit: 
> https://reviews.apache.org/r/72104/
> 
> Ship it!
> 
> Ship It!
> 
> - Bolke de Bruin
> 
> 
> On March 26th, 2020, 7:41 a.m. UTC, Mariusz Górski wrote:
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> By Mariusz Górski.
> Updated March 26, 2020, 7:41 a.m.
> 
> Repository: atlas
> Description
> 
> This patch enables logging to STDOUT from processes spawned through 
> atlas_start.py or atlas_config.py scripts. For now, even if configured in 
> log4j, logging to STDOUT was supressed (by redirecting to log files only).
> Testing
> 
> The tests were concluded by:
> 
> Building & running Atlas locally with default log4j configuration and 
> -Dlog.console mvn build option set to true.
> Building & running Atlas on Openshift with log4j configuration pushing 
> everything to STDOUT and -Dlog.console mvn build option set to true.
> Running distro tests on localhost
> 
> In both scenarios logs were available both in the .out/.err files in the 
> Atlas logdir (backwards compatibility), but at the same time I was able to 
> see them in STDOUT of both running process (local installation) and pod 
> (openshift deployment).
> Diffs
> 
> distro/pom.xml (7159b16cf)
> distro/src/bin/atlas_config.py (f09026ff9)
> distro/src/bin/atlas_start.py (963faf402)
> distro/src/bin/cputil.py (98a9dc36d)
> distro/src/conf/atlas-env.sh (c4241e665)
> distro/src/test/python/scripts/TestMetadata.py (f1235f747)
> View Diff


[jira] [Updated] (ATLAS-3697) [Business Metadata] Incorrect values populated in Entity details > Business Metatdata attribute values, after encountering an error previously

2020-03-26 Thread Umesh Padashetty (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Umesh Padashetty updated ATLAS-3697:

Attachment: Issue with editing attribute values post error.mov

> [Business Metadata] Incorrect values populated in Entity details > Business 
> Metatdata attribute values, after encountering an error previously
> --
>
> Key: ATLAS-3697
> URL: https://issues.apache.org/jira/browse/ATLAS-3697
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Umesh Padashetty
>Priority: Critical
> Attachments: Issue with editing attribute values post error.mov
>
>
> While adding/updating a Business Metadata attribute value in the entity 
> details page, suppose a user updates multiple values, and then click on save. 
> If say, there is an error in updating some value, the user cannot obviously 
> save it. So once you click on cancel, and click on edit again, instead of 
> populating the original values, we are populating the values which the user 
> tried to update while he encountered an error.
> This could be problematic because let's say the user changes the mind and 
> wants to update only one value. Now he cannot do it, because the original 
> values are not populated. Also, the user might save wrong data unknowingly 
> while trying to fix a rogue field.
> Attached video for the detailed explanation. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3697) [Business Metadata] Incorrect values populated in Entity details > Business Metatdata attribute values, after encountering an error previously

2020-03-26 Thread Umesh Padashetty (Jira)
Umesh Padashetty created ATLAS-3697:
---

 Summary: [Business Metadata] Incorrect values populated in Entity 
details > Business Metatdata attribute values, after encountering an error 
previously
 Key: ATLAS-3697
 URL: https://issues.apache.org/jira/browse/ATLAS-3697
 Project: Atlas
  Issue Type: Bug
  Components: atlas-webui
Reporter: Umesh Padashetty


While adding/updating a Business Metadata attribute value in the entity details 
page, suppose a user updates multiple values, and then click on save. If say, 
there is an error in updating some value, the user cannot obviously save it. So 
once you click on cancel, and click on edit again, instead of populating the 
original values, we are populating the values which the user tried to update 
while he encountered an error.

This could be problematic because let's say the user changes the mind and wants 
to update only one value. Now he cannot do it, because the original values are 
not populated. Also, the user might save wrong data unknowingly while trying to 
fix a rogue field.

Attached video for the detailed explanation. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3696) [Business Metadata] No option to check/uncheck Business Metadata field in search results

2020-03-26 Thread Umesh Padashetty (Jira)
Umesh Padashetty created ATLAS-3696:
---

 Summary: [Business Metadata] No option to check/uncheck Business 
Metadata field in search results
 Key: ATLAS-3696
 URL: https://issues.apache.org/jira/browse/ATLAS-3696
 Project: Atlas
  Issue Type: Bug
  Components: atlas-webui
Reporter: Umesh Padashetty
 Attachments: Screenshot 2020-03-26 at 9.00.55 PM.png, Screenshot 
2020-03-26 at 9.04.22 PM.png

For instance, there is no way to show "Business Metadata" column if Business 
Metadata attribute filter is not applied while searching. Attached screenshots



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3575) Update authorization - "admin-purge" for purge entity.

2020-03-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067741#comment-17067741
 ] 

ASF subversion and git services commented on ATLAS-3575:


Commit 272d46d532ad15b67ffb9d66c1d97f6ba044dc55 in atlas's branch 
refs/heads/branch-2.0 from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=272d46d ]

ATLAS-3575:- Update authorization - admin-purge for purge entity.

(cherry picked from commit c06221ae636babeabdeff042853286051f46cf07)


> Update authorization - "admin-purge" for purge entity.
> --
>
> Key: ATLAS-3575
> URL: https://issues.apache.org/jira/browse/ATLAS-3575
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3575.patch
>
>
> For Atlas Admin Purge we need to add new privilege - admin-purge at ranger 
> and change the atlas purge to verifyAccess accordingly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3575) Update authorization - "admin-purge" for purge entity.

2020-03-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067740#comment-17067740
 ] 

ASF subversion and git services commented on ATLAS-3575:


Commit c06221ae636babeabdeff042853286051f46cf07 in atlas's branch 
refs/heads/master from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=c06221a ]

ATLAS-3575:- Update authorization - admin-purge for purge entity.


> Update authorization - "admin-purge" for purge entity.
> --
>
> Key: ATLAS-3575
> URL: https://issues.apache.org/jira/browse/ATLAS-3575
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3575.patch
>
>
> For Atlas Admin Purge we need to add new privilege - admin-purge at ranger 
> and change the atlas purge to verifyAccess accordingly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3695) [Business Metadata] Special characters are being allowed in Attribute Name

2020-03-26 Thread Umesh Padashetty (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Umesh Padashetty updated ATLAS-3695:

Attachment: Screenshot 2020-03-26 at 8.10.11 PM.png
Screenshot 2020-03-26 at 8.09.45 PM.png

> [Business Metadata] Special characters are being allowed in Attribute Name
> --
>
> Key: ATLAS-3695
> URL: https://issues.apache.org/jira/browse/ATLAS-3695
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Reporter: Umesh Padashetty
>Priority: Major
> Attachments: Screenshot 2020-03-26 at 8.09.45 PM.png, Screenshot 
> 2020-03-26 at 8.10.11 PM.png
>
>
> Special characters are not being allowed in the Business Metadata Name, but 
> are being allowed in the Attribute Name and Description.
> Having special characters in Description should be fine, but not in 
> Attributes name. Attached screenshots. This is reproducible both from UI and 
> API. Screenshots attached.
> {code:java}
> curl -X POST \
>   'https://:31443/api/atlas/v2/types/typedefs?type=business_metadata' \
>   -H 'cache-control: no-cache' \
>   -H 'content-type: application/json' \
>   -H 'postman-token: e91ead11-8ff2-8919-3d3e-133a213cd226' \
>   -H 'x-xsrf-header: \"\"' \
>   -d 
> '{"enumDefs":[],"structDefs":[],"classificationDefs":[],"entityDefs":[],"businessMetadataDefs":[{"category":"BUSINESS_METADATA","createdBy":"admin","updatedBy":"admin","version":1,"typeVersion":"1.1","name":"Special
>  Character 
> Test","description":"^%*()*^*()","attributeDefs":[{"name":"&(*^%&*()*&^%$^&*()","typeName":"string","isOptional":true,"cardinality":"SINGLE","valuesMinCount":0,"valuesMaxCount":1,"isUnique":false,"isIndexable":false,"options":{"maxStrLength":"50"}}]}]}'
>  {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3695) [Business Metadata] Special characters are being allowed in Attribute Name

2020-03-26 Thread Umesh Padashetty (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Umesh Padashetty updated ATLAS-3695:

Description: 
Special characters are not being allowed in the Business Metadata Name, but are 
being allowed in the Attribute Name and Description.

Having special characters in Description should be fine, but not in Attributes 
name. Attached screenshots. This is reproducible both from UI and API. 
Screenshots attached.
{code:java}
curl -X POST \
  'https://:31443/api/atlas/v2/types/typedefs?type=business_metadata' \
  -H 'cache-control: no-cache' \
  -H 'content-type: application/json' \
  -H 'postman-token: e91ead11-8ff2-8919-3d3e-133a213cd226' \
  -H 'x-xsrf-header: \"\"' \
  -d 
'{"enumDefs":[],"structDefs":[],"classificationDefs":[],"entityDefs":[],"businessMetadataDefs":[{"category":"BUSINESS_METADATA","createdBy":"admin","updatedBy":"admin","version":1,"typeVersion":"1.1","name":"Special
 Character 
Test","description":"^%*()*^*()","attributeDefs":[{"name":"&(*^%&*()*&^%$^&*()","typeName":"string","isOptional":true,"cardinality":"SINGLE","valuesMinCount":0,"valuesMaxCount":1,"isUnique":false,"isIndexable":false,"options":{"maxStrLength":"50"}}]}]}'
 {code}

  was:
Special characters are not being allowed in the Business Metadata Name, but are 
being allowed in the Attribute Name and Description.

Having special characters in Description should be fine, but not in Attributes 
name. Attached screenshots. This is reproducible both from UI and API
{code:java}
curl -X POST \
  'https://:31443/api/atlas/v2/types/typedefs?type=business_metadata' \
  -H 'cache-control: no-cache' \
  -H 'content-type: application/json' \
  -H 'postman-token: e91ead11-8ff2-8919-3d3e-133a213cd226' \
  -H 'x-xsrf-header: \"\"' \
  -d 
'{"enumDefs":[],"structDefs":[],"classificationDefs":[],"entityDefs":[],"businessMetadataDefs":[{"category":"BUSINESS_METADATA","createdBy":"admin","updatedBy":"admin","version":1,"typeVersion":"1.1","name":"Special
 Character 
Test","description":"^%*()*^*()","attributeDefs":[{"name":"&(*^%&*()*&^%$^&*()","typeName":"string","isOptional":true,"cardinality":"SINGLE","valuesMinCount":0,"valuesMaxCount":1,"isUnique":false,"isIndexable":false,"options":{"maxStrLength":"50"}}]}]}'
 {code}


> [Business Metadata] Special characters are being allowed in Attribute Name
> --
>
> Key: ATLAS-3695
> URL: https://issues.apache.org/jira/browse/ATLAS-3695
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Reporter: Umesh Padashetty
>Priority: Major
> Attachments: Screenshot 2020-03-26 at 8.09.45 PM.png, Screenshot 
> 2020-03-26 at 8.10.11 PM.png
>
>
> Special characters are not being allowed in the Business Metadata Name, but 
> are being allowed in the Attribute Name and Description.
> Having special characters in Description should be fine, but not in 
> Attributes name. Attached screenshots. This is reproducible both from UI and 
> API. Screenshots attached.
> {code:java}
> curl -X POST \
>   'https://:31443/api/atlas/v2/types/typedefs?type=business_metadata' \
>   -H 'cache-control: no-cache' \
>   -H 'content-type: application/json' \
>   -H 'postman-token: e91ead11-8ff2-8919-3d3e-133a213cd226' \
>   -H 'x-xsrf-header: \"\"' \
>   -d 
> '{"enumDefs":[],"structDefs":[],"classificationDefs":[],"entityDefs":[],"businessMetadataDefs":[{"category":"BUSINESS_METADATA","createdBy":"admin","updatedBy":"admin","version":1,"typeVersion":"1.1","name":"Special
>  Character 
> Test","description":"^%*()*^*()","attributeDefs":[{"name":"&(*^%&*()*&^%$^&*()","typeName":"string","isOptional":true,"cardinality":"SINGLE","valuesMinCount":0,"valuesMaxCount":1,"isUnique":false,"isIndexable":false,"options":{"maxStrLength":"50"}}]}]}'
>  {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3695) [Business Metadata] Special characters are being allowed in Attribute Name

2020-03-26 Thread Umesh Padashetty (Jira)
Umesh Padashetty created ATLAS-3695:
---

 Summary: [Business Metadata] Special characters are being allowed 
in Attribute Name
 Key: ATLAS-3695
 URL: https://issues.apache.org/jira/browse/ATLAS-3695
 Project: Atlas
  Issue Type: Bug
Reporter: Umesh Padashetty


Special characters are not being allowed in the Business Metadata Name, but are 
being allowed in the Attribute Name and Description.

Having special characters in Description should be fine, but not in Attributes 
name. Attached screenshots. This is reproducible both from UI and API
{code:java}
curl -X POST \
  'https://:31443/api/atlas/v2/types/typedefs?type=business_metadata' \
  -H 'cache-control: no-cache' \
  -H 'content-type: application/json' \
  -H 'postman-token: e91ead11-8ff2-8919-3d3e-133a213cd226' \
  -H 'x-xsrf-header: \"\"' \
  -d 
'{"enumDefs":[],"structDefs":[],"classificationDefs":[],"entityDefs":[],"businessMetadataDefs":[{"category":"BUSINESS_METADATA","createdBy":"admin","updatedBy":"admin","version":1,"typeVersion":"1.1","name":"Special
 Character 
Test","description":"^%*()*^*()","attributeDefs":[{"name":"&(*^%&*()*&^%$^&*()","typeName":"string","isOptional":true,"cardinality":"SINGLE","valuesMinCount":0,"valuesMaxCount":1,"isUnique":false,"isIndexable":false,"options":{"maxStrLength":"50"}}]}]}'
 {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3695) [Business Metadata] Special characters are being allowed in Attribute Name

2020-03-26 Thread Umesh Padashetty (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Umesh Padashetty updated ATLAS-3695:

Component/s: atlas-webui
  atlas-core

> [Business Metadata] Special characters are being allowed in Attribute Name
> --
>
> Key: ATLAS-3695
> URL: https://issues.apache.org/jira/browse/ATLAS-3695
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Reporter: Umesh Padashetty
>Priority: Major
>
> Special characters are not being allowed in the Business Metadata Name, but 
> are being allowed in the Attribute Name and Description.
> Having special characters in Description should be fine, but not in 
> Attributes name. Attached screenshots. This is reproducible both from UI and 
> API
> {code:java}
> curl -X POST \
>   'https://:31443/api/atlas/v2/types/typedefs?type=business_metadata' \
>   -H 'cache-control: no-cache' \
>   -H 'content-type: application/json' \
>   -H 'postman-token: e91ead11-8ff2-8919-3d3e-133a213cd226' \
>   -H 'x-xsrf-header: \"\"' \
>   -d 
> '{"enumDefs":[],"structDefs":[],"classificationDefs":[],"entityDefs":[],"businessMetadataDefs":[{"category":"BUSINESS_METADATA","createdBy":"admin","updatedBy":"admin","version":1,"typeVersion":"1.1","name":"Special
>  Character 
> Test","description":"^%*()*^*()","attributeDefs":[{"name":"&(*^%&*()*&^%$^&*()","typeName":"string","isOptional":true,"cardinality":"SINGLE","valuesMinCount":0,"valuesMaxCount":1,"isUnique":false,"isIndexable":false,"options":{"maxStrLength":"50"}}]}]}'
>  {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3694) [Business Metadata] Max length defined for attributes of string type is not getting enforced

2020-03-26 Thread Umesh Padashetty (Jira)
Umesh Padashetty created ATLAS-3694:
---

 Summary: [Business Metadata] Max length defined for attributes of 
string type is not getting enforced
 Key: ATLAS-3694
 URL: https://issues.apache.org/jira/browse/ATLAS-3694
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core, atlas-webui
Reporter: Umesh Padashetty
 Attachments: Screenshot 2020-03-26 at 7.49.51 PM.png, Screenshot 
2020-03-26 at 7.51.13 PM.png

Even when the max length applicable to an attribute is defined as 10, I was 
able to add all the alphabets of an english language i.e. a-z, 26 in length, as 
the attribute value.

This is reproducible both from API as well as UI.
{code:java}
curl -X POST \
  
'https://:31443/api/atlas/v2/entity/guid/ab29815d-6d20-44ee-b426-8fba946b72a5/businessmetata?isOverwrite=true'
 \
  -H 'cache-control: no-cache' \
  -H 'content-type: application/json' \
  -H 'postman-token: 6c5a0476-ac64-57c9-5845-cbea945fdf99' \
  -H 'x-xsrf-header: \"\"' \
  -d '{"String Length":{"Name":"abcdefghijklmnopqrstuvwxyz"}}' {code}
Screenshots attached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3693) [Business Metadata] Unable to add negative values in multi-valued attributes for byte, short, int, long, float, double

2020-03-26 Thread Umesh Padashetty (Jira)
Umesh Padashetty created ATLAS-3693:
---

 Summary: [Business Metadata] Unable to add negative values in 
multi-valued attributes for byte, short, int, long, float, double 
 Key: ATLAS-3693
 URL: https://issues.apache.org/jira/browse/ATLAS-3693
 Project: Atlas
  Issue Type: Bug
  Components: atlas-webui
Reporter: Umesh Padashetty


byte, short, int, long, float, double data types can have values ranging from - 
to +, but when the attribute is defined as multi valued, unable to add negative 
values for these attributes. Entering a - sign, does nothing. The same works 
fine if the attribute is defined to be non multi-valued.

Also, this works fine via the REST API.
{code:java}
curl -X POST \ 
'https://:31443/api/atlas/v2/entity/guid/ab29815d-6d20-44ee-b426-8fba946b72a5/businessmetata?isOverwrite=true'
 \ -H 'cache-control: no-cache' \ -H 'content-type: application/json' \ -H 
'postman-token: 43107e84-a29c-b1b9-b628-4e0cf4645158' \ -H 'x-xsrf-header: 
\"\"' \ -d '{"Test Multi":{"int":["1221","121222", 
"-99162"]},"Test":{"long":"922337203685477"}}'  {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3690) storm qualiftname of hbase is not right

2020-03-26 Thread Madhan Neethiraj (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067702#comment-17067702
 ] 

Madhan Neethiraj commented on ATLAS-3690:
-

[~jackylau] - you are right. Storm hook has incorrect qualifiedName format for 
HBase table. This should be replaced with the following format used in HBase 
hook.

{code}
  class HBaseAtlasHook {
...
public static final String HBASE_TABLE_QUALIFIED_NAME_FORMAT = 
"%s:%s@%s";
  }
{code}

If you already have a patch to fix this issue, can you please attach to the 
JIA? Thanks!


> storm qualiftname of hbase is not right
> ---
>
> Key: ATLAS-3690
> URL: https://issues.apache.org/jira/browse/ATLAS-3690
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: jackylau
>Priority: Major
> Fix For: 2.1.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> hi all, when i read the code of storm hook, i found that 
> {code:java}
> // code placeholder
> public static String getHbaseTableQualifiedName(String metadataNamespace, 
> String nameSpace, String tableName) {
> return String.format("%s.%s@%s", nameSpace.toLowerCase(), 
> tableName.toLowerCase(), metadataNamespace);
> }
> {code}
> I am not familiar with atlas, i think the qualified name is unique for search 
> by JanusGraph.
> And the atlas  document of hbase table is used with separator ":"
> So I think it should be %s:%s@%s.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72104: ATLAS-3610 Enable logging to STDOUT in Atlas startup scripts

2020-03-26 Thread Bolke de Bruin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72104/#review220088
---


Ship it!




Ship It!

- Bolke de Bruin


On March 26, 2020, 7:41 a.m., Mariusz Górski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72104/
> ---
> 
> (Updated March 26, 2020, 7:41 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch enables logging to STDOUT from processes spawned through 
> atlas_start.py or atlas_config.py scripts. For now, even if configured in 
> log4j, logging to STDOUT was supressed (by redirecting to log files only).
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 7159b16cf 
>   distro/src/bin/atlas_config.py f09026ff9 
>   distro/src/bin/atlas_start.py 963faf402 
>   distro/src/bin/cputil.py 98a9dc36d 
>   distro/src/conf/atlas-env.sh c4241e665 
>   distro/src/test/python/scripts/TestMetadata.py f1235f747 
> 
> 
> Diff: https://reviews.apache.org/r/72104/diff/4/
> 
> 
> Testing
> ---
> 
> The tests were concluded by:
> 
> 1. Building & running Atlas locally with default log4j configuration and 
> -Dlog.console mvn build option set to true.
> 2. Building & running Atlas on Openshift with log4j configuration pushing 
> everything to STDOUT and -Dlog.console mvn build option set to true.
> 3. Running distro tests on localhost
> 
> In both scenarios logs were available both in the .out/.err files in the 
> Atlas logdir (backwards compatibility), but at the same time I was able to 
> see them in STDOUT of both running process (local installation) and pod 
> (openshift deployment).
> 
> 
> Thanks,
> 
> Mariusz Górski
> 
>



[jira] [Created] (ATLAS-3692) [Business Metadata] Incorrect values for long data type being stored

2020-03-26 Thread Umesh Padashetty (Jira)
Umesh Padashetty created ATLAS-3692:
---

 Summary: [Business Metadata] Incorrect values for long data type 
being stored 
 Key: ATLAS-3692
 URL: https://issues.apache.org/jira/browse/ATLAS-3692
 Project: Atlas
  Issue Type: Bug
  Components: atlas-webui
Reporter: Umesh Padashetty
 Attachments: long issue.mov

While assigning very long values to the business metadata attribute, the values 
are being stored incorrectly. For instance, the range of long data type in java 
is +9223372036854775807 to -9223372036854775808. But the following issues are 
being observed 
 # When you give the value as +9223372036854775807 it is being stored as 
+9223372036854776000
 # When you give the value as -9223372036854775808 it is being stored as 
-9223372036854776000
 # Once the value gets stored as 9223372036854776000, any further save on the 
attribute values keeps throwing out of range exception. This is weird, because 
the value is still saved as 9223372036854776000, but UI keeps complaining

Attached is the video



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ATLAS-3635) [Namespace-UI] Noticeable delay in loading Namespace section in entity details page

2020-03-26 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt resolved ATLAS-3635.

Resolution: Fixed

> [Namespace-UI] Noticeable delay in loading Namespace section in entity 
> details page
> ---
>
> Key: ATLAS-3635
> URL: https://issues.apache.org/jira/browse/ATLAS-3635
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 2.1.0, 3.0.0
>Reporter: Umesh Padashetty
>Assignee: Keval Bhatt
>Priority: Major
> Attachments: Screenshot 2020-02-25 at 2.59.51 PM.png, Screenshot 
> 2020-02-25 at 3.00.14 PM.png
>
>
> On clicking an entity, the Namespace section takes around 3-4 seconds extra 
> to load even when the complete page has loaded successfully. The namespace 
> section suddenly pops up.
> This behavior is consistently reproducible in Google Chrome, and not so 
> evident in Firefox (the delay is way lesser, hence difficult to notice)
> Attached screenshots.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3156) UI:No loading animation while creating or deleting a Classification, Create Entity, View loading

2020-03-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067660#comment-17067660
 ] 

ASF subversion and git services commented on ATLAS-3156:


Commit 518897962a7e49395d9337abb451a18a2da97ba4 in atlas's branch 
refs/heads/branch-2.0 from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=5188979 ]

ATLAS-3156 : UI:No loading animation while creating or deleting a 
Classification, Create Entity, View loading

(cherry picked from commit 60b7d2ac75828a806b64322599e09fe3376ce7b6)


> UI:No loading animation while creating or deleting a Classification, Create 
> Entity, View loading
> 
>
> Key: ATLAS-3156
> URL: https://issues.apache.org/jira/browse/ATLAS-3156
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Rahul Kurup
>Assignee: Keval Bhatt
>Priority: Minor
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3156.patch
>
>
> While creating a Classification, there is no loading animation or any 
> indication to the user that the creation process is underway. The user only 
> gets a notification that the creation process is complete. If for some reason 
> the creation process takes a long while, then this lack of indication might 
> confuse the user into thinking that nothing is happening on clicking the 
> 'Create' button.
>  
> This same issue exists when trying to delete a classification.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3156) UI:No loading animation while creating or deleting a Classification, Create Entity, View loading

2020-03-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067658#comment-17067658
 ] 

ASF subversion and git services commented on ATLAS-3156:


Commit 60b7d2ac75828a806b64322599e09fe3376ce7b6 in atlas's branch 
refs/heads/master from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=60b7d2a ]

ATLAS-3156 : UI:No loading animation while creating or deleting a 
Classification, Create Entity, View loading


> UI:No loading animation while creating or deleting a Classification, Create 
> Entity, View loading
> 
>
> Key: ATLAS-3156
> URL: https://issues.apache.org/jira/browse/ATLAS-3156
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Rahul Kurup
>Assignee: Keval Bhatt
>Priority: Minor
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3156.patch
>
>
> While creating a Classification, there is no loading animation or any 
> indication to the user that the creation process is underway. The user only 
> gets a notification that the creation process is complete. If for some reason 
> the creation process takes a long while, then this lack of indication might 
> confuse the user into thinking that nothing is happening on clicking the 
> 'Create' button.
>  
> This same issue exists when trying to delete a classification.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3156) UI:No loading animation while creating or deleting a Classification, Create Entity, View loading

2020-03-26 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067656#comment-17067656
 ] 

Nixon Rodrigues commented on ATLAS-3156:


+1 for the patch. Thanks [~kevalbhatt]!

> UI:No loading animation while creating or deleting a Classification, Create 
> Entity, View loading
> 
>
> Key: ATLAS-3156
> URL: https://issues.apache.org/jira/browse/ATLAS-3156
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Rahul Kurup
>Assignee: Keval Bhatt
>Priority: Minor
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3156.patch
>
>
> While creating a Classification, there is no loading animation or any 
> indication to the user that the creation process is underway. The user only 
> gets a notification that the creation process is complete. If for some reason 
> the creation process takes a long while, then this lack of indication might 
> confuse the user into thinking that nothing is happening on clicking the 
> 'Create' button.
>  
> This same issue exists when trying to delete a classification.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3691) [Business Metadata] Date field does not have year and month selector

2020-03-26 Thread Umesh Padashetty (Jira)
Umesh Padashetty created ATLAS-3691:
---

 Summary: [Business Metadata] Date field does not have year and 
month selector
 Key: ATLAS-3691
 URL: https://issues.apache.org/jira/browse/ATLAS-3691
 Project: Atlas
  Issue Type: Bug
  Components: atlas-webui
Reporter: Umesh Padashetty


While assigining the business metadata attribute in the entity details page, 
the date selector does not have an option to change the year. We can just 
change the monthwise.

Imagine the case where I went to set the date to some distant date, either in 
past (say Jan 20, 1989) or future (say Feb 26, 2036), the user will have to 
click hundreds of times to reach this date. It is better to provide an year 
selection option



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ATLAS-3676) admin > Administration UI throws Something went wrong error

2020-03-26 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt resolved ATLAS-3676.

Resolution: Cannot Reproduce

> admin > Administration UI throws Something went wrong error
> ---
>
> Key: ATLAS-3676
> URL: https://issues.apache.org/jira/browse/ATLAS-3676
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 2.1.0, 3.0.0
>Reporter: Umesh Padashetty
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: Screenshot 2020-03-22 at 10.39.22 PM.png
>
>
> Looks like this issue is due to the recently added Audits tab under admin > 
> administration page
> The POST call to /api/atlas/admin/audits is failing with 500 Internal Server 
> Error. Screenshot attached !Screenshot 2020-03-22 at 10.39.22 
> PM.png|width=2146,height=986!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3156) UI:No loading animation while creating or deleting a Classification, Create Entity, View loading

2020-03-26 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3156:
---
Fix Version/s: 3.0.0
   2.1.0

> UI:No loading animation while creating or deleting a Classification, Create 
> Entity, View loading
> 
>
> Key: ATLAS-3156
> URL: https://issues.apache.org/jira/browse/ATLAS-3156
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Rahul Kurup
>Assignee: Keval Bhatt
>Priority: Minor
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3156.patch
>
>
> While creating a Classification, there is no loading animation or any 
> indication to the user that the creation process is underway. The user only 
> gets a notification that the creation process is complete. If for some reason 
> the creation process takes a long while, then this lack of indication might 
> confuse the user into thinking that nothing is happening on clicking the 
> 'Create' button.
>  
> This same issue exists when trying to delete a classification.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3156) UI:No loading animation while creating or deleting a Classification, Create Entity, View loading

2020-03-26 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3156:
---
Attachment: ATLAS-3156.patch

> UI:No loading animation while creating or deleting a Classification, Create 
> Entity, View loading
> 
>
> Key: ATLAS-3156
> URL: https://issues.apache.org/jira/browse/ATLAS-3156
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Rahul Kurup
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: ATLAS-3156.patch
>
>
> While creating a Classification, there is no loading animation or any 
> indication to the user that the creation process is underway. The user only 
> gets a notification that the creation process is complete. If for some reason 
> the creation process takes a long while, then this lack of indication might 
> confuse the user into thinking that nothing is happening on clicking the 
> 'Create' button.
>  
> This same issue exists when trying to delete a classification.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3686) UI : Allows user to add search weight in business-metadata for suggestion api

2020-03-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067632#comment-17067632
 ] 

ASF subversion and git services commented on ATLAS-3686:


Commit ed4c711c74957180b8222184eec208cc25421fac in atlas's branch 
refs/heads/branch-2.0 from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ed4c711 ]

ATLAS-3686 : UI : Allows user to add search weight in business-metadata for 
suggestion API.

Signed-off-by: nixonrodrigues 
(cherry picked from commit 5c9cb78154da808debd1fa9d8d4cacbcc4a3f7bf)


> UI : Allows user to add search weight in business-metadata for suggestion api
> -
>
> Key: ATLAS-3686
> URL: https://issues.apache.org/jira/browse/ATLAS-3686
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3686.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3686) UI : Allows user to add search weight in business-metadata for suggestion api

2020-03-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067629#comment-17067629
 ] 

ASF subversion and git services commented on ATLAS-3686:


Commit 5c9cb78154da808debd1fa9d8d4cacbcc4a3f7bf in atlas's branch 
refs/heads/master from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=5c9cb78 ]

ATLAS-3686 : UI : Allows user to add search weight in business-metadata for 
suggestion API.

Signed-off-by: nixonrodrigues 


> UI : Allows user to add search weight in business-metadata for suggestion api
> -
>
> Key: ATLAS-3686
> URL: https://issues.apache.org/jira/browse/ATLAS-3686
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3686.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3686) UI : Allows user to add search weight in business-metadata for suggestion api

2020-03-26 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067630#comment-17067630
 ] 

Nixon Rodrigues commented on ATLAS-3686:


+1 for the patch

> UI : Allows user to add search weight in business-metadata for suggestion api
> -
>
> Key: ATLAS-3686
> URL: https://issues.apache.org/jira/browse/ATLAS-3686
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3686.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3686) UI : Allows user to add search weight in business-metadata for suggestion api

2020-03-26 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3686:
---
Fix Version/s: 3.0.0
   2.1.0

> UI : Allows user to add search weight in business-metadata for suggestion api
> -
>
> Key: ATLAS-3686
> URL: https://issues.apache.org/jira/browse/ATLAS-3686
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3686.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3686) UI : Allows user to add search weight in business-metadata for suggestion api

2020-03-26 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3686:
---
Attachment: ATLAS-3686.patch

> UI : Allows user to add search weight in business-metadata for suggestion api
> -
>
> Key: ATLAS-3686
> URL: https://issues.apache.org/jira/browse/ATLAS-3686
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Attachments: ATLAS-3686.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72104: ATLAS-3610 Enable logging to STDOUT in Atlas startup scripts

2020-03-26 Thread Mariusz Górski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72104/
---

(Updated March 26, 2020, 7:41 a.m.)


Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Changes
---

Updating Testing Done section


Repository: atlas


Description
---

This patch enables logging to STDOUT from processes spawned through 
atlas_start.py or atlas_config.py scripts. For now, even if configured in 
log4j, logging to STDOUT was supressed (by redirecting to log files only).


Diffs
-

  distro/pom.xml 7159b16cf 
  distro/src/bin/atlas_config.py f09026ff9 
  distro/src/bin/atlas_start.py 963faf402 
  distro/src/bin/cputil.py 98a9dc36d 
  distro/src/conf/atlas-env.sh c4241e665 
  distro/src/test/python/scripts/TestMetadata.py f1235f747 


Diff: https://reviews.apache.org/r/72104/diff/4/


Testing (updated)
---

The tests were concluded by:

1. Building & running Atlas locally with default log4j configuration and 
-Dlog.console mvn build option set to true.
2. Building & running Atlas on Openshift with log4j configuration pushing 
everything to STDOUT and -Dlog.console mvn build option set to true.
3. Running distro tests on localhost

In both scenarios logs were available both in the .out/.err files in the Atlas 
logdir (backwards compatibility), but at the same time I was able to see them 
in STDOUT of both running process (local installation) and pod (openshift 
deployment).


Thanks,

Mariusz Górski



[jira] [Created] (ATLAS-3690) storm qualiftname of hbase is not right

2020-03-26 Thread jackylau (Jira)
jackylau created ATLAS-3690:
---

 Summary: storm qualiftname of hbase is not right
 Key: ATLAS-3690
 URL: https://issues.apache.org/jira/browse/ATLAS-3690
 Project: Atlas
  Issue Type: Bug
Affects Versions: 2.0.0
Reporter: jackylau
 Fix For: 2.1.0


hi all, when i read the code of storm hook, i found that 
{code:java}
// code placeholder
public static String getHbaseTableQualifiedName(String metadataNamespace, 
String nameSpace, String tableName) {
return String.format("%s.%s@%s", nameSpace.toLowerCase(), 
tableName.toLowerCase(), metadataNamespace);
}
{code}
I am not familiar with atlas, i think the qualified name is unique for search 
by JanusGraph.

And the atlas  document of hbase table is used with separator ":"

So I think it should be %s:%s@%s.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)