Re: Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72418/#review220442
---


Ship it!




Ship It!

- Madhan Neethiraj


On April 22, 2020, 6:56 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72418/
> ---
> 
> (Updated April 22, 2020, 6:56 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3753
> https://issues.apache.org/jira/browse/ATLAS-3753
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Tag `tag_abc_test` is created and associated to an entity.
> 
> Search with test or tag fetches the entity.
> 
> But Search with tag*test doesn't fetch the entity.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 5d7c50838 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 69770c3b4 
> 
> 
> Diff: https://reviews.apache.org/r/72418/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested below combinations for wildcard (CASE_INSENSITIVE)
> 
> 'tag_abc_*'
> '*_abc*'
> 'tag_*_*'
> 'tag*test'
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>



Re: Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Pinal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72418/#review220441
---




repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Line 207 (original), 206 (patched)


I have added delimeter '|' here , as _classificationNames can have multiple 
tag names


- Pinal Shah


On April 22, 2020, 6:56 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72418/
> ---
> 
> (Updated April 22, 2020, 6:56 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3753
> https://issues.apache.org/jira/browse/ATLAS-3753
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Tag `tag_abc_test` is created and associated to an entity.
> 
> Search with test or tag fetches the entity.
> 
> But Search with tag*test doesn't fetch the entity.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 5d7c50838 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 69770c3b4 
> 
> 
> Diff: https://reviews.apache.org/r/72418/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested below combinations for wildcard (CASE_INSENSITIVE)
> 
> 'tag_abc_*'
> '*_abc*'
> 'tag_*_*'
> 'tag*test'
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>



Re: Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Pinal Shah


> On April 22, 2020, 11:48 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
> > Lines 853 (patched)
> > 
> >
> > Is it necessary to add '.*' as prefix and suffix? Wouldn't this result 
> > in incorrect results, for example given seach string tag*a*b would match 
> > for tags: 'mytag_abcd' which is incorrect. Please review and update.

Yes Madhan you are correct.
To handle this scenario, i have added prefix and suffix with '|' to the 
classificationName


- Pinal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72418/#review220437
---


On April 22, 2020, 6:56 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72418/
> ---
> 
> (Updated April 22, 2020, 6:56 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3753
> https://issues.apache.org/jira/browse/ATLAS-3753
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Tag `tag_abc_test` is created and associated to an entity.
> 
> Search with test or tag fetches the entity.
> 
> But Search with tag*test doesn't fetch the entity.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 5d7c50838 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 69770c3b4 
> 
> 
> Diff: https://reviews.apache.org/r/72418/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested below combinations for wildcard (CASE_INSENSITIVE)
> 
> 'tag_abc_*'
> '*_abc*'
> 'tag_*_*'
> 'tag*test'
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>



Re: Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72418/#review220437
---




repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Lines 853 (patched)


Is it necessary to add '.*' as prefix and suffix? Wouldn't this result in 
incorrect results, for example given seach string tag*a*b would match for tags: 
'mytag_abcd' which is incorrect. Please review and update.


- Madhan Neethiraj


On April 22, 2020, 6:56 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72418/
> ---
> 
> (Updated April 22, 2020, 6:56 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3753
> https://issues.apache.org/jira/browse/ATLAS-3753
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Tag `tag_abc_test` is created and associated to an entity.
> 
> Search with test or tag fetches the entity.
> 
> But Search with tag*test doesn't fetch the entity.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 5d7c50838 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 69770c3b4 
> 
> 
> Diff: https://reviews.apache.org/r/72418/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested below combinations for wildcard (CASE_INSENSITIVE)
> 
> 'tag_abc_*'
> '*_abc*'
> 'tag_*_*'
> 'tag*test'
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>



Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-22 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72384/#review220436
---




repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 365 (patched)


This will be a good place to create a label for 
Constants.CLASSIFICATION_LABEL as well.



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 1032 (patched)


Processing relationship-defs for each entity-def would result in each 
relationship-def to be processed twice - one for entity-def at each end. I 
suggest the following:

  if (typeDef instanceof AtlasEntityDef) {
createEdgeLabels(management, (AtlasEntityDef) typeDef);
  } else if (typeDef instanceof AtlasRelationshipDef) {
createEdgeLabels(management, (AtlasRelationshipDef) typeDef);
  }



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 1045 (patched)


Use AtlasAttribute.getRelationshipEdgeLabel() to get the relationship-label 
name.


- Madhan Neethiraj


On April 22, 2020, 4:58 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72384/
> ---
> 
> (Updated April 22, 2020, 4:58 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3737
> https://issues.apache.org/jira/browse/ATLAS-3737
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Please refer to JIRA for details.
> 
> **Benefits with this Approach**
> - Memory usage remains constant.
> - Cores, based on numWorkers, are utilized.
> 
> **Changes to Migration Import**
> - Instantiates 2 _EntityStoreV2_, one with non-bulk _AtlasGraph_ and other 
> with bulk loading _AtlasGraph_.
> - For entities that causes schema change (handled by _IllegalStateException_ 
> or _IllegalArgumentException_), the same entity is attempted with non-bulk 
> instantiated _EntityStoreV2_.
> 
> 
> Diffs
> -
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
>  0176ba705 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
>  24859389b 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  25042c19c 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
> 5548740d0 
>   
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java
>  172e187e4 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java
>  417c96cd8 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  bff54ede3 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> dfaa739e8 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  9c57d54de 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerDelegate.java
>  512eb4636 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  540defca9 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
>  a32b67124 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
>  e614a4e41 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  d3d9367fb 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  379150b7b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java
>  f393e515b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
>  7425ac601 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
>  a4d732af0 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java
>  05878f405 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  04da41e1a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  36bee301d 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityStateChecker.java
>  2718a0627 
>   
> 

Review Request 72418: ATLAS-3753 : Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Pinal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72418/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3753
https://issues.apache.org/jira/browse/ATLAS-3753


Repository: atlas


Description
---

Tag `tag_abc_test` is created and associated to an entity.

Search with test or tag fetches the entity.

But Search with tag*test doesn't fetch the entity.


Diffs
-

  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
5d7c50838 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
69770c3b4 


Diff: https://reviews.apache.org/r/72418/diff/1/


Testing
---

Manually tested below combinations for wildcard (CASE_INSENSITIVE)

'tag_abc_*'
'*_abc*'
'tag_*_*'
'tag*test'


Thanks,

Pinal Shah



[jira] [Created] (ATLAS-3753) Classification Search with wildcard in between strings causes issues.

2020-04-22 Thread Pinal (Jira)
Pinal created ATLAS-3753:


 Summary: Classification Search with wildcard in between strings 
causes issues.
 Key: ATLAS-3753
 URL: https://issues.apache.org/jira/browse/ATLAS-3753
 Project: Atlas
  Issue Type: Bug
Reporter: Pinal
Assignee: Pinal


Tag `tag_abc_test` is created and associated to an entity.

Search with *test or tag* fetches the entity.

But Search with tag*test doesn't fetch the entity.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3744) [Beta UI] Long entity type filter load time

2020-04-22 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089786#comment-17089786
 ] 

Nixon Rodrigues commented on ATLAS-3744:


+1 for the patch. [~kevalbhatt] thanks

> [Beta UI] Long entity type filter load time 
> 
>
> Key: ATLAS-3744
> URL: https://issues.apache.org/jira/browse/ATLAS-3744
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Umesh Padashetty
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3744.patch, Screenshot 2020-04-20 at 12.57.05 
> PM.png, Screenshot 2020-04-20 at 12.57.16 PM.png
>
>
> Sometimes, we are taking around 15-20 seconds to load the entity type filters 
> in the new Beta UI when the user clicks on Filters drop down. Once the user 
> clicks on Filters, the UI just freezes there, while the content is loaded in 
> the background. This gives a feeling to the end-user that nothing is 
> happening and the UI is stuck, while in reality it isnt. This is pretty 
> confusing.
> I think it is a good idea to introduce a loading icon while the data is being 
> loaded in the backend.
> Attached screenshots. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3744) [Beta UI] Long entity type filter load time

2020-04-22 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3744:
---
Attachment: ATLAS-3744.patch

> [Beta UI] Long entity type filter load time 
> 
>
> Key: ATLAS-3744
> URL: https://issues.apache.org/jira/browse/ATLAS-3744
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Umesh Padashetty
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3744.patch, Screenshot 2020-04-20 at 12.57.05 
> PM.png, Screenshot 2020-04-20 at 12.57.16 PM.png
>
>
> Sometimes, we are taking around 15-20 seconds to load the entity type filters 
> in the new Beta UI when the user clicks on Filters drop down. Once the user 
> clicks on Filters, the UI just freezes there, while the content is loaded in 
> the background. This gives a feeling to the end-user that nothing is 
> happening and the UI is stuck, while in reality it isnt. This is pretty 
> confusing.
> I think it is a good idea to introduce a loading icon while the data is being 
> loaded in the backend.
> Attached screenshots. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3750) UI: Disable "Propagated from" button inside classification tab if entity status is purged

2020-04-22 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089762#comment-17089762
 ] 

Nixon Rodrigues commented on ATLAS-3750:


+1 for the patch, thanks [~kevalbhatt]

> UI: Disable "Propagated from" button inside classification tab if entity 
> status is purged
> -
>
> Key: ATLAS-3750
> URL: https://issues.apache.org/jira/browse/ATLAS-3750
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3750.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3696) [Business Metadata] No option to check/uncheck Business Metadata attributes in search results

2020-04-22 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089761#comment-17089761
 ] 

Nixon Rodrigues commented on ATLAS-3696:


+1 for the patch, thanks [~kevalbhatt]

> [Business Metadata] No option to check/uncheck Business Metadata attributes 
> in search results
> -
>
> Key: ATLAS-3696
> URL: https://issues.apache.org/jira/browse/ATLAS-3696
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Umesh Padashetty
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3696.patch, Screenshot 2020-03-26 at 9.00.55 
> PM.png, Screenshot 2020-03-26 at 9.04.22 PM.png
>
>
> For instance, there is no way to show "Business Metadata" column if Business 
> Metadata attribute filter is not applied while searching. Attached screenshots



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3752) UI: Login js improvment

2020-04-22 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089759#comment-17089759
 ] 

Nixon Rodrigues commented on ATLAS-3752:


+1 for the patch. [~kevalbhatt] thanks

> UI: Login js improvment
> ---
>
> Key: ATLAS-3752
> URL: https://issues.apache.org/jira/browse/ATLAS-3752
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3752.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3685) UI: Bulk import Business Metadata attribute assignment to entities

2020-04-22 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089757#comment-17089757
 ] 

Nixon Rodrigues commented on ATLAS-3685:


+1 for the patch, [~kevalbhatt] thanks

> UI: Bulk import Business Metadata attribute assignment to entities
> --
>
> Key: ATLAS-3685
> URL: https://issues.apache.org/jira/browse/ATLAS-3685
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3685-1.patch, ATLAS-3685.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3721) UI: Render attributes in filters of admin audits using entity def

2020-04-22 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3721:
---
Fix Version/s: 3.0.0
   2.1.0

> UI: Render attributes in filters of admin audits using entity def
> -
>
> Key: ATLAS-3721
> URL: https://issues.apache.org/jira/browse/ATLAS-3721
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3744) [Beta UI] Long entity type filter load time

2020-04-22 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3744:
---
Fix Version/s: 3.0.0
   2.1.0

> [Beta UI] Long entity type filter load time 
> 
>
> Key: ATLAS-3744
> URL: https://issues.apache.org/jira/browse/ATLAS-3744
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Umesh Padashetty
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: Screenshot 2020-04-20 at 12.57.05 PM.png, Screenshot 
> 2020-04-20 at 12.57.16 PM.png
>
>
> Sometimes, we are taking around 15-20 seconds to load the entity type filters 
> in the new Beta UI when the user clicks on Filters drop down. Once the user 
> clicks on Filters, the UI just freezes there, while the content is loaded in 
> the background. This gives a feeling to the end-user that nothing is 
> happening and the UI is stuck, while in reality it isnt. This is pretty 
> confusing.
> I think it is a good idea to introduce a loading icon while the data is being 
> loaded in the backend.
> Attached screenshots. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3685) UI: Bulk import Business Metadata attribute assignment to entities

2020-04-22 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3685:
---
Attachment: ATLAS-3685-1.patch

> UI: Bulk import Business Metadata attribute assignment to entities
> --
>
> Key: ATLAS-3685
> URL: https://issues.apache.org/jira/browse/ATLAS-3685
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3685-1.patch, ATLAS-3685.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3750) UI: Disable "Propagated from" button inside classification tab if entity status is purged

2020-04-22 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3750:
---
Attachment: ATLAS-3750.patch

> UI: Disable "Propagated from" button inside classification tab if entity 
> status is purged
> -
>
> Key: ATLAS-3750
> URL: https://issues.apache.org/jira/browse/ATLAS-3750
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3750.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3752) UI: Login js improvment

2020-04-22 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3752:
---
Attachment: ATLAS-3752.patch

> UI: Login js improvment
> ---
>
> Key: ATLAS-3752
> URL: https://issues.apache.org/jira/browse/ATLAS-3752
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3752.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3752) UI: Login js improvment

2020-04-22 Thread Keval Bhatt (Jira)
Keval Bhatt created ATLAS-3752:
--

 Summary: UI: Login js improvment
 Key: ATLAS-3752
 URL: https://issues.apache.org/jira/browse/ATLAS-3752
 Project: Atlas
  Issue Type: Bug
Reporter: Keval Bhatt
Assignee: Keval Bhatt
 Fix For: 2.1.0, 3.0.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72415: ATLAS-3667 : Option to store Ldap/AD bind password in jceks keystore file

2020-04-22 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72415/#review220421
---


Ship it!




Ship It!

- Nixon Rodrigues


On April 22, 2020, 11:12 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72415/
> ---
> 
> (Updated April 22, 2020, 11:12 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3667
> https://issues.apache.org/jira/browse/ATLAS-3667
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Set MASK_LDAP_PASSWORD constant value to "" to be sync with other 
> applications.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/ApplicationProperties.java e40ca8878 
> 
> 
> Diff: https://reviews.apache.org/r/72415/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> chaitali
> 
>



[jira] [Updated] (ATLAS-3696) [Business Metadata] No option to check/uncheck Business Metadata attributes in search results

2020-04-22 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3696:
---
Attachment: ATLAS-3696.patch

> [Business Metadata] No option to check/uncheck Business Metadata attributes 
> in search results
> -
>
> Key: ATLAS-3696
> URL: https://issues.apache.org/jira/browse/ATLAS-3696
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Umesh Padashetty
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3696.patch, Screenshot 2020-03-26 at 9.00.55 
> PM.png, Screenshot 2020-03-26 at 9.04.22 PM.png
>
>
> For instance, there is no way to show "Business Metadata" column if Business 
> Metadata attribute filter is not applied while searching. Attached screenshots



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72415: ATLAS-3667 : Option to store Ldap/AD bind password in jceks keystore file

2020-04-22 Thread chaitali

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72415/
---

(Updated April 22, 2020, 11:07 a.m.)


Review request for atlas and Nixon Rodrigues.


Bugs: ATLAS-3667
https://issues.apache.org/jira/browse/ATLAS-3667


Repository: atlas


Description (updated)
---

Set MASK_LDAP_PASSWORD constant value to "" to be sync with other 
applications.


Diffs
-

  intg/src/main/java/org/apache/atlas/ApplicationProperties.java e40ca8878 


Diff: https://reviews.apache.org/r/72415/diff/1/


Testing
---


Thanks,

chaitali



Review Request 72415: ATLAS-3667 : Option to store Ldap/AD bind password in jceks keystore file

2020-04-22 Thread chaitali

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72415/
---

Review request for atlas and Nixon Rodrigues.


Bugs: ATLAS-3667
https://issues.apache.org/jira/browse/ATLAS-3667


Repository: atlas


Description
---

Set mask password Constant value to mask ""


Diffs
-

  intg/src/main/java/org/apache/atlas/ApplicationProperties.java e40ca8878 


Diff: https://reviews.apache.org/r/72415/diff/1/


Testing
---


Thanks,

chaitali



[jira] [Updated] (ATLAS-3721) UI: Render attributes in filters of admin audits using entity def

2020-04-22 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3721:
---
Parent: ATLAS-3749
Issue Type: Sub-task  (was: Bug)

> UI: Render attributes in filters of admin audits using entity def
> -
>
> Key: ATLAS-3721
> URL: https://issues.apache.org/jira/browse/ATLAS-3721
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3751) UI: Add result count column in the admin audit table

2020-04-22 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3751:
---
Summary: UI: Add result count column in the admin audit table  (was: UI: 
Add Result Count Column in the admin audit table)

> UI: Add result count column in the admin audit table
> 
>
> Key: ATLAS-3751
> URL: https://issues.apache.org/jira/browse/ATLAS-3751
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3750) UI: Disable "Propagated from" button inside classification tab if entity status is purged

2020-04-22 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3750:
---
Fix Version/s: 3.0.0
   2.1.0

> UI: Disable "Propagated from" button inside classification tab if entity 
> status is purged
> -
>
> Key: ATLAS-3750
> URL: https://issues.apache.org/jira/browse/ATLAS-3750
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3751) UI: Add Result Count Column in the admin audit table

2020-04-22 Thread Keval Bhatt (Jira)
Keval Bhatt created ATLAS-3751:
--

 Summary: UI: Add Result Count Column in the admin audit table
 Key: ATLAS-3751
 URL: https://issues.apache.org/jira/browse/ATLAS-3751
 Project: Atlas
  Issue Type: Sub-task
Reporter: Keval Bhatt
Assignee: Keval Bhatt
 Fix For: 2.1.0, 3.0.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3750) UI: Disable "Propagated from" button inside classification tab if entity status is purged

2020-04-22 Thread Keval Bhatt (Jira)
Keval Bhatt created ATLAS-3750:
--

 Summary: UI: Disable "Propagated from" button inside 
classification tab if entity status is purged
 Key: ATLAS-3750
 URL: https://issues.apache.org/jira/browse/ATLAS-3750
 Project: Atlas
  Issue Type: Sub-task
Reporter: Keval Bhatt
Assignee: Keval Bhatt






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3749) Atlas UI Changes for Admin Audit

2020-04-22 Thread Keval Bhatt (Jira)
Keval Bhatt created ATLAS-3749:
--

 Summary: Atlas UI Changes for Admin Audit  
 Key: ATLAS-3749
 URL: https://issues.apache.org/jira/browse/ATLAS-3749
 Project: Atlas
  Issue Type: Bug
Reporter: Keval Bhatt
Assignee: Keval Bhatt






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3748) UI: Add new UI feature into Classic UI

2020-04-22 Thread Keval Bhatt (Jira)
Keval Bhatt created ATLAS-3748:
--

 Summary: UI: Add new UI feature into Classic UI
 Key: ATLAS-3748
 URL: https://issues.apache.org/jira/browse/ATLAS-3748
 Project: Atlas
  Issue Type: Bug
Reporter: Keval Bhatt
Assignee: Keval Bhatt


* Add Business Metadata in the basic search filter
 * Administrator tab

 ** Admin audit
 ** Business Metadata management
 ** Enum management



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-3745) [Business Metadata] Newly added BM definitions in admin/BM page are not immediately listed. Refresh is needed to load the new BM definitions.

2020-04-22 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt reassigned ATLAS-3745:
--

Assignee: Keval Bhatt

> [Business Metadata] Newly added BM definitions in admin/BM page are not 
> immediately listed. Refresh is needed to load the new BM definitions.
> -
>
> Key: ATLAS-3745
> URL: https://issues.apache.org/jira/browse/ATLAS-3745
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Umesh Padashetty
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: Screenshot 2020-04-20 at 7.26.22 PM.png, Screenshot 
> 2020-04-20 at 7.26.44 PM.png
>
>
> This was working fine before, seems to be a regression. Attached screenshots.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)