[jira] [Commented] (ATLAS-3775) Migration Import Display: Incorrect Status Display

2020-05-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100059#comment-17100059
 ] 

ASF subversion and git services commented on ATLAS-3775:


Commit f467229294baa5550f4101d1e8ea59e82fdf3e3b in atlas's branch 
refs/heads/master from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f467229 ]

ATLAS-3775: Migration Import: Status display fix.


> Migration Import Display: Incorrect Status Display
> --
>
> Key: ATLAS-3775
> URL: https://issues.apache.org/jira/browse/ATLAS-3775
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: ATLAS-3775-Migration-Import-Status-display-fix.patch
>
>
> *Background*
> Zip file based migration introduced _DataMigrationStatusService_. This class 
> is responsible for displaying the status.
> *Steps to Duplicate*
> Pre-requisites:
>  * Keep the REST http:///api/atlas/admin output open in a browser 
> window.
>  * Keep zip-file based migration import in progress.
>  * Ensure that you see the current status. Once migration progress, refresh 
> the REST API output to display the status. The status should be accurate.
>  * Refresh the REST API output after 5 mins. This will expire the status 
> cache and make a request to _DataMigrationService_ for status.
> _Expected results_
>  * Status returned by API should reflect the status logged.
>  
> _Actual results_
>  * There is a mismatch in the status.
>  * Additional information: The status is never updated for that session.
> Root cause:
> - _DataMigrationService_ maintains cached status object for each requestor. 
> This is not refreshed from the database status.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3762) Entity Creation: Improve Edges Fetch Between Vertices

2020-05-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100060#comment-17100060
 ] 

ASF subversion and git services commented on ATLAS-3762:


Commit 23aea76fff6c8f530816319649218583f4dfd091 in atlas's branch 
refs/heads/master from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=23aea76 ]

ATLAS-3762: Improve edge creation using genuine iterator. Part 2


> Entity Creation: Improve Edges Fetch Between Vertices
> -
>
> Key: ATLAS-3762
> URL: https://issues.apache.org/jira/browse/ATLAS-3762
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-3762-Edge-fetch-improvement-gremlin.patch, 
> ATLAS-3762-Improve-Edge-creator-using-Genuine-iterat.patch
>
>
> *Background*
> One of the earlier commits replaced vertices and edges fetch with 
> _StreamSupport.stream_. This uses _Collect(toList),_ which causes all 
> contents to be fetched. 
> Using this causes large amount of data to be fetched.
> *Solution*
> Switch to iterators that will use lazy loading.
> *Edge Fetch Refactoring*
> Change the _getEdge_ to iterate on smaller dataset. 
> Here are the scenarios:
> - _fromVertex_ is _hive_table_, _toVertex_ is _hive_column_. This means that 
> outgoing edges from _fromVertex_ will be many more than incoming edges to 
> _toVertex_.
> - _fromVertex_ is _hive_process_execution_, _toVertex_ is _hive_table_. This 
> means that outgoing edges from _fromVertex_ will be fewer than incoming edges 
> _hive_table_.
> Approach:
>  * Search it is a linear search, it will be more efficient to iterate over 
> fewer items than more items.
>  * Fetch count edge items for _fromVertex_ and _toVertex_. If either of the 
> count is 0, return NULL, since it will not result in anything being found.
>  * If either of the counts is not 0, take the one with fewer elements and 
> perform a search.
> [~sidharthkmishra] Thanks for this simple but effective fix.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski


> On May 2, 2020, 2:44 p.m., Bolke de Bruin wrote:
> > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
> > Line 203 (original), 203 (patched)
> > 
> >
> > can you add a test please?

Added bunch of tests, introduce little fix to get right result count for 
graphQuery. There is kind of undeterminism while running test for sortBy. I 
think that implementation of sortBy on graphQuery never worked properly.


- Damian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72459/#review220587
---


On May 5, 2020, 3:26 p.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72459/
> ---
> 
> (Updated May 5, 2020, 3:26 p.m.)
> 
> 
> Review request for atlas, Bolke de Bruin, Madhan Neethiraj, and Nixon 
> Rodrigues.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> EntitySearchProcessor fails when doing search by classification and specify 
> orderBy attribute. The issue is that for graph query you cannot refer to 
> attribute by name but need to provide absolute path to entity attribute e.g. 
> 
>  
> 
> ```
> 
> { "attributes": [ "description", "comment", "popularityScore" ], 
> "classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
> "limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
> "DESCENDING", "typeName": "hive_table" }
> ```
> 
> this query fails with following exception:
> 
>  
> 
> ```
> 
> {"exception":{"message":"Provided key does not exist: 
> hive_table.popularityScore","class":"java.lang.IllegalArgumentException","stacktrace":"java.lang.IllegalArgumentException:
>  Provided key does not exist: hive_table.popularityScore\n\tat 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:163)\n\tat
>  org.janusgraph.graphdb.query.graph.GraphCentricQueryBuilder.
> orderBy(GraphCentricQueryBuilder.java:160)
> 
> ```
> 
>  
> 
> When specify full reference to attribute e.g. 
> 
>  
> 
> ```
> 
> { "attributes": [ "description", "comment", "popularityScore" ], 
> "classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
> "limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
> "DESCENDING", "typeName": "hive_table" }
> ```
> 
> it fails on validation stage
> 
>  
> 
> ```
> 
> {"exception":{"message":"Attribute Table.popularityScore not found for type 
> Table","class":"org.apache.atlas.exception.AtlasBaseException","stacktrace":"org.apache.atlas.exception.AtlasBaseException:
>  Attribute Table.popularityScore not found for type Table\n\tat 
> org.apache.atlas.discovery.SearchContext.validateAttributes(SearchContext.java:288)
> 
> ```
> 
> Reference to JIRA https://issues.apache.org/jira/browse/ATLAS-3776
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  1a7bf6b16 
>   
> repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
>  PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 
> 9aa554ad5 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 0bbff2f46 
> 
> 
> Diff: https://reviews.apache.org/r/72459/diff/3/
> 
> 
> Testing
> ---
> 
> tested on our dev env.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>



[jira] [Commented] (ATLAS-3775) Migration Import Display: Incorrect Status Display

2020-05-05 Thread Nikhil Bonte (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100023#comment-17100023
 ] 

Nikhil Bonte commented on ATLAS-3775:
-

+1 for the patch, thanks [~amestry] .

> Migration Import Display: Incorrect Status Display
> --
>
> Key: ATLAS-3775
> URL: https://issues.apache.org/jira/browse/ATLAS-3775
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: ATLAS-3775-Migration-Import-Status-display-fix.patch
>
>
> *Background*
> Zip file based migration introduced _DataMigrationStatusService_. This class 
> is responsible for displaying the status.
> *Steps to Duplicate*
> Pre-requisites:
>  * Keep the REST http:///api/atlas/admin output open in a browser 
> window.
>  * Keep zip-file based migration import in progress.
>  * Ensure that you see the current status. Once migration progress, refresh 
> the REST API output to display the status. The status should be accurate.
>  * Refresh the REST API output after 5 mins. This will expire the status 
> cache and make a request to _DataMigrationService_ for status.
> _Expected results_
>  * Status returned by API should reflect the status logged.
>  
> _Actual results_
>  * There is a mismatch in the status.
>  * Additional information: The status is never updated for that session.
> Root cause:
> - _DataMigrationService_ maintains cached status object for each requestor. 
> This is not refreshed from the database status.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72459/
---

(Updated May 5, 2020, 3:26 p.m.)


Review request for atlas, Bolke de Bruin, Madhan Neethiraj, and Nixon Rodrigues.


Changes
---

optimize getResultCount() for graphQuery


Repository: atlas


Description
---

EntitySearchProcessor fails when doing search by classification and specify 
orderBy attribute. The issue is that for graph query you cannot refer to 
attribute by name but need to provide absolute path to entity attribute e.g. 

 

```

{ "attributes": [ "description", "comment", "popularityScore" ], 
"classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
"limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
"DESCENDING", "typeName": "hive_table" }
```

this query fails with following exception:

 

```

{"exception":{"message":"Provided key does not exist: 
hive_table.popularityScore","class":"java.lang.IllegalArgumentException","stacktrace":"java.lang.IllegalArgumentException:
 Provided key does not exist: hive_table.popularityScore\n\tat 
com.google.common.base.Preconditions.checkArgument(Preconditions.java:163)\n\tat
 org.janusgraph.graphdb.query.graph.GraphCentricQueryBuilder.
orderBy(GraphCentricQueryBuilder.java:160)

```

 

When specify full reference to attribute e.g. 

 

```

{ "attributes": [ "description", "comment", "popularityScore" ], 
"classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
"limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
"DESCENDING", "typeName": "hive_table" }
```

it fails on validation stage

 

```

{"exception":{"message":"Attribute Table.popularityScore not found for type 
Table","class":"org.apache.atlas.exception.AtlasBaseException","stacktrace":"org.apache.atlas.exception.AtlasBaseException:
 Attribute Table.popularityScore not found for type Table\n\tat 
org.apache.atlas.discovery.SearchContext.validateAttributes(SearchContext.java:288)

```

Reference to JIRA https://issues.apache.org/jira/browse/ATLAS-3776


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
1a7bf6b16 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 9aa554ad5 
  repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 0bbff2f46 


Diff: https://reviews.apache.org/r/72459/diff/3/

Changes: https://reviews.apache.org/r/72459/diff/2-3/


Testing
---

tested on our dev env.


Thanks,

Damian Warszawski



Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72459/
---

(Updated May 5, 2020, 10:11 p.m.)


Review request for atlas, Bolke de Bruin, Madhan Neethiraj, and Nixon Rodrigues.


Changes
---

Fixed orderBy for graphQuery by replacing Hashset with LinkedHashSet to 
maintain insertion order.


Repository: atlas


Description
---

EntitySearchProcessor fails when doing search by classification and specify 
orderBy attribute. The issue is that for graph query you cannot refer to 
attribute by name but need to provide absolute path to entity attribute e.g. 

 

```

{ "attributes": [ "description", "comment", "popularityScore" ], 
"classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
"limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
"DESCENDING", "typeName": "hive_table" }
```

this query fails with following exception:

 

```

{"exception":{"message":"Provided key does not exist: 
hive_table.popularityScore","class":"java.lang.IllegalArgumentException","stacktrace":"java.lang.IllegalArgumentException:
 Provided key does not exist: hive_table.popularityScore\n\tat 
com.google.common.base.Preconditions.checkArgument(Preconditions.java:163)\n\tat
 org.janusgraph.graphdb.query.graph.GraphCentricQueryBuilder.
orderBy(GraphCentricQueryBuilder.java:160)

```

 

When specify full reference to attribute e.g. 

 

```

{ "attributes": [ "description", "comment", "popularityScore" ], 
"classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
"limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
"DESCENDING", "typeName": "hive_table" }
```

it fails on validation stage

 

```

{"exception":{"message":"Attribute Table.popularityScore not found for type 
Table","class":"org.apache.atlas.exception.AtlasBaseException","stacktrace":"org.apache.atlas.exception.AtlasBaseException:
 Attribute Table.popularityScore not found for type Table\n\tat 
org.apache.atlas.discovery.SearchContext.validateAttributes(SearchContext.java:288)

```

Reference to JIRA https://issues.apache.org/jira/browse/ATLAS-3776


Diffs (updated)
-

  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java
 c70e8bfe8 
  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
1a7bf6b16 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 9aa554ad5 
  repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 0bbff2f46 


Diff: https://reviews.apache.org/r/72459/diff/4/

Changes: https://reviews.apache.org/r/72459/diff/3-4/


Testing
---

tested on our dev env.


Thanks,

Damian Warszawski



[jira] [Commented] (ATLAS-3781) update authorization to admin-purge for admin entity purge Rest

2020-05-05 Thread Sidharth Kumar Mishra (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100215#comment-17100215
 ] 

Sidharth Kumar Mishra commented on ATLAS-3781:
--

Duplicate to https://issues.apache.org/jira/browse/ATLAS-3575

> update authorization to admin-purge for admin entity purge Rest
> ---
>
> Key: ATLAS-3781
> URL: https://issues.apache.org/jira/browse/ATLAS-3781
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ATLAS-3781) update authorization to admin-purge for admin entity purge Rest

2020-05-05 Thread Sidharth Kumar Mishra (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sidharth Kumar Mishra resolved ATLAS-3781.
--
Resolution: Duplicate

> update authorization to admin-purge for admin entity purge Rest
> ---
>
> Key: ATLAS-3781
> URL: https://issues.apache.org/jira/browse/ATLAS-3781
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3781) update authorization to admin-purge for admin entity purge Rest

2020-05-05 Thread Sidharth Kumar Mishra (Jira)
Sidharth Kumar Mishra created ATLAS-3781:


 Summary: update authorization to admin-purge for admin entity 
purge Rest
 Key: ATLAS-3781
 URL: https://issues.apache.org/jira/browse/ATLAS-3781
 Project: Atlas
  Issue Type: Bug
Reporter: Sidharth Kumar Mishra
Assignee: Sidharth Kumar Mishra






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3780) Remove 'Status' from Classification System Attributes

2020-05-05 Thread Pinal (Jira)
Pinal created ATLAS-3780:


 Summary: Remove 'Status' from Classification System Attributes
 Key: ATLAS-3780
 URL: https://issues.apache.org/jira/browse/ATLAS-3780
 Project: Atlas
  Issue Type: Task
  Components: atlas-intg
Reporter: Pinal
Assignee: Pinal






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3780) Remove 'Status' from Classification System Attributes

2020-05-05 Thread Pinal (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal updated ATLAS-3780:
-
Attachment: Screen Shot 2020-05-05 at 4.40.40 PM.png

> Remove 'Status' from Classification System Attributes
> -
>
> Key: ATLAS-3780
> URL: https://issues.apache.org/jira/browse/ATLAS-3780
> Project: Atlas
>  Issue Type: Task
>  Components: atlas-intg
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
> Attachments: Screen Shot 2020-05-05 at 4.40.40 PM.png
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72459/
---

(Updated May 5, 2020, 11:45 a.m.)


Review request for atlas, Bolke de Bruin, Madhan Neethiraj, and Nixon Rodrigues.


Repository: atlas


Description
---

EntitySearchProcessor fails when doing search by classification and specify 
orderBy attribute. The issue is that for graph query you cannot refer to 
attribute by name but need to provide absolute path to entity attribute e.g. 

 

```

{ "attributes": [ "description", "comment", "popularityScore" ], 
"classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
"limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
"DESCENDING", "typeName": "hive_table" }
```

this query fails with following exception:

 

```

{"exception":{"message":"Provided key does not exist: 
hive_table.popularityScore","class":"java.lang.IllegalArgumentException","stacktrace":"java.lang.IllegalArgumentException:
 Provided key does not exist: hive_table.popularityScore\n\tat 
com.google.common.base.Preconditions.checkArgument(Preconditions.java:163)\n\tat
 org.janusgraph.graphdb.query.graph.GraphCentricQueryBuilder.
orderBy(GraphCentricQueryBuilder.java:160)

```

 

When specify full reference to attribute e.g. 

 

```

{ "attributes": [ "description", "comment", "popularityScore" ], 
"classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
"limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
"DESCENDING", "typeName": "hive_table" }
```

it fails on validation stage

 

```

{"exception":{"message":"Attribute Table.popularityScore not found for type 
Table","class":"org.apache.atlas.exception.AtlasBaseException","stacktrace":"org.apache.atlas.exception.AtlasBaseException:
 Attribute Table.popularityScore not found for type Table\n\tat 
org.apache.atlas.discovery.SearchContext.validateAttributes(SearchContext.java:288)

```

Reference to JIRA https://issues.apache.org/jira/browse/ATLAS-3776


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
1a7bf6b16 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/BasicTestSetup.java 9aa554ad5 
  repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 0bbff2f46 


Diff: https://reviews.apache.org/r/72459/diff/2/

Changes: https://reviews.apache.org/r/72459/diff/1-2/


Testing
---

tested on our dev env.


Thanks,

Damian Warszawski



[jira] [Updated] (ATLAS-3583) Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-05-05 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3583:
---
Summary: Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE  (was: Use Audit framework to generate audit entries for 
Classification CREATE, UPDATE and DELETE)

> Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and 
> DELETE
> 
>
> Key: ATLAS-3583
> URL: https://issues.apache.org/jira/browse/ATLAS-3583
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72459/
---

(Updated May 5, 2020, 11:45 a.m.)


Review request for atlas, Bolke de Bruin, Madhan Neethiraj, and Nixon Rodrigues.


Repository: atlas


Description
---

EntitySearchProcessor fails when doing search by classification and specify 
orderBy attribute. The issue is that for graph query you cannot refer to 
attribute by name but need to provide absolute path to entity attribute e.g. 

 

```

{ "attributes": [ "description", "comment", "popularityScore" ], 
"classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
"limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
"DESCENDING", "typeName": "hive_table" }
```

this query fails with following exception:

 

```

{"exception":{"message":"Provided key does not exist: 
hive_table.popularityScore","class":"java.lang.IllegalArgumentException","stacktrace":"java.lang.IllegalArgumentException:
 Provided key does not exist: hive_table.popularityScore\n\tat 
com.google.common.base.Preconditions.checkArgument(Preconditions.java:163)\n\tat
 org.janusgraph.graphdb.query.graph.GraphCentricQueryBuilder.
orderBy(GraphCentricQueryBuilder.java:160)

```

 

When specify full reference to attribute e.g. 

 

```

{ "attributes": [ "description", "comment", "popularityScore" ], 
"classification": "customer_NON_PII", "excludeDeletedEntities": "False", 
"limit": "", "offset": 100, "sortBy": "Table.popularityScore", "sortOrder": 
"DESCENDING", "typeName": "hive_table" }
```

it fails on validation stage

 

```

{"exception":{"message":"Attribute Table.popularityScore not found for type 
Table","class":"org.apache.atlas.exception.AtlasBaseException","stacktrace":"org.apache.atlas.exception.AtlasBaseException:
 Attribute Table.popularityScore not found for type Table\n\tat 
org.apache.atlas.discovery.SearchContext.validateAttributes(SearchContext.java:288)

```

Reference to JIRA https://issues.apache.org/jira/browse/ATLAS-3776


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
1a7bf6b16 


Diff: https://reviews.apache.org/r/72459/diff/1/


Testing
---

tested on our dev env.


File Attachments (updated)


ATLAS-3776-1.patch
  
https://reviews.apache.org/media/uploaded/files/2020/05/05/96de2792-c75b-4440-8368-8791be7b005f__ATLAS-3776-1.patch


Thanks,

Damian Warszawski



[jira] [Updated] (ATLAS-3780) Remove 'Status' from Classification System Attributes

2020-05-05 Thread Pinal (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal updated ATLAS-3780:
-
Attachment: (was: Screen Shot 2020-05-05 at 4.40.40 PM.png)

> Remove 'Status' from Classification System Attributes
> -
>
> Key: ATLAS-3780
> URL: https://issues.apache.org/jira/browse/ATLAS-3780
> Project: Atlas
>  Issue Type: Task
>  Components: atlas-intg
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3780) Remove 'Status' from Classification System Attributes

2020-05-05 Thread Pinal (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal updated ATLAS-3780:
-
Attachment: Screen Shot 2020-05-05 at 4.40.40 PM.png

> Remove 'Status' from Classification System Attributes
> -
>
> Key: ATLAS-3780
> URL: https://issues.apache.org/jira/browse/ATLAS-3780
> Project: Atlas
>  Issue Type: Task
>  Components: atlas-intg
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)