Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

2020-07-01 Thread Jyoti Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72638/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
---

There are many missing API endpoints in AtlasClientV2. This solution is adding 
functions corresponding to those missing APIs for the following Rest endpoints.

1. TypeRest
2. EntityRest
3. LineageRest
4. DiscoveryRest
5. GlossaryRest
6. RelationshipRest

This will enable users to test and integrate with APIs more effectively via 
AtlasCient.


Diffs
-

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 7b6d1d0f3 
  webapp/pom.xml 3c55b4dd4 
  webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10d 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
680028892 
  
webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java
 cc883d615 
  webapp/src/test/java/org/apache/atlas/web/integration/GlossaryClientV2IT.java 
PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/integration/LineageClientV2IT.java 
PRE-CREATION 
  
webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java
 331ea2c47 


Diff: https://reviews.apache.org/r/72638/diff/1/


Testing
---

IT has been added for newly created functions in AtlasClientV2.
Validated by running IT on local system.


Thanks,

Jyoti Singh



[jira] [Updated] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases

2020-07-01 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3875:
--
Labels: api client  (was: )

> Adding missing APIs in AtlasClient with test cases
> --
>
> Key: ATLAS-3875
> URL: https://issues.apache.org/jira/browse/ATLAS-3875
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0
>Reporter: Jyoti Singh
>Assignee: Jyoti Singh
>Priority: Major
>  Labels: api, client
>
> There are many new APIs added to Atlas Project but the corresponding  APIs 
> are missing from AtlasClientv2. The aim of this task is to complete the gap 
> amongst existing APIs and their endpoints in Atls client. This will also 
> include adding test cases via integration testing.
> There are functions from AtlasClient for the following REST endpoints
>  * TypeRest
>  * EntityRest
>  * LineageRest
>  * DiscoveryRest
>  * GlossaryRest
>  * RelationshipRest



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases

2020-07-01 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3875:
--
Component/s:  atlas-core

> Adding missing APIs in AtlasClient with test cases
> --
>
> Key: ATLAS-3875
> URL: https://issues.apache.org/jira/browse/ATLAS-3875
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0
>Reporter: Jyoti Singh
>Assignee: Jyoti Singh
>Priority: Major
>
> There are many new APIs added to Atlas Project but the corresponding  APIs 
> are missing from AtlasClientv2. The aim of this task is to complete the gap 
> amongst existing APIs and their endpoints in Atls client. This will also 
> include adding test cases via integration testing.
> There are functions from AtlasClient for the following REST endpoints
>  * TypeRest
>  * EntityRest
>  * LineageRest
>  * DiscoveryRest
>  * GlossaryRest
>  * RelationshipRest



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3869) Upgrade httpclient from 4.5.3 to 4.5.4

2020-07-01 Thread Sarath Subramanian (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149715#comment-17149715
 ] 

Sarath Subramanian commented on ATLAS-3869:
---

[~nixon], consider merging this to branch-2.0 as well.

> Upgrade httpclient from 4.5.3 to 4.5.4
> --
>
> Key: ATLAS-3869
> URL: https://issues.apache.org/jira/browse/ATLAS-3869
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3869-Upgrade-httpclient-from-4.5.3-to-4.5.4.patch
>
>
> Found below exception where data was not getting added in SOLR from 
> janusgraph.
>  
> {noformat}
> Caused by: java.lang.ClassCastException: [B cannot be cast to java.lang.String
>   at 
> org.apache.http.conn.ssl.DefaultHostnameVerifier.getSubjectAltNames(DefaultHostnameVerifier.java:309)
>   at 
> org.apache.http.conn.ssl.DefaultHostnameVerifier.verify(DefaultHostnameVerifier.java:112)
>   at 
> org.apache.http.conn.ssl.DefaultHostnameVerifier.verify(DefaultHostnameVerifier.java:99)
>   at 
> org.apache.http.conn.ssl.SSLConnectionSocketFactory.verifyHostname(SSLConnectionSocketFactory.java:463)
>   at 
> org.apache.http.conn.ssl.SSLConnectionSocketFactory.createLayeredSocket(SSLConnectionSocketFactory.java:397)
>   at 
> org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:355)
>   at 
> org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:142)
>   at 
> org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:359)
>   at 
> org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:381)
>   at 
> org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:237)
>   at 
> org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)
>   at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
>   at 
> org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)
>   at 
> org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
>   at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
>   at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56)
>   at 
> org.apache.solr.client.solrj.impl.HttpSolrClient.executeMethod(HttpSolrClient.java:526)
>   at 
> org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:253)
>   at 
> org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:242)
>   at 
> org.apache.solr.client.solrj.impl.LBHttpSolrClient.doRequest(LBHttpSolrClient.java:483)
>   ... 7 more
> 2020-06-29 07:31:25,893 WARN  - [SIGTERM handler:] ~ Unable to close 
> transaction standardjanusgraphtx[0x18d7a16a] (StandardJanusGraph:230)
> java.lang.IllegalArgumentException: The transaction has already been closed
>   at 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
>   at 
> org.janusgraph.graphdb.transaction.StandardJanusGraphTx.rollback(StandardJanusGraphTx.java:1401)
>   at 
> org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsTransaction$1.doRollback(JanusGraphBlueprintsTransaction.java:190)
>   at 
> org.apache.tinkerpop.gremlin.structure.util.AbstractTransaction.rollback(AbstractTransaction.java:114)
>   at 
> org.apache.tinkerpop.gremlin.structure.Transaction$CLOSE_BEHAVIOR$2.accept(Transaction.java:182)
>   at 
> org.apache.tinkerpop.gremlin.structure.Transaction$CLOSE_BEHAVIOR$2.accept(Transaction.java:179)
>   at 
> org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsGraph$GraphTransaction.close(JanusGraphBlueprintsGraph.java:327)
>   at 
> org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsTransaction$1.doClose(JanusGraphBlueprintsTransaction.java:205)
>   at 
> org.apache.tinkerpop.gremlin.structure.util.AbstractTransaction.close(AbstractTransaction.java:139)
>   at 
> org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsTransaction.close(JanusGraphBlueprintsTransaction.java:215)
>   at 
> org.janusgraph.graphdb.database.StandardJanusGraph.closeInternal(StandardJanusGraph.java:226)
>   at 
> org.janusgraph.graphdb.database.StandardJanusGraph.access$500(StandardJanusGraph.java:91)
>   at 
> org.janusgraph.graphdb.database.StandardJanusGraph$ShutdownThread.start(StandardJanusGraph.java:818)
>   at 
> java.lang.ApplicationShutdownHooks.runHooks(ApplicationShutdownHooks.java:102)
>   at 
> java.lang.ApplicationShutdownHooks$1.run(ApplicationShutdownHooks.java:46)

[jira] [Updated] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases

2020-07-01 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3875:
--
Affects Version/s: 2.0.0

> Adding missing APIs in AtlasClient with test cases
> --
>
> Key: ATLAS-3875
> URL: https://issues.apache.org/jira/browse/ATLAS-3875
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: Jyoti Singh
>Assignee: Jyoti Singh
>Priority: Major
>
> There are many new APIs added to Atlas Project but the corresponding  APIs 
> are missing from AtlasClientv2. The aim of this task is to complete the gap 
> amongst existing APIs and their endpoints in Atls client. This will also 
> include adding test cases via integration testing.
> There are functions from AtlasClient for the following REST endpoints
>  * TypeRest
>  * EntityRest
>  * LineageRest
>  * DiscoveryRest
>  * GlossaryRest
>  * RelationshipRest



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3871) Add unit tests to path extractor utility for s3, s3 v2, adls path entities

2020-07-01 Thread Sarath Subramanian (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149714#comment-17149714
 ] 

Sarath Subramanian commented on ATLAS-3871:
---

please merge this in branch-2.0 as well.

> Add unit tests to path extractor utility for s3, s3 v2, adls path entities
> --
>
> Key: ATLAS-3871
> URL: https://issues.apache.org/jira/browse/ATLAS-3871
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0
>Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
>
> AtlasPathExtractorUtilTest added in ATLAS-3836 which covers unit tests for 
> ozone & hdfs path entites.
>  
> This Jira will improve AtlasPathExtractorUtilTest.java to cover s3, s3v2 & 
> adls path entities.
> Would add more tests for ozone as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3852) Entity Bulk Create with unique reference

2020-07-01 Thread Vasanth kumar RJ (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149651#comment-17149651
 ] 

Vasanth kumar RJ commented on ATLAS-3852:
-

[~madhan] I shared my use case and patch got test cases. Can you guide me 
whether this patch is useful or not? 

> Entity Bulk Create with unique reference
> 
>
> Key: ATLAS-3852
> URL: https://issues.apache.org/jira/browse/ATLAS-3852
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Vasanth kumar RJ
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: ATLAS-3852.patch, BulkPostCreate.json
>
>
> Entities created in bulk and unique referenced in same request. Bulk create 
> DB, Table and Column referenced in a request itself.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases

2020-07-01 Thread Jyoti Singh (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jyoti Singh updated ATLAS-3875:
---
Description: 
There are many new APIs added to Atlas Project but the corresponding  APIs are 
missing from AtlasClientv2. The aim of this task is to complete the gap amongst 
existing APIs and their endpoints in Atls client. This will also include adding 
test cases via integration testing.

There are functions from AtlasClient for the following REST endpoints
 * TypeRest
 * EntityRest
 * LineageRest
 * DiscoveryRest
 * GlossaryRest
 * RelationshipRest

> Adding missing APIs in AtlasClient with test cases
> --
>
> Key: ATLAS-3875
> URL: https://issues.apache.org/jira/browse/ATLAS-3875
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Jyoti Singh
>Assignee: Jyoti Singh
>Priority: Major
>
> There are many new APIs added to Atlas Project but the corresponding  APIs 
> are missing from AtlasClientv2. The aim of this task is to complete the gap 
> amongst existing APIs and their endpoints in Atls client. This will also 
> include adding test cases via integration testing.
> There are functions from AtlasClient for the following REST endpoints
>  * TypeRest
>  * EntityRest
>  * LineageRest
>  * DiscoveryRest
>  * GlossaryRest
>  * RelationshipRest



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3875) Adding missing APIs in AtlasClient with test cases

2020-07-01 Thread Jyoti Singh (Jira)
Jyoti Singh created ATLAS-3875:
--

 Summary: Adding missing APIs in AtlasClient with test cases
 Key: ATLAS-3875
 URL: https://issues.apache.org/jira/browse/ATLAS-3875
 Project: Atlas
  Issue Type: Improvement
Reporter: Jyoti Singh
Assignee: Jyoti Singh






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 72636: NotificationHookConsumer: Concurrent Message Processing

2020-07-01 Thread Ashutosh Mestry via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72636/
---

Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-3874
https://issues.apache.org/jira/browse/ATLAS-3874


Repository: atlas


Description
---

**Background**
Please see bug description.

**Approach**
At a high-level: Introduce a notion where the individual consumers are aware of 
the entities being processed by each other. If there are no entities being 
processed concurrently, everything proceeds as usual (the way it is before his 
change). If same entity is being procesed by multiple consumers, then one 
consumer waits for the other to finish before proceeding.

Classes:
New *UniqueKeysExtractor*: Extracts values of unique keys from 
*AtlasEntitiesWithExtInfo*. It navigates *relationshipAttributes* and 
*attributes* that has *objectRef* set.
New *UniquenessChecker*: Maintains a set of unique keys provided by 
*UniqueKeysExtractor*. It detects the presence of duplicates and waits until 
duplicates are resolved.
Modified *NoitficationHookConsumer.createOrUpdate* Updates *UniquenessChecker* 
with output from *UniqueKeysExtractor*. Clears the keys at the end of entity 
creation.
Modified *NotificationHookConsumer*: Accepts an shared instance of 
*UniqunessChecker*.


Diffs
-

  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 3f1ea05e1 
  webapp/src/main/java/org/apache/atlas/notification/UniqueKeysExtractor.java 
PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/notification/UniquenessChecker.java 
PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/notification/UniquenessCheckerTest.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72636/diff/1/


Testing
---

**Unit tests**
Tests added to verify new clases.

*UniquessCheckerTest*
Performs worst case checking by adding 100s of keys that are duplicates and 
verifies output of those.

**Functional tests**
Used Spark hook to verify.

Start Spark shell using:
```
sudo -u hdfs spark-shell
```

Spark sql commands:
```
spark.sql("create table default.t1_1381104676(col1 int)")
spark.sql("create table default.t2_1381104676(col2 int)")
spark.sql("select * from t1_1381104676, t2_1381104676 where 
col1=col2").write.saveAsTable("t3_1381104676")
```

**Volume test**
Medium-size Kafka dump added.

**Pre-commit Build**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/2003/


Thanks,

Ashutosh Mestry



[jira] [Updated] (ATLAS-3874) NotificationHookConsumer: Shell Entity Resolution When Multiple Consumers Process Same Entity

2020-07-01 Thread Ashutosh Mestry (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-3874:
---
Attachment: ATLAS-3874-Notification-hook-processing-concurrent-e.patch

> NotificationHookConsumer: Shell Entity Resolution When Multiple Consumers 
> Process Same Entity
> -
>
> Key: ATLAS-3874
> URL: https://issues.apache.org/jira/browse/ATLAS-3874
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.0.0, trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-3874-Notification-hook-processing-concurrent-e.patch
>
>
> *Background*
> Atlas has ability to consume messages from multiple hooks. When doing so, if 
> there are messages in multiple queue requesting creation of  the same entity, 
> then this case leads to a race condition. 
> *Steps to Duplicate*
> _Pre-requisites_
> Atlas should be configured to consume from 2 Kafka queues viz. _queue1_ and 
> _queue2_.
> _Steps:_
>  # Add a message in _queue1_ that references a non-existent entity.
>  # Add a message in _queue2_ that creates the entity in step 1.
> _Expected behavior_:
> Shell entity should get created in step 1 that is resolved into first class 
> entity in step 2.
> _Actual behavior:_
> Shell entity is not resolved. A duplicate entity with same _qualifiedName_ 
> gets created.
> *Root Cause*
> The _NotificationHookConsumer_ is not aware of messages processed by other 
> consumers there by leading to concurrent entity creation. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3874) NotificationHookConsumer: Shell Entity Resolution When Multiple Consumers Process Same Entity

2020-07-01 Thread Ashutosh Mestry (Jira)
Ashutosh Mestry created ATLAS-3874:
--

 Summary: NotificationHookConsumer: Shell Entity Resolution When 
Multiple Consumers Process Same Entity
 Key: ATLAS-3874
 URL: https://issues.apache.org/jira/browse/ATLAS-3874
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 2.0.0, trunk
Reporter: Ashutosh Mestry
Assignee: Ashutosh Mestry
 Fix For: trunk


*Background*

Atlas has ability to consume messages from multiple hooks. When doing so, if 
there are messages in multiple queue requesting creation of  the same entity, 
then this case leads to a race condition. 

*Steps to Duplicate*

_Pre-requisites_

Atlas should be configured to consume from 2 Kafka queues viz. _queue1_ and 
_queue2_.

_Steps:_
 # Add a message in _queue1_ that references a non-existent entity.
 # Add a message in _queue2_ that creates the entity in step 1.

_Expected behavior_:

Shell entity should get created in step 1 that is resolved into first class 
entity in step 2.

_Actual behavior:_

Shell entity is not resolved. A duplicate entity with same _qualifiedName_ gets 
created.

*Root Cause*

The _NotificationHookConsumer_ is not aware of messages processed by other 
consumers there by leading to concurrent entity creation. 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3873) branch-0.8 - Optimisation for findByTypeAndPropertyName method and isNotEmpty check for entityType.getAllSubTypes()

2020-07-01 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3873:
---
Attachment: ATLAS-3873-branch-0.8.patch

> branch-0.8 - Optimisation for findByTypeAndPropertyName method and isNotEmpty 
> check for entityType.getAllSubTypes()
> ---
>
> Key: ATLAS-3873
> URL: https://issues.apache.org/jira/browse/ATLAS-3873
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8.3
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 0.8.4
>
> Attachments: ATLAS-3873-branch-0.8.patch
>
>
> Optimisation for findByTypeAndPropertyName method and isNotEmpty check for 
> entityType.getAllSubTypes() on branch-0.8.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3873) branch-0.8 - Optimisation for findByTypeAndPropertyName method and isNotEmpty check for entityType.getAllSubTypes()

2020-07-01 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-3873:
--

 Summary: branch-0.8 - Optimisation for findByTypeAndPropertyName 
method and isNotEmpty check for entityType.getAllSubTypes()
 Key: ATLAS-3873
 URL: https://issues.apache.org/jira/browse/ATLAS-3873
 Project: Atlas
  Issue Type: Bug
Affects Versions: 0.8.3
Reporter: Nixon Rodrigues
Assignee: Nixon Rodrigues
 Fix For: 0.8.4


Optimisation for findByTypeAndPropertyName method and isNotEmpty check for 
entityType.getAllSubTypes() on branch-0.8.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3840) Atlas website's html meta description is set to "My awesome app using docz"

2020-07-01 Thread Keval Bhatt (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149388#comment-17149388
 ] 

Keval Bhatt commented on ATLAS-3840:


Thanks [~umesh.padashetty] for the patch

> Atlas website's html meta description is set to "My awesome app using docz"
> ---
>
> Key: ATLAS-3840
> URL: https://issues.apache.org/jira/browse/ATLAS-3840
> Project: Atlas
>  Issue Type: Bug
>Reporter: Umesh Padashetty
>Assignee: Umesh Padashetty
>Priority: Major
> Attachments: ATLAS-3840-1.patch, ATLAS-3840.patch, Screenshot 
> 2020-06-04 at 3.11.48 PM.png, Screenshot 2020-06-12 at 9.36.43 PM.png
>
>
> As seen at [view-source:https://atlas.apache.org/#/] meta tag is set to
> {code:java}
>  {code}
> !Screenshot 2020-06-12 at 9.36.43 PM.png|width=1390,height=122!
> When Atlas website link is posted in apps which support thumbnail view (like 
> Slack, WhatsApp etc), the thumbnail view shows "My awesome app using docz"
> !Screenshot 2020-06-04 at 3.11.48 PM.png|width=596,height=194!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3840) Atlas website's html meta description is set to "My awesome app using docz"

2020-07-01 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3840:
---
Fix Version/s: 3.0.0
   2.1.0

> Atlas website's html meta description is set to "My awesome app using docz"
> ---
>
> Key: ATLAS-3840
> URL: https://issues.apache.org/jira/browse/ATLAS-3840
> Project: Atlas
>  Issue Type: Bug
>Reporter: Umesh Padashetty
>Assignee: Umesh Padashetty
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3840-1.patch, ATLAS-3840.patch, Screenshot 
> 2020-06-04 at 3.11.48 PM.png, Screenshot 2020-06-12 at 9.36.43 PM.png
>
>
> As seen at [view-source:https://atlas.apache.org/#/] meta tag is set to
> {code:java}
>  {code}
> !Screenshot 2020-06-12 at 9.36.43 PM.png|width=1390,height=122!
> When Atlas website link is posted in apps which support thumbnail view (like 
> Slack, WhatsApp etc), the thumbnail view shows "My awesome app using docz"
> !Screenshot 2020-06-04 at 3.11.48 PM.png|width=596,height=194!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3840) Atlas website's html meta description is set to "My awesome app using docz"

2020-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149387#comment-17149387
 ] 

ASF subversion and git services commented on ATLAS-3840:


Commit 2401aeeae43e3a654e359020ceb020accb2e5436 in atlas's branch 
refs/heads/branch-2.0 from Umesh S Padashetty
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=2401aee ]

ATLAS-3840: Atlas website's html meta description is set to My awesome app 
using docz

Signed-off-by: kevalbhatt 


> Atlas website's html meta description is set to "My awesome app using docz"
> ---
>
> Key: ATLAS-3840
> URL: https://issues.apache.org/jira/browse/ATLAS-3840
> Project: Atlas
>  Issue Type: Bug
>Reporter: Umesh Padashetty
>Assignee: Umesh Padashetty
>Priority: Major
> Attachments: ATLAS-3840-1.patch, ATLAS-3840.patch, Screenshot 
> 2020-06-04 at 3.11.48 PM.png, Screenshot 2020-06-12 at 9.36.43 PM.png
>
>
> As seen at [view-source:https://atlas.apache.org/#/] meta tag is set to
> {code:java}
>  {code}
> !Screenshot 2020-06-12 at 9.36.43 PM.png|width=1390,height=122!
> When Atlas website link is posted in apps which support thumbnail view (like 
> Slack, WhatsApp etc), the thumbnail view shows "My awesome app using docz"
> !Screenshot 2020-06-04 at 3.11.48 PM.png|width=596,height=194!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3840) Atlas website's html meta description is set to "My awesome app using docz"

2020-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149386#comment-17149386
 ] 

ASF subversion and git services commented on ATLAS-3840:


Commit 3d559d0195c3a93890a0b4c303b5ee99f71dd4de in atlas's branch 
refs/heads/master from Umesh S Padashetty
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=3d559d0 ]

ATLAS-3840: Atlas website's html meta description is set to My awesome app 
using docz

Signed-off-by: kevalbhatt 


> Atlas website's html meta description is set to "My awesome app using docz"
> ---
>
> Key: ATLAS-3840
> URL: https://issues.apache.org/jira/browse/ATLAS-3840
> Project: Atlas
>  Issue Type: Bug
>Reporter: Umesh Padashetty
>Assignee: Umesh Padashetty
>Priority: Major
> Attachments: ATLAS-3840-1.patch, ATLAS-3840.patch, Screenshot 
> 2020-06-04 at 3.11.48 PM.png, Screenshot 2020-06-12 at 9.36.43 PM.png
>
>
> As seen at [view-source:https://atlas.apache.org/#/] meta tag is set to
> {code:java}
>  {code}
> !Screenshot 2020-06-12 at 9.36.43 PM.png|width=1390,height=122!
> When Atlas website link is posted in apps which support thumbnail view (like 
> Slack, WhatsApp etc), the thumbnail view shows "My awesome app using docz"
> !Screenshot 2020-06-04 at 3.11.48 PM.png|width=596,height=194!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3870) UI: hive_table entity table not updating queryparams based on filter selected

2020-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149356#comment-17149356
 ] 

ASF subversion and git services commented on ATLAS-3870:


Commit d1c7cc81de5c7adbeea38053222688333ee686d9 in atlas's branch 
refs/heads/branch-2.0 from kevalbhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=d1c7cc8 ]

ATLAS-3870:- UI: hive_table entity table not updating queryparams based on 
filter selected

(cherry picked from commit 0c3d2ed350507db12a8884bb209467185d4723a5)


> UI: hive_table entity table not updating queryparams based on filter selected
> -
>
> Key: ATLAS-3870
> URL: https://issues.apache.org/jira/browse/ATLAS-3870
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-webui
>Affects Versions: 2.0.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
>  Labels: ui
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3870.patch, Screenshot 2020-06-30 at 2.33.11 
> PM.png, Screenshot 2020-06-30 at 2.34.06 PM.png
>
>
> * Go to hive_db entity detail page
>  * Click on Table tab
>  * toggle "Show historical entities" checkbox and check the network for the 
> API
> API always send the same value for
> {code:java}
> excludeDeletedEntities: true
> {code}
> !Screenshot 2020-06-30 at 2.33.11 PM.png|width=374,height=219!
> !Screenshot 2020-06-30 at 2.34.06 PM.png|width=397,height=142!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3870) UI: hive_table entity table not updating queryparams based on filter selected

2020-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149354#comment-17149354
 ] 

ASF subversion and git services commented on ATLAS-3870:


Commit 0c3d2ed350507db12a8884bb209467185d4723a5 in atlas's branch 
refs/heads/master from kevalbhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=0c3d2ed ]

ATLAS-3870:- UI: hive_table entity table not updating queryparams based on 
filter selected


> UI: hive_table entity table not updating queryparams based on filter selected
> -
>
> Key: ATLAS-3870
> URL: https://issues.apache.org/jira/browse/ATLAS-3870
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-webui
>Affects Versions: 2.0.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
>  Labels: ui
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3870.patch, Screenshot 2020-06-30 at 2.33.11 
> PM.png, Screenshot 2020-06-30 at 2.34.06 PM.png
>
>
> * Go to hive_db entity detail page
>  * Click on Table tab
>  * toggle "Show historical entities" checkbox and check the network for the 
> API
> API always send the same value for
> {code:java}
> excludeDeletedEntities: true
> {code}
> !Screenshot 2020-06-30 at 2.33.11 PM.png|width=374,height=219!
> !Screenshot 2020-06-30 at 2.34.06 PM.png|width=397,height=142!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3870) UI: hive_table entity table not updating queryparams based on filter selected

2020-07-01 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149292#comment-17149292
 ] 

Nixon Rodrigues commented on ATLAS-3870:


+1 for the patch. Thanks [~kevalbhatt] for the patch.

> UI: hive_table entity table not updating queryparams based on filter selected
> -
>
> Key: ATLAS-3870
> URL: https://issues.apache.org/jira/browse/ATLAS-3870
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-webui
>Affects Versions: 2.0.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
>  Labels: ui
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3870.patch, Screenshot 2020-06-30 at 2.33.11 
> PM.png, Screenshot 2020-06-30 at 2.34.06 PM.png
>
>
> * Go to hive_db entity detail page
>  * Click on Table tab
>  * toggle "Show historical entities" checkbox and check the network for the 
> API
> API always send the same value for
> {code:java}
> excludeDeletedEntities: true
> {code}
> !Screenshot 2020-06-30 at 2.33.11 PM.png|width=374,height=219!
> !Screenshot 2020-06-30 at 2.34.06 PM.png|width=397,height=142!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3869) Upgrade httpclient from 4.5.3 to 4.5.4

2020-07-01 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3869:
---
Fix Version/s: 3.0.0

> Upgrade httpclient from 4.5.3 to 4.5.4
> --
>
> Key: ATLAS-3869
> URL: https://issues.apache.org/jira/browse/ATLAS-3869
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3869-Upgrade-httpclient-from-4.5.3-to-4.5.4.patch
>
>
> Found below exception where data was not getting added in SOLR from 
> janusgraph.
>  
> {noformat}
> Caused by: java.lang.ClassCastException: [B cannot be cast to java.lang.String
>   at 
> org.apache.http.conn.ssl.DefaultHostnameVerifier.getSubjectAltNames(DefaultHostnameVerifier.java:309)
>   at 
> org.apache.http.conn.ssl.DefaultHostnameVerifier.verify(DefaultHostnameVerifier.java:112)
>   at 
> org.apache.http.conn.ssl.DefaultHostnameVerifier.verify(DefaultHostnameVerifier.java:99)
>   at 
> org.apache.http.conn.ssl.SSLConnectionSocketFactory.verifyHostname(SSLConnectionSocketFactory.java:463)
>   at 
> org.apache.http.conn.ssl.SSLConnectionSocketFactory.createLayeredSocket(SSLConnectionSocketFactory.java:397)
>   at 
> org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:355)
>   at 
> org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:142)
>   at 
> org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:359)
>   at 
> org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:381)
>   at 
> org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:237)
>   at 
> org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)
>   at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
>   at 
> org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)
>   at 
> org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
>   at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
>   at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56)
>   at 
> org.apache.solr.client.solrj.impl.HttpSolrClient.executeMethod(HttpSolrClient.java:526)
>   at 
> org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:253)
>   at 
> org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:242)
>   at 
> org.apache.solr.client.solrj.impl.LBHttpSolrClient.doRequest(LBHttpSolrClient.java:483)
>   ... 7 more
> 2020-06-29 07:31:25,893 WARN  - [SIGTERM handler:] ~ Unable to close 
> transaction standardjanusgraphtx[0x18d7a16a] (StandardJanusGraph:230)
> java.lang.IllegalArgumentException: The transaction has already been closed
>   at 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
>   at 
> org.janusgraph.graphdb.transaction.StandardJanusGraphTx.rollback(StandardJanusGraphTx.java:1401)
>   at 
> org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsTransaction$1.doRollback(JanusGraphBlueprintsTransaction.java:190)
>   at 
> org.apache.tinkerpop.gremlin.structure.util.AbstractTransaction.rollback(AbstractTransaction.java:114)
>   at 
> org.apache.tinkerpop.gremlin.structure.Transaction$CLOSE_BEHAVIOR$2.accept(Transaction.java:182)
>   at 
> org.apache.tinkerpop.gremlin.structure.Transaction$CLOSE_BEHAVIOR$2.accept(Transaction.java:179)
>   at 
> org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsGraph$GraphTransaction.close(JanusGraphBlueprintsGraph.java:327)
>   at 
> org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsTransaction$1.doClose(JanusGraphBlueprintsTransaction.java:205)
>   at 
> org.apache.tinkerpop.gremlin.structure.util.AbstractTransaction.close(AbstractTransaction.java:139)
>   at 
> org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsTransaction.close(JanusGraphBlueprintsTransaction.java:215)
>   at 
> org.janusgraph.graphdb.database.StandardJanusGraph.closeInternal(StandardJanusGraph.java:226)
>   at 
> org.janusgraph.graphdb.database.StandardJanusGraph.access$500(StandardJanusGraph.java:91)
>   at 
> org.janusgraph.graphdb.database.StandardJanusGraph$ShutdownThread.start(StandardJanusGraph.java:818)
>   at 
> java.lang.ApplicationShutdownHooks.runHooks(ApplicationShutdownHooks.java:102)
>   at 
> java.lang.ApplicationShutdownHooks$1.run(ApplicationShutdownHooks.java:46)
>   at java.lang.Shutdown.runHooks(Shutdown.java:123)
>   at 

[jira] [Updated] (ATLAS-3867) Relationship search API should have a provision to fetch custom attributes in search results

2020-07-01 Thread Pinal (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal updated ATLAS-3867:
-
Fix Version/s: 3.0.0

> Relationship search API should have a provision to fetch custom attributes in 
> search results
> 
>
> Key: ATLAS-3867
> URL: https://issues.apache.org/jira/browse/ATLAS-3867
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core, atlas-intg
>Affects Versions: 2.0.0
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: Relationships
> Fix For: 3.0.0
>
>
> {code:java}
> /v2/search/relationship?guid=ac9e04cc-f927-4334-af08-c83bc3733f5b=__hive_table.columns=name=ASCENDING
> {code}
> The response of the  above API contains below attributes only:
> {code:java}
> "attributes": {
> "owner": "hive",
> "qualifiedName": "ho.us_customers.age@cm",
> "name": "age"
>   },{code}
>  Is it possible to fetch a custom attribute "*dcProfiledData*" present in 
> Technical properties of the entity detailed page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72615: ATLAS-3855 Bulk entity tag association and bulk api enhancement

2020-07-01 Thread chaitali


> On June 29, 2020, 6:49 a.m., Sarath Subramanian wrote:
> > Consider introducing an optional query param in REST to pass - 
> > 'ignoreUnauthorized'. If this flag is set, the resultset should include 
> > only results of authorized entities.

Done


- chaitali


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72615/#review221087
---


On July 1, 2020, 9:39 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72615/
> ---
> 
> (Updated July 1, 2020, 9:39 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3855
> https://issues.apache.org/jira/browse/ATLAS-3855
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> API : /api/atlas/v2/entity/bulk/classification & v2/entity/bulk : if some 
> guids belong to entities on which user is unauthorized other guids belong to 
> entities on which user is authorized This APIs fail with 403 error without 
> returning the authorized entities.
> 
> 1.Unauthorized guids are filtered with this patch for both the APIs.
> 2.Added ignoreUnauthorisedGuids flag for /bulk/classification API as it 
> doesn't return any object
> 2.Also added unauthorized guids in return object of /bulk in response for 
> user's reference.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  7b9455ef3 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  bf1629cb3 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
>  b9cbef1b0 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> 00b29e6c8 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 88de8b679 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 
> 615bc0f1b 
> 
> 
> Diff: https://reviews.apache.org/r/72615/diff/5/
> 
> 
> Testing
> ---
> 
> Tested with ranger policies:
> For /bulk api following policy were applied:
> 1.Added hive_column entity as entity type.
> 2.Included admin as user and prohibited access for read entity all this under 
> deny policy.
> 
> For /bulk/classification following policy were applied:
> 1.Added hive_column entity as entity type.
> 2.Gave all the access to admin but kwpt hive_column entity type in excluded 
> state.
> 
> 
> Thanks,
> 
> chaitali
> 
>



Re: Review Request 72615: ATLAS-3855 Bulk entity tag association and bulk api enhancement

2020-07-01 Thread chaitali

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72615/
---

(Updated July 1, 2020, 9:39 a.m.)


Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
---

Removed getter setter for unauthorised entities


Bugs: ATLAS-3855
https://issues.apache.org/jira/browse/ATLAS-3855


Repository: atlas


Description
---

API : /api/atlas/v2/entity/bulk/classification & v2/entity/bulk : if some guids 
belong to entities on which user is unauthorized other guids belong to entities 
on which user is authorized This APIs fail with 403 error without returning the 
authorized entities.

1.Unauthorized guids are filtered with this patch for both the APIs.
2.Added ignoreUnauthorisedGuids flag for /bulk/classification API as it doesn't 
return any object
2.Also added unauthorized guids in return object of /bulk in response for 
user's reference.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 7b9455ef3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 bf1629cb3 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 b9cbef1b0 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
00b29e6c8 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 88de8b679 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 
615bc0f1b 


Diff: https://reviews.apache.org/r/72615/diff/5/

Changes: https://reviews.apache.org/r/72615/diff/4-5/


Testing
---

Tested with ranger policies:
For /bulk api following policy were applied:
1.Added hive_column entity as entity type.
2.Included admin as user and prohibited access for read entity all this under 
deny policy.

For /bulk/classification following policy were applied:
1.Added hive_column entity as entity type.
2.Gave all the access to admin but kwpt hive_column entity type in excluded 
state.


Thanks,

chaitali



[jira] [Commented] (ATLAS-3871) Add unit tests to path extractor utility for s3, s3 v2, adls path entities

2020-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149238#comment-17149238
 ] 

ASF subversion and git services commented on ATLAS-3871:


Commit e72aa1076a5a1272935fed4dedaf9e29e41fa30b in atlas's branch 
refs/heads/master from Nikhil Bonte
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=e72aa10 ]

ATLAS-3871 Add unit tests to path extractor utility for s3, s3 v2, adls path 
entities

Signed-off-by: nixonrodrigues 


> Add unit tests to path extractor utility for s3, s3 v2, adls path entities
> --
>
> Key: ATLAS-3871
> URL: https://issues.apache.org/jira/browse/ATLAS-3871
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.0.0
>Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
>
> AtlasPathExtractorUtilTest added in ATLAS-3836 which covers unit tests for 
> ozone & hdfs path entites.
>  
> This Jira will improve AtlasPathExtractorUtilTest.java to cover s3, s3v2 & 
> adls path entities.
> Would add more tests for ozone as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3867) Relationship search API should have a provision to fetch custom attributes in search results

2020-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149237#comment-17149237
 ] 

ASF subversion and git services commented on ATLAS-3867:


Commit f932e52c687479c77b9967165353b0fffa6f2fa0 in atlas's branch 
refs/heads/master from Pinal Shah
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f932e52 ]

ATLAS-3867 : Relationship search API should have a provision to fetch custom 
attributes in search results

Signed-off-by: nixonrodrigues 


> Relationship search API should have a provision to fetch custom attributes in 
> search results
> 
>
> Key: ATLAS-3867
> URL: https://issues.apache.org/jira/browse/ATLAS-3867
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core, atlas-intg
>Affects Versions: 2.0.0
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: Relationships
>
> {code:java}
> /v2/search/relationship?guid=ac9e04cc-f927-4334-af08-c83bc3733f5b=__hive_table.columns=name=ASCENDING
> {code}
> The response of the  above API contains below attributes only:
> {code:java}
> "attributes": {
> "owner": "hive",
> "qualifiedName": "ho.us_customers.age@cm",
> "name": "age"
>   },{code}
>  Is it possible to fetch a custom attribute "*dcProfiledData*" present in 
> Technical properties of the entity detailed page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3869) Upgrade httpclient from 4.5.3 to 4.5.4

2020-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149239#comment-17149239
 ] 

ASF subversion and git services commented on ATLAS-3869:


Commit 337575c81b993e2cdcd6dc462dcf614940c783c2 in atlas's branch 
refs/heads/master from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=337575c ]

ATLAS-3869 Upgrade httpclient from 4.5.3 to 4.5.4

Signed-off-by: nixonrodrigues 


> Upgrade httpclient from 4.5.3 to 4.5.4
> --
>
> Key: ATLAS-3869
> URL: https://issues.apache.org/jira/browse/ATLAS-3869
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3869-Upgrade-httpclient-from-4.5.3-to-4.5.4.patch
>
>
> Found below exception where data was not getting added in SOLR from 
> janusgraph.
>  
> {noformat}
> Caused by: java.lang.ClassCastException: [B cannot be cast to java.lang.String
>   at 
> org.apache.http.conn.ssl.DefaultHostnameVerifier.getSubjectAltNames(DefaultHostnameVerifier.java:309)
>   at 
> org.apache.http.conn.ssl.DefaultHostnameVerifier.verify(DefaultHostnameVerifier.java:112)
>   at 
> org.apache.http.conn.ssl.DefaultHostnameVerifier.verify(DefaultHostnameVerifier.java:99)
>   at 
> org.apache.http.conn.ssl.SSLConnectionSocketFactory.verifyHostname(SSLConnectionSocketFactory.java:463)
>   at 
> org.apache.http.conn.ssl.SSLConnectionSocketFactory.createLayeredSocket(SSLConnectionSocketFactory.java:397)
>   at 
> org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:355)
>   at 
> org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:142)
>   at 
> org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:359)
>   at 
> org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:381)
>   at 
> org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:237)
>   at 
> org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)
>   at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
>   at 
> org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:111)
>   at 
> org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
>   at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
>   at 
> org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56)
>   at 
> org.apache.solr.client.solrj.impl.HttpSolrClient.executeMethod(HttpSolrClient.java:526)
>   at 
> org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:253)
>   at 
> org.apache.solr.client.solrj.impl.HttpSolrClient.request(HttpSolrClient.java:242)
>   at 
> org.apache.solr.client.solrj.impl.LBHttpSolrClient.doRequest(LBHttpSolrClient.java:483)
>   ... 7 more
> 2020-06-29 07:31:25,893 WARN  - [SIGTERM handler:] ~ Unable to close 
> transaction standardjanusgraphtx[0x18d7a16a] (StandardJanusGraph:230)
> java.lang.IllegalArgumentException: The transaction has already been closed
>   at 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
>   at 
> org.janusgraph.graphdb.transaction.StandardJanusGraphTx.rollback(StandardJanusGraphTx.java:1401)
>   at 
> org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsTransaction$1.doRollback(JanusGraphBlueprintsTransaction.java:190)
>   at 
> org.apache.tinkerpop.gremlin.structure.util.AbstractTransaction.rollback(AbstractTransaction.java:114)
>   at 
> org.apache.tinkerpop.gremlin.structure.Transaction$CLOSE_BEHAVIOR$2.accept(Transaction.java:182)
>   at 
> org.apache.tinkerpop.gremlin.structure.Transaction$CLOSE_BEHAVIOR$2.accept(Transaction.java:179)
>   at 
> org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsGraph$GraphTransaction.close(JanusGraphBlueprintsGraph.java:327)
>   at 
> org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsTransaction$1.doClose(JanusGraphBlueprintsTransaction.java:205)
>   at 
> org.apache.tinkerpop.gremlin.structure.util.AbstractTransaction.close(AbstractTransaction.java:139)
>   at 
> org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsTransaction.close(JanusGraphBlueprintsTransaction.java:215)
>   at 
> org.janusgraph.graphdb.database.StandardJanusGraph.closeInternal(StandardJanusGraph.java:226)
>   at 
> org.janusgraph.graphdb.database.StandardJanusGraph.access$500(StandardJanusGraph.java:91)
>   at 
> 

Re: Review Request 72631: ATLAS-3871 Add unit tests to path extractor utility for s3, s3 v2, adls path entities

2020-07-01 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72631/#review221107
---


Ship it!




Ship It!

- Nixon Rodrigues


On July 1, 2020, 4:29 a.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72631/
> ---
> 
> (Updated July 1, 2020, 4:29 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3871
> https://issues.apache.org/jira/browse/ATLAS-3871
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasPathExtractorUtilTest added in ATLAS-3836 which covers unit tests for 
> ozone & hdfs path entites.
>  
> This will improve AtlasPathExtractorUtilTest.java to cover s3, s3v2 & adls 
> path entities.
> 
> Would add more tests for ozone as well.
> 
> 
> Diffs
> -
> 
>   common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
> 664bfb72b 
> 
> 
> Diff: https://reviews.apache.org/r/72631/diff/2/
> 
> 
> Testing
> ---
> 
> PC build 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2001/console 
> (Finished: SUCCESS)
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>