Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72695/#review221401
---


Ship it!




Ship It!

- Madhan Neethiraj


On July 25, 2020, 8:53 p.m., Damian Warszawski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72695/
> ---
> 
> (Updated July 25, 2020, 8:53 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath 
> Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Optional configuration to support locks on JanusGraph to ensure data 
> consitency.
> 
> JanusGraph is eventually consistent by default which is efficient but results 
> in duplicates when race condition occurs.
> 
> 
> Reference to jira 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-3398
> 
> 
> Diffs
> -
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
>  6ef9cb76c 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca01 
> 
> 
> Diff: https://reviews.apache.org/r/72695/diff/3/
> 
> 
> Testing
> ---
> 
> Not possible to reproduce the error on local machine. Enable locking on our 
> dev env and have not introduce any regression.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>

Re: Review Request 72713: ATLAS-3892 : Basic search enhanced Feature - Search history

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72713/#review221398
---




intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java
Lines 475 (patched)


- Consider renaming operator BETWEEN as TIME_RANGE
- I suggest to not model the time periods (LAST_7_DAYS, LAST_30_DAYS, .., 
CUSTOM_RANGE) as operators. Instead, these should be valid values for  operator 
TIME_RANGE.


- Madhan Neethiraj


On July 28, 2020, 5:30 p.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72713/
> ---
> 
> (Updated July 28, 2020, 5:30 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3892
> https://issues.apache.org/jira/browse/ATLAS-3892
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> 1.This patch implements the search history feature where from UI we will 
> receive below filters.
> 2.In backend we have introduced a new operator "BETWEEN" where all the below 
> 7 operators will be converted to BETWEEN operator.
> 3.There will be a slight change in the JSON where previously we were passing 
> the Attribute value in Search parameters from the UI but for below filters   
> we will not pass any attributeValue except for "custom range" filter we 
> provide attribute value 
>   for eg ;"attributeValue":"159354180,159544260" .
> 
> New 7 filters :
> 
> 1.last 7 days.
> 2.Last month.
> 3.Last 30 days.
> 4.Today.
> 5.Yesterday.
> 6.Custom Range.
> 7.This Month.
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java a71787bc0 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
> fcc4494f2 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> c9a605355 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 5069d78c8 
>   
> repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
>  8e42d1700 
> 
> 
> Diff: https://reviews.apache.org/r/72713/diff/3/
> 
> 
> Testing
> ---
> 
> Tested with below json: 
> eg : 
> {
>   "excludeDeletedEntities": true,
>   "includeSubClassifications": true,
>   "includeSubTypes": true,
>   "includeClassificationAttributes": true,
>   "entityFilters": {
> "condition": "AND",
> "criterion": [
>   {
> "attributeName": "__timestamp",
> "operator": "THISMONTH",
> "attributeValue": ""
>   }
> ]
>   },
>   "tagFilters": null,
>   "attributes": [
> "__timestamp"
>   ],
>   "limit": 25,
>   "offset": 0,
>   "typeName": "Table",
>   "classification": null,
>   "termName": null
> }
> eg: Only For custom range filter we provide attribute value.
> {
>   "excludeDeletedEntities": true,
>   "includeSubClassifications": true,
>   "includeSubTypes": true,
>   "includeClassificationAttributes": true,
>   "entityFilters": {
> "condition": "AND",
> "criterion": [
>   {
> "attributeName": "createTime",
> "operator": "CUSTOM_RANGE",
> "attributeValue": "159354180,159544260"
>   }
> ]
>   },
>   "tagFilters": null,
>   "attributes": [
> "createTime"
>   ],
>   "limit": 25,
>   "offset": 0,
>   "typeName": "Table",
>   "classification": null,
>   "termName": null
> }
> 
> * Added Test cases to check new processDateRange method functionality
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 72713: ATLAS-3892 : Basic search enhanced Feature - Search history

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72713/
---

(Updated July 28, 2020, 5:25 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3892
https://issues.apache.org/jira/browse/ATLAS-3892


Repository: atlas


Description
---

1.This patch implements the search history feature where from UI we will 
receive below filters.
2.In backend we have introduced a new operator "BETWEEN" where all the below 7 
operators will be converted to BETWEEN operator.
3.There will be a slight change in the JSON where previously we were passing 
the Attribute value in Search parameters from the UI but for below filters   we 
will not pass any attributeValue except for "custom range" filter we provide 
attribute value 
  for eg ;"attributeValue":"159354180,159544260" .

New 7 filters :

1.last 7 days.
2.Last month.
3.Last 30 days.
4.Today.
5.Yesterday.
6.Custom Range.
7.This Month.


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java a71787bc0 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
fcc4494f2 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
c9a605355 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
5069d78c8 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 8e42d1700 


Diff: https://reviews.apache.org/r/72713/diff/2/

Changes: https://reviews.apache.org/r/72713/diff/1-2/


Testing
---

Tested with below json: 
eg : 
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "__timestamp",
"operator": "THISMONTH",
"attributeValue": ""
  }
]
  },
  "tagFilters": null,
  "attributes": [
"__timestamp"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "Table",
  "classification": null,
  "termName": null
}
eg: Only For custom range filter we provide attribute value.
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "createTime",
"operator": "CUSTOM_RANGE",
"attributeValue": "159354180,159544260"
  }
]
  },
  "tagFilters": null,
  "attributes": [
"createTime"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "Table",
  "classification": null,
  "termName": null
}

* Added Test cases to check new processDateRange method functionality


Thanks,

chaitali

Re: Review Request 72713: ATLAS-3892 : Basic search enhanced Feature - Search history

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72713/
---

(Updated July 28, 2020, 5:30 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3892
https://issues.apache.org/jira/browse/ATLAS-3892


Repository: atlas


Description
---

1.This patch implements the search history feature where from UI we will 
receive below filters.
2.In backend we have introduced a new operator "BETWEEN" where all the below 7 
operators will be converted to BETWEEN operator.
3.There will be a slight change in the JSON where previously we were passing 
the Attribute value in Search parameters from the UI but for below filters   we 
will not pass any attributeValue except for "custom range" filter we provide 
attribute value 
  for eg ;"attributeValue":"159354180,159544260" .

New 7 filters :

1.last 7 days.
2.Last month.
3.Last 30 days.
4.Today.
5.Yesterday.
6.Custom Range.
7.This Month.


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java a71787bc0 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
fcc4494f2 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
c9a605355 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
5069d78c8 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 8e42d1700 


Diff: https://reviews.apache.org/r/72713/diff/3/

Changes: https://reviews.apache.org/r/72713/diff/2-3/


Testing
---

Tested with below json: 
eg : 
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "__timestamp",
"operator": "THISMONTH",
"attributeValue": ""
  }
]
  },
  "tagFilters": null,
  "attributes": [
"__timestamp"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "Table",
  "classification": null,
  "termName": null
}
eg: Only For custom range filter we provide attribute value.
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "createTime",
"operator": "CUSTOM_RANGE",
"attributeValue": "159354180,159544260"
  }
]
  },
  "tagFilters": null,
  "attributes": [
"createTime"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "Table",
  "classification": null,
  "termName": null
}

* Added Test cases to check new processDateRange method functionality


Thanks,

chaitali

[jira] [Updated] (ATLAS-3898) Authorize read of Classifications def to user with create permission.

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Attachment: ATLAS-3898.2.patch

> Authorize read of Classifications def to user with create permission.
> -
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.2.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This jira propose to authorize read of classifications def to user with 
> create permission.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72713: ATLAS-3892 : Basic search enhanced Feature - Search history

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72713/
---

(Updated July 28, 2020, 1:58 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Added description


Bugs: ATLAS-3892
https://issues.apache.org/jira/browse/ATLAS-3892


Repository: atlas


Description (updated)
---

1.This patch implements the search history feature where from UI we will 
receive below filters.
2.In backend we have introduced a new operator "BETWEEN" where all the below 7 
operators will be converted to BETWEEN operator.
3.There will be a slight change in the JSON where previously we were passing 
the Attribute value in Search parameters from the UI but for below filters   we 
will not pass any attributeValue except for "custom range" filter we provide 
attribute value 
  for eg ;"attributeValue":"159354180,159544260" .

New 7 filters :

1.last 7 days.
2.Last month.
3.Last 30 days.
4.Today.
5.Yesterday.
6.Custom Range.
7.This Month.


Diffs
-

  common/src/main/java/org/apache/atlas/repository/Constants.java a71787bc0 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
fcc4494f2 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
c9a605355 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
5069d78c8 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 8e42d1700 


Diff: https://reviews.apache.org/r/72713/diff/1/


Testing
---

Tested with below json: 
eg : 
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "__timestamp",
"operator": "THISMONTH",
"attributeValue": ""
  }
]
  },
  "tagFilters": null,
  "attributes": [
"__timestamp"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "Table",
  "classification": null,
  "termName": null
}
eg: Only For custom range filter we provide attribute value.
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "createTime",
"operator": "CUSTOM_RANGE",
"attributeValue": "159354180,159544260"
  }
]
  },
  "tagFilters": null,
  "attributes": [
"createTime"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "Table",
  "classification": null,
  "termName": null
}

* Added Test cases to check new processDateRange method functionality


Thanks,

chaitali

Re: Review Request 72713: ATLAS-3892 : Basic search enhanced Feature - Search history

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72713/
---

(Updated July 28, 2020, 1:56 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3892
https://issues.apache.org/jira/browse/ATLAS-3892


Repository: atlas


Description (updated)
---

1.This patch implements the search history feature where from UI we will 
receive below filters.
2.In backend we have introduced a new operator "BETWEEN" where all the below 7 
operators will be converted to BETWEEN operator.
3.There will be a slight change in the JSON where previously we were passing 
the Attribute value in Search parameters from the UI but for below filters   we 
will not pass any attributeValue except for "custom range" filter we provide 
attribute value 
  for eg ;"attributeValue":"159354180,159544260".

New 7 filters :

1.last 7 days.
2.Last month.
3.Last 30 days.
4.Today.
5.Yesterday.
6.Custom Range.
7.This Month.


Diffs
-

  common/src/main/java/org/apache/atlas/repository/Constants.java a71787bc0 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
fcc4494f2 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
c9a605355 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
5069d78c8 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 8e42d1700 


Diff: https://reviews.apache.org/r/72713/diff/1/


Testing (updated)
---

Tested with below json: 
eg : 
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "__timestamp",
"operator": "THISMONTH",
"attributeValue": ""
  }
]
  },
  "tagFilters": null,
  "attributes": [
"__timestamp"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "Table",
  "classification": null,
  "termName": null
}
eg: Only For custom range filter we provide attribute value.
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "createTime",
"operator": "CUSTOM_RANGE",
"attributeValue": "159354180,159544260"
  }
]
  },
  "tagFilters": null,
  "attributes": [
"createTime"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "Table",
  "classification": null,
  "termName": null
}

* Added Test cases to check new processDateRange method functionality


Thanks,

chaitali

Review Request 72713: ATLAS-3892 : Basic search enhanced Feature - Search history

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72713/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3892
https://issues.apache.org/jira/browse/ATLAS-3892


Repository: atlas


Description
---

Date Range feature with 6 different filters :
1.last 7 days.
2.Last month.
3.Last 30 days.
4.Today.
5.Yesterday.
6.Custom Range.
7.This Month.


Diffs
-

  common/src/main/java/org/apache/atlas/repository/Constants.java a71787bc0 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
fcc4494f2 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
c9a605355 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
5069d78c8 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 8e42d1700 


Diff: https://reviews.apache.org/r/72713/diff/1/


Testing
---

Tested with below json 
eg : 
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "__timestamp",
"operator": "THISMONTH",
"attributeValue": ""
  }
]
  },
  "tagFilters": null,
  "attributes": [
"__timestamp"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "Table",
  "classification": null,
  "termName": null
}

* Added Test cases to check new processDateRange method functionality


Thanks,

chaitali

[jira] [Updated] (ATLAS-3898) Authorize read of Classifications def to user with create permission.

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Description: 
Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This jira propose to Currently in the Atlas-Ranger plugin for types resource 
READ permission is not available and read access is available by default to all 
types of any category.



  was:
Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This jira propose to Currently in the Atlas-Ranger plugin for types resource 
READ permission is not available and read access is available by default to all 
types of any category.



> Authorize read of Classifications def to user with create permission.
> -
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This jira propose to Currently in the Atlas-Ranger plugin for types resource 
> READ permission is not available and read access is available by default to 
> all types of any category.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of Classifications def to user with create permission.

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Description: 
Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This jira propose to authorize read of classifications def to user with create 
permission.



  was:
Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This jira propose to Currently in the Atlas-Ranger plugin for types resource 
READ permission is not available and read access is available by default to all 
types of any category.




> Authorize read of Classifications def to user with create permission.
> -
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This jira propose to authorize read of classifications def to user with 
> create permission.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of Classifications def to user with create permission.

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Description: 
Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This jira propose to Currently in the Atlas-Ranger plugin for types resource 
READ permission is not available and read access is available by default to all 
types of any category.


  was:
Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This jira propose to 


> Authorize read of Classifications def to user with create permission.
> -
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This jira propose to Currently in the Atlas-Ranger plugin for types resource 
> READ permission is not available and read access is available by default to 
> all types of any category.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of Classifications def to user with create permission.

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Description: 
Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This jira propose to 

  was:Add Authorization for classification read so that classifications created 
by one user should not be visible to other users.


> Authorize read of Classifications def to user with create permission.
> -
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This jira propose to 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3898) Authorize read of Classifications def to user with create permission.

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Summary: Authorize read of Classifications def to user with create 
permission.  (was: Authorization :- Classifications created by one user should 
not be visible to other users.)

> Authorize read of Classifications def to user with create permission.
> -
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>
> Add Authorization for classification read so that classifications created by 
> one user should not be visible to other users.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3904) Regression: Glossary term deatils page not able to render the classfication tab

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3904:
---
Description: 
Click on the term details page and check the console.

 

!Screen Shot 2020-07-28 at 5.09.08 PM.png|width=618,height=304!

> Regression: Glossary term deatils page not able to render the classfication 
> tab
> ---
>
> Key: ATLAS-3904
> URL: https://issues.apache.org/jira/browse/ATLAS-3904
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: Screen Shot 2020-07-28 at 5.09.08 PM.png
>
>
> Click on the term details page and check the console.
>  
> !Screen Shot 2020-07-28 at 5.09.08 PM.png|width=618,height=304!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3904) Regression: Glossary term deatils page not able to render the classfication tab

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3904:
---
Attachment: Screen Shot 2020-07-28 at 5.09.08 PM.png

> Regression: Glossary term deatils page not able to render the classfication 
> tab
> ---
>
> Key: ATLAS-3904
> URL: https://issues.apache.org/jira/browse/ATLAS-3904
> Project: Atlas
>  Issue Type: Sub-task
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: Screen Shot 2020-07-28 at 5.09.08 PM.png
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3904) Regression: Glossary term deatils page not able to render the classfication tab

[Keval Bhatt (Jira)]

Keval Bhatt created ATLAS-3904:
--

 Summary: Regression: Glossary term deatils page not able to render 
the classfication tab
 Key: ATLAS-3904
 URL: https://issues.apache.org/jira/browse/ATLAS-3904
 Project: Atlas
  Issue Type: Sub-task
Reporter: Keval Bhatt
Assignee: Keval Bhatt
 Fix For: 3.0.0, 2.2.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3903) New UI: Glossary category not reflected in the tree after creation.

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3903:
---
Description: 
Steps reproduce the issue:
 * Create the glossary
 * Click on "..." to create the category
 * After adding category details click on save

Due to regression newly created category is not rendered in the tree view. if a 
user clicks on the refresh button then it is visible.

Please check the attached video for a better understanding.

[^Category_does_not_reflect_in_dropdown.mkv]

  was:
Steps reproduce the issue:
 * Create the glossary
 * Click on "..." to create the category
 * After adding category details click on save

Due to regression newly created category is not rendered in the tree view. if 
the user clicks on refresh button then it is visible.

Please check the attached video for better understanding.


> New UI: Glossary category not reflected in the tree after creation.
> ---
>
> Key: ATLAS-3903
> URL: https://issues.apache.org/jira/browse/ATLAS-3903
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: Category_does_not_reflect_in_dropdown.mkv
>
>
> Steps reproduce the issue:
>  * Create the glossary
>  * Click on "..." to create the category
>  * After adding category details click on save
> Due to regression newly created category is not rendered in the tree view. if 
> a user clicks on the refresh button then it is visible.
> Please check the attached video for a better understanding.
> [^Category_does_not_reflect_in_dropdown.mkv]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3903) New UI: Glossary category not reflected in the tree after creation.

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3903:
---
Attachment: Category_does_not_reflect_in_dropdown.mkv

> New UI: Glossary category not reflected in the tree after creation.
> ---
>
> Key: ATLAS-3903
> URL: https://issues.apache.org/jira/browse/ATLAS-3903
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: Category_does_not_reflect_in_dropdown.mkv
>
>
> Steps reproduce the issue:
>  * Create the glossary
>  * Click on "..." to create the category
>  * After adding category details click on save
> Due to regression newly created category is not rendered in the tree view. if 
> the user clicks on refresh button then it is visible.
> Please check the attached video for better understanding.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3903) New UI: Glossary category not reflected in the tree after creation.

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3903:
---
Description: 
Steps reproduce the issue:
 * Create the glossary
 * Click on "..." to create the category
 * After adding category details click on save

Due to regression newly created category is not rendered in the tree view. if 
the user clicks on refresh button then it is visible.

Please check the attached video for better understanding.

  was:
Steps reproduce the issue:
 * Create the glossary
 * Click on "..." to create the 


> New UI: Glossary category not reflected in the tree after creation.
> ---
>
> Key: ATLAS-3903
> URL: https://issues.apache.org/jira/browse/ATLAS-3903
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0
>
>
> Steps reproduce the issue:
>  * Create the glossary
>  * Click on "..." to create the category
>  * After adding category details click on save
> Due to regression newly created category is not rendered in the tree view. if 
> the user clicks on refresh button then it is visible.
> Please check the attached video for better understanding.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3903) New UI: Glossary category not reflected in the tree after creation.

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3903:
---
Description: 
Steps reproduce the issue:
 * Create the glossary
 * Click on "..." to create the 

> New UI: Glossary category not reflected in the tree after creation.
> ---
>
> Key: ATLAS-3903
> URL: https://issues.apache.org/jira/browse/ATLAS-3903
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0
>
>
> Steps reproduce the issue:
>  * Create the glossary
>  * Click on "..." to create the 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3903) New UI: Glossary category not reflected in the tree after creation.

[Keval Bhatt (Jira)]

Keval Bhatt created ATLAS-3903:
--

 Summary: New UI: Glossary category not reflected in the tree after 
creation.
 Key: ATLAS-3903
 URL: https://issues.apache.org/jira/browse/ATLAS-3903
 Project: Atlas
  Issue Type: Bug
Reporter: Keval Bhatt
Assignee: Keval Bhatt
 Fix For: 3.0.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Asking for JIRA permissions

[Madhan Neethiraj]

Viktor,

Thanks for your interest in contributing to Apache Atlas. I added you as a 
contributor to Apache Atlas. You can now assign JIRAs to yourself, and add 
patches.

Review board (https://reviews.apache.org/) is preferred by most Atlas folks to 
review and provide feedback on the patches.

Regards,
Madhan




On 6/25/20, 2:56 AM, "Viktor Somogyi-Vass" 
 wrote:

Hi devs,

I created a JIRA [1] that I'd like to resolve (and have a PR already) but
I'd like to assign it to myself. Could you please grant me the
required permissions?
Also, do you accept PR's against the master branch or does it have to be
provided via JIRA in git patch format?

[1]
https://issues.apache.org/jira/browse/ATLAS-3864

Thanks,
Viktor

Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72644/#review221390
---




intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Lines 173 (patched)


Consider including parent type name in the message, like:
  Invalid attribute name: {0}.{1}. Attribute already exists in parent type 
{}"



intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java
Lines 509 (patched)


Instead of checkForExistingAttributeInParentTypeDefs() method to verify 
this, I suggest to perform the validation in following methods:
  - AtlasEntityType.resolveReferences()
  - AtlasClassificationType.resolveReferences()


- Madhan Neethiraj


On July 7, 2020, 9:30 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72644/
> ---
> 
> (Updated July 7, 2020, 9:30 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3872
> https://issues.apache.org/jira/browse/ATLAS-3872
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Cause of the problem:
> Type-def Column is created by quick-start script.
> 
> Here in this case, Type-def Column has the attribute "name". And it has 
> property isOptional = true
> 
> Type-def Column is a child of Type-def Asset which also has the attribute 
> "name". And it has property isOptional = false
> 
> Now while creating Entity of Type-def Column from UI, it does not show 
> attribute "name" in the mandatory fields because for Type-def Column its 
> property isOptional = true
> 
> But while validating the attributes from server side we iterate through all 
> the attributes of Entity type (Including Parent's attributes)
> In this case, while validating Type-def Asset's attribute "name" (which has 
> property isOptional = false) we get an error because its value is sent as 
> "null" from UI side.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4a79b6f 
>   repository/src/test/resources/sales-v1-full.zip 
> 07afbf6ecae312a840b54cae5ab01335c513d180 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
> 6800288 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java
>  7c820e7 
> 
> 
> Diff: https://reviews.apache.org/r/72644/diff/3/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>