Re: Review Request 72636: NotificationHookConsumer: Concurrent Message Processing
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72636/
---
(Updated Aug. 3, 2020, 11:18 p.m.)
Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and
Sarath Subramanian.
Changes
---
Updates include: New approach to solving the problem.
Bugs: ATLAS-3874
https://issues.apache.org/jira/browse/ATLAS-3874
Repository: atlas
Description (updated)
---
**Background**
Please see bug description.
**New Approach**
The new patch now uses the improvements made by ATLAS-3398.
Modified *NotificationHookConsumer*: Uses current retry logic. Handles
exceptions encountered during commit and displays messages that do not
overwhelm the log file.
Bug fix: *EntityDiscoveryContext*: The *resolvedIdsByUniqAttribs* did not
return the correct value if the map contained *AtlasRelationshipObjectId*. The
logic in the method *getResolvedEntityVertex* has been tweaked to handle the
*AtlasRelationshipObjectId* while maintaining backward compatibility. New
method *getAtlasVertexFromResolvedIdsByAttribs* was added to encapsulate the
existing processing of subTypes.
**Earlier Approach** (Obsolete)
At a high-level: Introduce a notion where the individual consumers are aware of
the entities being processed by each other. If there are no entities being
processed concurrently, everything proceeds as usual (the way it is before his
change). If same entity is being procesed by multiple consumers, then one
consumer waits for the other to finish before proceeding.
Classes:
New *UniqueKeysExtractor*: Extracts values of unique keys from
*AtlasEntitiesWithExtInfo*. It navigates *relationshipAttributes* and
*attributes* that has *objectRef* set.
New *UniquenessChecker*: Maintains a set of unique keys provided by
*UniqueKeysExtractor*. It detects the presence of duplicates and waits until
duplicates are resolved.
Modified *NoitficationHookConsumer.createOrUpdate*
- Updates *UniquenessChecker* with output from *UniqueKeysExtractor*. Clears
the keys at the end of entity creation.
- Handles JanusGraph's *PermanentLockingException*. See
[ATLAS-3801](https://issues.apache.org/jira/browse/ATLAS-3801).
Modified *NotificationHookConsumer*: Accepts an shared instance of
*UniqunessChecker*.
**Additional Logging**
Log entry is added when attempt is made to creates entities concurrently.
Diffs (updated)
-
repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscoveryContext.java
2221ac4f4
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
3f1ea05e1
Diff: https://reviews.apache.org/r/72636/diff/3/
Changes: https://reviews.apache.org/r/72636/diff/2-3/
Testing
---
**Unit tests**
Tests added to verify new clases.
*UniquessCheckerTest*
Performs worst case checking by adding 100s of keys that are duplicates and
verifies output of those.
**Functional tests**
Used Spark hook to verify. These sequence of commands will create shell entity
and first class entity. If resolution for first class entity is available, then
no shell entity is created.
Start Spark shell using:
```
sudo -u hdfs spark-shell
```
Spark sql commands:
```
spark.sql("create table default.t1_1381104676(col1 int)")
spark.sql("create table default.t2_1381104676(col2 int)")
spark.sql("select * from t1_1381104676, t2_1381104676 where
col1=col2").write.saveAsTable("t3_1381104676")
```
**Volume test**
Medium-size Kafka dump added.
*Setup* Add same kafka dump to multiple topics. This will result in contention
for almost every message.
**Pre-commit Build**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/2003/
Thanks,
Ashutosh Mestry
[jira] [Updated] (ATLAS-3874) NotificationHookConsumer: Shell Entity Resolution When Multiple Consumers Process Same Entity
[ https://issues.apache.org/jira/browse/ATLAS-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Mestry updated ATLAS-3874: --- Attachment: (was: ATLAS-3874-Notification-hook-processing-concurrent-e.patch) > NotificationHookConsumer: Shell Entity Resolution When Multiple Consumers > Process Same Entity > - > > Key: ATLAS-3874 > URL: https://issues.apache.org/jira/browse/ATLAS-3874 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.0.0, trunk >Reporter: Ashutosh Mestry >Assignee: Ashutosh Mestry >Priority: Major > Fix For: trunk > > > *Background* > Atlas has ability to consume messages from multiple hooks. When doing so, if > there are messages in multiple queue requesting creation of the same entity, > then this case leads to a race condition. > *Steps to Duplicate* > _Pre-requisites_ > Atlas should be configured to consume from 2 Kafka queues viz. _queue1_ and > _queue2_. > _Steps:_ > # Add a message in _queue1_ that references a non-existent entity. > # Add a message in _queue2_ that creates the entity in step 1. > _Expected behavior_: > Shell entity should get created in step 1 that is resolved into first class > entity in step 2. > _Actual behavior:_ > Shell entity is not resolved. A duplicate entity with same _qualifiedName_ > gets created. > *Root Cause* > The _NotificationHookConsumer_ is not aware of messages processed by other > consumers there by leading to concurrent entity creation. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3878) Notifications: Improve Memory Usage in Scale Enviroment
[ https://issues.apache.org/jira/browse/ATLAS-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170428#comment-17170428 ] ASF subversion and git services commented on ATLAS-3878: Commit 89f74e55be487148953ed5e74e354e6b87048ae2 in atlas's branch refs/heads/branch-2.0 from Ashutosh Mestry [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=89f74e5 ] ATLAS-3878: Notifications: Improve Memory Usage for HBase Audits Writing > Notifications: Improve Memory Usage in Scale Enviroment > --- > > Key: ATLAS-3878 > URL: https://issues.apache.org/jira/browse/ATLAS-3878 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 2.0.0, trunk >Reporter: Ashutosh Mestry >Assignee: Ashutosh Mestry >Priority: Major > Fix For: trunk > > Attachments: > ATLAS-3878-Notifications-Improve-Memory-Usage-in-Sca-v2.patch > > > *Background* > As part of entity creation, Atlas sends notifications of different types. > Current implementation, to listeners. Listeners in turn perform specific > tasks. > At a more concrete level, the _EntityAuditListenerV2_ will write audits and > the _NotificationEntityChangeListener_ will send Kafka notifications. > Each of the listeners create notification objects. The notification objects > are large in number and are short lived. > The transient nature of the notification objects causes memory pressure in > scale environment. > *Solution* > Create object pool for notification objects. This way objects can be > reused.and existing design can be kept in tact. This will also offer benefit > of using existing test setup for verification. > *Tests Used* > _Setup_ > Create a test rig that will spawn multiple works that will invoke Atlas' bulk > APIs for entity creation. > Node: 40 workers, 8 GB allocated memory and 40 cores. > _Observation_ > About 40 mins into the exercise, memory pressure builds up causing GC > collects to take longer. This causes ZK timeout and finally Atlas process > crashes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ATLAS-3878) Notifications: Improve Memory Usage in Scale Enviroment
[ https://issues.apache.org/jira/browse/ATLAS-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Mestry resolved ATLAS-3878. Resolution: Fixed > Notifications: Improve Memory Usage in Scale Enviroment > --- > > Key: ATLAS-3878 > URL: https://issues.apache.org/jira/browse/ATLAS-3878 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 2.0.0, trunk >Reporter: Ashutosh Mestry >Assignee: Ashutosh Mestry >Priority: Major > Fix For: trunk > > Attachments: > ATLAS-3878-Notifications-Improve-Memory-Usage-in-Sca-v2.patch > > > *Background* > As part of entity creation, Atlas sends notifications of different types. > Current implementation, to listeners. Listeners in turn perform specific > tasks. > At a more concrete level, the _EntityAuditListenerV2_ will write audits and > the _NotificationEntityChangeListener_ will send Kafka notifications. > Each of the listeners create notification objects. The notification objects > are large in number and are short lived. > The transient nature of the notification objects causes memory pressure in > scale environment. > *Solution* > Create object pool for notification objects. This way objects can be > reused.and existing design can be kept in tact. This will also offer benefit > of using existing test setup for verification. > *Tests Used* > _Setup_ > Create a test rig that will spawn multiple works that will invoke Atlas' bulk > APIs for entity creation. > Node: 40 workers, 8 GB allocated memory and 40 cores. > _Observation_ > About 40 mins into the exercise, memory pressure builds up causing GC > collects to take longer. This causes ZK timeout and finally Atlas process > crashes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3878) Notifications: Improve Memory Usage in Scale Enviroment
[ https://issues.apache.org/jira/browse/ATLAS-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170364#comment-17170364 ] ASF subversion and git services commented on ATLAS-3878: Commit 4a57f92f649e389b8f5ef653394a5f091f1a36de in atlas's branch refs/heads/master from Ashutosh Mestry [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=4a57f92 ] ATLAS-3878: Notifications: Improve Memory Usage for HBase Audits Writing > Notifications: Improve Memory Usage in Scale Enviroment > --- > > Key: ATLAS-3878 > URL: https://issues.apache.org/jira/browse/ATLAS-3878 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 2.0.0, trunk >Reporter: Ashutosh Mestry >Assignee: Ashutosh Mestry >Priority: Major > Fix For: trunk > > Attachments: > ATLAS-3878-Notifications-Improve-Memory-Usage-in-Sca-v2.patch > > > *Background* > As part of entity creation, Atlas sends notifications of different types. > Current implementation, to listeners. Listeners in turn perform specific > tasks. > At a more concrete level, the _EntityAuditListenerV2_ will write audits and > the _NotificationEntityChangeListener_ will send Kafka notifications. > Each of the listeners create notification objects. The notification objects > are large in number and are short lived. > The transient nature of the notification objects causes memory pressure in > scale environment. > *Solution* > Create object pool for notification objects. This way objects can be > reused.and existing design can be kept in tact. This will also offer benefit > of using existing test setup for verification. > *Tests Used* > _Setup_ > Create a test rig that will spawn multiple works that will invoke Atlas' bulk > APIs for entity creation. > Node: 40 workers, 8 GB allocated memory and 40 cores. > _Observation_ > About 40 mins into the exercise, memory pressure builds up causing GC > collects to take longer. This causes ZK timeout and finally Atlas process > crashes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72730/ --- (Updated Aug. 3, 2020, 6 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- - Added basic structure for Python client - This includes all classes for Entity and TypeDef - Added all endpoints for typedef Diffs (updated) - client/client-v2/src/main/python/atlas_discovery.py PRE-CREATION client/client-v2/src/main/python/atlas_entity.py PRE-CREATION client/client-v2/src/main/python/atlas_typedef.py PRE-CREATION client/client-v2/src/main/python/base_client.py PRE-CREATION client/client-v2/src/main/python/entity_client.py PRE-CREATION client/client-v2/src/main/python/glossary.py PRE-CREATION client/client-v2/src/main/python/typedef_client.py PRE-CREATION client/client-v2/src/main/python/utils.py PRE-CREATION Diff: https://reviews.apache.org/r/72730/diff/2/ Changes: https://reviews.apache.org/r/72730/diff/1-2/ Testing --- Tested on local. Thanks, Jyoti Singh
Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72730/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Sidharth Mishra. Bugs: ATLAS-3875 https://issues.apache.org/jira/browse/ATLAS-3875 Repository: atlas Description --- - Added basic structure for Python client - This includes all classes for Entity and TypeDef - Added all endpoints for typedef Diffs - client/client-v2/src/main/python/atlas_discovery.py PRE-CREATION client/client-v2/src/main/python/atlas_entity.py PRE-CREATION client/client-v2/src/main/python/atlas_typedef.py PRE-CREATION client/client-v2/src/main/python/base_client.py PRE-CREATION client/client-v2/src/main/python/entity_client.py PRE-CREATION client/client-v2/src/main/python/glossary.py PRE-CREATION client/client-v2/src/main/python/typedef_client.py PRE-CREATION client/client-v2/src/main/python/utils.py PRE-CREATION Diff: https://reviews.apache.org/r/72730/diff/1/ Testing --- Tested on local. Thanks, Jyoti Singh
Re: Asking for JIRA permissions
Hi Madhan, Thanks, I'll submit my patch through Reviewboard then. Viktor On Tue, Jul 28, 2020 at 9:00 AM Madhan Neethiraj wrote: > Viktor, > > Thanks for your interest in contributing to Apache Atlas. I added you as a > contributor to Apache Atlas. You can now assign JIRAs to yourself, and add > patches. > > Review board (https://reviews.apache.org/) is preferred by most Atlas > folks to review and provide feedback on the patches. > > Regards, > Madhan > > > > > On 6/25/20, 2:56 AM, "Viktor Somogyi-Vass" > > wrote: > > Hi devs, > > I created a JIRA [1] that I'd like to resolve (and have a PR already) > but > I'd like to assign it to myself. Could you please grant me the > required permissions? > Also, do you accept PR's against the master branch or does it have to > be > provided via JIRA in git patch format? > > [1] > https://issues.apache.org/jira/browse/ATLAS-3864 > > Thanks, > Viktor > > >
[jira] [Updated] (ATLAS-3864) Atlas should use AdminClient where possible
[ https://issues.apache.org/jira/browse/ATLAS-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated ATLAS-3864: --- Description: Zookeeper access should be restricted wherever possible as going forward Kafka won't use Zookeeper (see [KIP-500|https://cwiki.apache.org/confluence/display/KAFKA/KIP-500%3A+Replace+ZooKeeper+with+a+Self-Managed+Metadata+Quorum]). Also the Zookeeper classes in Kafka aren't public apis so usage should be avoided wherever possible. As a tactical fix (see ATLAS-3910) though it is possible to continue using KafkaZkClient as that class likely won't change much until the completion of KIP-500. was: Zookeeper access should be restricted wherever possible as going forward Kafka won't use Zookeeper (see [KIP-500|https://cwiki.apache.org/confluence/display/KAFKA/KIP-500%3A+Replace+ZooKeeper+with+a+Self-Managed+Metadata+Quorum]). Also the Zookeeper classes in Kafka aren't public apis so usage should be avoided wherever possible. As a tactical fix though it is possible to continue > Atlas should use AdminClient where possible > --- > > Key: ATLAS-3864 > URL: https://issues.apache.org/jira/browse/ATLAS-3864 > Project: Atlas > Issue Type: Improvement >Reporter: Viktor Somogyi-Vass >Priority: Major > > Zookeeper access should be restricted wherever possible as going forward > Kafka won't use Zookeeper (see > [KIP-500|https://cwiki.apache.org/confluence/display/KAFKA/KIP-500%3A+Replace+ZooKeeper+with+a+Self-Managed+Metadata+Quorum]). > Also the Zookeeper classes in Kafka aren't public apis so usage should be > avoided wherever possible. As a tactical fix (see ATLAS-3910) though it is > possible to continue using KafkaZkClient as that class likely won't change > much until the completion of KIP-500. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3864) Atlas should use AdminClient where possible
[ https://issues.apache.org/jira/browse/ATLAS-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated ATLAS-3864: --- Description: Zookeeper access should be restricted wherever possible as going forward Kafka won't use Zookeeper (see [KIP-500|https://cwiki.apache.org/confluence/display/KAFKA/KIP-500%3A+Replace+ZooKeeper+with+a+Self-Managed+Metadata+Quorum]). Also the Zookeeper classes in Kafka aren't public apis so usage should be avoided wherever possible. As a tactical fix though it is possible to continue was:Zookeeper access should be restricted wherever possible as going forward Kafka won't use Zookeeper (see KIP-500). > Atlas should use AdminClient where possible > --- > > Key: ATLAS-3864 > URL: https://issues.apache.org/jira/browse/ATLAS-3864 > Project: Atlas > Issue Type: Improvement >Reporter: Viktor Somogyi-Vass >Priority: Major > > Zookeeper access should be restricted wherever possible as going forward > Kafka won't use Zookeeper (see > [KIP-500|https://cwiki.apache.org/confluence/display/KAFKA/KIP-500%3A+Replace+ZooKeeper+with+a+Self-Managed+Metadata+Quorum]). > Also the Zookeeper classes in Kafka aren't public apis so usage should be > avoided wherever possible. As a tactical fix though it is possible to > continue -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3864) Atlas should use AdminClient where possible
[ https://issues.apache.org/jira/browse/ATLAS-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated ATLAS-3864: --- Description: Zookeeper access should be restricted wherever possible as going forward Kafka won't use Zookeeper (see KIP-500). (was: Kafka removed ZkUtils as it's an internal class and replaced it with KafkaZkClient. To be compatible with newer Kafka versions Atlas should use AdminClient and migrate from ZkUtils to KafkaZkClient.) > Atlas should use AdminClient where possible > --- > > Key: ATLAS-3864 > URL: https://issues.apache.org/jira/browse/ATLAS-3864 > Project: Atlas > Issue Type: Improvement >Reporter: Viktor Somogyi-Vass >Priority: Major > > Zookeeper access should be restricted wherever possible as going forward > Kafka won't use Zookeeper (see KIP-500). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3910) Use KafkaZkClient instead of ZkUtils
Viktor Somogyi-Vass created ATLAS-3910: -- Summary: Use KafkaZkClient instead of ZkUtils Key: ATLAS-3910 URL: https://issues.apache.org/jira/browse/ATLAS-3910 Project: Atlas Issue Type: Improvement Reporter: Viktor Somogyi-Vass Assignee: Viktor Somogyi-Vass Kafka removed ZkUtils from 2.5 as it's an internal class and replaced it with KafkaZkClient. To be compatible with newer Kafka versions Atlas shouldn't use ZkUtils. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3864) Atlas should use AdminClient where possible
[ https://issues.apache.org/jira/browse/ATLAS-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated ATLAS-3864: --- Summary: Atlas should use AdminClient where possible (was: Atlas should use AdminClient where possible and remove ZkUtils) > Atlas should use AdminClient where possible > --- > > Key: ATLAS-3864 > URL: https://issues.apache.org/jira/browse/ATLAS-3864 > Project: Atlas > Issue Type: Improvement >Reporter: Viktor Somogyi-Vass >Priority: Major > > Kafka removed ZkUtils as it's an internal class and replaced it with > KafkaZkClient. To be compatible with newer Kafka versions Atlas should use > AdminClient and migrate from ZkUtils to KafkaZkClient. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [atlas] Aka-shi removed a comment on pull request #101: add-dist-cassandra-elasticsearch-profile and support GS
Aka-shi removed a comment on pull request #101: URL: https://github.com/apache/atlas/pull/101#issuecomment-668012977 @mohamed-a-abdelaziz I've tried those earlier and again clean installed everything(cassandra, es) to follow your steps. But still I get `503-problem accessing /.` because of service unavailable. I don't see anything in logs too apart from Apache atlas server started. Can you help me here please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [atlas] Aka-shi commented on pull request #101: add-dist-cassandra-elasticsearch-profile and support GS
Aka-shi commented on pull request #101: URL: https://github.com/apache/atlas/pull/101#issuecomment-668012977 @mohamed-a-abdelaziz I've tried those earlier and again clean installed everything(cassandra, es) to follow your steps. But still I get `503-problem accessing /.` because of service unavailable. I don't see anything in logs too apart from Apache atlas server started. Can you help me here please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169971#comment-17169971 ] ASF subversion and git services commented on ATLAS-3909: Commit c1513bacc9027e1e44d2ad61a04c6272b21d2e1b in atlas's branch refs/heads/branch-2.0 from Keval Bhatt [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=c1513ba ] ATLAS-3909: UI: Improve readability for the table view in the entity detail page (cherry picked from commit ba1b40f0426e5ff0e621eab5184d916a6f506f59) > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3909.patch, image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > !image-2020-08-03-12-48-10-984.png|width=508,height=311! > *Expected:* > !image-2020-08-03-12-48-28-192.png|width=541,height=341! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169970#comment-17169970 ] ASF subversion and git services commented on ATLAS-3909: Commit ba1b40f0426e5ff0e621eab5184d916a6f506f59 in atlas's branch refs/heads/master from Keval Bhatt [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ba1b40f ] ATLAS-3909: UI: Improve readability for the table view in the entity detail page > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3909.patch, image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > !image-2020-08-03-12-48-10-984.png|width=508,height=311! > *Expected:* > !image-2020-08-03-12-48-28-192.png|width=541,height=341! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169969#comment-17169969 ] Nikhil Bonte commented on ATLAS-3909: - +1 for the patch, thanks [~kevalbhatt]. > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3909.patch, image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > !image-2020-08-03-12-48-10-984.png|width=508,height=311! > *Expected:* > !image-2020-08-03-12-48-28-192.png|width=541,height=341! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3864) Atlas should use AdminClient where possible and remove ZkUtils
[ https://issues.apache.org/jira/browse/ATLAS-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated ATLAS-3864: --- Summary: Atlas should use AdminClient where possible and remove ZkUtils (was: KafkaBridge should use AdminClient) > Atlas should use AdminClient where possible and remove ZkUtils > -- > > Key: ATLAS-3864 > URL: https://issues.apache.org/jira/browse/ATLAS-3864 > Project: Atlas > Issue Type: Improvement >Reporter: Viktor Somogyi-Vass >Priority: Major > > Kafka removed ZkUtils as it's an internal class and replaced it with > KafkaZkClient. To be compatible with newer Kafka versions Atlas should use > AdminClient and migrate from ZkUtils to KafkaZkClient. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3909: --- Attachment: ATLAS-3909.patch > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3909.patch, image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > !image-2020-08-03-12-48-10-984.png|width=508,height=311! > *Expected:* > !image-2020-08-03-12-48-28-192.png|width=541,height=341! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Bonte updated ATLAS-3909: Comment: was deleted (was: +1 for the patch, thanks [~kevalbhatt] .) > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > !image-2020-08-03-12-48-10-984.png|width=508,height=311! > *Expected:* > !image-2020-08-03-12-48-28-192.png|width=541,height=341! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3909: --- Attachment: (was: ATLAS-3909.patch) > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > !image-2020-08-03-12-48-10-984.png|width=508,height=311! > *Expected:* > !image-2020-08-03-12-48-28-192.png|width=541,height=341! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169961#comment-17169961 ] Nikhil Bonte commented on ATLAS-3909: - +1 for the patch, thanks [~kevalbhatt] . > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3909.patch, image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > !image-2020-08-03-12-48-10-984.png|width=508,height=311! > *Expected:* > !image-2020-08-03-12-48-28-192.png|width=541,height=341! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3909: --- Attachment: (was: ATLAS-3909.patch) > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3909.patch, image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > !image-2020-08-03-12-48-10-984.png|width=508,height=311! > *Expected:* > !image-2020-08-03-12-48-28-192.png|width=541,height=341! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3909: --- Attachment: ATLAS-3909.patch > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3909.patch, image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > !image-2020-08-03-12-48-10-984.png|width=508,height=311! > *Expected:* > !image-2020-08-03-12-48-28-192.png|width=541,height=341! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3909: --- Attachment: ATLAS-3909.patch > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3909.patch, image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > !image-2020-08-03-12-48-10-984.png|width=508,height=311! > *Expected:* > !image-2020-08-03-12-48-28-192.png|width=541,height=341! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3904) Regression: Glossary term deatils page not able to render the classfication tab
[ https://issues.apache.org/jira/browse/ATLAS-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169924#comment-17169924 ] ASF subversion and git services commented on ATLAS-3904: Commit 65f1a2bc82779d1371f1cdffb8399893a36c9e7d in atlas's branch refs/heads/branch-2.0 from Keval Bhatt [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=65f1a2b ] ATLAS-3904: Regression: Glossary term deatils page not able to render the classfication tab #2 (cherry picked from commit ce2ba123a2b9ce43503d5e101400b93fa5b6267e) > Regression: Glossary term deatils page not able to render the classfication > tab > --- > > Key: ATLAS-3904 > URL: https://issues.apache.org/jira/browse/ATLAS-3904 > Project: Atlas > Issue Type: Sub-task >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3904-1.patch, ATLAS-3904.patch, Screen Shot > 2020-07-28 at 5.09.08 PM.png > > > Click on the term details page and check the console. > > !Screen Shot 2020-07-28 at 5.09.08 PM.png|width=618,height=304! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3904) Regression: Glossary term deatils page not able to render the classfication tab
[ https://issues.apache.org/jira/browse/ATLAS-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169915#comment-17169915 ] ASF subversion and git services commented on ATLAS-3904: Commit ce2ba123a2b9ce43503d5e101400b93fa5b6267e in atlas's branch refs/heads/master from Keval Bhatt [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ce2ba12 ] ATLAS-3904: Regression: Glossary term deatils page not able to render the classfication tab #2 > Regression: Glossary term deatils page not able to render the classfication > tab > --- > > Key: ATLAS-3904 > URL: https://issues.apache.org/jira/browse/ATLAS-3904 > Project: Atlas > Issue Type: Sub-task >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3904-1.patch, ATLAS-3904.patch, Screen Shot > 2020-07-28 at 5.09.08 PM.png > > > Click on the term details page and check the console. > > !Screen Shot 2020-07-28 at 5.09.08 PM.png|width=618,height=304! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3904) Regression: Glossary term deatils page not able to render the classfication tab
[ https://issues.apache.org/jira/browse/ATLAS-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3904: --- Attachment: ATLAS-3904-1.patch > Regression: Glossary term deatils page not able to render the classfication > tab > --- > > Key: ATLAS-3904 > URL: https://issues.apache.org/jira/browse/ATLAS-3904 > Project: Atlas > Issue Type: Sub-task >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: ATLAS-3904-1.patch, ATLAS-3904.patch, Screen Shot > 2020-07-28 at 5.09.08 PM.png > > > Click on the term details page and check the console. > > !Screen Shot 2020-07-28 at 5.09.08 PM.png|width=618,height=304! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3909: --- Description: Change the key style to bold for table view in the entity details page. !image-2020-08-03-12-48-10-984.png|width=508,height=311! *Expected:* !image-2020-08-03-12-48-28-192.png|width=541,height=341! was: Change the key style to bold for table view in the entity details page. > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > !image-2020-08-03-12-48-10-984.png|width=508,height=311! > *Expected:* > !image-2020-08-03-12-48-28-192.png|width=541,height=341! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3909: --- Attachment: image-2020-08-03-12-48-28-192.png > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
[ https://issues.apache.org/jira/browse/ATLAS-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3909: --- Attachment: image-2020-08-03-12-48-10-984.png > UI: Improve readability for the table view in the entity detail page > - > > Key: ATLAS-3909 > URL: https://issues.apache.org/jira/browse/ATLAS-3909 > Project: Atlas > Issue Type: Improvement >Reporter: Keval Bhatt >Assignee: Keval Bhatt >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: image-2020-08-03-12-48-10-984.png, > image-2020-08-03-12-48-28-192.png > > > Change the key style to bold for table view in the entity details page. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3909) UI: Improve readability for the table view in the entity detail page
Keval Bhatt created ATLAS-3909: -- Summary: UI: Improve readability for the table view in the entity detail page Key: ATLAS-3909 URL: https://issues.apache.org/jira/browse/ATLAS-3909 Project: Atlas Issue Type: Improvement Reporter: Keval Bhatt Assignee: Keval Bhatt Fix For: 3.0.0, 2.2.0 Change the key style to bold for table view in the entity details page. -- This message was sent by Atlassian Jira (v8.3.4#803005)
