[jira] [Commented] (ATLAS-3876) Relationship Search API not showing correct approximateCount

2020-08-04 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171295#comment-17171295
 ] 

ASF subversion and git services commented on ATLAS-3876:


Commit aa441de4f62947b96f6ff387f4d140a2b83c99dc in atlas's branch 
refs/heads/master from Pinal Shah
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=aa441de ]

ATLAS-3876 : Relationship Search API not showing correct approximateCount

Signed-off-by: nixonrodrigues 


> Relationship Search API not showing correct approximateCount
> 
>
> Key: ATLAS-3876
> URL: https://issues.apache.org/jira/browse/ATLAS-3876
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.0.0
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: Relationships
>
> Relationship Search API for hive columns showing *approximateCount* as -1 in 
> response.
>  E.g.
> {code:java}
> v2/search/relationship?limit=10&offset=0&guid=3e424245-0676-4d47-96a1-e17228b38367&relation=__hive_table.columns&sortBy=name&sortOrder=ASCENDING&excludeDeletedEntities=true{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-04 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72646/#review221472
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 5, 2020, 4:27 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72646/
> ---
> 
> (Updated Aug. 5, 2020, 4:27 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3876
> https://issues.apache.org/jira/browse/ATLAS-3876
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Issue:**
> Relationship api doesn't provide approximate count of the related entities in 
> the response.
> 
> **Workaround:**
> Get the total count of related given entity , irrespective of the 
> offset/limit.
> Added 'getApproximateCount' as queryParam in Rest api.
> 
> 
> Also this patch includes **improvement in the time taken to fetch related 
> entities**  .
> Average time taken for the Api to search relationship entities having **5000 
> end vertices** with limit **500**:
> Before: 9seconds
> After applying this patch : 3seconds
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee4589f 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  86572598a 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4b9564295 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 044179d44 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  863a00350 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 5069d78c8 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4 
> 
> 
> Diff: https://reviews.apache.org/r/72646/diff/6/
> 
> 
> Testing
> ---
> 
> Manually tested
> Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2084
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-04 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72646/#review221471
---


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 5, 2020, 4:27 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72646/
> ---
> 
> (Updated Aug. 5, 2020, 4:27 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3876
> https://issues.apache.org/jira/browse/ATLAS-3876
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Issue:**
> Relationship api doesn't provide approximate count of the related entities in 
> the response.
> 
> **Workaround:**
> Get the total count of related given entity , irrespective of the 
> offset/limit.
> Added 'getApproximateCount' as queryParam in Rest api.
> 
> 
> Also this patch includes **improvement in the time taken to fetch related 
> entities**  .
> Average time taken for the Api to search relationship entities having **5000 
> end vertices** with limit **500**:
> Before: 9seconds
> After applying this patch : 3seconds
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee4589f 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  86572598a 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4b9564295 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 044179d44 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  863a00350 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 5069d78c8 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4 
> 
> 
> Diff: https://reviews.apache.org/r/72646/diff/6/
> 
> 
> Testing
> ---
> 
> Manually tested
> Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2084
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-04 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72646/
---

(Updated Aug. 5, 2020, 4:27 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3876
https://issues.apache.org/jira/browse/ATLAS-3876


Repository: atlas


Description
---

**Issue:**
Relationship api doesn't provide approximate count of the related entities in 
the response.

**Workaround:**
Get the total count of related given entity , irrespective of the offset/limit.
Added 'getApproximateCount' as queryParam in Rest api.


Also this patch includes **improvement in the time taken to fetch related 
entities**  .
Average time taken for the Api to search relationship entities having **5000 
end vertices** with limit **500**:
Before: 9seconds
After applying this patch : 3seconds


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee4589f 
  
repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 
86572598a 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
4b9564295 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
044179d44 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 863a00350 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
5069d78c8 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4 


Diff: https://reviews.apache.org/r/72646/diff/6/

Changes: https://reviews.apache.org/r/72646/diff/5-6/


Testing (updated)
---

Manually tested
Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2084


Thanks,

Pinal Shah

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-04 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72646/#review221470
---


Fix it, then Ship it!





intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Line 19 (original), 19 (patched)


Only import related changes are in AtlasEntityType.java. Please review and 
revert.


- Madhan Neethiraj


On Aug. 4, 2020, 11:01 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72646/
> ---
> 
> (Updated Aug. 4, 2020, 11:01 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3876
> https://issues.apache.org/jira/browse/ATLAS-3876
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Issue:**
> Relationship api doesn't provide approximate count of the related entities in 
> the response.
> 
> **Workaround:**
> Get the total count of related given entity , irrespective of the 
> offset/limit.
> Added 'getApproximateCount' as queryParam in Rest api.
> 
> 
> Also this patch includes **improvement in the time taken to fetch related 
> entities**  .
> Average time taken for the Api to search relationship entities having **5000 
> end vertices** with limit **500**:
> Before: 9seconds
> After applying this patch : 3seconds
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc47 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee4589f 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  86572598a 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4b9564295 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 044179d44 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  863a00350 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 5069d78c8 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4 
> 
> 
> Diff: https://reviews.apache.org/r/72646/diff/5/
> 
> 
> Testing
> ---
> 
> Manually tested
> Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2011 
> (Failed in Impala build)
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-08-04 Thread Jyoti Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72698/
---

(Updated Aug. 4, 2020, 4:27 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
---

Using this project users can get an idea as how to integrate with Atlas using 
AtlasCleint. This helps the user to understand the basic rest functionality of 
Atlas such as

- EntityRest
- TypeDefRest
- DiscoveryRest
- LineageRest
- GlossaryRest


Diffs (updated)
-

  atlas-examples/pom.xml PRE-CREATION 
  atlas-examples/sample-app/README.md PRE-CREATION 
  atlas-examples/sample-app/pom.xml PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java
 PRE-CREATION 
  atlas-examples/sample-app/src/main/resources/atlas-application.properties 
PRE-CREATION 
  pom.xml 5e0442ae5 


Diff: https://reviews.apache.org/r/72698/diff/7/

Changes: https://reviews.apache.org/r/72698/diff/6-7/


Testing
---


Thanks,

Jyoti Singh

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-08-04 Thread Jyoti Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72698/
---

(Updated Aug. 4, 2020, 4:05 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
---

Using this project users can get an idea as how to integrate with Atlas using 
AtlasCleint. This helps the user to understand the basic rest functionality of 
Atlas such as

- EntityRest
- TypeDefRest
- DiscoveryRest
- LineageRest
- GlossaryRest


Diffs (updated)
-

  atlas-examples/pom.xml PRE-CREATION 
  atlas-examples/sample-app/README.md PRE-CREATION 
  atlas-examples/sample-app/pom.xml PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java
 PRE-CREATION 
  atlas-examples/sample-app/src/main/resources/atlas-application.properties 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72698/diff/6/

Changes: https://reviews.apache.org/r/72698/diff/5-6/


Testing
---


Thanks,

Jyoti Singh

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-04 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72646/
---

(Updated Aug. 4, 2020, 11:01 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

added support for Edge attribute predicate


Bugs: ATLAS-3876
https://issues.apache.org/jira/browse/ATLAS-3876


Repository: atlas


Description
---

**Issue:**
Relationship api doesn't provide approximate count of the related entities in 
the response.

**Workaround:**
Get the total count of related given entity , irrespective of the offset/limit.
Added 'getApproximateCount' as queryParam in Rest api.


Also this patch includes **improvement in the time taken to fetch related 
entities**  .
Average time taken for the Api to search relationship entities having **5000 
end vertices** with limit **500**:
Before: 9seconds
After applying this patch : 3seconds


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc47 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee4589f 
  
repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 
86572598a 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
4b9564295 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
044179d44 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 863a00350 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
5069d78c8 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4 


Diff: https://reviews.apache.org/r/72646/diff/5/

Changes: https://reviews.apache.org/r/72646/diff/4-5/


Testing
---

Manually tested
Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2011 
(Failed in Impala build)


Thanks,

Pinal Shah

Review Request 72729: ATLAS-3910: Use KafkaZkClient instead of ZkUtils

2020-08-04 Thread Viktor Somogyi-Vass 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72729/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS-3910: Use KafkaZkClient instead of ZkUtils


Diffs
-

  
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
 40b1fee71e57175cd7ddf8a3696ef147282295c2 
  
addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java
 c8cc85cda1f62b2d1a0a49c61abf06d9beb6fdb7 
  notification/src/main/java/org/apache/atlas/hook/AtlasTopicCreator.java 
c69574103e360fcfb7dfb525bb06043a1fd647c3 
  notification/src/test/java/org/apache/atlas/hook/AtlasTopicCreatorTest.java 
293784770502299875177bd4a4a9c4b32c6b5a9a 


Diff: https://reviews.apache.org/r/72729/diff/1/


Testing
---


Thanks,

Viktor Somogyi-Vass

[GitHub] [atlas] Aka-shi commented on pull request #101: add-dist-cassandra-elasticsearch-profile and support GS

2020-08-04 Thread GitBox 


Aka-shi commented on pull request #101:
URL: https://github.com/apache/atlas/pull/101#issuecomment-668440631


   @mohamed-a-abdelaziz thanks. This worked for me. I checked out onto your 
branch and was able to build this. Any idea when this PR will be merged to 
master?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org