Re: Review Request 72994: ATLAS-4010: Sort properties lexicographically in pom.xml for readability

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/#review222148
---




distro/pom.xml
Line 51 (original), 39 (patched)


The value of property graph.index.properties is written to configuration 
file, refer to distro/src/conf/atlas-application.properties. Hence leading 
spaces should be avoided.


- Madhan Neethiraj


On Oct. 30, 2020, 1:44 a.m., Radhika Kundam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72994/
> ---
> 
> (Updated Oct. 30, 2020, 1:44 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-4010
> https://issues.apache.org/jira/browse/ATLAS-4010
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Properties are in random order under  section in pom.xml
> 
> For better readability, need to sort properties in lexicographic order.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml db1f23acd 
>   docs/pom.xml f22f9e2ff 
>   pom.xml aca36aaee 
>   webapp/pom.xml 5a8cfe616 
> 
> 
> Diff: https://reviews.apache.org/r/72994/diff/1/
> 
> 
> Testing
> ---
> 
> Build is successful.
> 
> 
> Thanks,
> 
> Radhika Kundam
> 
>

[jira] [Updated] (ATLAS-4008) Cache getGuid and getStatus in GraphTransactionInterceptor

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4008:

Description: 
*Problem Statement:*

GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
multiple times in a same request.

 

*Approach:*

Implement a caching mechanism in GraphTransactionInterceptor to cache the 
following mappings:

*vertexID -> guid*

*vertexID -> entityStatus*

*edgeId -> status*

  was:
*Problem Statement:*

GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
multiple times in a same request.

 

*Approach:*

Implement a caching mechanism in GraphTransactionInterceptor to cache the 
following mappings:

*vertexID -> guid*

*vertexID -> entityStatus*


> Cache getGuid and getStatus in GraphTransactionInterceptor
> --
>
> Key: ATLAS-4008
> URL: https://issues.apache.org/jira/browse/ATLAS-4008
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
>
> *Problem Statement:*
> GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
> multiple times in a same request.
>  
> *Approach:*
> Implement a caching mechanism in GraphTransactionInterceptor to cache the 
> following mappings:
> *vertexID -> guid*
> *vertexID -> entityStatus*
> *edgeId -> status*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4008) Cache getGuid and getStatus in GraphTransactionInterceptor

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223596#comment-17223596
 ] 

ASF subversion and git services commented on ATLAS-4008:


Commit 7c68048fcc314d83100c7a5fc0a5b8294f62e2cd in atlas's branch 
refs/heads/master from Nikhil Bonte
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=7c68048 ]

ATLAS-4008: Cache getGuid and getStatus in GraphTransactionInterceptor

Signed-off-by: Nikhil Bonte 


> Cache getGuid and getStatus in GraphTransactionInterceptor
> --
>
> Key: ATLAS-4008
> URL: https://issues.apache.org/jira/browse/ATLAS-4008
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
>
> *Problem Statement:*
> GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
> multiple times in a same request.
>  
> *Approach:*
> Implement a caching mechanism in GraphTransactionInterceptor to cache the 
> following mappings:
> *vertexID -> guid*
> *vertexID -> entityStatus*
> *edgeId -> status*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4008) Cache getGuid and getStatus in GraphTransactionInterceptor

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4008:

Attachment: ATLAS-4008-Cache-getGuid-and-getStatus-in-GraphTrans-v1.patch

> Cache getGuid and getStatus in GraphTransactionInterceptor
> --
>
> Key: ATLAS-4008
> URL: https://issues.apache.org/jira/browse/ATLAS-4008
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
> Attachments: 
> ATLAS-4008-Cache-getGuid-and-getStatus-in-GraphTrans-v1.patch
>
>
> *Problem Statement:*
> GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
> multiple times in a same request.
>  
> *Approach:*
> Implement a caching mechanism in GraphTransactionInterceptor to cache the 
> following mappings:
> *vertexID -> guid*
> *vertexID -> entityStatus*
> *edgeId -> status*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (ATLAS-4008) Cache getGuid and getStatus in GraphTransactionInterceptor

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte resolved ATLAS-4008.
-
Fix Version/s: 2.2.0
   3.0.0
   Resolution: Done

> Cache getGuid and getStatus in GraphTransactionInterceptor
> --
>
> Key: ATLAS-4008
> URL: https://issues.apache.org/jira/browse/ATLAS-4008
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> ATLAS-4008-Cache-getGuid-and-getStatus-in-GraphTrans-v1.patch
>
>
> *Problem Statement:*
> GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
> multiple times in a same request.
>  
> *Approach:*
> Implement a caching mechanism in GraphTransactionInterceptor to cache the 
> following mappings:
> *vertexID -> guid*
> *vertexID -> entityStatus*
> *edgeId -> status*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4008) Cache getGuid and getStatus in GraphTransactionInterceptor

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223599#comment-17223599
 ] 

ASF subversion and git services commented on ATLAS-4008:


Commit 538ed8ef7689fcdc3ee294f09dfff73211c6cd3a in atlas's branch 
refs/heads/branch-2.0 from Nikhil Bonte
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=538ed8e ]

ATLAS-4008: Cache getGuid and getStatus in GraphTransactionInterceptor

Signed-off-by: Nikhil Bonte 
(cherry picked from commit 7c68048fcc314d83100c7a5fc0a5b8294f62e2cd)


> Cache getGuid and getStatus in GraphTransactionInterceptor
> --
>
> Key: ATLAS-4008
> URL: https://issues.apache.org/jira/browse/ATLAS-4008
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
>
> *Problem Statement:*
> GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
> multiple times in a same request.
>  
> *Approach:*
> Implement a caching mechanism in GraphTransactionInterceptor to cache the 
> following mappings:
> *vertexID -> guid*
> *vertexID -> entityStatus*
> *edgeId -> status*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3922) Need an instruction for atlas integrated with Impala

[yuyu (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223550#comment-17223550
 ] 

yuyu commented on ATLAS-3922:
-

Have you solved this problem? We also want to integrate impala hook on Atlas, 
but there is no documentation. What's more, I find that there are very few 
introductions about impala hook. It bothers me.

> Need an instruction for atlas integrated with Impala
> 
>
> Key: ATLAS-3922
> URL: https://issues.apache.org/jira/browse/ATLAS-3922
> Project: Atlas
>  Issue Type: Improvement
>  Components: impala-integration
>Affects Versions: 2.1.0
>Reporter: daxingyu
>Priority: Minor
>  Labels: newbie
>
> We are using the CDH6.3.0, and our major query components is Impala. Is there 
> an instrunction on how to work through the atlas impala-hook with impala 
> deployment?? We badly need one. Thanks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72994: ATLAS-4010: Sort properties lexicographically in pom.xml for readability

[Radhika Kundam]

> On Oct. 30, 2020, 2:57 p.m., Madhan Neethiraj wrote:
> > distro/pom.xml
> > Line 51 (original), 39 (patched)
> > 
> >
> > The value of property graph.index.properties is written to 
> > configuration file, refer to distro/src/conf/atlas-application.properties. 
> > Hence leading spaces should be avoided.

Fixed, attached the patach with updates.


- Radhika


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/#review222148
---


On Oct. 30, 2020, 5:46 p.m., Radhika Kundam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72994/
> ---
> 
> (Updated Oct. 30, 2020, 5:46 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-4010
> https://issues.apache.org/jira/browse/ATLAS-4010
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Properties are in random order under  section in pom.xml
> 
> For better readability, need to sort properties in lexicographic order.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml db1f23acd 
>   docs/pom.xml f22f9e2ff 
>   pom.xml aca36aaee 
>   webapp/pom.xml 5a8cfe616 
> 
> 
> Diff: https://reviews.apache.org/r/72994/diff/1/
> 
> 
> Testing
> ---
> 
> Build is successful.
> 
> 
> File Attachments
> 
> 
> Removing extra spaces
>   
> https://reviews.apache.org/media/uploaded/files/2020/10/30/40e165c6-985c-48e0-a61a-558ef4d9b2a3__0002-ATLAS-4010-Sort-properties-in-pom-removing-extra-spa.patch
> 
> 
> Thanks,
> 
> Radhika Kundam
> 
>

Re: Review Request 72994: ATLAS-4010: Sort properties lexicographically in pom.xml for readability

[Radhika Kundam]

> On Oct. 30, 2020, 5:43 a.m., Ashutosh Mestry wrote:
> > distro/pom.xml
> > Line 51 (original), 39 (patched)
> > 
> >
> > nit: Remove extraneous tabs.

Fixed, attached the patach with updates.


- Radhika


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/#review222145
---


On Oct. 30, 2020, 5:46 p.m., Radhika Kundam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72994/
> ---
> 
> (Updated Oct. 30, 2020, 5:46 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-4010
> https://issues.apache.org/jira/browse/ATLAS-4010
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Properties are in random order under  section in pom.xml
> 
> For better readability, need to sort properties in lexicographic order.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml db1f23acd 
>   docs/pom.xml f22f9e2ff 
>   pom.xml aca36aaee 
>   webapp/pom.xml 5a8cfe616 
> 
> 
> Diff: https://reviews.apache.org/r/72994/diff/1/
> 
> 
> Testing
> ---
> 
> Build is successful.
> 
> 
> File Attachments
> 
> 
> Removing extra spaces
>   
> https://reviews.apache.org/media/uploaded/files/2020/10/30/40e165c6-985c-48e0-a61a-558ef4d9b2a3__0002-ATLAS-4010-Sort-properties-in-pom-removing-extra-spa.patch
> 
> 
> Thanks,
> 
> Radhika Kundam
> 
>

Re: Review Request 72994: ATLAS-4010: Sort properties lexicographically in pom.xml for readability

[Radhika Kundam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/
---

(Updated Oct. 30, 2020, 5:46 p.m.)


Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.


Changes
---

Removed the extra tabs as mentioned in comments.


Bugs: ATLAS-4010
https://issues.apache.org/jira/browse/ATLAS-4010


Repository: atlas


Description
---

Properties are in random order under  section in pom.xml

For better readability, need to sort properties in lexicographic order.


Diffs
-

  distro/pom.xml db1f23acd 
  docs/pom.xml f22f9e2ff 
  pom.xml aca36aaee 
  webapp/pom.xml 5a8cfe616 


Diff: https://reviews.apache.org/r/72994/diff/1/


Testing
---

Build is successful.


File Attachments (updated)


Removing extra spaces
  
https://reviews.apache.org/media/uploaded/files/2020/10/30/40e165c6-985c-48e0-a61a-558ef4d9b2a3__0002-ATLAS-4010-Sort-properties-in-pom-removing-extra-spa.patch


Thanks,

Radhika Kundam