Re: Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60938/#review181009 --- Ship it! Ship It! - Madhan Neethiraj On July 19, 2017, 7:27

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-19 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60980/#review181000 --- Ship it! Ship It! - Apoorv Naik On July 19, 2017, 9:59

[jira] [Created] (ATLAS-1966) attribute value containing @ gives inconsistent results

2017-07-19 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1966: -- Summary: attribute value containing @ gives inconsistent results Key: ATLAS-1966 URL: https://issues.apache.org/jira/browse/ATLAS-1966 Project: Atlas Issue

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-19 Thread Madhan Neethiraj
> On July 19, 2017, 7:42 p.m., Apoorv Naik wrote: > > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > > Line 181 (original), 181 (patched) > > > > > > Do it make more sense to pass a

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60980/ --- (Updated July 19, 2017, 9:59 p.m.) Review request for atlas. Changes ---

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-19 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60980/#review180967 ---

Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-19 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60980/#review180964 --- Ship it! Ship It! - Apoorv Naik On July 19, 2017, 6:40

Re: Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-19 Thread Sarath Subramanian
> On July 19, 2017, 8:11 a.m., David Radley wrote: > > addons/models/0010-base_model.json > > Line 105 (original), 105 (patched) > > > > > > I am not sunderstanding why some of these endpoints have the > >

Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)

2017-07-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60980/ --- Review request for atlas. Bugs: ATLAS-1961

Re: Review Request 60857: ATLAS-1950: Import API: Improvement: Specify Supertypes in Import Transforms

2017-07-19 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60857/ --- (Updated July 19, 2017, 6:34 p.m.) Review request for atlas, Ayub Pathan and

Re: Review Request 60971: ATLAS-1914 : UI - Search using entity and trait attributes : "Clear" button doesn't clear the filter applied to a type

2017-07-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60971/#review180948 --- Ship it! Ship It! - Madhan Neethiraj On July 19, 2017, 2:22

[jira] [Created] (ATLAS-1965) UI update to allow browsing of tables in the db

2017-07-19 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-1965: --- Summary: UI update to allow browsing of tables in the db Key: ATLAS-1965 URL: https://issues.apache.org/jira/browse/ATLAS-1965 Project: Atlas Issue

Re: Review Request 60970: ATLAS-1901: Tolerate no propogatetags on Relationshipdef

2017-07-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60970/#review180940 ---

Re: Review Request 60927: ATLAS-1957: Multi-vertex atlas graph query

2017-07-19 Thread Apoorv Naik
> On July 19, 2017, 8:46 a.m., Graham Wallis wrote: > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasMultiVertexQuery.java > > Lines 29 (patched) > > > > > > Minor point but it would be nicer to

Re: Maven restructure

2017-07-19 Thread David Radley
Hi Graham, Thanks for your reply. I guess this means that we will compile at Java 8 and hope that the Hadoop libraries(compiled at Java 7) we call and the Hbase dependancies will work - if not we may need to make some changes - we hope that any changes we make will still allow the code to be

Re: Review Request 60970: ATLAS-1901: Tolerate no propogatetags on Relationshipdef

2017-07-19 Thread David Radley
> On July 19, 2017, 3:02 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java > > Lines 484 (patched) > > > > > > It will be good to

Re: Maven restructure

2017-07-19 Thread Graham Wallis
I think that specifying the -source and -target options won't help really. For example, -target specifies the minimum runtime version - but we would need to set it 1.8 as documented below. I believe that JanusGraph requires Java 1.8.0 Update 40. (BTW it also requires Maven 3.3.9, but I imagine

[jira] [Commented] (ATLAS-1955) Validation for Attributes

2017-07-19 Thread Nigel Jones (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093242#comment-16093242 ] Nigel Jones commented on ATLAS-1955: I believe here you are modeling the fact that an email has to

Re: Review Request 60970: ATLAS-1901: Tolerate no propogatetags on Relationshipdef

2017-07-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60970/#review180928 --- Fix it, then Ship it!

[jira] [Updated] (ATLAS-1901) null pointer when Creating RelationshipDef without propagateTags

2017-07-19 Thread David Radley (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Radley updated ATLAS-1901: Attachment: ATLAS-1901.patch > null pointer when Creating RelationshipDef without propagateTags >

Review Request 60970: ATLAS-1901: Tolerate no propogatetags on Relationshipdef

2017-07-19 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60970/ --- Review request for atlas and Madhan Neethiraj. Repository: atlas Description

[jira] [Commented] (ATLAS-1698) Create Glossary OMAS API

2017-07-19 Thread Nigel Jones (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093149#comment-16093149 ] Nigel Jones commented on ATLAS-1698: Thanks for sharing. For next steps a few more thoughts (this is

[jira] [Commented] (ATLAS-1698) Create Glossary OMAS API

2017-07-19 Thread Nigel Jones (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093146#comment-16093146 ] Nigel Jones commented on ATLAS-1698: A few thoughts * I notice the swagger API rendering from the

[jira] [Updated] (ATLAS-1914) UI - Search using entity and trait attributes : "Clear" button doesn't clear the filter applied to a type

2017-07-19 Thread Keval Bhatt (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-1914: --- Attachment: ATLAS-1914.patch > UI - Search using entity and trait attributes : "Clear" button doesn't

[jira] [Assigned] (ATLAS-1914) UI - Search using entity and trait attributes : "Clear" button doesn't clear the filter applied to a type

2017-07-19 Thread Keval Bhatt (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt reassigned ATLAS-1914: -- Assignee: Keval Bhatt (was: Kalyani Kashikar) > UI - Search using entity and trait attributes

[jira] [Commented] (ATLAS-1757) Proposal to update graph DB

2017-07-19 Thread Dougal Watt (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093035#comment-16093035 ] Dougal Watt commented on ATLAS-1757: Interesting point David. GraphQL isn't in the FB open source

[jira] [Commented] (ATLAS-1698) Create Glossary OMAS API

2017-07-19 Thread David Radley (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092988#comment-16092988 ] David Radley commented on ATLAS-1698: - [~grahamwallis] I have amended the code in the light of your

Re: Review Request 60681: ATLAS-1698 Glossary OMAS API - early Swagger draft

2017-07-19 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60681/ --- (Updated July 19, 2017, 12:18 p.m.) Review request for atlas and Madhan

[jira] [Updated] (ATLAS-1698) Create Glossary OMAS API

2017-07-19 Thread David Radley (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Radley updated ATLAS-1698: Attachment: apidocs-5.zip > Create Glossary OMAS API > > >

Re: Review Request 60927: ATLAS-1957: Multi-vertex atlas graph query

2017-07-19 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60927/#review180913 ---

[jira] [Commented] (ATLAS-1757) Proposal to update graph DB

2017-07-19 Thread David Radley (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092891#comment-16092891 ] David Radley commented on ATLAS-1757: - [~dougal_watt] Interesting - I do not know anything about this

[jira] [Commented] (ATLAS-1757) Proposal to update graph DB

2017-07-19 Thread Dougal Watt (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092850#comment-16092850 ] Dougal Watt commented on ATLAS-1757: The state of integration for graph DB's is somewhat in flux, with

[jira] [Updated] (ATLAS-1964) UI : Support to resize and order columns in Search table

2017-07-19 Thread Keval Bhatt (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-1964: --- Attachment: ATLAS-1964.patch > UI : Support to resize and order columns in Search table >

Re: Review Request 60927: ATLAS-1957: Multi-vertex atlas graph query

2017-07-19 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60927/#review180908 ---