date:20171110

[jira] [Commented] (ATLAS-2246) Define OMRS Connector interface

2017-11-10 Thread Mandy Chessell (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247523#comment-16247523
 ] 

Mandy Chessell commented on ATLAS-2246:
---

Hello Cassio,
I recreated the patch to include the IGC skeleton code.  I think you should 
focus on supporting Glossary terms, Glossary categories and Databases plus any 
of the Hadoop resources Marc wants.

You need to implement the following methods :

EntitySummary getEntitySummary(String guid) throws 
RepositoryErrorException,
   
EntityNotKnownException;
 
EntityDetail getEntityDetail(String guid) throws 
RepositoryErrorException,
 
EntityNotKnownException;

EntityUniverse getEntityUniverse(String  guid) throws 
RepositoryErrorException,
  
EntityNotKnownException;


Relationships getRelationshipsForEntity(String   entityGUID,
InstanceStatus   
limitResultsByStatus,
int  
fromRelationshipElement,
String   
sequencingProperty,
SequencingOrder  
sequencingOrder,
int  pageSize) 
throws RepositoryErrorException,

  EntityNotKnownException,

  PropertyErrorException,

  PagingErrorException;

Classifications getClassificationsForEntity(String   entityGUID,
int  
fromClassificationElement,
String   
sequencingProperty,
SequencingOrder  
sequencingOrder,
int  pageSize) 
throws RepositoryErrorException,

  EntityNotKnownException,

  PropertyErrorException,

  PagingErrorException;

EntityDetails findEntitiesByProperty(String   entityTypeGUID,
 InstanceProperties   matchProperties,
 MatchCriteriamatchCriteria,
 int  
fromEntityDetailElement,
 String   
sequencingProperty,
 SequencingOrder  sequencingOrder,
 int  pageSize) throws 
RepositoryErrorException,
   
TypeErrorException,
   
PropertyErrorException,
   
PagingErrorException;

EntityDetails findEntitiesByClassification(String   
entityTypeGUID,
   String   
classificationName,
   InstanceProperties   
matchClassificationProperties,
   MatchCriteria
matchCriteria,
   InstanceStatus   
limitResultsByStatus,
   String   
sequencingProperty,
   SequencingOrder  
sequencingOrder,
   int  
fromEntityDetailElement,
   int  pageSize) 
throws RepositoryErrorException,

 TypeErrorException,

 ClassificationNotKnownException,

 PropertyErrorException,

 PagingErrorException;


Relationship getRelationship(Stringguid) throws 
RepositoryErrorException,

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2017-11-10 Thread Mandy Chessell


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/
---

(Updated Nov. 10, 2017, 1:43 p.m.)


Review request for atlas, David Radley and Madhan Neethiraj.


Repository: atlas


Description
---

This is a request for review of the OMRS Connector API.  The files of interest 
are:

omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/*
omrs/src/main/java/org/apache/atlas/omrs/connectors/*
omrs/src/main/java/org/apache/atlas/omrs/ffdc/*

There is a patch connected to 
https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
code plus other code that is not ready for review.  The OMRS Connector API 
depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.


Diffs (updated)
-

  omrs/README.md PRE-CREATION 
  omrs/pom.xml PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnection.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnector.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorBase.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorProviderBase.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSConnector.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnector.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/ffdc/ClassificationNotKnownException.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotDeletedException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotKnownException.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/ffdc/NotImplementedRuntimeException.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSCheckedExceptionBase.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSErrorCode.java PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSRuntimeException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/PagingErrorException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/PropertyErrorException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/README.md PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotDeletedException.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotKnownException.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/RepositoryErrorException.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/ffdc/StatusNotSupportedException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefInUseException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefNotKnownException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeErrorException.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollectionBase.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/MatchCriteria.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/SequencingOrder.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classifications.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetail.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetails.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityProxy.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummaries.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2017-11-10 Thread Mandy Chessell


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/
---

(Updated Nov. 10, 2017, 1:39 p.m.)


Review request for atlas, David Radley and Madhan Neethiraj.


Changes
---

Updated the patch ...


Repository: atlas


Description (updated)
---

This is a request for review of the OMRS Connector API.  The files of interest 
are:

omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/*
omrs/src/main/java/org/apache/atlas/omrs/connectors/*
omrs/src/main/java/org/apache/atlas/omrs/ffdc/*

There is a patch connected to 
https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
code plus other code that is not ready for review.  The OMRS Connector API 
depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.


Diffs (updated)
-

  omrs/README.md PRE-CREATION 
  omrs/pom.xml PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnection.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnector.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorBase.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorProviderBase.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSConnector.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnector.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/ffdc/ClassificationNotKnownException.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotDeletedException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotKnownException.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/ffdc/NotImplementedRuntimeException.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSCheckedExceptionBase.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSErrorCode.java PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSRuntimeException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/PagingErrorException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/PropertyErrorException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/README.md PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotDeletedException.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotKnownException.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/RepositoryErrorException.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/ffdc/StatusNotSupportedException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefInUseException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefNotKnownException.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeErrorException.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollectionBase.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/MatchCriteria.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/SequencingOrder.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classifications.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetail.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetails.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityProxy.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummaries.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java
 PRE-CREATION

[jira] [Updated] (ATLAS-2246) Define OMRS Connector interface

2017-11-10 Thread Mandy Chessell (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandy Chessell updated ATLAS-2246:
--
Attachment: 0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch

Updated patch to include IGC skeleton Connector implementation and remove GAF 
and OMAS implementations

> Define OMRS Connector interface
> ---
>
> Key: ATLAS-2246
> URL: https://issues.apache.org/jira/browse/ATLAS-2246
> Project: Atlas
>  Issue Type: Sub-task
>  Components: atlas-intg
>Reporter: Mandy Chessell
>Assignee: Mandy Chessell
>Priority: Critical
> Attachments: 
> 0002-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch, 
> 0002-ATLAS-2246-OMRS-Connector-API.patch, OMRS Javadoc.zip
>
>
> This task covers the creation of the OMRS Connector APIs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2017-11-10 Thread Mandy Chessell



> On Nov. 3, 2017, 9:02 a.m., Nigel Jones wrote:
> > omrs/pom.xml
> > Lines 26 (patched)
> > 
> >
> > The parent pom doesn't specify this module. I presume this is due to 
> > the omrs code not being ready yet ie intentional? (similar applies to other 
> > omas poms)

Yes this is intentional.  The aim is to get feedback on the APIs before 
integrating into hte main build.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review190017
---


On Nov. 2, 2017, 12:03 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Nov. 2, 2017, 12:03 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for review of the OMRS Connector API.  The files of 
> interest are:
> 
> omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/*
> omrs/src/main/java/org/apache/atlas/omrs/connectors/*
> omrs/src/main/java/org/apache/atlas/omrs/ffdc/*
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> There is some OMAS code in the patch that can be ignored.
> 
> 
> Diffs
> -
> 
>   om-fwk-gaf/pom.xml PRE-CREATION 
>   om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFCheckedException.java 
> PRE-CREATION 
>   om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFErrorCode.java 
> PRE-CREATION 
>   om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFRuntimeException.java 
> PRE-CREATION 
>   om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/README.md PRE-CREATION 
>   omas-assetconsumer/README.md PRE-CREATION 
>   omas-assetconsumer/pom.xml PRE-CREATION 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/AssetConsumerInterface.java
>  PRE-CREATION 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java
>  PRE-CREATION 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerCheckedExceptionBase.java
>  PRE-CREATION 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerErrorCode.java
>  PRE-CREATION 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerRuntimeException.java
>  PRE-CREATION 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetNotReferenceableException.java
>  PRE-CREATION 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/ConnectionNameAmbiguousException.java
>  PRE-CREATION 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/README.md
>  PRE-CREATION 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/UnknownConnectionGUIDException.java
>  PRE-CREATION 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/UnknownConnectionURLException.java
>  PRE-CREATION 
>   
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerREST.java
>  PRE-CREATION 
>   omas-assetowner/pom.xml PRE-CREATION 
>   
> omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/ffdc/AssetOwnerErrorCode.java
>  PRE-CREATION 
>   
> omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Endpoints.java
>  PRE-CREATION 
>   
> omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Host.java
>  PRE-CREATION 
>   
> omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Platform.java
>  PRE-CREATION 
>   
> omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Server.java
>  PRE-CREATION 
>   
> omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/ServerCapabilities.java
>  PRE-CREATION 
>   
> omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/ServerCapability.java
>  PRE-CREATION 
>   
> omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Servers.java
>  PRE-CREATION 
>   omas-connectedasset/README.md PRE-CREATION 
>   omas-connectedasset/pom.xml PRE-CREATION 
>   
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ConnectedAssetInterface.java
>  PRE-CREATION 
>   
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/client/ConnectedAsset.java
>  PRE-CREATION 
>   
>

[jira] [Updated] (ATLAS-1095) Open connector framework

2017-11-10 Thread Mandy Chessell (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandy Chessell updated ATLAS-1095:
--
Attachment: 0001-ATLAS-1095-initial-code-drop-for-OCF-with-fixes-from.patch

Updated patch based on Yao's review

> Open connector framework
> 
>
> Key: ATLAS-1095
> URL: https://issues.apache.org/jira/browse/ATLAS-1095
> Project: Atlas
>  Issue Type: New Feature
>Affects Versions: 1.0.0
>Reporter: Stephanie Hazlewood
>Assignee: Mandy Chessell
>  Labels: VirtualDataConnector
> Attachments: 
> 0001-ATLAS-1095-initial-code-drop-for-OCF-with-fixes-from.patch, 
> ATLAS-1095.patch, OCF Javadoc.zip, Open Connector Framework - 20th June 
> 2017.doc, Open Connector Framework - 9th May 2017.doc
>
>
> Atlas provides a common approach to metadata management and governance across 
> all systems and data within an organization.  Today Atlas provides access to 
> metadata.   A connector provides access to a data source.  As connectors are 
> the proxy of all data, they can also be explicit providers of metadata.   
> This JIRA proposes an open connector framework to manage connectors that 
> provide access to both data and the metadata Atlas provides together through 
> a single connector interface.  
> This will help data tools to to better the exchange of information between 
> platforms. It also offers new opportunities for the consistent enforcement of 
> the governance policies and rules (e.g., rules of visibility).  Source 
> connector/connection metadata provides the nucleus around which all other 
> metadata describing the data builds.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2017-11-10 Thread Mandy Chessell


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/
---

(Updated Nov. 10, 2017, 12:48 p.m.)


Review request for atlas and Madhan Neethiraj.


Repository: atlas


Description
---

This patch contains the open connector framework code.  This code is located in 
the om-fwk-ocf component and is described in JIRA 
https://issues.apache.org/jira/browse/ATLAS-1095

I have added a new patch to the Jira with fixes from Yao's comments.  Upgraded 
Maven to 352 and rebuilt/rerun tests.


Diffs (updated)
-

  om-fwk-ocf/README.md PRE-CREATION 
  om-fwk-ocf/pom.xml PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java
 PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java
 PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/README.md PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java
 PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Analysis.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certification.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classification.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comments.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java
 PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connections.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java
 PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementType.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java
 PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java
 PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Endpoint.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifier.java
 PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifiers.java
 PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalReference.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalReferences.java
 PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Feedback.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTags.java

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2017-11-10 Thread Mandy Chessell


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/
---

(Updated Nov. 10, 2017, 12:45 p.m.)


Review request for atlas and Madhan Neethiraj.


Repository: atlas


Description (updated)
---

This patch contains the open connector framework code.  This code is located in 
the om-fwk-ocf component and is described in JIRA 
https://issues.apache.org/jira/browse/ATLAS-1095

I have added a new patch to the Jira with fixes from Yao's comments.  Upgraded 
Maven to 352 and rebuilt/rerun tests.


Diffs
-

  om-fwk-ocf/README.md PRE-CREATION 
  om-fwk-ocf/pom.xml PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java
 PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java
 PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/README.md PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java
 PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Analysis.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certification.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classification.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comments.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java
 PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connections.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java
 PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementType.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java
 PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java
 PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Endpoint.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifier.java
 PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifiers.java
 PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalReference.java 
PRE-CREATION 
  
om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalReferences.java
 PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Feedback.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java 
PRE-CREATION 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTags.java

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2017-11-10 Thread Mandy Chessell



> On Nov. 7, 2017, 1:27 p.m., Yao Li wrote:
> > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaAttribute.java
> > Lines 67 (patched)
> > 
> >
> > is that necessary to check whether template.getAttributeType is null?

yes - and call the cloneSchemaElement() method rather than new SchemaElement() 
because SchemaElement is abstract.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review190294
---


On Nov. 2, 2017, 12:27 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63503/
> ---
> 
> (Updated Nov. 2, 2017, 12:27 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch contains the open connector framework code.  This code is located 
> in the om-fwk-ocf component and is described in JIRA 
> https://issues.apache.org/jira/browse/ATLAS-1095
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/README.md PRE-CREATION 
>   om-fwk-ocf/pom.xml PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/README.md PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Analysis.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comments.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connections.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java
>  PRE-CREATION 
>   
>

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2017-11-10 Thread Mandy Chessell



> On Nov. 7, 2017, 1:27 p.m., Yao Li wrote:
> > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Schema.java
> > Lines 49 (patched)
> > 
> >
> > this is class is not included in the patch, I can't find it.

SchemaType is defined as an inline enum a few lines above the declaration of 
schemaType.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review190294
---


On Nov. 2, 2017, 12:27 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63503/
> ---
> 
> (Updated Nov. 2, 2017, 12:27 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch contains the open connector framework code.  This code is located 
> in the om-fwk-ocf component and is described in JIRA 
> https://issues.apache.org/jira/browse/ATLAS-1095
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/README.md PRE-CREATION 
>   om-fwk-ocf/pom.xml PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/README.md PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Analysis.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comments.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connections.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java
>  PRE-CREATION 
>   
>

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2017-11-10 Thread Mandy Chessell



> On Nov. 7, 2017, 2:55 p.m., Yao Li wrote:
> > based on your OCF document, Connector Instance Adapter and Connector 
> > Provider Adapter are not in the patch

Agreed - With the base classes for connector and connector provider, I do not 
think we need this


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review190305
---


On Nov. 2, 2017, 12:27 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63503/
> ---
> 
> (Updated Nov. 2, 2017, 12:27 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch contains the open connector framework code.  This code is located 
> in the om-fwk-ocf component and is described in JIRA 
> https://issues.apache.org/jira/browse/ATLAS-1095
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/README.md PRE-CREATION 
>   om-fwk-ocf/pom.xml PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/README.md PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Analysis.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comments.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connections.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Endpoint.java 
>

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2017-11-10 Thread Mandy Chessell



> On Nov. 7, 2017, 5:55 a.m., Yao Li wrote:
> > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedAssetProperties.java
> > Lines 45 (patched)
> > 
> >
> > AssetUniverse extends AssetDetail which extends AssetSummary

Fixed comment


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review190164
---


On Nov. 2, 2017, 12:27 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63503/
> ---
> 
> (Updated Nov. 2, 2017, 12:27 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch contains the open connector framework code.  This code is located 
> in the om-fwk-ocf component and is described in JIRA 
> https://issues.apache.org/jira/browse/ATLAS-1095
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/README.md PRE-CREATION 
>   om-fwk-ocf/pom.xml PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/README.md PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Analysis.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comments.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connections.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java
>  PRE-CREATION 
>

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2017-11-10 Thread Mandy Chessell



> On Nov. 7, 2017, 5:55 a.m., Yao Li wrote:
> > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/OperationalStatus.java
> > Lines 23 (patched)
> > 
> >
> > should here be the explanation of OperationalStatus?

Yes it does need a header - but also it is not used so I have removed it from 
the OCF.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review190164
---


On Nov. 2, 2017, 12:27 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63503/
> ---
> 
> (Updated Nov. 2, 2017, 12:27 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch contains the open connector framework code.  This code is located 
> in the om-fwk-ocf component and is described in JIRA 
> https://issues.apache.org/jira/browse/ATLAS-1095
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/README.md PRE-CREATION 
>   om-fwk-ocf/pom.xml PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/README.md PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Analysis.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comments.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connections.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java
>  PRE-CREATION 
>   
>

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2017-11-10 Thread Mandy Chessell



> On Nov. 7, 2017, 5:55 a.m., Yao Li wrote:
> > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/MapSchemaElement.java
> > Lines 20 (patched)
> > 
> >
> > Would you mind adding an explanation for this Class? I don't really 
> > understand the function of this SchemaElement
> 
> Mandy Chessell wrote:
> MapSchemaElement describes a part of a schema that defines a map.  So may 
> have a JSON structure where one of the attributes is of type map.

I also noticed that PrimitiveSchemaElement is missing a header description too


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review190164
---


On Nov. 2, 2017, 12:27 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63503/
> ---
> 
> (Updated Nov. 2, 2017, 12:27 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch contains the open connector framework code.  This code is located 
> in the om-fwk-ocf component and is described in JIRA 
> https://issues.apache.org/jira/browse/ATLAS-1095
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/README.md PRE-CREATION 
>   om-fwk-ocf/pom.xml PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/README.md PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Analysis.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comments.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connections.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 
> PRE-CREATION 
>

Review Request 63721: ATLAS-1964 :UI, Support to resize and order columns in Search table

2017-11-10 Thread pratik pandey


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63721/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-1964
https://issues.apache.org/jira/browse/ATLAS-1964


Repository: atlas


Description
---

Add support for drag and drop column.


Diffs
-

  dashboardv2/gruntfile.js ba9ea0f 
  dashboardv2/package.json 957e916 
  dashboardv2/public/css/scss/search.scss 26f1505 
  dashboardv2/public/js/main.js f6c0157 
  dashboardv2/public/js/utils/Utils.js 47e9ac2 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 2e8c165 


Diff: https://reviews.apache.org/r/63721/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey

[jira] [Updated] (ATLAS-1964) UI : Support to resize and order columns in Search table

2017-11-10 Thread pratik pandey (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-1964:
-
Attachment: ATLAS-1964-branch0.8.patch

> UI : Support to resize and order columns in Search table
> 
>
> Key: ATLAS-1964
> URL: https://issues.apache.org/jira/browse/ATLAS-1964
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Keval Bhatt
>Assignee: pratik pandey
> Fix For: 1.0.0, 0.8.1
>
> Attachments: ATLAS-1964-branch0.8.patch, ATLAS-1964-master.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ATLAS-1964) UI : Support to resize and order columns in Search table

2017-11-10 Thread pratik pandey (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-1964:
-
Attachment: ATLAS-1964-master.patch

> UI : Support to resize and order columns in Search table
> 
>
> Key: ATLAS-1964
> URL: https://issues.apache.org/jira/browse/ATLAS-1964
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Keval Bhatt
>Assignee: pratik pandey
> Fix For: 1.0.0, 0.8.1
>
> Attachments: ATLAS-1964-branch0.8.patch, ATLAS-1964-master.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2017-11-10 Thread Mandy Chessell



> On Nov. 6, 2017, 2:38 p.m., Yao Li wrote:
> > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java
> > Lines 47 (patched)
> > 
> >
> > AssetUniverse extends AssetDetail which extends AssetSummary

Updated comment


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63503/#review190148
---


On Nov. 2, 2017, 12:27 p.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63503/
> ---
> 
> (Updated Nov. 2, 2017, 12:27 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch contains the open connector framework code.  This code is located 
> in the om-fwk-ocf component and is described in JIRA 
> https://issues.apache.org/jira/browse/ATLAS-1095
> 
> 
> Diffs
> -
> 
>   om-fwk-ocf/README.md PRE-CREATION 
>   om-fwk-ocf/pom.xml PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectionCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/ConnectorCheckedException.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFCheckedExceptionBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFRuntimeException.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/PropertyServerException.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/README.md PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Analysis.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AnnotationStatus.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotations.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certifications.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classification.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Classifications.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comments.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connections.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectorType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java
>  PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java 
> PRE-CREATION 
>   om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementType.java 
> PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java
>  PRE-CREATION 
>   
> om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnections.java
>  PRE-CREATION 
>

[jira] [Updated] (ATLAS-1964) UI : Support to resize and order columns in Search table

2017-11-10 Thread pratik pandey (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-1964:
-
Fix Version/s: 1.0.0

> UI : Support to resize and order columns in Search table
> 
>
> Key: ATLAS-1964
> URL: https://issues.apache.org/jira/browse/ATLAS-1964
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Keval Bhatt
>Assignee: pratik pandey
> Fix For: 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 63706: [ATLAS-2256]: Make JanusGraph as the default graph-provider in atlas

2017-11-10 Thread Graham Wallis



> On Nov. 9, 2017, 9:10 p.m., Madhan Neethiraj wrote:
> > Ship It!

Looks great - thanks for making the change Sarath


- Graham


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63706/#review190641
---


On Nov. 9, 2017, 8:09 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63706/
> ---
> 
> (Updated Nov. 9, 2017, 8:09 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2256
> https://issues.apache.org/jira/browse/ATLAS-2256
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas currently use Titan 0.5.4 as the default graph provider. This JIRA will 
> make JanusGraph 0.1.1 as the default graph-provider.
> Atlas can be build against Titan by explicitly specifying it as profile:
> mvn clean package -DGRAPH-PROVIDER=titan0
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 9db742d0 
>   distro/src/bin/atlas_config.py 4d13b303 
>   distro/src/conf/atlas-application.properties b61c2bcb 
>   pom.xml bacec7f6 
>   
> repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java
>  09f366e2 
> 
> 
> Diff: https://reviews.apache.org/r/63706/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean package succeeded.
> 
> Ran quickstart and hive hook messages.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

[jira] [Assigned] (ATLAS-1964) UI : Support to resize and order columns in Search table

2017-11-10 Thread pratik pandey (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-1964:


Assignee: pratik pandey  (was: Keval Bhatt)

> UI : Support to resize and order columns in Search table
> 
>
> Key: ATLAS-1964
> URL: https://issues.apache.org/jira/browse/ATLAS-1964
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Keval Bhatt
>Assignee: pratik pandey
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ATLAS-2246) Define OMRS Connector interface

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

[jira] [Updated] (ATLAS-2246) Define OMRS Connector interface

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

[jira] [Updated] (ATLAS-1095) Open connector framework

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

Review Request 63721: ATLAS-1964 :UI, Support to resize and order columns in Search table

[jira] [Updated] (ATLAS-1964) UI : Support to resize and order columns in Search table

[jira] [Updated] (ATLAS-1964) UI : Support to resize and order columns in Search table

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

[jira] [Updated] (ATLAS-1964) UI : Support to resize and order columns in Search table

Re: Review Request 63706: [ATLAS-2256]: Make JanusGraph as the default graph-provider in atlas

[jira] [Assigned] (ATLAS-1964) UI : Support to resize and order columns in Search table

21 matches

Site Navigation

Mail list logo

Footer information