[jira] [Updated] (ATLAS-2421) Notification updates to support V2 data structures

2018-01-26 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-2421: Attachment: ATLAS-2421.patch > Notification updates to support V2 data structures >

Review Request 65370: ATLAS-2421: updated Atlas notificaiton module to support V2 data structures

2018-01-26 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65370/ --- Review request for atlas. Bugs: ATLAS-2421 https://issues.apache.org/jira/b

[jira] [Created] (ATLAS-2421) Notification updates to support V2 data structures

2018-01-26 Thread Madhan Neethiraj (JIRA)
Madhan Neethiraj created ATLAS-2421: --- Summary: Notification updates to support V2 data structures Key: ATLAS-2421 URL: https://issues.apache.org/jira/browse/ATLAS-2421 Project: Atlas Issue

[jira] [Assigned] (ATLAS-1095) Open connector framework

2018-01-26 Thread David Radley (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Radley reassigned ATLAS-1095: --- Assignee: David Radley (was: Mandy Chessell) > Open connector framework > --

[jira] [Assigned] (ATLAS-2330) Integration tests failures

2018-01-26 Thread Ashutosh Mestry (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Mestry reassigned ATLAS-2330: -- Assignee: (was: Ashutosh Mestry) > Integration tests failures > ---

[jira] [Updated] (ATLAS-2330) Integration tests failures

2018-01-26 Thread Ashutosh Mestry (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Mestry updated ATLAS-2330: --- Attachment: ATLAS-2330-ZipSource-Unit-test.patch > Integration tests failures > --

[jira] [Assigned] (ATLAS-2330) Integration tests failures

2018-01-26 Thread Ashutosh Mestry (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Mestry reassigned ATLAS-2330: -- Assignee: Ashutosh Mestry > Integration tests failures > -- > >

[jira] [Commented] (ATLAS-2419) [DSL] Semantic validation

2018-01-26 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341678#comment-16341678 ] Apoorv Naik commented on ATLAS-2419: https://github.com/apache/atlas/commit/c35f82ca1a

[jira] [Commented] (ATLAS-2418) Advanced Search DSL: Support System Attributes

2018-01-26 Thread Ashutosh Mestry (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341672#comment-16341672 ] Ashutosh Mestry commented on ATLAS-2418: This [commit|https://github.com/apache/a

[jira] [Commented] (ATLAS-2375) Add hbase_namespace type to DEFAULT_EDITABLE_ENTITY_TYPES

2018-01-26 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341646#comment-16341646 ] Madhan Neethiraj commented on ATLAS-2375: - +1 for the patch. Thanks [~vishal.suvag

Jenkins build is back to normal : Atlas-master-UnitTests #342

2018-01-26 Thread Apache Jenkins Server
See

Build failed in Jenkins: Atlas-master-UnitTests #341

2018-01-26 Thread Apache Jenkins Server
See -- [...truncated 1.83 KB...] + export PATH=/home/jenkins/tools/java/latest1.8/bin:/home/jenkins/tools/maven/latest/bin:/home/jenkins/tools/java/latest1.8/bin:/usr/local/sbin:/us

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 19, 2018, 10:40 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java > > Lines 51 (patched) > > > > > > missing name here It

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 22, 2018, 2:17 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java > > Lines 162 (patched) > > > > > > why do we need to dissconn

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 3:55 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java > > Lines 56 (patched) > > > > > > here what type of real

Re: Review Request 65327: Fix: Repository Unit Tests: Occasional Seemingly Random Failures

2018-01-26 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65327/#review196356 --- Ship it! Ship It! - Madhan Neethiraj On Jan. 26, 2018, 1:18

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java > > Lines 48 (patched) > > > > > > I suggest changing s

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review196353 --- omrs/src/main/java/org/apache/atlas/omrs/localrepository/reposito

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 3:22 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java > > Lines 414 (patched) > > > > > > Id -> id I am not su

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 3:22 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java > > Lines 251 (patched) > > > > > > if outboundRepository

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review196350 --- omrs/src/main/java/org/apache/atlas/omrs/localrepository/reposito

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 1:17 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapper.java > > Lines 39 (patched) > > > > > > 1, can you please finis

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 1:17 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/repositoryeventmapper/OMRSRepositoryEventMapperProviderBase.java > > Lines 24 (patched) > > > > > > here "OMRSR

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 1:43 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java > > Lines 28 (patched) > > > > > > can you add an explanation

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 1:43 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java > > Lines 95 (patched) > > > > > > can you finish the java doc

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 1:43 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefManager.java > > Lines 97 (patched) > > > > > > can you finish the java doc

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li
> On Jan. 26, 2018, 11:52 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java > > Lines 384 (patched) > > > > > > should this code put into the > > >

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review196334 --- omrs/src/main/java/org/apache/atlas/omrs/localrepository/reposito

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li
> On Jan. 26, 2018, 11:52 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java > > Lines 384 (patched) > > > > > > should this code put into the > > >

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review196318 --- omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/reposito

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/ --- (Updated Jan. 26, 2018, 1:15 p.m.) Review request for atlas, David Radley and M

[jira] [Updated] (ATLAS-2246) Define OMRS Connector interface

2018-01-26 Thread Mandy Chessell (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mandy Chessell updated ATLAS-2246: -- Attachment: 0002-ATLAS-2246-26th-Jan-Code-Drop-of-OMRS.patch > Define OMRS Connector interface >

[jira] [Updated] (ATLAS-2246) Define OMRS Connector interface

2018-01-26 Thread Mandy Chessell (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mandy Chessell updated ATLAS-2246: -- Attachment: (was: 0002-ATLAS-2246-code-review-version.patch) > Define OMRS Connector interfa

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 11:52 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java > > Lines 384 (patched) > > > > > > should this code put into the > > >

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 11:52 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventManager.java > > Lines 112 (patched) > > > > > > i saw you have validTypeDef(), validRelat

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 10:30 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java > > Lines 90 (patched) > > > > > > should be retrieve the list based on the component's

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 10:30 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java > > Lines 82 (patched) > > > > > > for severity, should here use class "OMRSAuditLogReco

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 10:30 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogStore.java > > Lines 70 (patched) > > > > > > should retrieve the list based on the "severity" Yes

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 10:30 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAuditLogRecordOriginator.java > > Lines 20 (patched) > > > > > > can you add the explaination for this clas

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Mandy Chessell
> On Jan. 26, 2018, 7:38 a.m., Maryna Strelchuk wrote: > > omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java > > Lines 34 (patched) > > > > > > 2 other sections are missing he

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review196316 --- omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepo

[jira] [Commented] (ATLAS-2397) Disabled Unit Test: UserProfileServiceTest.java:195

2018-01-26 Thread Graham Wallis (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340949#comment-16340949 ] Graham Wallis commented on ATLAS-2397: -- @ashutosh ThanksĀ  > Disabled Unit Test: User

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

2018-01-26 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review196317 --- Ship it! Ship It! - David Radley On Jan. 19, 2018, 9:30 a.m.

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li
> On Jan. 22, 2018, 2:17 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormanager/OMRSEnterpriseConnectorManager.java > > Lines 162 (patched) > > > > > > why do we need to dissconn

***UNCHECKED*** Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-01-26 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review196310 --- omrs/src/main/java/org/apache/atlas/omrs/auditlog/store/OMRSAudit