[jira] [Updated] (ATLAS-2421) Notification updates to support V2 data structures

2018-01-28 Thread Madhan Neethiraj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ATLAS-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-2421:

Attachment: ATLAS-2421-master.patch

> Notification updates to support V2 data structures
> --
>
> Key: ATLAS-2421
> URL: https://issues.apache.org/jira/browse/ATLAS-2421
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 0.8.2, 1.0.0
>
> Attachments: ATLAS-2421-branch-0.8.patch, ATLAS-2421-master.patch
>
>
> Currently Atlas notifications use V1 data structures - like 
> Referenceable/Struct/ReferenceableInstance. The notification interface should 
> be updated to support V2 data structures as well. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2421) Notification updates to support V2 data structures

2018-01-28 Thread Madhan Neethiraj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ATLAS-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-2421:

Fix Version/s: 1.0.0

> Notification updates to support V2 data structures
> --
>
> Key: ATLAS-2421
> URL: https://issues.apache.org/jira/browse/ATLAS-2421
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 0.8.2, 1.0.0
>
> Attachments: ATLAS-2421-branch-0.8.patch, ATLAS-2421-master.patch
>
>
> Currently Atlas notifications use V1 data structures - like 
> Referenceable/Struct/ReferenceableInstance. The notification interface should 
> be updated to support V2 data structures as well. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2421) Notification updates to support V2 data structures

2018-01-28 Thread Madhan Neethiraj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ATLAS-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-2421:

Attachment: (was: ATLAS-2421-master.patch)

> Notification updates to support V2 data structures
> --
>
> Key: ATLAS-2421
> URL: https://issues.apache.org/jira/browse/ATLAS-2421
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 0.8.2
>
> Attachments: ATLAS-2421-branch-0.8.patch
>
>
> Currently Atlas notifications use V1 data structures - like 
> Referenceable/Struct/ReferenceableInstance. The notification interface should 
> be updated to support V2 data structures as well. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Add me as Atlas contributor

2018-01-28 Thread Madhan Neethiraj 
Vishal,

Thanks for your interest in contributing to Apache Atlas. You have been added 
as a contributor in Apache Atlas. You should have appropriate access in JIRA - 
like being able to assign/edit JIRAs. Please let me know if you face any issues 
with these.

Regards,
Madhan


On 1/28/18, 10:43 PM, "vishal suvagia"  wrote:

Dear community, I 
would like to contribute to Apache Atlas project.
 Request to kindly add me as a contributor for 
Apache Atlas,  my full-name is Vishal Suvagia and 
email-id is vishalsuva...@yahoo.com.

Thanks and Regards,
Vishal Suvagia.

Re: Review Request 65373: ATLAS-2421: updated Atlas notificaiton module to support V2 data structures

2018-01-28 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65373/
---

(Updated Jan. 29, 2018, 7 a.m.)


Review request for atlas.


Changes
---

updates to fix IT failure in pre-commit run.


Bugs: ATLAS-2421
https://issues.apache.org/jira/browse/ATLAS-2421


Repository: atlas


Description
---

Following new notificaiton types are added: ENTITY_CREATE_V2, 
ENTITY_FULL_UPDATE_V2, ENTITY_PARTIAL_UPDATE_V2, ENTITY_DELETE_V2.


Diffs (updated)
-

  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
 03e340c9 
  
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java 
0d2e8df2 
  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 42003bcf 
  intg/src/main/java/org/apache/atlas/model/notification/HookNotification.java 
83e52d55 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 7b77a736 
  intg/src/main/java/org/apache/atlas/utils/AtlasJson.java adf0665d 
  
notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java
 47f72c55 
  
notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java
 cf691af1 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 456a7784 


Diff: https://reviews.apache.org/r/65373/diff/2/

Changes: https://reviews.apache.org/r/65373/diff/1-2/


Testing
---

Added unit tests to validate SerDe for newly added notification types.


Thanks,

Madhan Neethiraj

Re: Review Request 65373: ATLAS-2421: updated Atlas notificaiton module to support V2 data structures

2018-01-28 Thread Madhan Neethiraj 


> On Jan. 29, 2018, 4:38 a.m., Sarath Subramanian wrote:
> > One of the IT failed with this patch:
> >   
> > DataSetLineageJerseyResourceIT.setUp:61->setupInstances:198->table:266->BaseResourceIT.createInstance:225
> >  » AtlasService
> > 
> > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/67/consoleFull

Thanks for catching this IT failure. I updated the patch to address this issue. 
Pre-commit run passes after this update - 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/69/console


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65373/#review196402
---


On Jan. 29, 2018, 7 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65373/
> ---
> 
> (Updated Jan. 29, 2018, 7 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2421
> https://issues.apache.org/jira/browse/ATLAS-2421
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Following new notificaiton types are added: ENTITY_CREATE_V2, 
> ENTITY_FULL_UPDATE_V2, ENTITY_PARTIAL_UPDATE_V2, ENTITY_DELETE_V2.
> 
> 
> Diffs
> -
> 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
>  03e340c9 
>   
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java
>  0d2e8df2 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 42003bcf 
>   
> intg/src/main/java/org/apache/atlas/model/notification/HookNotification.java 
> 83e52d55 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 7b77a736 
>   intg/src/main/java/org/apache/atlas/utils/AtlasJson.java adf0665d 
>   
> notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java
>  47f72c55 
>   
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java
>  cf691af1 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  456a7784 
> 
> 
> Diff: https://reviews.apache.org/r/65373/diff/2/
> 
> 
> Testing
> ---
> 
> Added unit tests to validate SerDe for newly added notification types.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Add me as Atlas contributor

2018-01-28 Thread vishal suvagia 
Dear community,                                                         I would 
like to contribute to Apache Atlas project.
                         Request to kindly add me as a contributor for Apache 
Atlas,                          my full-name is Vishal Suvagia and email-id is 
vishalsuva...@yahoo.com.

Thanks and Regards,
Vishal Suvagia.

Re: Review Request 65373: ATLAS-2421: updated Atlas notificaiton module to support V2 data structures

2018-01-28 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65373/#review196402
---



One of the IT failed with this patch:
  
DataSetLineageJerseyResourceIT.setUp:61->setupInstances:198->table:266->BaseResourceIT.createInstance:225
 » AtlasService

https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/67/consoleFull

- Sarath Subramanian


On Jan. 28, 2018, 5:07 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65373/
> ---
> 
> (Updated Jan. 28, 2018, 5:07 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2421
> https://issues.apache.org/jira/browse/ATLAS-2421
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Following new notificaiton types are added: ENTITY_CREATE_V2, 
> ENTITY_FULL_UPDATE_V2, ENTITY_PARTIAL_UPDATE_V2, ENTITY_DELETE_V2.
> 
> 
> Diffs
> -
> 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
>  03e340c9 
>   
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java
>  0d2e8df2 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 42003bcf 
>   
> intg/src/main/java/org/apache/atlas/model/notification/HookNotification.java 
> 83e52d55 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 7b77a736 
>   intg/src/main/java/org/apache/atlas/utils/AtlasJson.java adf0665d 
>   
> notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java
>  47f72c55 
>   
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java
>  cf691af1 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  456a7784 
> 
> 
> Diff: https://reviews.apache.org/r/65373/diff/1/
> 
> 
> Testing
> ---
> 
> Added unit tests to validate SerDe for newly added notification types.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 65373: ATLAS-2421: updated Atlas notificaiton module to support V2 data structures

2018-01-28 Thread Apoorv Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65373/#review196401
---



Looks good overall. Will be testing on actual deployment shortly for a more 
comprehensive review.

- Apoorv Naik


On Jan. 29, 2018, 1:07 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65373/
> ---
> 
> (Updated Jan. 29, 2018, 1:07 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2421
> https://issues.apache.org/jira/browse/ATLAS-2421
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Following new notificaiton types are added: ENTITY_CREATE_V2, 
> ENTITY_FULL_UPDATE_V2, ENTITY_PARTIAL_UPDATE_V2, ENTITY_DELETE_V2.
> 
> 
> Diffs
> -
> 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
>  03e340c9 
>   
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java
>  0d2e8df2 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 42003bcf 
>   
> intg/src/main/java/org/apache/atlas/model/notification/HookNotification.java 
> 83e52d55 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 7b77a736 
>   intg/src/main/java/org/apache/atlas/utils/AtlasJson.java adf0665d 
>   
> notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java
>  47f72c55 
>   
> notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java
>  cf691af1 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  456a7784 
> 
> 
> Diff: https://reviews.apache.org/r/65373/diff/1/
> 
> 
> Testing
> ---
> 
> Added unit tests to validate SerDe for newly added notification types.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[jira] [Comment Edited] (ATLAS-2421) Notification updates to support V2 data structures

2018-01-28 Thread Madhan Neethiraj (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341986#comment-16341986
 ] 

Madhan Neethiraj edited comment on ATLAS-2421 at 1/29/18 1:08 AM:
--

Review board URL for branch-0.8 patch: https://reviews.apache.org/r/65370/
Review board URL for master patch: https://reviews.apache.org/r/65373/


was (Author: madhan.neethiraj):
Review board URL for branch-0.8 patch: https://reviews.apache.org/r/65370/

> Notification updates to support V2 data structures
> --
>
> Key: ATLAS-2421
> URL: https://issues.apache.org/jira/browse/ATLAS-2421
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 0.8.2
>
> Attachments: ATLAS-2421-branch-0.8.patch, ATLAS-2421-master.patch
>
>
> Currently Atlas notifications use V1 data structures - like 
> Referenceable/Struct/ReferenceableInstance. The notification interface should 
> be updated to support V2 data structures as well. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 65373: ATLAS-2421: updated Atlas notificaiton module to support V2 data structures

2018-01-28 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65373/
---

Review request for atlas.


Bugs: ATLAS-2421
https://issues.apache.org/jira/browse/ATLAS-2421


Repository: atlas


Description
---

Following new notificaiton types are added: ENTITY_CREATE_V2, 
ENTITY_FULL_UPDATE_V2, ENTITY_PARTIAL_UPDATE_V2, ENTITY_DELETE_V2.


Diffs
-

  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
 03e340c9 
  
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java 
0d2e8df2 
  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 42003bcf 
  intg/src/main/java/org/apache/atlas/model/notification/HookNotification.java 
83e52d55 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 7b77a736 
  intg/src/main/java/org/apache/atlas/utils/AtlasJson.java adf0665d 
  
notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java
 47f72c55 
  
notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java
 cf691af1 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 456a7784 


Diff: https://reviews.apache.org/r/65373/diff/1/


Testing
---

Added unit tests to validate SerDe for newly added notification types.


Thanks,

Madhan Neethiraj

[jira] [Updated] (ATLAS-2421) Notification updates to support V2 data structures

2018-01-28 Thread Madhan Neethiraj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ATLAS-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-2421:

Attachment: ATLAS-2421-master.patch
ATLAS-2421-branch-0.8.patch

> Notification updates to support V2 data structures
> --
>
> Key: ATLAS-2421
> URL: https://issues.apache.org/jira/browse/ATLAS-2421
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 0.8.2
>
> Attachments: ATLAS-2421-branch-0.8.patch, ATLAS-2421-master.patch
>
>
> Currently Atlas notifications use V1 data structures - like 
> Referenceable/Struct/ReferenceableInstance. The notification interface should 
> be updated to support V2 data structures as well. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (ATLAS-2421) Notification updates to support V2 data structures

2018-01-28 Thread Madhan Neethiraj (JIRA) 

[ 
https://issues.apache.org/jira/browse/ATLAS-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341986#comment-16341986
 ] 

Madhan Neethiraj edited comment on ATLAS-2421 at 1/29/18 12:51 AM:
---

Review board URL for branch-0.8 patch: https://reviews.apache.org/r/65370/


was (Author: madhan.neethiraj):
Review board URL: https://reviews.apache.org/r/65370/

> Notification updates to support V2 data structures
> --
>
> Key: ATLAS-2421
> URL: https://issues.apache.org/jira/browse/ATLAS-2421
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 0.8.2
>
> Attachments: ATLAS-2421-branch-0.8.patch, ATLAS-2421-master.patch
>
>
> Currently Atlas notifications use V1 data structures - like 
> Referenceable/Struct/ReferenceableInstance. The notification interface should 
> be updated to support V2 data structures as well. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2421) Notification updates to support V2 data structures

2018-01-28 Thread Madhan Neethiraj (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ATLAS-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-2421:

Attachment: (was: ATLAS-2421.patch)

> Notification updates to support V2 data structures
> --
>
> Key: ATLAS-2421
> URL: https://issues.apache.org/jira/browse/ATLAS-2421
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 0.8.2
>
> Attachments: ATLAS-2421-branch-0.8.patch, ATLAS-2421-master.patch
>
>
> Currently Atlas notifications use V1 data structures - like 
> Referenceable/Struct/ReferenceableInstance. The notification interface should 
> be updated to support V2 data structures as well. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 65329: [ATLAS-2420]: Create indexes for relationship attributes

2018-01-28 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65329/#review196396
---


Ship it!




Ship It!

- Madhan Neethiraj


On Jan. 25, 2018, 12:56 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65329/
> ---
> 
> (Updated Jan. 25, 2018, 12:56 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2420
> https://issues.apache.org/jira/browse/ATLAS-2420
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently attributes and system attributes (guid)  of relationship is not 
> indexed. This Jira enables adding indexing for relationship attributes. It 
> makes use of edge_index in solr.
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java d63f361b 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
>  620ba101 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
>  036c566f 
>   
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java
>  43b95cae 
>   
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java
>  ed4099b8 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java
>  5b9c9330 
>   
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java
>  fbbfdef4 
>   
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java
>  3756382f 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  9f1206ca 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 8c886100 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
>  cf414bf4 
> 
> 
> Diff: https://reviews.apache.org/r/65329/diff/3/
> 
> 
> Testing
> ---
> 
> Verified in indexing backend (solr), indexes were created for relationship 
> attributes.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 65329: [ATLAS-2420]: Create indexes for relationship attributes

2018-01-28 Thread Sarath Subramanian 


> On Jan. 27, 2018, 10:43 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
> > Lines 347 (patched)
> > 
> >
> > line #347 should be removed - as this shouldn't be executed for 
> > relationship-type and it is already executed in line #344 for other types.

good catch! missed to remove it.


- Sarath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65329/#review196388
---


On Jan. 24, 2018, 4:56 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65329/
> ---
> 
> (Updated Jan. 24, 2018, 4:56 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2420
> https://issues.apache.org/jira/browse/ATLAS-2420
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently attributes and system attributes (guid)  of relationship is not 
> indexed. This Jira enables adding indexing for relationship attributes. It 
> makes use of edge_index in solr.
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java d63f361b 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
>  620ba101 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
>  036c566f 
>   
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java
>  43b95cae 
>   
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java
>  ed4099b8 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java
>  5b9c9330 
>   
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java
>  fbbfdef4 
>   
> graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java
>  3756382f 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  9f1206ca 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 8c886100 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
>  cf414bf4 
> 
> 
> Diff: https://reviews.apache.org/r/65329/diff/2/
> 
> 
> Testing
> ---
> 
> Verified in indexing backend (solr), indexes were created for relationship 
> attributes.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 65370: ATLAS-2421: updated Atlas notificaiton module to support V2 data structures

2018-01-28 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65370/
---

(Updated Jan. 28, 2018, 10:06 a.m.)


Review request for atlas.


Changes
---

updated HBase Atlas hook to use newly added V2 data-structure notifications


Bugs: ATLAS-2421
https://issues.apache.org/jira/browse/ATLAS-2421


Repository: atlas


Description
---

Following new notificaiton types are added: ENTITY_CREATE_V2, 
ENTITY_FULL_UPDATE_V2, ENTITY_PARTIAL_UPDATE_V2, ENTITY_DELETE_V2.


Diffs (updated)
-

  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
 8c7481af 
  
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookIT.java 
032cb518 
  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 24a3ef63 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java c0135f52 
  
notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java
 37a57d17 
  
notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java
 7a3bfe43 
  
notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java
 a25aa521 
  
notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java
 dd3257e0 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 2df28f33 


Diff: https://reviews.apache.org/r/65370/diff/2/

Changes: https://reviews.apache.org/r/65370/diff/1-2/


Testing
---

Added unit tests to validate SerDe for newly added notification types.


Thanks,

Madhan Neethiraj