Build failed in Jenkins: Atlas-0.8-IntegrationTests #175

2018-02-14 Thread Apache Jenkins Server
See 


Changes:

[nixon] ATLAS-2442:- Fix for read-only permission to allow read entity when http

--
[...truncated 494.29 KB...]
127.0.0.1 - - [15/Feb/2018:07:47:23 +] "POST /api/atlas/v2/types/typedefs 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:23 +] "GET 
/api/atlas/v2/entity/uniqueAttribute/type/hdfs_path?attr:qualifiedName=test%241test%2B%2B-%2B%26%26%2B%7C%7C%2B%21%2B%28%2B%29%2B%7B%2B%7D%2B%5B%2B%5D%2B%5E%2B%3C%2B%3E%2B%3B%2B%3A%2B%22%2B%25%2B*%2B%60%2B%7E
 HTTP/1.1" 404 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:23 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:28 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/search/fulltext?offset=0=dbeQ4zVSud2f=10 HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/search/fulltext?query=dbeQ4zVSud2f HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/search/fulltext?offset=0=dbeQ4zVSud2f=10 HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/search/fulltext?offset=1=dbeQ4zVSud2f=10 HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/search/fulltext?offset=0=dbeQ4zVSud2f=1 HTTP/1.1" 200 
- "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/search/fulltext?offset=2=dbeQ4zVSud2f=1 HTTP/1.1" 200 
- "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/tableType HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/serdeType HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/classification HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/pii_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/phi_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/pci_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/sox_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/sec_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/finance_Tag HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/FactozLaaq3ksx HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/ETLkVHaBfl2FX HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/DimensiongKbrbV3zvA HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/MetricXhaZGTpE6k HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/hive_db_v1 HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/hive_column_v1 HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:07:47:29 +] "GET 
/api/atlas/v2/types/typedef/name/hive_table_v1 HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - 

[jira] [Commented] (ATLAS-2448) Import: Performance Improvement by Using Configuration Parameters

2018-02-14 Thread Madhan Neethiraj (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365201#comment-16365201
 ] 

Madhan Neethiraj commented on ATLAS-2448:
-

+1 for the patch. Thanks [~ashutoshm].

> Import: Performance Improvement by Using Configuration Parameters
> -
>
> Key: ATLAS-2448
> URL: https://issues.apache.org/jira/browse/ATLAS-2448
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: ATLAS-2448-txn-default-parameters.patch
>
>
> *Background*
> During high volume data ingestions to Atlas the transactions performance 
> becomes is critical factor in contributing to overall performance of the 
> operation.
> Operations like Import and data ingestion via hooks are the ones affected by 
> transaction performance.
> *Approach*
> JanusGraph 
> [documentation|http://docs.janusgraph.org/latest/config-ref.html#_cache] 
> lists specific options for this. If these are applied by default will 
> performance of transaction commits. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (ATLAS-2442) User with read-only permission on entity resource not able perform basic search

2018-02-14 Thread Nixon Rodrigues (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365200#comment-16365200
 ] 

Nixon Rodrigues edited comment on ATLAS-2442 at 2/15/18 7:35 AM:
-

Thanks [~madhan.neethiraj] for review.

 

Committed patch on master and branch0.8

* master [http://git-wip-us.apache.org/repos/asf/atlas/commit/340f8637]

*  branch-0.8  [http://git-wip-us.apache.org/repos/asf/atlas/commit/435338cc]

 

 

 


was (Author: nixonrodrigues):
Thanks [~madhan.neethiraj] for review.

 

Committed patch on master and branch0.8

*master http://git-wip-us.apache.org/repos/asf/atlas/commit/340f8637

*branch-0.8  [http://git-wip-us.apache.org/repos/asf/atlas/commit/435338cc]

 

 

 

> User with read-only permission on entity resource not able perform basic 
> search
> ---
>
> Key: ATLAS-2442
> URL: https://issues.apache.org/jira/browse/ATLAS-2442
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8.2
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 1.0.0, 0.8.3
>
> Attachments: ATLAS-2442.patch
>
>
> Logged into Atlas as a read only user and fired basic search. Since Basic 
> search on UI is a POST request , Atlas throws 403 error. If Basic search is 
> fired using GET, search succeeds. In Atlas apart from creating entities, tags 
> , Basic search is also fired as POST request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2442) User with read-only permission on entity resource not able perform basic search

2018-02-14 Thread Nixon Rodrigues (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-2442:
---
Fix Version/s: 1.0.0

> User with read-only permission on entity resource not able perform basic 
> search
> ---
>
> Key: ATLAS-2442
> URL: https://issues.apache.org/jira/browse/ATLAS-2442
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8.2
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 1.0.0, 0.8.3
>
> Attachments: ATLAS-2442.patch
>
>
> Logged into Atlas as a read only user and fired basic search. Since Basic 
> search on UI is a POST request , Atlas throws 403 error. If Basic search is 
> fired using GET, search succeeds. In Atlas apart from creating entities, tags 
> , Basic search is also fired as POST request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Build failed in Jenkins: Atlas-master-IntegrationTests #528

2018-02-14 Thread Apache Jenkins Server
See 


--
[...truncated 626.83 KB...]
at 
org.apache.atlas.hive.HiveITBase.assertTableIsRegistered(HiveITBase.java:153)
at 
org.apache.atlas.hive.hook.HiveHookIT.testDropView(HiveHookIT.java:1528)

testExportImportPartitionedTable(org.apache.atlas.hive.hook.HiveHookIT)  Time 
elapsed: 10.978 sec  <<< FAILURE!
java.lang.AssertionError: expected 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/export-data-y3vk1em2sz]
 but found 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/export-data-y3vk1em2sz@primary]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:167)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateTables(HiveHookIT.java:270)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateOutputTables(HiveHookIT.java:253)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:498)
at 
org.apache.atlas.hive.hook.HiveHookIT.testExportImportPartitionedTable(HiveHookIT.java:789)

testExportImportUnPartitionedTable(org.apache.atlas.hive.hook.HiveHookIT)  Time 
elapsed: 85.429 sec  <<< FAILURE!
java.lang.AssertionError: Assertions failed. Failing after waiting for timeout 
8 msecs
at 
org.apache.atlas.AtlasBaseClient.callAPIWithResource(AtlasBaseClient.java:388)
at 
org.apache.atlas.AtlasBaseClient.callAPIWithResource(AtlasBaseClient.java:323)
at 
org.apache.atlas.AtlasBaseClient.callAPIWithRetries(AtlasBaseClient.java:472)
at org.apache.atlas.AtlasClient.callAPIWithRetries(AtlasClient.java:931)
at org.apache.atlas.AtlasClient.getEntity(AtlasClient.java:640)
at org.apache.atlas.hive.HiveITBase$1.evaluate(HiveITBase.java:168)
at org.apache.atlas.hive.HiveITBase.waitFor(HiveITBase.java:205)
at 
org.apache.atlas.hive.HiveITBase.assertEntityIsRegistered(HiveITBase.java:165)
at 
org.apache.atlas.hive.hook.HiveHookIT.assertProcessIsRegistered(HiveHookIT.java:1737)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:485)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:505)
at 
org.apache.atlas.hive.hook.HiveHookIT.testExportImportUnPartitionedTable(HiveHookIT.java:736)

testInsertIntoDFSDirPartitioned(org.apache.atlas.hive.hook.HiveHookIT)  Time 
elapsed: 7.172 sec  <<< FAILURE!
java.lang.AssertionError: expected 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/somedfspath1-data-0etkmj1jog]
 but found 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/somedfspath1-data-0etkmj1jog@primary]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:167)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateTables(HiveHookIT.java:270)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateOutputTables(HiveHookIT.java:253)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:498)
at 
org.apache.atlas.hive.hook.HiveHookIT.testInsertIntoDFSDirPartitioned(HiveHookIT.java:636)

testLoadDFSPathPartitioned(org.apache.atlas.hive.hook.HiveHookIT)  Time 
elapsed: 10.543 sec  <<< FAILURE!
java.lang.AssertionError: expected 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/loaddfsfile-data-wdlw5npyit]
 but found 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/loaddfsfile-data-wdlw5npyit@primary]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:167)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateTables(HiveHookIT.java:270)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateInputTables(HiveHookIT.java:257)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:491)
at 
org.apache.atlas.hive.hook.HiveHookIT.testLoadDFSPathPartitioned(HiveHookIT.java:458)

testUpdateProcess(org.apache.atlas.hive.hook.HiveHookIT)  Time elapsed: 7.256 
sec  <<< FAILURE!
java.lang.AssertionError: expected 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/somedfspath1-data-zubckgwkc0]
 but found 

Build failed in Jenkins: Atlas-master-IntegrationTests #525

2018-02-14 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-2447: DSL improvement in handling of select clause

[madhan] ATLAS-2446: updated HBase Model to capture more attributes of table and

--
[...truncated 627.79 KB...]
at 
org.apache.atlas.hive.HiveITBase.assertTableIsRegistered(HiveITBase.java:153)
at 
org.apache.atlas.hive.hook.HiveHookIT.testDropView(HiveHookIT.java:1528)

testExportImportPartitionedTable(org.apache.atlas.hive.hook.HiveHookIT)  Time 
elapsed: 11.323 sec  <<< FAILURE!
java.lang.AssertionError: expected 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/export-data-dlrrtu5sr0]
 but found 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/export-data-dlrrtu5sr0@primary]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:167)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateTables(HiveHookIT.java:270)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateOutputTables(HiveHookIT.java:253)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:498)
at 
org.apache.atlas.hive.hook.HiveHookIT.testExportImportPartitionedTable(HiveHookIT.java:789)

testExportImportUnPartitionedTable(org.apache.atlas.hive.hook.HiveHookIT)  Time 
elapsed: 85.514 sec  <<< FAILURE!
java.lang.AssertionError: Assertions failed. Failing after waiting for timeout 
8 msecs
at 
org.apache.atlas.AtlasBaseClient.callAPIWithResource(AtlasBaseClient.java:388)
at 
org.apache.atlas.AtlasBaseClient.callAPIWithResource(AtlasBaseClient.java:323)
at 
org.apache.atlas.AtlasBaseClient.callAPIWithRetries(AtlasBaseClient.java:472)
at org.apache.atlas.AtlasClient.callAPIWithRetries(AtlasClient.java:931)
at org.apache.atlas.AtlasClient.getEntity(AtlasClient.java:640)
at org.apache.atlas.hive.HiveITBase$1.evaluate(HiveITBase.java:168)
at org.apache.atlas.hive.HiveITBase.waitFor(HiveITBase.java:205)
at 
org.apache.atlas.hive.HiveITBase.assertEntityIsRegistered(HiveITBase.java:165)
at 
org.apache.atlas.hive.hook.HiveHookIT.assertProcessIsRegistered(HiveHookIT.java:1737)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:485)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:505)
at 
org.apache.atlas.hive.hook.HiveHookIT.testExportImportUnPartitionedTable(HiveHookIT.java:736)

testInsertIntoDFSDirPartitioned(org.apache.atlas.hive.hook.HiveHookIT)  Time 
elapsed: 7.177 sec  <<< FAILURE!
java.lang.AssertionError: expected 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/somedfspath1-data-jxtrzmkfpa]
 but found 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/somedfspath1-data-jxtrzmkfpa@primary]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:167)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateTables(HiveHookIT.java:270)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateOutputTables(HiveHookIT.java:253)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:498)
at 
org.apache.atlas.hive.hook.HiveHookIT.testInsertIntoDFSDirPartitioned(HiveHookIT.java:636)

testLoadDFSPathPartitioned(org.apache.atlas.hive.hook.HiveHookIT)  Time 
elapsed: 10.608 sec  <<< FAILURE!
java.lang.AssertionError: expected 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/loaddfsfile-data-x1vuycgatd]
 but found 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/loaddfsfile-data-x1vuycgatd@primary]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:167)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateTables(HiveHookIT.java:270)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateInputTables(HiveHookIT.java:257)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:491)
at 
org.apache.atlas.hive.hook.HiveHookIT.testLoadDFSPathPartitioned(HiveHookIT.java:458)

testUpdateProcess(org.apache.atlas.hive.hook.HiveHookIT)  Time elapsed: 7.583 
sec  <<< FAILURE!
java.lang.AssertionError: expected 

Build failed in Jenkins: Atlas-0.8-IntegrationTests #174

2018-02-14 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-2446: updated HBase Model to capture more attributes of table and

--
[...truncated 498.29 KB...]
127.0.0.1 - - [15/Feb/2018:00:51:50 +] "DELETE 
/api/atlas/entities?guid=d78419b0-3609-4e78-9824-2a7f507928b8=e3139acc-8f99-4f9d-b54f-dd8a7862869c
 HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:50 +] "GET 
/api/atlas/entities/e3139acc-8f99-4f9d-b54f-dd8a7862869c HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:50 +] "GET 
/api/atlas/entities/d78419b0-3609-4e78-9824-2a7f507928b8 HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:50 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "DELETE 
/api/atlas/entities?guid=18ac1b87-5c6e-4da7-92ec-a4e8aec0d825=fdcdb435-9875-484c-b0b1-3f735fabcaa6
 HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "GET 
/api/atlas/entities/fdcdb435-9875-484c-b0b1-3f735fabcaa6 HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "GET 
/api/atlas/entities/18ac1b87-5c6e-4da7-92ec-a4e8aec0d825 HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "DELETE 
/api/atlas/entities?type=hive_db=qualifiedName=Rht4P0SakX 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "GET 
/api/atlas/entities/2ff802f3-08aa-4bc1-b5f7-6ecebcf5cd31 HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "GET 
/api/atlas/v2/types/typedef/name/PII_TraitIgwK2GjNGv HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "DELETE 
/api/atlas/entities/d9177847-e6ab-4662-943e-4a5be12fdcaa/traits/PII_TraitIgwK2GjNGv
 HTTP/1.1" 404 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:51 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "GET 
/api/atlas/v2/types/typedef/name/PII_TraitXLWczJ7AzZ HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "POST 
/api/atlas/entities/9163553d-7554-42df-a7fb-2bbd2873221c/traits HTTP/1.1" 201 - 
"-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "GET 
/api/atlas/entities/9163553d-7554-42df-a7fb-2bbd2873221c/audit?count=100 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "DELETE 
/api/atlas/entities/9163553d-7554-42df-a7fb-2bbd2873221c/traits/PII_TraitXLWczJ7AzZ
 HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "GET 
/api/atlas/entities/9163553d-7554-42df-a7fb-2bbd2873221c/traitDefinitions/PII_TraitXLWczJ7AzZ
 HTTP/1.1" 404 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "GET 
/api/atlas/entities/9163553d-7554-42df-a7fb-2bbd2873221c/audit?count=100 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "DELETE 
/api/atlas/entities/3dc3e152-8e24-498d-bb45-ae4c05f0ecab/traits/blah_trait 
HTTP/1.1" 404 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "GET 
/api/atlas/entities/7d077912-2fff-4646-89ec-8e864bbdefc9/audit?count=100 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:52 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db+where+qualifiedName%3D'dbpHdChm63CA'=10=0
 HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:53 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:53 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db+where+qualifiedName%3D'dbpHdChm63CA'=10=0
 HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:54 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [15/Feb/2018:00:51:54 +] 

[jira] [Updated] (ATLAS-2446) HBase model should capture more attributes for table & column-family

2018-02-14 Thread Madhan Neethiraj (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-2446:

Summary: HBase model should capture more attributes for table & 
column-family  (was: Hbase Model to have more HBase specific attributes.)

> HBase model should capture more attributes for table & column-family
> 
>
> Key: ATLAS-2446
> URL: https://issues.apache.org/jira/browse/ATLAS-2446
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-intg
>Affects Versions: trunk, 0.8.1
>Reporter: Sharmadha Sainath
>Assignee: Ramesh Mani
>Priority: Major
> Fix For: 1.0.0, 0.8.3
>
>
> Hbase Model to have more HBase specific attributes.
> {code:java}
> // code placeholder
> {NAME => 'col_fam_1', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false', 
> NEW_VERSION_BEHAVIOR => 'false', KEEP_DELETED_CELLS => 'FALSE', 
> CACHE_DATA_ON_WRITE => 'false', DATA_
> BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', 
> REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', CACHE_INDEX_ON_WRITE => 
> 'false', IN_MEMORY => 'false',
>  CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false', 
> COMPRESSION => 'NONE', BLOCKCACHE => 'false', BLOCKSIZE => '65536'}
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ATLAS-2446) Hbase Model to have more HBase specific attributes.

2018-02-14 Thread Madhan Neethiraj (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj resolved ATLAS-2446.
-
   Resolution: Fixed
Fix Version/s: (was: 0.8.1)
   (was: trunk)
   0.8.3
   1.0.0

Committed to following branches:
 - master: http://git-wip-us.apache.org/repos/asf/atlas/commit/19d67a13
 - branch-0.8: http://git-wip-us.apache.org/repos/asf/atlas/commit/043ab72b

> Hbase Model to have more HBase specific attributes.
> ---
>
> Key: ATLAS-2446
> URL: https://issues.apache.org/jira/browse/ATLAS-2446
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-intg
>Affects Versions: trunk, 0.8.1
>Reporter: Sharmadha Sainath
>Assignee: Ramesh Mani
>Priority: Major
> Fix For: 1.0.0, 0.8.3
>
>
> Hbase Model to have more HBase specific attributes.
> {code:java}
> // code placeholder
> {NAME => 'col_fam_1', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false', 
> NEW_VERSION_BEHAVIOR => 'false', KEEP_DELETED_CELLS => 'FALSE', 
> CACHE_DATA_ON_WRITE => 'false', DATA_
> BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', 
> REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', CACHE_INDEX_ON_WRITE => 
> 'false', IN_MEMORY => 'false',
>  CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false', 
> COMPRESSION => 'NONE', BLOCKCACHE => 'false', BLOCKSIZE => '65536'}
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 65662: ATLAS-2446: Hbase Model to have more HBase specific attributes.

2018-02-14 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65662/#review197600
---


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 14, 2018, 10:46 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65662/
> ---
> 
> (Updated Feb. 14, 2018, 10:46 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2446
> https://issues.apache.org/jira/browse/ATLAS-2446
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2446: Hbase Model to have more HBase specific attributes.
> 
> 
> Diffs
> -
> 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
>  f839f87 
>   
> addons/models/1000-Hadoop/patches/005-hbase_table_column_family_add_additional_attribute.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65662/diff/1/
> 
> 
> Testing
> ---
> 
> Testing done in Local vm. Fixed one issue with Create / modified time update 
> also with this patch.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>



[jira] [Updated] (ATLAS-2446) Hbase Model to have more HBase specific attributes.

2018-02-14 Thread Madhan Neethiraj (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-2446:

Reporter: Sharmadha Sainath  (was: Ramesh Mani)

> Hbase Model to have more HBase specific attributes.
> ---
>
> Key: ATLAS-2446
> URL: https://issues.apache.org/jira/browse/ATLAS-2446
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-intg
>Affects Versions: trunk, 0.8.1
>Reporter: Sharmadha Sainath
>Assignee: Ramesh Mani
>Priority: Major
> Fix For: trunk, 0.8.1
>
>
> Hbase Model to have more HBase specific attributes.
> {code:java}
> // code placeholder
> {NAME => 'col_fam_1', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false', 
> NEW_VERSION_BEHAVIOR => 'false', KEEP_DELETED_CELLS => 'FALSE', 
> CACHE_DATA_ON_WRITE => 'false', DATA_
> BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', 
> REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', CACHE_INDEX_ON_WRITE => 
> 'false', IN_MEMORY => 'false',
>  CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false', 
> COMPRESSION => 'NONE', BLOCKCACHE => 'false', BLOCKSIZE => '65536'}
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-2246) Define OMRS Connector interface

2018-02-14 Thread Jerry He (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364993#comment-16364993
 ] 

Jerry He commented on ATLAS-2246:
-

Hi, Mandy

In the patch, there is a OMRSOperationalServices class which initializes the 
OMRS components (connectors, etc).  Are you going to have a separate patch for 
the the container of these services (the caller of the initialize method)?  I 
see you mentioned somewhere OMAG Server.

> Define OMRS Connector interface
> ---
>
> Key: ATLAS-2246
> URL: https://issues.apache.org/jira/browse/ATLAS-2246
> Project: Atlas
>  Issue Type: Sub-task
>  Components: atlas-intg
>Reporter: Mandy Chessell
>Assignee: Mandy Chessell
>Priority: Critical
> Attachments: 
> 0001-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch, OMRS 
> Javadoc.zip
>
>
> This task covers the creation of the OMRS Connector APIs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2447) Advanced Search DSL: Improve Select Queries Using De-duplication During Query Formation

2018-02-14 Thread Madhan Neethiraj (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-2447:

Affects Version/s: (was: trunk)
   1.0.0-alpha

> Advanced Search DSL: Improve Select Queries Using De-duplication During Query 
> Formation
> ---
>
> Key: ATLAS-2447
> URL: https://issues.apache.org/jira/browse/ATLAS-2447
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 1.0.0-alpha
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2447-Added-Dedup.patch
>
>
> In the provided Atlas instance , there are many 1000+ hive_table entities .
> Few of them :
> db2.table1
> db1.table1
> db1.table2 
> db3.table2
> DSL query :
> {code:java}
> typename = hive_table
> query = name > "table1"
> {code}
> listed all the hive_table entities whose name>"table1" ,
> With limit 25 per page ,
> db3.table2 is in 19th page (467th entity)
> db1.table2 is in 21st page (521th entity)
> *+Error scenario :+*
> DSL query :
> {code:java}
> typename = hive_db
> query = where name > "table1" select db
> {code}
> limit = 25 , lists only 1 db .
> Expected that it would result db3 and db1 along with other db's since 
> "table2" is greater than "table1" and "table2" is in db3 and db1.
> when same query with limit =1000 , lists many results along with db1 and db3.
> When limit is 25 , "select db" is done on the returned 25 results of "name > 
> table1" and selects the db.
> Since table2 doesn't appear in the first 25 entities , db3 and db1 didn't 
> result.
> Attaching the screenshots for limit 1 and limit 25.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ATLAS-2447) Advanced Search DSL: Improve Select Queries Using De-duplication During Query Formation

2018-02-14 Thread Madhan Neethiraj (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj resolved ATLAS-2447.
-
   Resolution: Fixed
Fix Version/s: (was: trunk)
   1.0.0

Committed to master: 
http://git-wip-us.apache.org/repos/asf/atlas/commit/a2ccdf12

> Advanced Search DSL: Improve Select Queries Using De-duplication During Query 
> Formation
> ---
>
> Key: ATLAS-2447
> URL: https://issues.apache.org/jira/browse/ATLAS-2447
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 1.0.0-alpha
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2447-Added-Dedup.patch
>
>
> In the provided Atlas instance , there are many 1000+ hive_table entities .
> Few of them :
> db2.table1
> db1.table1
> db1.table2 
> db3.table2
> DSL query :
> {code:java}
> typename = hive_table
> query = name > "table1"
> {code}
> listed all the hive_table entities whose name>"table1" ,
> With limit 25 per page ,
> db3.table2 is in 19th page (467th entity)
> db1.table2 is in 21st page (521th entity)
> *+Error scenario :+*
> DSL query :
> {code:java}
> typename = hive_db
> query = where name > "table1" select db
> {code}
> limit = 25 , lists only 1 db .
> Expected that it would result db3 and db1 along with other db's since 
> "table2" is greater than "table1" and "table2" is in db3 and db1.
> when same query with limit =1000 , lists many results along with db1 and db3.
> When limit is 25 , "select db" is done on the returned 25 results of "name > 
> table1" and selects the db.
> Since table2 doesn't appear in the first 25 entities , db3 and db1 didn't 
> result.
> Attaching the screenshots for limit 1 and limit 25.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 65659: Advanced Search: DSL: Improved Select Clause and Error Handling

2018-02-14 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65659/#review197597
---


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 14, 2018, 10:12 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65659/
> ---
> 
> (Updated Feb. 14, 2018, 10:12 p.m.)
> 
> 
> Review request for atlas and Apoorv Naik.
> 
> 
> Bugs: ATLAS-2447
> https://issues.apache.org/jira/browse/ATLAS-2447
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Within _GremlinQueryComposer_ the gremlin query construction used a 
> combination of _limit_ and _limit-local_ for limiting results. This caused 
> some scenarios to fail. See bug for details.
> 
> Also, if there was any exception within the Gremlin script engine, it would 
> not display the exact cause of the failure. This caused users  not to know 
> the exact problem with the constructed query.
> 
> **Approach**
> * _GremlinClause_: Replaced _limit-local_ with _dedup_.
> * Added exception handling to display cause of exception if available.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4a18ed13 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java c770f77e 
>   repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
> 92029f56 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 82b73812 
>   
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 
> 85addc26 
> 
> 
> Diff: https://reviews.apache.org/r/65659/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - Additional tests added to verify error scenarios when comparing floats with 
> values larger than max float.
> - Updated unit tests to reflect the new _dedup_ usage within the query 
> composition.
> 
> **Functional tests**
> - Executed scenarios to view new error messages.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>



Build failed in Jenkins: Atlas-master-IntegrationTests #524

2018-02-14 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-2444: Atlas changes for HDFS NameNode federation

--
[...truncated 625.61 KB...]
at org.apache.atlas.hive.HiveITBase$1.evaluate(HiveITBase.java:168)
at org.apache.atlas.hive.HiveITBase.waitFor(HiveITBase.java:205)
at 
org.apache.atlas.hive.HiveITBase.assertEntityIsRegistered(HiveITBase.java:165)
at 
org.apache.atlas.hive.HiveITBase.assertTableIsRegistered(HiveITBase.java:159)
at 
org.apache.atlas.hive.HiveITBase.assertTableIsRegistered(HiveITBase.java:153)
at 
org.apache.atlas.hive.hook.HiveHookIT.testDropView(HiveHookIT.java:1528)

testExportImportPartitionedTable(org.apache.atlas.hive.hook.HiveHookIT)  Time 
elapsed: 10.788 sec  <<< FAILURE!
java.lang.AssertionError: expected 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/export-data-5sfxxwsamw]
 but found 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/export-data-5sfxxwsamw@primary]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:167)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateTables(HiveHookIT.java:270)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateOutputTables(HiveHookIT.java:253)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:498)
at 
org.apache.atlas.hive.hook.HiveHookIT.testExportImportPartitionedTable(HiveHookIT.java:789)

testExportImportUnPartitionedTable(org.apache.atlas.hive.hook.HiveHookIT)  Time 
elapsed: 85.543 sec  <<< FAILURE!
java.lang.AssertionError: Assertions failed. Failing after waiting for timeout 
8 msecs
at 
org.apache.atlas.AtlasBaseClient.callAPIWithResource(AtlasBaseClient.java:388)
at 
org.apache.atlas.AtlasBaseClient.callAPIWithResource(AtlasBaseClient.java:323)
at 
org.apache.atlas.AtlasBaseClient.callAPIWithRetries(AtlasBaseClient.java:472)
at org.apache.atlas.AtlasClient.callAPIWithRetries(AtlasClient.java:931)
at org.apache.atlas.AtlasClient.getEntity(AtlasClient.java:640)
at org.apache.atlas.hive.HiveITBase$1.evaluate(HiveITBase.java:168)
at org.apache.atlas.hive.HiveITBase.waitFor(HiveITBase.java:205)
at 
org.apache.atlas.hive.HiveITBase.assertEntityIsRegistered(HiveITBase.java:165)
at 
org.apache.atlas.hive.hook.HiveHookIT.assertProcessIsRegistered(HiveHookIT.java:1737)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:485)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:505)
at 
org.apache.atlas.hive.hook.HiveHookIT.testExportImportUnPartitionedTable(HiveHookIT.java:736)

testInsertIntoDFSDirPartitioned(org.apache.atlas.hive.hook.HiveHookIT)  Time 
elapsed: 7.4 sec  <<< FAILURE!
java.lang.AssertionError: expected 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/somedfspath1-data-fnoeh2qkhl]
 but found 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/somedfspath1-data-fnoeh2qkhl@primary]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:167)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateTables(HiveHookIT.java:270)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateOutputTables(HiveHookIT.java:253)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:498)
at 
org.apache.atlas.hive.hook.HiveHookIT.testInsertIntoDFSDirPartitioned(HiveHookIT.java:636)

testLoadDFSPathPartitioned(org.apache.atlas.hive.hook.HiveHookIT)  Time 
elapsed: 10.607 sec  <<< FAILURE!
java.lang.AssertionError: expected 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/loaddfsfile-data-p9b6n2biuw]
 but found 
[pfile:/home/jenkins/jenkins-slave/workspace/atlas-master-integrationtests/addons/hive-bridge/target/loaddfsfile-data-p9b6n2biuw@primary]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:167)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateTables(HiveHookIT.java:270)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateInputTables(HiveHookIT.java:257)
at 
org.apache.atlas.hive.hook.HiveHookIT.validateProcess(HiveHookIT.java:491)
at 

Review Request 65662: ATLAS-2446: Hbase Model to have more HBase specific attributes.

2018-02-14 Thread Ramesh Mani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65662/
---

Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-2446
https://issues.apache.org/jira/browse/ATLAS-2446


Repository: atlas


Description
---

ATLAS-2446: Hbase Model to have more HBase specific attributes.


Diffs
-

  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
 f839f87 
  
addons/models/1000-Hadoop/patches/005-hbase_table_column_family_add_additional_attribute.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65662/diff/1/


Testing
---

Testing done in Local vm. Fixed one issue with Create / modified time update 
also with this patch.


Thanks,

Ramesh Mani



[jira] [Updated] (ATLAS-2444) HDFS NameNode Federation support

2018-02-14 Thread Madhan Neethiraj (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-2444:

Description: 
With Hadoop 3, HDFS supports multiple namespaces; each namespace is serviced by 
a cluster of name-nodes identified by a nameServiceId. HDFS path entity in 
Atlas should be updated to capture the the nameServiceId of the namenode 
cluster for the path. Also, references to individual namenode in the path 
should be replaced with corresponding nameServiceID.

Changes:
 # HDFS model to include a new attribute called nameServiceId, default will be 
empty
 # hdfs path's qualified name will include the cluster info as well
 # All Hooks dealing with HDFS path will resolve the host:port to the 
respective nameServiceId

  was:
With Hadoop 3, HDFS is introducing namespace/nameServiceId for data 
segregation. 

A cluster with hadoop 3 deployment can have multiple name nodes under a single 
name space and multiple namespace/nameserviceIds as well.

This metadata can be captured for other interested application/parties, eg. 
Ranger can use this to enforce policies per Namespace.

 

Changes:

 
 # HDFS model to include a new attribute called nameServiceId, default will be 
empty
 # hdfs path's qualified name will include the cluster info as well
 # All Hooks dealing with HDFS path will resolve the host:port to the 
respective nameServiceId


> HDFS NameNode Federation support
> 
>
> Key: ATLAS-2444
> URL: https://issues.apache.org/jira/browse/ATLAS-2444
> Project: Atlas
>  Issue Type: Bug
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.0.0
>
>
> With Hadoop 3, HDFS supports multiple namespaces; each namespace is serviced 
> by a cluster of name-nodes identified by a nameServiceId. HDFS path entity in 
> Atlas should be updated to capture the the nameServiceId of the namenode 
> cluster for the path. Also, references to individual namenode in the path 
> should be replaced with corresponding nameServiceID.
> Changes:
>  # HDFS model to include a new attribute called nameServiceId, default will 
> be empty
>  # hdfs path's qualified name will include the cluster info as well
>  # All Hooks dealing with HDFS path will resolve the host:port to the 
> respective nameServiceId



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ATLAS-2444) HDFS NameNode Federation support

2018-02-14 Thread Madhan Neethiraj (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj resolved ATLAS-2444.
-
   Resolution: Fixed
 Assignee: Apoorv Naik
Fix Version/s: 1.0.0

Committed to master: 
http://git-wip-us.apache.org/repos/asf/atlas/commit/3ec37cae

> HDFS NameNode Federation support
> 
>
> Key: ATLAS-2444
> URL: https://issues.apache.org/jira/browse/ATLAS-2444
> Project: Atlas
>  Issue Type: Bug
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.0.0
>
>
> With Hadoop 3, HDFS is introducing namespace/nameServiceId for data 
> segregation. 
> A cluster with hadoop 3 deployment can have multiple name nodes under a 
> single name space and multiple namespace/nameserviceIds as well.
> This metadata can be captured for other interested application/parties, eg. 
> Ranger can use this to enforce policies per Namespace.
>  
> Changes:
>  
>  # HDFS model to include a new attribute called nameServiceId, default will 
> be empty
>  # hdfs path's qualified name will include the cluster info as well
>  # All Hooks dealing with HDFS path will resolve the host:port to the 
> respective nameServiceId



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 65647: ATLAS-2444: HDFS namenode federation support

2018-02-14 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65647/#review197586
---


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 14, 2018, 9:34 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65647/
> ---
> 
> (Updated Feb. 14, 2018, 9:34 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2444
> https://issues.apache.org/jira/browse/ATLAS-2444
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> See ATLAS-2444
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  7cca48f11 
>   addons/models/1000-Hadoop/1020-fs_model.json ff17261bc 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
>  57fc7a1fd 
>   common/pom.xml a7ab6a312 
>   common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/utils/HdfsNameServiceResolverTest.java 
> PRE-CREATION 
>   common/src/test/resources/atlas-log4j.xml PRE-CREATION 
>   common/src/test/resources/hdfs-site.xml PRE-CREATION 
>   pom.xml c15e0dad7 
> 
> 
> Diff: https://reviews.apache.org/r/65647/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean package executes successfully.
> 
> The modified war was tested on a multi-node cluster with one nameServiceId 
> and 2 NameNodes, the required information was captured successfully in the 
> entity when an external table was created from beeline (hive context)
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>



[jira] [Updated] (ATLAS-2448) Import: Performance Improvement by Using Configuration Parameters

2018-02-14 Thread Ashutosh Mestry (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-2448:
---
Attachment: ATLAS-2448-txn-default-parameters.patch

> Import: Performance Improvement by Using Configuration Parameters
> -
>
> Key: ATLAS-2448
> URL: https://issues.apache.org/jira/browse/ATLAS-2448
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: ATLAS-2448-txn-default-parameters.patch
>
>
> *Background*
> During high volume data ingestions to Atlas the transactions performance 
> becomes is critical factor in contributing to overall performance of the 
> operation.
> Operations like Import and data ingestion via hooks are the ones affected by 
> transaction performance.
> *Approach*
> JanusGraph 
> [documentation|http://docs.janusgraph.org/latest/config-ref.html#_cache] 
> lists specific options for this. If these are applied by default will 
> performance of transaction commits. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2448) Import: Performance Improvement by Using Configuration Parameters

2018-02-14 Thread Ashutosh Mestry (JIRA)
Ashutosh Mestry created ATLAS-2448:
--

 Summary: Import: Performance Improvement by Using Configuration 
Parameters
 Key: ATLAS-2448
 URL: https://issues.apache.org/jira/browse/ATLAS-2448
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: trunk
Reporter: Ashutosh Mestry
Assignee: Ashutosh Mestry
 Fix For: trunk


*Background*

During high volume data ingestions to Atlas the transactions performance 
becomes is critical factor in contributing to overall performance of the 
operation.

Operations like Import and data ingestion via hooks are the ones affected by 
transaction performance.

*Approach*

JanusGraph 
[documentation|http://docs.janusgraph.org/latest/config-ref.html#_cache] lists 
specific options for this. If these are applied by default will performance of 
transaction commits. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 65659: Advanced Search: DSL: Improved Select Clause and Error Handling

2018-02-14 Thread Ashutosh Mestry

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65659/
---

Review request for atlas and Apoorv Naik.


Bugs: ATLAS-2447
https://issues.apache.org/jira/browse/ATLAS-2447


Repository: atlas


Description
---

**Background**
Within _GremlinQueryComposer_ the gremlin query construction used a combination 
of _limit_ and _limit-local_ for limiting results. This caused some scenarios 
to fail. See bug for details.

Also, if there was any exception within the Gremlin script engine, it would not 
display the exact cause of the failure. This caused users  not to know the 
exact problem with the constructed query.

**Approach**
* _GremlinClause_: Replaced _limit-local_ with _dedup_.
* Added exception handling to display cause of exception if available.


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
4a18ed13 
  repository/src/main/java/org/apache/atlas/query/GremlinClause.java c770f77e 
  repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
92029f56 
  repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 82b73812 
  repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 
85addc26 


Diff: https://reviews.apache.org/r/65659/diff/1/


Testing
---

**Unit tests**
- Additional tests added to verify error scenarios when comparing floats with 
values larger than max float.
- Updated unit tests to reflect the new _dedup_ usage within the query 
composition.

**Functional tests**
- Executed scenarios to view new error messages.


Thanks,

Ashutosh Mestry



[jira] [Updated] (ATLAS-2447) Advanced Search DSL: Improve Select Queries Using De-duplication During Query Formation

2018-02-14 Thread Ashutosh Mestry (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-2447:
---
Attachment: ATLAS-2447-Added-Dedup.patch

> Advanced Search DSL: Improve Select Queries Using De-duplication During Query 
> Formation
> ---
>
> Key: ATLAS-2447
> URL: https://issues.apache.org/jira/browse/ATLAS-2447
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: ATLAS-2447-Added-Dedup.patch
>
>
> In the provided Atlas instance , there are many 1000+ hive_table entities .
> Few of them :
> db2.table1
> db1.table1
> db1.table2 
> db3.table2
> DSL query :
> {code:java}
> typename = hive_table
> query = name > "table1"
> {code}
> listed all the hive_table entities whose name>"table1" ,
> With limit 25 per page ,
> db3.table2 is in 19th page (467th entity)
> db1.table2 is in 21st page (521th entity)
> *+Error scenario :+*
> DSL query :
> {code:java}
> typename = hive_db
> query = where name > "table1" select db
> {code}
> limit = 25 , lists only 1 db .
> Expected that it would result db3 and db1 along with other db's since 
> "table2" is greater than "table1" and "table2" is in db3 and db1.
> when same query with limit =1000 , lists many results along with db1 and db3.
> When limit is 25 , "select db" is done on the returned 25 results of "name > 
> table1" and selects the db.
> Since table2 doesn't appear in the first 25 entities , db3 and db1 didn't 
> result.
> Attaching the screenshots for limit 1 and limit 25.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2447) Advanced Search DSL: Improve Select Queries Using De-duplication During Query Formation

2018-02-14 Thread Ashutosh Mestry (JIRA)
Ashutosh Mestry created ATLAS-2447:
--

 Summary: Advanced Search DSL: Improve Select Queries Using 
De-duplication During Query Formation
 Key: ATLAS-2447
 URL: https://issues.apache.org/jira/browse/ATLAS-2447
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: trunk
Reporter: Ashutosh Mestry
Assignee: Ashutosh Mestry
 Fix For: trunk


In the provided Atlas instance , there are many 1000+ hive_table entities .

Few of them :
db2.table1
db1.table1
db1.table2 
db3.table2

DSL query :
{code:java}
typename = hive_table
query = name > "table1"
{code}
listed all the hive_table entities whose name>"table1" ,

With limit 25 per page ,
db3.table2 is in 19th page (467th entity)
db1.table2 is in 21st page (521th entity)

*+Error scenario :+*
DSL query :
{code:java}
typename = hive_db
query = where name > "table1" select db
{code}
limit = 25 , lists only 1 db .

Expected that it would result db3 and db1 along with other db's since "table2" 
is greater than "table1" and "table2" is in db3 and db1.

when same query with limit =1000 , lists many results along with db1 and db3.

When limit is 25 , "select db" is done on the returned 25 results of "name > 
table1" and selects the db.

Since table2 doesn't appear in the first 25 entities , db3 and db1 didn't 
result.

Attaching the screenshots for limit 1 and limit 25.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 65647: ATLAS-2444: HDFS namenode federation support

2018-02-14 Thread Apoorv Naik

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65647/
---

(Updated Feb. 14, 2018, 9:34 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Changes
---

Refactoring around caching, moved all Constants into Resolver class and updated 
the path.replace to StringUtils.replaceOnce(...) to avoid replacing other values


Bugs: ATLAS-2444
https://issues.apache.org/jira/browse/ATLAS-2444


Repository: atlas


Description
---

See ATLAS-2444


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 7cca48f11 
  addons/models/1000-Hadoop/1020-fs_model.json ff17261bc 
  
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
 57fc7a1fd 
  common/pom.xml a7ab6a312 
  common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/utils/HdfsNameServiceResolverTest.java 
PRE-CREATION 
  common/src/test/resources/atlas-log4j.xml PRE-CREATION 
  common/src/test/resources/hdfs-site.xml PRE-CREATION 
  pom.xml c15e0dad7 


Diff: https://reviews.apache.org/r/65647/diff/3/

Changes: https://reviews.apache.org/r/65647/diff/2-3/


Testing
---

mvn clean package executes successfully.

The modified war was tested on a multi-node cluster with one nameServiceId and 
2 NameNodes, the required information was captured successfully in the entity 
when an external table was created from beeline (hive context)


Thanks,

Apoorv Naik



Build failed in Jenkins: Atlas-0.8-IntegrationTests #173

2018-02-14 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-2445: updated HBase hook to handle table-clone and

--
[...truncated 528.30 KB...]
127.0.0.1 - - [14/Feb/2018:20:49:41 +] "GET 
/api/atlas/v2/types/typedef/name/hive_table_v2 HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:41 +] "GET 
/api/atlas/v2/types/typedef/name/hive_process_v2 HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:41 +] "GET 
/api/atlas/v2/types/typedef/name/classification HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:41 +] "GET 
/api/atlas/v2/types/typedef/name/pii_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:41 +] "GET 
/api/atlas/v2/types/typedef/name/phi_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:41 +] "GET 
/api/atlas/v2/types/typedef/name/pci_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:41 +] "GET 
/api/atlas/v2/types/typedef/name/sox_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:41 +] "GET 
/api/atlas/v2/types/typedef/name/sec_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:41 +] "GET 
/api/atlas/v2/types/typedef/name/finance_Tag HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:41 +] "POST /api/atlas/v2/types/typedefs 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:42 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:42 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:42 +] "GET 
/api/atlas/v2/entity/guid/791a3a80-e81f-4656-99c6-ebc146c0d771 HTTP/1.1" 200 - 
"-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:42 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:43 +] "POST 
/api/atlas/v2/entity/guid/random/classifications HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:43 +] "POST /api/atlas/v2/entity/bulk 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:43 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:43 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:43 +] "DELETE 
/api/atlas/v2/entity/bulk?guid=249475aa-ae22-4d81-9df4-deaad0a40d74=65b97192-6b18-400f-ae2f-4dda31930156
 HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:43 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:43 +] "DELETE 
/api/atlas/v2/entity/uniqueAttribute/type/hive_db_v2?attr:name=dbelGyzYBtiq%E6%AC%9A%E3%B5%85%E3%B8%AE%E8%A3%A1%E8%9B%B6%E8%80%BA%E6%B2%BF%E9%AD%B3%EA%B2%8C%EB%9B%8C
 HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:43 +] "DELETE 
/api/atlas/v2/entity/guid/random/classification/blah_trait HTTP/1.1" 400 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:43 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db_v2+where+name%3D'dbelGyzYBtiq'=10=0
 HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:44 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db_v2+where+name%3D'dbelGyzYBtiq'=10=0
 HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:45 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:45 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db_v2+where+name%3D'dbelGyzYBtiq'=10=0
 HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:46 +] "POST /api/atlas/v2/types/typedefs 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:46 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:46 +] "PUT /api/atlas/v2/types/typedefs 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:47 +] "GET 
/api/atlas/v2/entity/guid/99ecc236-df62-44da-809b-35d12012bf7c HTTP/1.1" 200 - 
"-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:47 +] "POST /api/atlas/v2/entity HTTP/1.1" 
404 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:47 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:47 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:47 +] "GET 
/api/atlas/v2/entity/uniqueAttribute/type/hive_db_v2?attr:name=dbelGyzYBtiq 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:47 +] "GET /api/atlas/v2/entity/guid/blah 
HTTP/1.1" 404 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:20:49:47 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"

[jira] [Created] (ATLAS-2446) Hbase Model to have more HBase specific attributes.

2018-02-14 Thread Ramesh Mani (JIRA)
Ramesh Mani created ATLAS-2446:
--

 Summary: Hbase Model to have more HBase specific attributes.
 Key: ATLAS-2446
 URL: https://issues.apache.org/jira/browse/ATLAS-2446
 Project: Atlas
  Issue Type: Bug
  Components: atlas-intg
Affects Versions: 0.8.1, trunk
Reporter: Ramesh Mani
Assignee: Ramesh Mani
 Fix For: trunk, 0.8.1


Hbase Model to have more HBase specific attributes.
{code:java}
// code placeholder
{NAME => 'col_fam_1', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false', 
NEW_VERSION_BEHAVIOR => 'false', KEEP_DELETED_CELLS => 'FALSE', 
CACHE_DATA_ON_WRITE => 'false', DATA_
BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', 
REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', CACHE_INDEX_ON_WRITE => 
'false', IN_MEMORY => 'false',
 CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false', 
COMPRESSION => 'NONE', BLOCKCACHE => 'false', BLOCKSIZE => '65536'}
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 65658: ATLAS-2445:No Notification sent to Atlas from HBase hook if an HBase table is cloned or restored from an HBase snapshot

2018-02-14 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65658/#review197578
---


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 14, 2018, 7:31 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65658/
> ---
> 
> (Updated Feb. 14, 2018, 7:31 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2445
> https://issues.apache.org/jira/browse/ATLAS-2445
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> No Notification sent to Atlas from HBase hook if an HBase table is cloned or 
> restored from an HBase snapshot
> 
> 
> Diffs
> -
> 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java
>  8beccd2 
> 
> 
> Diff: https://reviews.apache.org/r/65658/diff/1/
> 
> 
> Testing
> ---
> 
> Testing done in local VM
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>



Review Request 65658: ATLAS-2445:No Notification sent to Atlas from HBase hook if an HBase table is cloned or restored from an HBase snapshot

2018-02-14 Thread Ramesh Mani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65658/
---

Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-2445
https://issues.apache.org/jira/browse/ATLAS-2445


Repository: atlas


Description
---

No Notification sent to Atlas from HBase hook if an HBase table is cloned or 
restored from an HBase snapshot


Diffs
-

  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java
 8beccd2 


Diff: https://reviews.apache.org/r/65658/diff/1/


Testing
---

Testing done in local VM


Thanks,

Ramesh Mani



Re: Review Request 65647: ATLAS-2444: HDFS namenode federation support

2018-02-14 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65647/#review197575
---




addons/models/1000-Hadoop/patches/005-hdfs_path_add_nameServiceId_attribute.json
Lines 1 (patched)


Given migration from earlier version of Atlas to 1.0 will be via 
export/import, I think it will be better to add 'nameServiceId' attribute 
directly in hdfs_path entity-def - instead of adding via a patch.



common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java
Lines 43 (patched)


Caching all the URLs handled by HdfsNameServiceResolver may result in the 
map to grow very large and take up a lot of memory. Consider avoding this cache.



common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java
Lines 56 (patched)


Consider using int for paramter 'port'.



common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java
Lines 98 (patched)


This would replace all occurances of "uri.getAuthority()" in the URL with 
nsId - which may not be desired. Only the first instance should be replaced:

hdfs://myhost/d1/d2/myhost.txt ==> hdfs://ns1/d1/d2/ns1.txt.

Please review and update.



common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java
Lines 230 (patched)


Why not directly add these constants in outer class? Just as 
'NS_ID_FOR_PATH', 'PATH_WITH_NSID' were added above.



common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java
Lines 231 (patched)


I think the default port can be configured in HDFS configuration. Instead 
of hardcoding "8020" here, read default port from HDFS configuration.


- Madhan Neethiraj


On Feb. 14, 2018, 6:36 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65647/
> ---
> 
> (Updated Feb. 14, 2018, 6:36 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2444
> https://issues.apache.org/jira/browse/ATLAS-2444
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> See ATLAS-2444
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  7cca48f11 
>   
> addons/models/1000-Hadoop/patches/005-hdfs_path_add_nameServiceId_attribute.json
>  PRE-CREATION 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
>  57fc7a1fd 
>   common/pom.xml a7ab6a312 
>   common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java 
> PRE-CREATION 
>   
> common/src/test/java/org/apache/atlas/utils/HdfsNameServiceResolverTest.java 
> PRE-CREATION 
>   common/src/test/resources/atlas-log4j.xml PRE-CREATION 
>   common/src/test/resources/hdfs-site.xml PRE-CREATION 
>   pom.xml c15e0dad7 
> 
> 
> Diff: https://reviews.apache.org/r/65647/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean package executes successfully.
> 
> The modified war was tested on a multi-node cluster with one nameServiceId 
> and 2 NameNodes, the required information was captured successfully in the 
> entity when an external table was created from beeline (hive context)
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>



Re: Deletion of relationships

2018-02-14 Thread Sarath Subramanian
Pierre,

Yes, that is a bug. We have changed guid to relationshipGuid. I have made
the fix as part of another patch I'm working on. Will get this fixed
shortly.

Thanks for catching this.


Thanks,
Sarath Subramanian

On Wed, Feb 14, 2018 at 7:12 AM, Pierre Padovani <
pierre.padov...@civitaslearning.com> wrote:

> Hey folks.. I'm playing with the latest master, and I ran across something
> I just don't get. According to the code, delete of relationships is
> supported as long as you have the guid of the relationship. When I create a
> simple setup of a hive_table as an input to a Process, and retrieve it I
> get something that looks like this:
>
> {
> "referredEntities": {},
> "entity": {
> "typeName": "Process",
> "attributes": {
> "owner": null,
> "outputs": null,
> "qualifiedName": "p1",
> "inputs": [
> {
> "guid": "eb0734a0-fe08-42fe-97ee-860c822571bc",
> "typeName": "hbase_table"
> }
> ],
> "name": "p1",
> "description": null
> },
> "guid": "241347a7-5051-4919-8892-b2a2cb25e785",
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1518560480743,
> "updateTime": 1518560494636,
> "version": 0,
> "relationshipAttributes": {
> "outputs": [],
> "knownLocations": [],
> "externalReferences": [],
> "notes": [],
> "comments": [],
> "inputs": [
> {
> "guid": "eb0734a0-fe08-42fe-97ee-860c822571bc",
> "typeName": "hbase_table",
> "displayText": "t1",
> "relationshipAttributes": {
> "typeName": "dataset_process_inputs"
> }
> }
> ],
> "relatedEntity": null,
> "consumedBy": [],
> "meanings": [],
> "alsoKnownAs": [],
> "tags": [],
> "embeddedMetadata": [],
> "contributor": [],
> "starRatings": [],
> "managedResources": [],
> "meetings": [],
> "todos": [],
> "likes": []
> },
> "classifications": []
> }
> }
>
> The relationship has no guid, and therefore I cannot directly access it to
> delete it. I know the guid was there in a previous build off of master, but
> it seems to have vanished.
>
> Ideas?
>
> Thanks!
>


Build failed in Jenkins: Atlas-0.8-IntegrationTests #172

2018-02-14 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-2440: UI: fix to render date attribute values in date-formatted

--
[...truncated 489.18 KB...]
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "GET 
/api/atlas/v2/types/typedef/name/PII_TraitAre2VnKU5k HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "DELETE 
/api/atlas/entities/a5ce43fd-2c1f-47f4-af26-44d43b182088/traits/PII_TraitAre2VnKU5k
 HTTP/1.1" 404 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "GET 
/api/atlas/v2/types/typedef/name/PII_TraitKs5kQWKSPg HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "POST 
/api/atlas/entities/f16082e8-d956-4ecc-b3e6-1bc5bde59843/traits HTTP/1.1" 201 - 
"-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "GET 
/api/atlas/entities/f16082e8-d956-4ecc-b3e6-1bc5bde59843/audit?count=100 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "GET /api/atlas/entities?type=blah 
HTTP/1.1" 400 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "DELETE 
/api/atlas/entities/1ef3d059-f541-4848-96e1-050b48012f5e/traits/blah_trait 
HTTP/1.1" 404 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:53 +] "DELETE 
/api/atlas/entities?type=hive_db=qualifiedName=FKUC6Ge4Gv 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "GET 
/api/atlas/entities/9078a24b-4db3-424a-9e8d-83d358438582 HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "GET 
/api/atlas/v2/types/typedef/name/PII_TraitJkJBvWep37 HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "POST 
/api/atlas/entities/e1348801-ecb9-482a-89d7-c4e33d1dc4da/traits HTTP/1.1" 201 - 
"-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "GET 
/api/atlas/entities/e1348801-ecb9-482a-89d7-c4e33d1dc4da HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "PUT /api/atlas/entities HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "GET 
/api/atlas/entities/9b0d8cd2-3193-42f2-ba11-9f7d1dd37101 HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "GET 
/api/atlas/v2/types/typedef/name/testsYNG0QW65L HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "GET 
/api/atlas/entities?type=testsYNG0QW65L HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "GET 
/api/atlas/entities/2f04a8b6-a8d9-4b28-b660-339e9a7e6623 HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "POST 
/api/atlas/entities/35099fbf-9bca-414b-be31-4a360b98e67b?property=description 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:18:47:54 +] "GET 
/api/atlas/entities/35099fbf-9bca-414b-be31-4a360b98e67b HTTP/1.1" 200 - 

Re: Review Request 65647: ATLAS-2444: HDFS namenode federation support

2018-02-14 Thread Apoorv Naik

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65647/
---

(Updated Feb. 14, 2018, 6:36 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Changes
---

Addressed review comments.


Bugs: ATLAS-2444
https://issues.apache.org/jira/browse/ATLAS-2444


Repository: atlas


Description
---

See ATLAS-2444


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 7cca48f11 
  
addons/models/1000-Hadoop/patches/005-hdfs_path_add_nameServiceId_attribute.json
 PRE-CREATION 
  
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
 57fc7a1fd 
  common/pom.xml a7ab6a312 
  common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java 
PRE-CREATION 
  common/src/test/java/org/apache/atlas/utils/HdfsNameServiceResolverTest.java 
PRE-CREATION 
  common/src/test/resources/atlas-log4j.xml PRE-CREATION 
  common/src/test/resources/hdfs-site.xml PRE-CREATION 
  pom.xml c15e0dad7 


Diff: https://reviews.apache.org/r/65647/diff/2/

Changes: https://reviews.apache.org/r/65647/diff/1-2/


Testing
---

mvn clean package executes successfully.

The modified war was tested on a multi-node cluster with one nameServiceId and 
2 NameNodes, the required information was captured successfully in the entity 
when an external table was created from beeline (hive context)


Thanks,

Apoorv Naik



Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/
---

(Updated Feb. 14, 2018, 6:06 p.m.)


Review request for atlas, David Radley and Madhan Neethiraj.


Repository: atlas


Description
---

This is a request for code review of the OMRS.  There are still parts of the 
code not written - the aim of the review is to make the connector interfaces 
available so they can be evaluated by teams buinding components against the 
APIs.

There is a patch connected to 
https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
code plus other code that is not ready for review.  The OMRS Connector API 
depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.


Diffs (updated)
-

  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java cc2e430 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProviderBase.java 
fafd20c 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java 
d34e6f4 
  om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/KeyPattern.java 
ce6dae1 
  omrs/README.md PRE-CREATION 
  omrs/pom.xml PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v1/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapper.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/eventmapper/IGCV2OMRSRepositoryEventMapperProvider.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSMetadataCollection.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnector.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/v2/repositoryconnector/IGCV2OMRSRepositoryConnectorProvider.java
 PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
PRE-CREATION 
  omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveBuilder.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java 
PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/opentypes/OpenMetadataTypesArchive.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchive.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveInstanceStore.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveProperties.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveType.java
 PRE-CREATION 
  
omrs/src/main/java/org/apache/atlas/omrs/archivemanager/properties/OpenMetadataArchiveTypeStore.java
 PRE-CREATION 
  

Metadata security policies examples

2018-02-14 Thread Mandy Chessell
Hello Madhan,
I was thinking through our common use cases for metadata security.  For 
most metadata entities and relationships, we would want to enforce that 
metadata is readable by logged on users but edit access is limited to the 
user identified in the createdBy property. 

Then we have special cases for entities such as connections and some 
governance actions.
For example there may be a connection to an audit log and that can only be 
seen by members of the security team since having access to the connection 
means you can connect to the data store.
Some governance actions may be updateable by anyone in the governance team 
- not just the creator.

When it comes to classifications, we have 2 scenarios 
- where a classification can only be added to an entity by a user that has 
edit access to the entity.
- where a classification can only be added to any entity by a user with 
create rights on the classification.

I was trying to think through similar examples for relationships - for 
example, where edit access to an entity is required before a relationship 
can connect it to something else - but I can't think of one - and it would 
be good from a graph decoupling point of view if adding relationships 
could be done independently of the access rights to either entity.

All the best
Mandy
___
Mandy Chessell CBE FREng CEng FBCS
IBM Distinguished Engineer

Master Inventor
Member of the IBM Academy of Technology
Visiting Professor, Department of Computer Science, University of 
Sheffield

Email: mandy_chess...@uk.ibm.com
LinkedIn: http://www.linkedin.com/pub/mandy-chessell/22/897/a49

Assistant: Janet Brooks - jsbrook...@uk.ibm.com

[jira] [Updated] (ATLAS-2441) UI : DSL Search : type select __guid doesn't display result though the result has GUID response

2018-02-14 Thread Madhan Neethiraj (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-2441:

Affects Version/s: 1.0.0-alpha
   0.8.2
Fix Version/s: (was: 0.8.2)
   0.8.3

Committed to following branches:
 - master: http://git-wip-us.apache.org/repos/asf/atlas/commit/3635e8e2
 - branch-0.8: http://git-wip-us.apache.org/repos/asf/atlas/commit/562739a1

> UI : DSL Search : type select __guid doesn't display result though the result 
> has GUID response
> ---
>
> Key: ATLAS-2441
> URL: https://issues.apache.org/jira/browse/ATLAS-2441
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0-alpha, 0.8.2
>Reporter: pratik pandey
>Assignee: pratik pandey
>Priority: Major
> Fix For: 1.0.0, 0.8.3
>
> Attachments: ATLAS-2441.1.patch, ATLAS-2441.patch
>
>
> DSL query 
> hive_table select __guid
> results all the guids. But the UI doesn't display them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Build failed in Jenkins: Atlas-0.8-IntegrationTests #171

2018-02-14 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-2441 - UI, DSL Search : type select __guid doesn't display result

--
[...truncated 494.35 KB...]
127.0.0.1 - - [14/Feb/2018:17:49:05 +] "GET 
/api/atlas/v2/search/fulltext?offset=0=dbtpCiCWln6W=10 HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:05 +] "GET 
/api/atlas/v2/search/fulltext?offset=1=dbtpCiCWln6W=10 HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:05 +] "GET 
/api/atlas/v2/search/fulltext?offset=0=dbtpCiCWln6W=1 HTTP/1.1" 200 
- "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:05 +] "GET 
/api/atlas/v2/search/fulltext?offset=2=dbtpCiCWln6W=1 HTTP/1.1" 200 
- "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:05 +] "POST /api/atlas/admin/import 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:08 +] "GET 
/api/atlas/v2/types/typedef/name/fooTag HTTP/1.1" 404 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:08 +] "POST /api/atlas/v2/types/typedefs 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:08 +] "GET 
/api/atlas/v2/entity/uniqueAttribute/type/hdfs_path?attr:qualifiedName=test%241test%2B%2B-%2B%26%26%2B%7C%7C%2B%21%2B%28%2B%29%2B%7B%2B%7D%2B%5B%2B%5D%2B%5E%2B%3C%2B%3E%2B%3B%2B%3A%2B%22%2B%25%2B*%2B%60%2B%7E
 HTTP/1.1" 404 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:08 +] "POST /api/atlas/v2/entity HTTP/1.1" 
200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:13 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:13 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:13 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:13 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "POST /api/atlas/v2/search/basic 
HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/tableType HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/serdeType HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/classification HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/pii_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/phi_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/pci_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/sox_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/sec_Tag HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/finance_Tag HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/Factaf4iR1M9UO HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/ETLrruHynmq9E HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/DimensionVApw1V1iRZ HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/MetricAhdBntzDf4 HTTP/1.1" 404 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/hive_db_v1 HTTP/1.1" 200 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/hive_column_v1 HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 
/api/atlas/v2/types/typedef/name/hive_table_v1 HTTP/1.1" 200 - "-" 
"Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:17:49:14 +] "GET 

Fwd: Travel Assistance applications open. Please inform your communities

2018-02-14 Thread Alan Gates
-- Forwarded message --
From: Gavin McDonald 
Date: Wed, Feb 14, 2018 at 1:34 AM
Subject: Travel Assistance applications open. Please inform your communities
To: travel-assista...@apache.org


Hello PMCs.

Please could you forward on the below email to your dev and user lists.

Thanks

Gav…

—
The Travel Assistance Committee (TAC) are pleased to announce that travel
assistance applications for ApacheCon NA 2018 are now open!

We will be supporting ApacheCon NA Montreal, Canada on 24th - 29th
September 2018

 TAC exists to help those that would like to attend ApacheCon events, but
are unable to do so for financial reasons.
For more info on this years applications and qualifying criteria, please
visit the TAC website at < http://www.apache.org/travel/ >. Applications
are now open and will close 1st May.

*Important*: Applications close on May 1st, 2018. Applicants have until the
closing date above to submit their applications (which should contain as
much supporting material as required to efficiently and accurately process
their request), this will enable TAC to announce successful awards shortly
afterwards.

As usual, TAC expects to deal with a range of applications from a diverse
range of backgrounds. We therefore encourage (as always) anyone thinking
about sending in an application to do so ASAP.
We look forward to greeting many of you in Montreal

Kind Regards,
Gavin - (On behalf of the Travel Assistance Committee)
—


Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefValidator.java
> > Lines 57 (patched)
> > 
> >
> > List as param for validateTypeDefs?

Using ArrayLists


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
> > Lines 136 (patched)
> > 
> >
> > List as return type?
> 
> Mandy Chessell wrote:
> Needs to be ArrayList as need concrete implementation for ease of use.

Choice of ArrayList is deliberate


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositorycontentmanager/OMRSTypeDefValidator.java
> > Lines 37 (patched)
> > 
> >
> > List ?

It should be ArrayList


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
> > Lines 668 (patched)
> > 
> >
> > the most generic type for param (ArrayList(. Can you 
> > change to List in this case?
> > Also the same comment for return type.

The OMRS is using ArrayLists consistently


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSMetadataCollection.java
> > Lines 136 (patched)
> > 
> >
> > It is best to return the most generic type. Can you return List in this 
> > case?

The OMRS is using ArrayLists consistently


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 10:45 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventExchangeRule.java
> > Lines 33 (patched)
> > 
> >
> > can be List instead of implementation (ArrayList)?

Already commented on this point, above and below


> On Feb. 6, 2018, 10:45 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/eventmanagement/OMRSRepositoryEventExchangeRule.java
> > Lines 60 (patched)
> > 
> >
> > return exchangeRule != OpenMetadataExchangeRule.REGISTRATION_ONLY 
> > directly?

Seems to be the same logic - just a more complicated way of writing it.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196882
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 10:45 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
> > Lines 239 (patched)
> > 
> >
> > it may be faster to call combinedResults.isEmpty() that to look an the 
> > entire list (.size).

The complier will optimize


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196882
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 10:45 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
> > Lines 190 (patched)
> > 
> >
> > it may be faster to call combinedResults.isEmpty() that to look an the 
> > entire list (.size).

The complier will do that for us.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196882
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 10:26 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
> > Lines 111 (patched)
> > 
> >
> > can be List combinedResults = new ArrayList<>(); ?

Deliberately using ArrayLists


> On Feb. 6, 2018, 10:26 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSMetadataCollection.java
> > Lines 139 (patched)
> > 
> >
> > it may be faster to call combinedResults.isEmpty() that to look an the 
> > entire list (.size).

The complier will do that for us


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196881
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 10:08 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
> > Lines 71 (patched)
> > 
> >
> > It may be better to use interfaces over concrete types for good 
> > encapsulation and for loose coupling. I suggest to have "private List<>" 
> > instead of "private ArrayList<>".

I have commented on this abover and below


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196879
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 9:43 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java
> > Lines 35 (patched)
> > 
> >
> > It may be better to use interfaces over concrete types for good 
> > encapsulation and for loose coupling. I suggest to have "private 
> > List" instead of "private ArrayList 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 9:29 a.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java
> > Lines 31 (patched)
> > 
> >
> > It may be better to use interfaces over concrete types for good 
> > encapsulation and for loose coupling. I suggest to have "private 
> > List" instead of "private ArrayList 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 3:45 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/OMRSCohortRegistry.java
> > Lines 1051 (patched)
> > 
> >
> > only one if with && operator?
> 
> Mandy Chessell wrote:
> I don't understand this comment

Worked it out now - the suggested change does not change the logic and it is 
easier to read if it is simple.  Just a different style preference


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196899
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 3:45 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/OMRSCohortRegistry.java
> > Lines 1051 (patched)
> > 
> >
> > only one if with && operator?

I don't understand this comment


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196899
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java
> > Lines 111 (patched)
> > 
> >
> > protectec static instead of "static protected". It's more common to 
> > have the access modifier (public/private...) before the modifier static.
> > also  List as return type.
> 
> Mandy Chessell wrote:
> ok - but I don't think it makes any difference

This line does not exist in the current version .  I think it was removed when 
I restructured the PrimitiveTypeDef


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java
> > Lines 53 (patched)
> > 
> >
> > is it needed ""?

It is not needed, and I have removed it - but I think it is sloppy to not 
initialise variables


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java
> > Lines 35 (patched)
> > 
> >
> > ArrayList -> List?

Its supposed to be ArrayList not List


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java
> > Lines 46 (patched)
> > 
> >
> > ArrayList ->List?

Its supposed to be ArrayList


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java
> > Lines 47 (patched)
> > 
> >
> > ArrayList ->List?

Its supposed to be ArrayList


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatchAction.java
> > Lines 26 (patched)
> > 
> >
> > implements Serializable?

Fixed


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196892
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:41 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java
> > Lines 149 (patched)
> > 
> >
> > is it not needed public access to this method?

Yes - I will fix it in the next patch


> On Feb. 6, 2018, 12:41 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDef.java
> > Lines 31 (patched)
> > 
> >
> > creationTime - why this value?
> > + ArrayList -> List

We need to have every instance of the collection def have the same values - it 
was the current time when I created the file.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196890
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:41 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java
> > Lines 115 (patched)
> > 
> >
> > is it not needed public access to this method?

Yes - I'll fix it in the next patch


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196890
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:41 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java
> > Lines 46 (patched)
> > 
> >
> > super() - not needed in this case (redundant)

It is not breaking anything and means that if the suprt class is changed in the 
future the new function will be invoked


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196890
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java
> > Lines 141 (patched)
> > 
> >
> > !isEmpty()?

Same behaviour ?


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/auditlog/OMRSAuditCode.java 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java
> > Lines 122 (patched)
> > 
> >
> > List?

Using ArraList for reasons described above


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java
> > Lines 72 (patched)
> > 
> >
> > return List (code to the interface?)

Using ArrayList for reasons above


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java
> > Lines 28 (patched)
> > 
> >
> > It may be better to use interfaces over concrete types for good 
> > encapsulation and for loose coupling. I suggest to have "private 
> > List" instead of "private ArrayList 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java
> > Lines 49 (patched)
> > 
> >
> > if (name == null || "".equals(name))?

Same behaviour


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
> > Lines 136 (patched)
> > 
> >
> > List as return type?

Needs to be ArrayList as need concrete implementation for ease of use.


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
> > Lines 148 (patched)
> > 
> >
> > List as return type?

Needs to be ArrayList as need concrete implementation for ease of use.


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
> > Lines 168 (patched)
> > 
> >
> > List as return type?

Needs to be ArrayList as need concrete implementation for ease of use.


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollection.java
> > Lines 388 (patched)
> > 
> >
> > List as return type and param for this method?

Needs to be ArrayList as need concrete implementation for ease of use.


> On Feb. 6, 2018, 12:15 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/OMRSMetadataCollectionBase.java
> > Lines 1393 (patched)
> > 
> >
> > is it correct the name of this method?

yes - what do you think it should be?


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196888
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> 

[jira] [Updated] (ATLAS-2246) Define OMRS Connector interface

2018-02-14 Thread Mandy Chessell (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandy Chessell updated ATLAS-2246:
--
Attachment: 0001-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch

> Define OMRS Connector interface
> ---
>
> Key: ATLAS-2246
> URL: https://issues.apache.org/jira/browse/ATLAS-2246
> Project: Atlas
>  Issue Type: Sub-task
>  Components: atlas-intg
>Reporter: Mandy Chessell
>Assignee: Mandy Chessell
>Priority: Critical
> Attachments: 
> 0001-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch, OMRS 
> Javadoc.zip
>
>
> This task covers the creation of the OMRS Connector APIs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2246) Define OMRS Connector interface

2018-02-14 Thread Mandy Chessell (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandy Chessell updated ATLAS-2246:
--
Attachment: (was: 0002-ATLAS-2246-26th-Jan-Code-Drop-of-OMRS.patch)

> Define OMRS Connector interface
> ---
>
> Key: ATLAS-2246
> URL: https://issues.apache.org/jira/browse/ATLAS-2246
> Project: Atlas
>  Issue Type: Sub-task
>  Components: atlas-intg
>Reporter: Mandy Chessell
>Assignee: Mandy Chessell
>Priority: Critical
> Attachments: 
> 0001-ATLAS-2246-OMRS-Connector-API-plus-REST-and-IGC-Conn.patch, OMRS 
> Javadoc.zip
>
>
> This task covers the creation of the OMRS Connector APIs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 3:50 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/OMRSCohortRegistryStoreProviderBase.java
> > Lines 34 (patched)
> > 
> >
> > is it needed?

Implementors of CohortRegistryStore connector providers am want a base class to 
inherit from.


> On Feb. 6, 2018, 3:50 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/cohortregistry/store/file/FileBasedRegistryStoreConnector.java
> > Lines 47 (patched)
> > 
> >
> > private static final variables should be declared before private 
> > variables. I suggest to add after "defaultFilename" the following vars: 
> > OMRSAuditLog auditLog and Logger log.

The variables are ordered by importance.  The logging/audit log are not 
important so at the end - They are at the end for all classes.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196900
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 13, 2018, 11:43 a.m., David Radley wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java
> > Lines 71 (patched)
> > 
> >
> > It would be normal to only expose List here are the return value and 
> > not expose the type of List, so you do not expose the List implementation.
> > The same for the setter.

I am not sure what the assumptions are for the "normal" case.  It make sense if 
the class is providing a service and exporting lists only but that is not the 
case.  However in this case, the change would make the use of the classes very 
awkward because the array list is manipulated and created both by the callers 
and the class itself.  We would be continually casting and have to have a 
"secret" rule that the implementation must be ArrayList to use the class.  I 
don't think that is an improvement.  It is also a big change because if we did 
if for this place we would want to change it for the whole of the OMRS.   We 
have to be sure it works with Spring and Jackson.  All of the examples I have 
been working with use ArrayList.  If you feel strongly about it, raise a Jira 
since this is a big piece of work and we can look into it when we have time.


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review197399
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> 

Apache EU Roadshow CFP Closing Soon (23 February)

2018-02-14 Thread Sharan F

Hello Everyone

This is an initial reminder to let you all know that we are holding an 
Apache EU Roadshow co-located with FOSS Backstage in Berlin on 13^th and 
14^th June 2018. https://s.apache.org/tCHx


The Call for Proposals (CFP) for the Apache EU Roadshow is currently 
open and will close at the end of next week, so if you have been 
delaying making a submission because the closing date seemed a long way 
off, then it's time to start getting your proposals submitted.


So what are we looking for?
We will have 2 Apache Devrooms available during the 2 day Roadshow so 
are looking for projects including incubating ones, to submit 
presentations, panel discussions, BoFs, or workshop proposals. The main 
focus of the Roadshow will be IoT, Cloud, Httpd and Tomcat so if your 
project is involved in or around any of these technologies at Apache 
then we are very interested in hearing from you.


Community and collaboration is important at Apache so if your project is 
interested in organising a project sprint, meetup or hackathon during 
the Roadshow, then please submit it inthe CFP as we do have some space 
available to allocate for these.


If you are wanting to submit a talk on open source community related 
topics such as the Apache Way, governance or legal aspects then please 
submit these to the CFP for FOSS Backstage.


Tickets for the Apache EU Roadshow are included as part of the 
registration for FOSS Backstage, so to attend the Roadshow you will need 
to register for FOSS Backstage. Early Bird tickets are still available 
until the 21^st February 2018.


Please see below for important URLs to remember:

-  To submit a CFP for the Apache EU Roadshow 
:http://apachecon.com/euroadshow18/ 


-  To submit a CFP for FOSS Backstage : 
https://foss-backstage.de/call-papers


-  To register to attend the Apache EU Roadshow and/or FOSS Backstage : 
https://foss-backstage.de/tickets


For further updates and information about the Apache EU Roadshowplease 
check http://apachecon.com/euroadshow18/


Thanks
Sharan Foga, VP Apache Community Development


Re: Server appears to start, but connections fail with 503

2018-02-14 Thread Ernie Ostic

Thanks for the pointer.   lots of errors there.  Hard to say
exactly which is the key error, but all seem to be related to
JanusGraph.

Ernie





Ernie Ostic

Worldwide Technical Sales
InfoSphere Information Server
IBM Analytics

Cell: (617) 331 8238
---
Apache Atlas Update!
https://dsrealtime.wordpress.com/2017/11/16/apache-atlas-update-have-you-been-watching/

Open IGC is here!
https://dsrealtime.wordpress.com/2015/07/29/open-igc-is-here/



From:   David Aspegren 
To: dev@atlas.apache.org
Date:   02/14/2018 10:06 AM
Subject:Re: Server appears to start, but connections fail with 503



HI Ernie,

what is the error you are gettin in the in the .out log file?

Regards,
David

2018-02-14 15:57 GMT+01:00 Ernie Ostic :

> Setting the variables in advance "helped", and they show up now, in the
> start console
>
> configured for local hbase.
> hbase started.
> configured for local solr.
> solr started.
> setting up solr collections...
> starting atlas on host localhost
> starting atlas on port 21000
> 
> 
> 
> 
> ..
> Apache Atlas Server started!!!
>
> ...but the resulting symptom of the 503 remains the same
>
> Thanks in advance for any thoughts or places to look
>
> Ernie
>
>
>
>
>
> Ernie Ostic
>
> Worldwide Technical Sales
> InfoSphere Information Server
> IBM Analytics
>
> Cell: (617) 331 8238 <(617)%20331-8238>
> ---
> Apache Atlas Update!
https://urldefense.proofpoint.com/v2/url?u=https-3A__dsrealtime.wordpress=DwIBaQ=jf_iaSHvJObTbx-siA1ZOg=BRpv_IJLfOPKPg5CMvWe7vPrIiVO97XiMOUrvOhs2KY=nCc64YQqQEEOhX5kQBcppc7EbLUkzXD3aUxoIldh9dc=M4AuNnxz5ad4ND8sWpxm7du15L0SER7df3JyyRUFNzg=
.
> com/2017/11/16/apache-atlas-update-have-you-been-watching/
>
> Open IGC is here!
https://urldefense.proofpoint.com/v2/url?u=https-3A__dsrealtime.wordpress.com_2015_07_29_open-2Digc-2Dis-2D=DwIBaQ=jf_iaSHvJObTbx-siA1ZOg=BRpv_IJLfOPKPg5CMvWe7vPrIiVO97XiMOUrvOhs2KY=nCc64YQqQEEOhX5kQBcppc7EbLUkzXD3aUxoIldh9dc=sbl9ldWlEw--5cA1_qxThJ0_52GGdGdkOrraH_5ag7E=

> here/
>
> [image: Inactive hide details for Graham Wallis ---02/14/2018 09:32:50
> AM---Hi David, If you build with the 'embedded-hbase-solr' profi]Graham
> Wallis ---02/14/2018 09:32:50 AM---Hi David, If you build with the
> 'embedded-hbase-solr' profile then it includes Solr
>
> From: Graham Wallis 
> To: dev@atlas.apache.org
> Date: 02/14/2018 09:32 AM
> Subject: Re: Server appears to start, but connections fail with 503
> --
>
>
>
> Hi David,
> If you build with the 'embedded-hbase-solr' profile then it includes Solr
> 5.5.1.
>
> The default graph database is now JanusGraph so you should not use
> Titan0GraphDatabase, and the atlas.graphdb.backend property should
already
> be set correctly (by the build).
> The properties file should not need editing, if using the embedded
> profile.
>
> Best regards,
>  Graham
>
> Graham Wallis
> IBM Analytics Emerging Technology Center
> Internet: graham_wal...@uk.ibm.com
> IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN
> Tel: +44-1962-815356 <+44%201962%20815356>Tie: 7-245356
>
>
>
>
> From:   David Aspegren 
> To: dev@atlas.apache.org
> Date:   14/02/2018 13:59
> Subject:Re: Server appears to start, but connections fail with
503
>
>
>
> Hi,
>
> yes, I have set the two variables to MANAGE solr and hbase locally, which
> makes the atlas_start.py script also start those services.
> But this doesn't help.
> Don't we need to use solr5 rather than solr as well as the
> atlas.graph.index.search.backend ??
>
> Should
> "echo
> atlas.graphdb.backend=org.apache.atlas.repository.graphdb.titan0.
> Titan0GraphDatabase
> >> ${ATLAS_HOME}/conf/atlas-application.properties"
> be used for the 1.0.0-alpha version?
>
> Thanks a lot in advance!
>
> Regards,
> David
>
> 2018-02-14 14:55 GMT+01:00 Graham Wallis :
>
> > Hi Ernie
> >
> > As Peter says in his email, there are a couple of environment variables
> > needed:
> >
> > I build the same as you, i.e.:
> >
> > mvn clean install -DskipTests -Pdist,embedded-hbase-solr
> >
> > Then I do the following (I am on Windows):
> >
> > set MANAGE_LOCAL_HBASE=true
> >
> > set MANAGE_LOCAL_SOLR=true
> >
> > set
> > ATLAS_HOME=c:\dev\atlas\atlas\distro\target\apache-atlas-1.
> > 0.0-SNAPSHOT-bin\apache-atlas-1.0.0-SNAPSHOT
> >
> > cd %ATLAS_HOME%
> >
> > cd bin
> >
> > atlas_start.py
> >
> > ### This will take a long time - several minutes - to claim that the
> > server is started.
> >
> > 

Deletion of relationships

2018-02-14 Thread Pierre Padovani
Hey folks.. I'm playing with the latest master, and I ran across something
I just don't get. According to the code, delete of relationships is
supported as long as you have the guid of the relationship. When I create a
simple setup of a hive_table as an input to a Process, and retrieve it I
get something that looks like this:

{
"referredEntities": {},
"entity": {
"typeName": "Process",
"attributes": {
"owner": null,
"outputs": null,
"qualifiedName": "p1",
"inputs": [
{
"guid": "eb0734a0-fe08-42fe-97ee-860c822571bc",
"typeName": "hbase_table"
}
],
"name": "p1",
"description": null
},
"guid": "241347a7-5051-4919-8892-b2a2cb25e785",
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 1518560480743,
"updateTime": 1518560494636,
"version": 0,
"relationshipAttributes": {
"outputs": [],
"knownLocations": [],
"externalReferences": [],
"notes": [],
"comments": [],
"inputs": [
{
"guid": "eb0734a0-fe08-42fe-97ee-860c822571bc",
"typeName": "hbase_table",
"displayText": "t1",
"relationshipAttributes": {
"typeName": "dataset_process_inputs"
}
}
],
"relatedEntity": null,
"consumedBy": [],
"meanings": [],
"alsoKnownAs": [],
"tags": [],
"embeddedMetadata": [],
"contributor": [],
"starRatings": [],
"managedResources": [],
"meetings": [],
"todos": [],
"likes": []
},
"classifications": []
}
}

The relationship has no guid, and therefore I cannot directly access it to
delete it. I know the guid was there in a previous build off of master, but
it seems to have vanished.

Ideas?

Thanks!


Re: Server appears to start, but connections fail with 503

2018-02-14 Thread David Aspegren
HI Ernie,

what is the error you are gettin in the in the .out log file?

Regards,
David

2018-02-14 15:57 GMT+01:00 Ernie Ostic :

> Setting the variables in advance "helped", and they show up now, in the
> start console
>
> configured for local hbase.
> hbase started.
> configured for local solr.
> solr started.
> setting up solr collections...
> starting atlas on host localhost
> starting atlas on port 21000
> 
> 
> 
> 
> ..
> Apache Atlas Server started!!!
>
> ...but the resulting symptom of the 503 remains the same
>
> Thanks in advance for any thoughts or places to look
>
> Ernie
>
>
>
>
>
> Ernie Ostic
>
> Worldwide Technical Sales
> InfoSphere Information Server
> IBM Analytics
>
> Cell: (617) 331 8238 <(617)%20331-8238>
> ---
> Apache Atlas Update! https://dsrealtime.wordpress.
> com/2017/11/16/apache-atlas-update-have-you-been-watching/
>
> Open IGC is here! https://dsrealtime.wordpress.com/2015/07/29/open-igc-is-
> here/
>
> [image: Inactive hide details for Graham Wallis ---02/14/2018 09:32:50
> AM---Hi David, If you build with the 'embedded-hbase-solr' profi]Graham
> Wallis ---02/14/2018 09:32:50 AM---Hi David, If you build with the
> 'embedded-hbase-solr' profile then it includes Solr
>
> From: Graham Wallis 
> To: dev@atlas.apache.org
> Date: 02/14/2018 09:32 AM
> Subject: Re: Server appears to start, but connections fail with 503
> --
>
>
>
> Hi David,
> If you build with the 'embedded-hbase-solr' profile then it includes Solr
> 5.5.1.
>
> The default graph database is now JanusGraph so you should not use
> Titan0GraphDatabase, and the atlas.graphdb.backend property should already
> be set correctly (by the build).
> The properties file should not need editing, if using the embedded
> profile.
>
> Best regards,
>  Graham
>
> Graham Wallis
> IBM Analytics Emerging Technology Center
> Internet: graham_wal...@uk.ibm.com
> IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN
> Tel: +44-1962-815356 <+44%201962%20815356>Tie: 7-245356
>
>
>
>
> From:   David Aspegren 
> To: dev@atlas.apache.org
> Date:   14/02/2018 13:59
> Subject:Re: Server appears to start, but connections fail with 503
>
>
>
> Hi,
>
> yes, I have set the two variables to MANAGE solr and hbase locally, which
> makes the atlas_start.py script also start those services.
> But this doesn't help.
> Don't we need to use solr5 rather than solr as well as the
> atlas.graph.index.search.backend ??
>
> Should
> "echo
> atlas.graphdb.backend=org.apache.atlas.repository.graphdb.titan0.
> Titan0GraphDatabase
> >> ${ATLAS_HOME}/conf/atlas-application.properties"
> be used for the 1.0.0-alpha version?
>
> Thanks a lot in advance!
>
> Regards,
> David
>
> 2018-02-14 14:55 GMT+01:00 Graham Wallis :
>
> > Hi Ernie
> >
> > As Peter says in his email, there are a couple of environment variables
> > needed:
> >
> > I build the same as you, i.e.:
> >
> > mvn clean install -DskipTests -Pdist,embedded-hbase-solr
> >
> > Then I do the following (I am on Windows):
> >
> > set MANAGE_LOCAL_HBASE=true
> >
> > set MANAGE_LOCAL_SOLR=true
> >
> > set
> > ATLAS_HOME=c:\dev\atlas\atlas\distro\target\apache-atlas-1.
> > 0.0-SNAPSHOT-bin\apache-atlas-1.0.0-SNAPSHOT
> >
> > cd %ATLAS_HOME%
> >
> > cd bin
> >
> > atlas_start.py
> >
> > ### This will take a long time - several minutes - to claim that the
> > server is started.
> >
> > ### A further a long time (several minutes) after Atlas claims to have
> > started,  I can see the Atlas console in the browser (@localhost:21000)
> >
> > ### It is possible to now run quick_start...
> >
> > quick_start.py
> >
> >
> > Best regards,
> >   Graham
> >
> > Graham Wallis
> > IBM Analytics Emerging Technology Center
> > Internet: graham_wal...@uk.ibm.com
> > IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN
> > Tel: +44-1962-815356 <+44%201962%20815356>Tie: 7-245356
> >
> >
> >
> >
> > From:   "Ernie Ostic" 
> > To: dev@atlas.apache.org
> > Date:   14/02/2018 13:47
> > Subject:Re: Server appears to start, but connections fail with
> 503
> >
> >
> >
> > the doc implies that if you use embedded, there is nothing special
> to
> > set (unless you want to override the defaults)...
> >
> > Ernie
> >
> >
> >
> >
> > Ernie Ostic
> >
> > Worldwide Technical Sales
> > InfoSphere Information Server
> > IBM Analytics
> >
> > Cell: (617) 331 8238 <(617)%20331-8238>
> > ---
> > Apache Atlas Update!
> >
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java
> > Lines 44 (patched)
> > 
> >
> > What is the purpose of this attribute?
> 
> Mandy Chessell wrote:
> It defines how many primitives there are

This line does not exist in the current version


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196892
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java
> > Lines 111 (patched)
> > 
> >
> > protectec static instead of "static protected". It's more common to 
> > have the access modifier (public/private...) before the modifier static.
> > also  List as return type.

ok - but I don't think it makes any difference


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196892
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
> 

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

2018-02-14 Thread Mandy Chessell


> On Feb. 6, 2018, 1:26 p.m., Daniela Otelea wrote:
> > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java
> > Lines 44 (patched)
> > 
> >
> > What is the purpose of this attribute?

It defines how many primitives there are


- Mandy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63502/#review196892
---


On Jan. 29, 2018, 9:51 a.m., Mandy Chessell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63502/
> ---
> 
> (Updated Jan. 29, 2018, 9:51 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This is a request for code review of the OMRS.  There are still parts of the 
> code not written - the aim of the review is to make the connector interfaces 
> available so they can be evaluated by teams buinding components against the 
> APIs.
> 
> There is a patch connected to 
> https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the 
> code plus other code that is not ready for review.  The OMRS Connector API 
> depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095.
> 
> 
> Diffs
> -
> 
>   omrs/README.md PRE-CREATION 
>   omrs/pom.xml PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/atlas/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapper.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/eventmapper/IGCOMRSRepositoryEventMapperProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSMetadataCollection.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnector.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/adapters/igc/repositoryconnector/IGCOMRSRepositoryConnectorProvider.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSOperationalServices.java 
> PRE-CREATION 
>   omrs/src/main/java/org/apache/atlas/omrs/admin/properties/CohortConfig.java 
> PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/EnterpriseAccessConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/LocalRepositoryConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataEventProtocolVersion.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/admin/properties/RepositoryServicesConfig.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/OMRSArchiveManager.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreConnectorBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/OpenMetadataArchiveStoreProviderBase.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchive.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveInstanceStore.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveProperties.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveType.java
>  PRE-CREATION 
>   
> omrs/src/main/java/org/apache/atlas/omrs/archivemanager/store/properties/OpenMetadataArchiveTypeStore.java
>  PRE-CREATION 
>   

Re: Server appears to start, but connections fail with 503

2018-02-14 Thread Ernie Ostic

Setting the variables in advance "helped", and they show up now, in the
start console

configured for local hbase.
hbase started.
configured for local solr.
solr started.
setting up solr collections...
starting atlas on host localhost
starting atlas on port 21000
..
Apache Atlas Server started!!!

...but the resulting symptom of the 503 remains the same

Thanks in advance for any thoughts or places to look

Ernie





Ernie Ostic

Worldwide Technical Sales
InfoSphere Information Server
IBM Analytics

Cell: (617) 331 8238
---
Apache Atlas Update!
https://dsrealtime.wordpress.com/2017/11/16/apache-atlas-update-have-you-been-watching/

Open IGC is here!
https://dsrealtime.wordpress.com/2015/07/29/open-igc-is-here/



From:   Graham Wallis 
To: dev@atlas.apache.org
Date:   02/14/2018 09:32 AM
Subject:Re: Server appears to start, but connections fail with 503



Hi David,
If you build with the 'embedded-hbase-solr' profile then it includes Solr
5.5.1.

The default graph database is now JanusGraph so you should not use
Titan0GraphDatabase, and the atlas.graphdb.backend property should already
be set correctly (by the build).
The properties file should not need editing, if using the embedded
profile.

Best regards,
  Graham

Graham Wallis
IBM Analytics Emerging Technology Center
Internet: graham_wal...@uk.ibm.com
IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN
Tel: +44-1962-815356Tie: 7-245356




From:   David Aspegren 
To: dev@atlas.apache.org
Date:   14/02/2018 13:59
Subject:Re: Server appears to start, but connections fail with 503



 Hi,

yes, I have set the two variables to MANAGE solr and hbase locally, which
makes the atlas_start.py script also start those services.
But this doesn't help.
Don't we need to use solr5 rather than solr as well as the
atlas.graph.index.search.backend ??

Should
"echo
atlas.graphdb.backend=org.apache.atlas.repository.graphdb.titan0.Titan0GraphDatabase

>> ${ATLAS_HOME}/conf/atlas-application.properties"
be used for the 1.0.0-alpha version?

Thanks a lot in advance!

Regards,
David

2018-02-14 14:55 GMT+01:00 Graham Wallis :

> Hi Ernie
>
> As Peter says in his email, there are a couple of environment variables
> needed:
>
> I build the same as you, i.e.:
>
> mvn clean install -DskipTests -Pdist,embedded-hbase-solr
>
> Then I do the following (I am on Windows):
>
> set MANAGE_LOCAL_HBASE=true
>
> set MANAGE_LOCAL_SOLR=true
>
> set
> ATLAS_HOME=c:\dev\atlas\atlas\distro\target\apache-atlas-1.
> 0.0-SNAPSHOT-bin\apache-atlas-1.0.0-SNAPSHOT
>
> cd %ATLAS_HOME%
>
> cd bin
>
> atlas_start.py
>
> ### This will take a long time - several minutes - to claim that the
> server is started.
>
> ### A further a long time (several minutes) after Atlas claims to have
> started,  I can see the Atlas console in the browser (@localhost:21000)
>
> ### It is possible to now run quick_start...
>
> quick_start.py
>
>
> Best regards,
>   Graham
>
> Graham Wallis
> IBM Analytics Emerging Technology Center
> Internet: graham_wal...@uk.ibm.com
> IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN
> Tel: +44-1962-815356Tie: 7-245356
>
>
>
>
> From:   "Ernie Ostic" 
> To: dev@atlas.apache.org
> Date:   14/02/2018 13:47
> Subject:Re: Server appears to start, but connections fail with
503
>
>
>
> the doc implies that if you use embedded, there is nothing special
to
> set (unless you want to override the defaults)...
>
> Ernie
>
>
>
>
> Ernie Ostic
>
> Worldwide Technical Sales
> InfoSphere Information Server
> IBM Analytics
>
> Cell: (617) 331 8238
> ---
> Apache Atlas Update!
>
https://urldefense.proofpoint.com/v2/url?u=https-3A__dsrealtime.wordpress.com_2017_11_16_apache-2Datlas-2D=DwIBaQ=jf_iaSHvJObTbx-siA1ZOg=Li6zJa6pLsu8dGS1GSW1j00glumVmLp0H5HVkn5QyAA=fBklEJZLGyZo0Kz0IdKUqe8Kc6zY7ms1MbkXC-4I2TQ=zlcAsVOioSri4zhOos2RgtKUENeIk5q4cHp1DCpP6Wg=


> update-have-you-been-watching/
>
>
> Open IGC is here!
>
https://urldefense.proofpoint.com/v2/url?u=https-3A__dsrealtime.wordpress.com_2015_07_29_open-2Digc-2Dis-2Dhere_=DwIBaQ=jf_iaSHvJObTbx-siA1ZOg=Li6zJa6pLsu8dGS1GSW1j00glumVmLp0H5HVkn5QyAA=fBklEJZLGyZo0Kz0IdKUqe8Kc6zY7ms1MbkXC-4I2TQ=YC17_j2zAo7FMjikpq1NcDXPpinCe9vVGUlfOIoC72Y=


>
> David Aspegren ---02/14/2018 08:40:19 AM---Hi, I have the same issue.
> Where are those environment variables for embedded
>
> From: David Aspegren 
> To: dev@atlas.apache.org
> Date: 02/14/2018 08:40 AM
> Subject: 

Re: Server appears to start, but connections fail with 503

2018-02-14 Thread Graham Wallis
Hi Ernie

As Peter says in his email, there are a couple of environment variables 
needed:

I build the same as you, i.e.:

mvn clean install -DskipTests -Pdist,embedded-hbase-solr

Then I do the following (I am on Windows):

set MANAGE_LOCAL_HBASE=true

set MANAGE_LOCAL_SOLR=true

set 
ATLAS_HOME=c:\dev\atlas\atlas\distro\target\apache-atlas-1.0.0-SNAPSHOT-bin\apache-atlas-1.0.0-SNAPSHOT

cd %ATLAS_HOME%

cd bin

atlas_start.py

### This will take a long time - several minutes - to claim that the 
server is started. 

### A further a long time (several minutes) after Atlas claims to have 
started,  I can see the Atlas console in the browser (@localhost:21000)

### It is possible to now run quick_start...

quick_start.py


Best regards,
  Graham

Graham Wallis
IBM Analytics Emerging Technology Center
Internet: graham_wal...@uk.ibm.com 
IBM Laboratories, Hursley Park, Hursley, Hampshire SO21 2JN
Tel: +44-1962-815356Tie: 7-245356




From:   "Ernie Ostic" 
To: dev@atlas.apache.org
Date:   14/02/2018 13:47
Subject:Re: Server appears to start, but connections fail with 503



the doc implies that if you use embedded, there is nothing special to 
set (unless you want to override the defaults)...

Ernie




Ernie Ostic

Worldwide Technical Sales
InfoSphere Information Server
IBM Analytics

Cell: (617) 331 8238
---
Apache Atlas Update! 
https://dsrealtime.wordpress.com/2017/11/16/apache-atlas-update-have-you-been-watching/


Open IGC is here! 
https://dsrealtime.wordpress.com/2015/07/29/open-igc-is-here/

David Aspegren ---02/14/2018 08:40:19 AM---Hi, I have the same issue. 
Where are those environment variables for embedded

From: David Aspegren 
To: dev@atlas.apache.org
Date: 02/14/2018 08:40 AM
Subject: Re: Server appears to start, but connections fail with 503



Hi,

I have the same issue. Where are those environment variables for embedded
hbase described?

regards,
David

2018-02-14 14:32 GMT+01:00 Ernie Ostic :

> Thanks David...
>
> build string I am using is: *mvn clean -DskipTests package
> -Pdist,embedded-hbase-solr*
>
> Will check again the environment variablesthx.
>
> Ernie
>
>
>
>
>
> Ernie Ostic
>
> Worldwide Technical Sales
> InfoSphere Information Server
> IBM Analytics
>
> Cell: (617) 331 8238 <(617)%20331-8238>
> ---
> Apache Atlas Update! 
https://urldefense.proofpoint.com/v2/url?u=https-3A__dsrealtime.wordpress=DwIBaQ=jf_iaSHvJObTbx-siA1ZOg=BRpv_IJLfOPKPg5CMvWe7vPrIiVO97XiMOUrvOhs2KY=M35fKxVn4QneHylVYfwieO03S865S_inu-tl_w8GZ3A=g4tN6Qrv0ZvUhv-nq7KDKXHIH-OpCQcNIxVvHDG1Au0=
.
> com/2017/11/16/apache-atlas-update-have-you-been-watching/
>
> Open IGC is here! 
https://urldefense.proofpoint.com/v2/url?u=https-3A__dsrealtime.wordpress.com_2015_07_29_open-2Digc-2Dis-2D=DwIBaQ=jf_iaSHvJObTbx-siA1ZOg=BRpv_IJLfOPKPg5CMvWe7vPrIiVO97XiMOUrvOhs2KY=M35fKxVn4QneHylVYfwieO03S865S_inu-tl_w8GZ3A=FbLTJa1kLcMv0I3DkMzJP2aJpR0aTWpXb3SyAduO2gs=

> here/
>
> [image: Inactive hide details for David Radley ---02/14/2018 07:44:19
> AM---Hi Ernie, There are 2 ways to build and run Atlas currently:]David
> Radley ---02/14/2018 07:44:19 AM---Hi Ernie, There are 2 ways to build 
and
> run Atlas currently:
>
> From: David Radley 
> To: dev@atlas.apache.org
> Date: 02/14/2018 07:44 AM
> Subject: Re: Server appears to start, but connections fail with 503
> --
>
>
>
> Hi Ernie,
> There are 2 ways to build and run Atlas currently:
>- external Hbase and Solr and ZK
>- embedded HBase Solr and ZK
>
> I am not sure which one you are trying. Sharing your build string would 
be
> helpful. If you are using the embedded HBase option then you need to
> specify environment variables, for the runtime Atlas to work,
>
> As per yesterdays call - Madhan suggests running with an external HBase,
> as he seems a performance delay using the embedded HBase.
>   all the best, David.
>
>
>
> From:   "Ernie Ostic" 
> To: "Atlas" 
> Date:   14/02/2018 11:52
> Subject:Server appears to start, but connections fail with 503
>
>
>
>
>
> Hi all...
>
> Using "master", the build appears to be successful, and the server is
> properly listening on port 21000, but quick start or even direct access
> fails with 503.   Any suggestions on where to look?   Thanks!
>
> Ernie
>
>
>
> $ bin/quick_start.py
>
> log4j:WARN No such property [maxFileSize] in
> org.apache.log4j.PatternLayout.
> log4j:WARN No such property [maxBackupIndex] in
> org.apache.log4j.PatternLayout.
> log4j:WARN No such property [maxFileSize] in
> org.apache.log4j.PatternLayout.
> log4j:WARN No such property [maxBackupIndex] in
> org.apache.log4j.PatternLayout.
> log4j:WARN No such property [maxFileSize] in
> org.apache.log4j.PatternLayout.
>
> Enter username for atlas 

Re: Server appears to start, but connections fail with 503

2018-02-14 Thread Peter Gergo Barna
Hi David,

# I think these are the env variables:

export MANAGE_LOCAL_HBASE=true
export MANAGE_LOCAL_SOLR=true



# Here is a script that builds and starts Atlas locally from source, it was 
posted to this mailing list earlier. 


BRANCH=0.8-incubating
ATLAS_SOURCE_DIR=/tmp/atlas-source
ATLAS_HOME=/tmp/atlas-bin
rm -rf ${ATLAS_SOURCE_DIR}
rm -rf ${ATLAS_HOME}

# Clone Apache Atlas sources
mkdir -p ${ATLAS_SOURCE_DIR}
cd ${ATLAS_SOURCE_DIR}

git clone https://github.com/apache/atlas.git 
 -b master

# build Apache Atlas
cd atlas
git checkout ${BRANCH}

mvn clean -DskipTests -DGRAPH_PROVIDER=titan0 install 
-Pdist,embedded-hbase-solr,graph-provider-titan0


# Install Apache Atlas
mkdir -p ${ATLAS_HOME}

tar xfz distro/target/apache-atlas-*bin.tar.gz --strip-components 1 -C 
${ATLAS_HOME}


# Setup environment and configuration
export MANAGE_LOCAL_HBASE=true

export MANAGE_LOCAL_SOLR=true

export PATH=${PATH}:/tmp/atlas-bin/bin

echo 
atlas.graphdb.backend=org.apache.atlas.repository.graphdb.titan0.Titan0GraphDatabase
 >> ${ATLAS_HOME}/conf/atlas-application.properties


# Start Apache Atlas
atlas_start.py

# Access Apache Atlas at http://localhost:21000 







On 2/14/18, 2:40 PM, "David Aspegren"  wrote:

>Hi,
>
>I have the same issue. Where are those environment variables for embedded
>hbase described?
>
>regards,
>David
>
>2018-02-14 14:32 GMT+01:00 Ernie Ostic :
>
>> Thanks David...
>>
>> build string I am using is: *mvn clean -DskipTests package
>> -Pdist,embedded-hbase-solr*
>>
>> Will check again the environment variablesthx.
>>
>> Ernie
>>
>>
>>
>>
>>
>> Ernie Ostic
>>
>> Worldwide Technical Sales
>> InfoSphere Information Server
>> IBM Analytics
>>
>> Cell: (617) 331 8238 <(617)%20331-8238>
>> ---
>> Apache Atlas Update! https://dsrealtime.wordpress.
>> com/2017/11/16/apache-atlas-update-have-you-been-watching/
>>
>> Open IGC is here! https://dsrealtime.wordpress.com/2015/07/29/open-igc-is-
>> here/
>>
>> [image: Inactive hide details for David Radley ---02/14/2018 07:44:19
>> AM---Hi Ernie, There are 2 ways to build and run Atlas currently:]David
>> Radley ---02/14/2018 07:44:19 AM---Hi Ernie, There are 2 ways to build and
>> run Atlas currently:
>>
>> From: David Radley 
>> To: dev@atlas.apache.org
>> Date: 02/14/2018 07:44 AM
>> Subject: Re: Server appears to start, but connections fail with 503
>> --
>>
>>
>>
>> Hi Ernie,
>> There are 2 ways to build and run Atlas currently:
>>- external Hbase and Solr and ZK
>>- embedded HBase Solr and ZK
>>
>> I am not sure which one you are trying. Sharing your build string would be
>> helpful. If you are using the embedded HBase option then you need to
>> specify environment variables, for the runtime Atlas to work,
>>
>> As per yesterdays call - Madhan suggests running with an external HBase,
>> as he seems a performance delay using the embedded HBase.
>>   all the best, David.
>>
>>
>>
>> From:   "Ernie Ostic" 
>> To: "Atlas" 
>> Date:   14/02/2018 11:52
>> Subject:Server appears to start, but connections fail with 503
>>
>>
>>
>>
>>
>> Hi all...
>>
>> Using "master", the build appears to be successful, and the server is
>> properly listening on port 21000, but quick start or even direct access
>> fails with 503.   Any suggestions on where to look?   Thanks!
>>
>> Ernie
>>
>>
>>
>> $ bin/quick_start.py
>>
>> log4j:WARN No such property [maxFileSize] in
>> org.apache.log4j.PatternLayout.
>> log4j:WARN No such property [maxBackupIndex] in
>> org.apache.log4j.PatternLayout.
>> log4j:WARN No such property [maxFileSize] in
>> org.apache.log4j.PatternLayout.
>> log4j:WARN No such property [maxBackupIndex] in
>> org.apache.log4j.PatternLayout.
>> log4j:WARN No such property [maxFileSize] in
>> org.apache.log4j.PatternLayout.
>>
>> Enter username for atlas :- admin
>> Enter password for atlas :-
>>
>> Creating sample types:
>>
>> Exception in thread "main" org.apache.atlas.AtlasServiceException:
>> Metadata
>> service API org.apache.atlas.AtlasClientV2$API_V2@1033576a failed with
>> status 503 (Service Unavailable) Response Body (
>> 
>> 
>> Error 503 
>> 
>> 
>> HTTP ERROR: 503
>> Problem accessing /api/atlas/v2/types/typedefs/. Reason:
>> Service Unavailable
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__eclipse.
>> org_jetty=DwMFAg=jf_iaSHvJObTbx-siA1ZOg=
>> QhpUQPr5YlG95aAgCvZGStEXHg4hBbSYQ9JkRqR_svY=
>> 0y7mtLMoBMEc2RNTv8nhllpgWZHIGzqdnqcU0FUYtvg=
>> yRGEThijdpp0lFksddATlowggX7r9D_zX0z2DXZR8EA=
>> ">Powered by Jetty://
>> 9.3.14.v20161028
>> 
>> 
>> )
>> at org.apache.atlas.AtlasBaseClient.callAPIWithResource
>> (AtlasBaseClient.java:388)
>> at org.apache.atlas.AtlasBaseClient.callAPIWithResource
>> (AtlasBaseClient.java:323)

Re: Server appears to start, but connections fail with 503

2018-02-14 Thread David Aspegren
Hi,

I have the same issue. Where are those environment variables for embedded
hbase described?

regards,
David

2018-02-14 14:32 GMT+01:00 Ernie Ostic :

> Thanks David...
>
> build string I am using is: *mvn clean -DskipTests package
> -Pdist,embedded-hbase-solr*
>
> Will check again the environment variablesthx.
>
> Ernie
>
>
>
>
>
> Ernie Ostic
>
> Worldwide Technical Sales
> InfoSphere Information Server
> IBM Analytics
>
> Cell: (617) 331 8238 <(617)%20331-8238>
> ---
> Apache Atlas Update! https://dsrealtime.wordpress.
> com/2017/11/16/apache-atlas-update-have-you-been-watching/
>
> Open IGC is here! https://dsrealtime.wordpress.com/2015/07/29/open-igc-is-
> here/
>
> [image: Inactive hide details for David Radley ---02/14/2018 07:44:19
> AM---Hi Ernie, There are 2 ways to build and run Atlas currently:]David
> Radley ---02/14/2018 07:44:19 AM---Hi Ernie, There are 2 ways to build and
> run Atlas currently:
>
> From: David Radley 
> To: dev@atlas.apache.org
> Date: 02/14/2018 07:44 AM
> Subject: Re: Server appears to start, but connections fail with 503
> --
>
>
>
> Hi Ernie,
> There are 2 ways to build and run Atlas currently:
>- external Hbase and Solr and ZK
>- embedded HBase Solr and ZK
>
> I am not sure which one you are trying. Sharing your build string would be
> helpful. If you are using the embedded HBase option then you need to
> specify environment variables, for the runtime Atlas to work,
>
> As per yesterdays call - Madhan suggests running with an external HBase,
> as he seems a performance delay using the embedded HBase.
>   all the best, David.
>
>
>
> From:   "Ernie Ostic" 
> To: "Atlas" 
> Date:   14/02/2018 11:52
> Subject:Server appears to start, but connections fail with 503
>
>
>
>
>
> Hi all...
>
> Using "master", the build appears to be successful, and the server is
> properly listening on port 21000, but quick start or even direct access
> fails with 503.   Any suggestions on where to look?   Thanks!
>
> Ernie
>
>
>
> $ bin/quick_start.py
>
> log4j:WARN No such property [maxFileSize] in
> org.apache.log4j.PatternLayout.
> log4j:WARN No such property [maxBackupIndex] in
> org.apache.log4j.PatternLayout.
> log4j:WARN No such property [maxFileSize] in
> org.apache.log4j.PatternLayout.
> log4j:WARN No such property [maxBackupIndex] in
> org.apache.log4j.PatternLayout.
> log4j:WARN No such property [maxFileSize] in
> org.apache.log4j.PatternLayout.
>
> Enter username for atlas :- admin
> Enter password for atlas :-
>
> Creating sample types:
>
> Exception in thread "main" org.apache.atlas.AtlasServiceException:
> Metadata
> service API org.apache.atlas.AtlasClientV2$API_V2@1033576a failed with
> status 503 (Service Unavailable) Response Body (
> 
> 
> Error 503 
> 
> 
> HTTP ERROR: 503
> Problem accessing /api/atlas/v2/types/typedefs/. Reason:
> Service Unavailable
> https://urldefense.proofpoint.com/v2/url?u=http-3A__eclipse.
> org_jetty=DwMFAg=jf_iaSHvJObTbx-siA1ZOg=
> QhpUQPr5YlG95aAgCvZGStEXHg4hBbSYQ9JkRqR_svY=
> 0y7mtLMoBMEc2RNTv8nhllpgWZHIGzqdnqcU0FUYtvg=
> yRGEThijdpp0lFksddATlowggX7r9D_zX0z2DXZR8EA=
> ">Powered by Jetty://
> 9.3.14.v20161028
> 
> 
> )
> at org.apache.atlas.AtlasBaseClient.callAPIWithResource
> (AtlasBaseClient.java:388)
> at org.apache.atlas.AtlasBaseClient.callAPIWithResource
> (AtlasBaseClient.java:323)
> at
> org.apache.atlas.AtlasBaseClient.callAPI(AtlasBaseClient.java:211)
> at org.apache.atlas.AtlasClientV2.createAtlasTypeDefs
> (AtlasClientV2.java:227)
> at org.apache.atlas.examples.QuickStartV2.createTypes
> (QuickStartV2.java:185)
> at org.apache.atlas.examples.QuickStartV2.runQuickstart
> (QuickStartV2.java:141)
> at
> org.apache.atlas.examples.QuickStartV2.main(QuickStartV2.java:126)
>
> No sample data added to Apache Atlas Server.
>
>
>
> Ernie Ostic
>
> Worldwide Technical Sales
> InfoSphere Information Server
> IBM Analytics
>
> Cell: (617) 331 8238 <(617)%20331-8238>
> ---
> Apache Atlas Update!
> https://urldefense.proofpoint.com/v2/url?u=https-3A__
> dsrealtime.wordpress.com_2017_11_16_apache-2Datlas-2Dupdate-
> 2Dhave-2Dyou-2Dbeen-2Dwatching_=DwIBAg=jf_iaSHvJObTbx-siA1ZOg=BRpv_
> IJLfOPKPg5CMvWe7vPrIiVO97XiMOUrvOhs2KY=M6GayZu1Kz1n1GaBTw60dDAEVnvATx
> HnnOZGJSEzcpU=gs5vWioZh6a6c0_9DRS06onmI6SoY4Wxjtoi5INdgyc=
>
>
> Open IGC is here!
> https://urldefense.proofpoint.com/v2/url?u=https-3A__
> dsrealtime.wordpress.com_2015_07_29_open-2Digc-2Dis-2Dhere_&
> d=DwIBAg=jf_iaSHvJObTbx-siA1ZOg=BRpv_IJLfOPKPg5CMvWe7vPrIiVO97XiMOU
> rvOhs2KY=M6GayZu1Kz1n1GaBTw60dDAEVnvATxHnnOZGJSEzcpU=
> zBAZF9LhSU96ytXo2OgCgXnZ8rriyL26nX82uskl8bY=
>
>
>
> Unless stated otherwise above:
> IBM 

Re: Server appears to start, but connections fail with 503

2018-02-14 Thread Ernie Ostic

Thanks David...

build string I am using is:   mvn clean -DskipTests package
-Pdist,embedded-hbase-solr

Will check again the environment variablesthx.

Ernie





Ernie Ostic

Worldwide Technical Sales
InfoSphere Information Server
IBM Analytics

Cell: (617) 331 8238
---
Apache Atlas Update!
https://dsrealtime.wordpress.com/2017/11/16/apache-atlas-update-have-you-been-watching/

Open IGC is here!
https://dsrealtime.wordpress.com/2015/07/29/open-igc-is-here/



From:   David Radley 
To: dev@atlas.apache.org
Date:   02/14/2018 07:44 AM
Subject:Re: Server appears to start, but connections fail with 503



Hi Ernie,
There are 2 ways to build and run Atlas currently:
- external Hbase and Solr and ZK
- embedded HBase Solr and ZK

I am not sure which one you are trying. Sharing your build string would be
helpful. If you are using the embedded HBase option then you need to
specify environment variables, for the runtime Atlas to work,

As per yesterdays call - Madhan suggests running with an external HBase,
as he seems a performance delay using the embedded HBase.
   all the best, David.



From:   "Ernie Ostic" 
To: "Atlas" 
Date:   14/02/2018 11:52
Subject:Server appears to start, but connections fail with 503





Hi all...

Using "master", the build appears to be successful, and the server is
properly listening on port 21000, but quick start or even direct access
fails with 503.   Any suggestions on where to look?   Thanks!

Ernie



$ bin/quick_start.py

log4j:WARN No such property [maxFileSize] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxBackupIndex] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxFileSize] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxBackupIndex] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxFileSize] in
org.apache.log4j.PatternLayout.

Enter username for atlas :- admin
Enter password for atlas :-

Creating sample types:

Exception in thread "main" org.apache.atlas.AtlasServiceException:
Metadata
service API org.apache.atlas.AtlasClientV2$API_V2@1033576a failed with
status 503 (Service Unavailable) Response Body (


Error 503 


HTTP ERROR: 503
Problem accessing /api/atlas/v2/types/typedefs/. Reason:
Service Unavailable
https://urldefense.proofpoint.com/v2/url?u=http-3A__eclipse.org_jetty=DwMFAg=jf_iaSHvJObTbx-siA1ZOg=QhpUQPr5YlG95aAgCvZGStEXHg4hBbSYQ9JkRqR_svY=0y7mtLMoBMEc2RNTv8nhllpgWZHIGzqdnqcU0FUYtvg=yRGEThijdpp0lFksddATlowggX7r9D_zX0z2DXZR8EA=

">Powered by Jetty://
9.3.14.v20161028


)
 at org.apache.atlas.AtlasBaseClient.callAPIWithResource
(AtlasBaseClient.java:388)
 at org.apache.atlas.AtlasBaseClient.callAPIWithResource
(AtlasBaseClient.java:323)
 at
org.apache.atlas.AtlasBaseClient.callAPI(AtlasBaseClient.java:211)
 at org.apache.atlas.AtlasClientV2.createAtlasTypeDefs
(AtlasClientV2.java:227)
 at org.apache.atlas.examples.QuickStartV2.createTypes
(QuickStartV2.java:185)
 at org.apache.atlas.examples.QuickStartV2.runQuickstart
(QuickStartV2.java:141)
 at
org.apache.atlas.examples.QuickStartV2.main(QuickStartV2.java:126)

No sample data added to Apache Atlas Server.



Ernie Ostic

Worldwide Technical Sales
InfoSphere Information Server
IBM Analytics

Cell: (617) 331 8238
---
Apache Atlas Update!
https://urldefense.proofpoint.com/v2/url?u=https-3A__dsrealtime.wordpress.com_2017_11_16_apache-2Datlas-2Dupdate-2Dhave-2Dyou-2Dbeen-2Dwatching_=DwIBAg=jf_iaSHvJObTbx-siA1ZOg=BRpv_IJLfOPKPg5CMvWe7vPrIiVO97XiMOUrvOhs2KY=M6GayZu1Kz1n1GaBTw60dDAEVnvATxHnnOZGJSEzcpU=gs5vWioZh6a6c0_9DRS06onmI6SoY4Wxjtoi5INdgyc=



Open IGC is here!
https://urldefense.proofpoint.com/v2/url?u=https-3A__dsrealtime.wordpress.com_2015_07_29_open-2Digc-2Dis-2Dhere_=DwIBAg=jf_iaSHvJObTbx-siA1ZOg=BRpv_IJLfOPKPg5CMvWe7vPrIiVO97XiMOUrvOhs2KY=M6GayZu1Kz1n1GaBTw60dDAEVnvATxHnnOZGJSEzcpU=zBAZF9LhSU96ytXo2OgCgXnZ8rriyL26nX82uskl8bY=




Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU




[jira] [Updated] (ATLAS-2440) UI : select on "date" attribute results value in long format instead of formatted date.

2018-02-14 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2440:
-
Attachment: ATLAS-2440.1.patch

> UI : select on "date" attribute results value in long format instead of 
> formatted date.
> ---
>
> Key: ATLAS-2440
> URL: https://issues.apache.org/jira/browse/ATLAS-2440
> Project: Atlas
>  Issue Type: Bug
>Reporter: pratik pandey
>Assignee: pratik pandey
>Priority: Major
> Fix For: 0.8.2, 1.0.0
>
> Attachments: ATLAS-2440.1.patch, ATLAS-2440.patch
>
>
> hive_table select createTime 
> lists the createTime in long format.
> On detailsPage or results page of basic search , the value is formatted date 
> and not long value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Server appears to start, but connections fail with 503

2018-02-14 Thread David Radley
Hi Ernie,
There are 2 ways to build and run Atlas currently:
- external Hbase and Solr and ZK
- embedded HBase Solr and ZK

I am not sure which one you are trying. Sharing your build string would be 
helpful. If you are using the embedded HBase option then you need to 
specify environment variables, for the runtime Atlas to work,

As per yesterdays call - Madhan suggests running with an external HBase, 
as he seems a performance delay using the embedded HBase. 
   all the best, David. 



From:   "Ernie Ostic" 
To: "Atlas" 
Date:   14/02/2018 11:52
Subject:Server appears to start, but connections fail with 503





Hi all...

Using "master", the build appears to be successful, and the server is
properly listening on port 21000, but quick start or even direct access
fails with 503.   Any suggestions on where to look?   Thanks!

Ernie



$ bin/quick_start.py

log4j:WARN No such property [maxFileSize] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxBackupIndex] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxFileSize] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxBackupIndex] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxFileSize] in
org.apache.log4j.PatternLayout.

Enter username for atlas :- admin
Enter password for atlas :-

Creating sample types:

Exception in thread "main" org.apache.atlas.AtlasServiceException: 
Metadata
service API org.apache.atlas.AtlasClientV2$API_V2@1033576a failed with
status 503 (Service Unavailable) Response Body (


Error 503 


HTTP ERROR: 503
Problem accessing /api/atlas/v2/types/typedefs/. Reason:
Service Unavailable
https://urldefense.proofpoint.com/v2/url?u=http-3A__eclipse.org_jetty=DwMFAg=jf_iaSHvJObTbx-siA1ZOg=QhpUQPr5YlG95aAgCvZGStEXHg4hBbSYQ9JkRqR_svY=0y7mtLMoBMEc2RNTv8nhllpgWZHIGzqdnqcU0FUYtvg=yRGEThijdpp0lFksddATlowggX7r9D_zX0z2DXZR8EA=
">Powered by Jetty://
9.3.14.v20161028


)
 at org.apache.atlas.AtlasBaseClient.callAPIWithResource
(AtlasBaseClient.java:388)
 at org.apache.atlas.AtlasBaseClient.callAPIWithResource
(AtlasBaseClient.java:323)
 at 
org.apache.atlas.AtlasBaseClient.callAPI(AtlasBaseClient.java:211)
 at org.apache.atlas.AtlasClientV2.createAtlasTypeDefs
(AtlasClientV2.java:227)
 at org.apache.atlas.examples.QuickStartV2.createTypes
(QuickStartV2.java:185)
 at org.apache.atlas.examples.QuickStartV2.runQuickstart
(QuickStartV2.java:141)
 at 
org.apache.atlas.examples.QuickStartV2.main(QuickStartV2.java:126)

No sample data added to Apache Atlas Server.



Ernie Ostic

Worldwide Technical Sales
InfoSphere Information Server
IBM Analytics

Cell: (617) 331 8238
---
Apache Atlas Update!
https://dsrealtime.wordpress.com/2017/11/16/apache-atlas-update-have-you-been-watching/


Open IGC is here!
https://dsrealtime.wordpress.com/2015/07/29/open-igc-is-here/



Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU


Re: Review Request 65632: ATLAS-2441 : UI : DSL Search : type select __guid doesn't display result though the result has GUID response.

2018-02-14 Thread keval bhatt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65632/#review197511
---


Ship it!




Ship It!

- keval bhatt


On Feb. 14, 2018, 11:05 a.m., pratik pandey wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65632/
> ---
> 
> (Updated Feb. 14, 2018, 11:05 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
> Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2441
> https://issues.apache.org/jira/browse/ATLAS-2441
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> DSL query 
> hive_table select __guid
> 
> results all the guids. But the UI doesn't display them.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/utils/CommonViewFunction.js 6a5fe25 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js b3f339b 
> 
> 
> Diff: https://reviews.apache.org/r/65632/diff/2/
> 
> 
> Testing
> ---
> 
> Done one round of sanity testing.
> 
> 
> Thanks,
> 
> pratik pandey
> 
>



Re: Server appears to start, but connections fail with 503

2018-02-14 Thread Nixon Rodrigues
Ernie,

Look in logs/application.log for exact issue Atlas is facing with.

How did you build Atlas?

Nixon


On Feb 14, 2018 5:22 PM, "Ernie Ostic"  wrote:



Hi all...

Using "master", the build appears to be successful, and the server is
properly listening on port 21000, but quick start or even direct access
fails with 503.   Any suggestions on where to look?   Thanks!

Ernie



$ bin/quick_start.py

log4j:WARN No such property [maxFileSize] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxBackupIndex] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxFileSize] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxBackupIndex] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxFileSize] in
org.apache.log4j.PatternLayout.

Enter username for atlas :- admin
Enter password for atlas :-

Creating sample types:

Exception in thread "main" org.apache.atlas.AtlasServiceException: Metadata
service API org.apache.atlas.AtlasClientV2$API_V2@1033576a failed with
status 503 (Service Unavailable) Response Body (


Error 503 


HTTP ERROR: 503
Problem accessing /api/atlas/v2/types/typedefs/. Reason:
Service Unavailable
http://eclipse.org/jetty;>Powered by Jetty://
9.3.14.v20161028


)
at org.apache.atlas.AtlasBaseClient.callAPIWithResource
(AtlasBaseClient.java:388)
at org.apache.atlas.AtlasBaseClient.callAPIWithResource
(AtlasBaseClient.java:323)
at org.apache.atlas.AtlasBaseClient.callAPI(
AtlasBaseClient.java:211)
at org.apache.atlas.AtlasClientV2.createAtlasTypeDefs
(AtlasClientV2.java:227)
at org.apache.atlas.examples.QuickStartV2.createTypes
(QuickStartV2.java:185)
at org.apache.atlas.examples.QuickStartV2.runQuickstart
(QuickStartV2.java:141)
at org.apache.atlas.examples.QuickStartV2.main(
QuickStartV2.java:126)

No sample data added to Apache Atlas Server.



Ernie Ostic

Worldwide Technical Sales
InfoSphere Information Server
IBM Analytics

Cell: (617) 331 8238
---
Apache Atlas Update!
https://dsrealtime.wordpress.com/2017/11/16/apache-atlas-
update-have-you-been-watching/

Open IGC is here!
https://dsrealtime.wordpress.com/2015/07/29/open-igc-is-here/


Server appears to start, but connections fail with 503

2018-02-14 Thread Ernie Ostic


Hi all...

Using "master", the build appears to be successful, and the server is
properly listening on port 21000, but quick start or even direct access
fails with 503.   Any suggestions on where to look?   Thanks!

Ernie



$ bin/quick_start.py

log4j:WARN No such property [maxFileSize] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxBackupIndex] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxFileSize] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxBackupIndex] in
org.apache.log4j.PatternLayout.
log4j:WARN No such property [maxFileSize] in
org.apache.log4j.PatternLayout.

Enter username for atlas :- admin
Enter password for atlas :-

Creating sample types:

Exception in thread "main" org.apache.atlas.AtlasServiceException: Metadata
service API org.apache.atlas.AtlasClientV2$API_V2@1033576a failed with
status 503 (Service Unavailable) Response Body (


Error 503 


HTTP ERROR: 503
Problem accessing /api/atlas/v2/types/typedefs/. Reason:
Service Unavailable
http://eclipse.org/jetty;>Powered by Jetty://
9.3.14.v20161028


)
at org.apache.atlas.AtlasBaseClient.callAPIWithResource
(AtlasBaseClient.java:388)
at org.apache.atlas.AtlasBaseClient.callAPIWithResource
(AtlasBaseClient.java:323)
at org.apache.atlas.AtlasBaseClient.callAPI(AtlasBaseClient.java:211)
at org.apache.atlas.AtlasClientV2.createAtlasTypeDefs
(AtlasClientV2.java:227)
at org.apache.atlas.examples.QuickStartV2.createTypes
(QuickStartV2.java:185)
at org.apache.atlas.examples.QuickStartV2.runQuickstart
(QuickStartV2.java:141)
at org.apache.atlas.examples.QuickStartV2.main(QuickStartV2.java:126)

No sample data added to Apache Atlas Server.



Ernie Ostic

Worldwide Technical Sales
InfoSphere Information Server
IBM Analytics

Cell: (617) 331 8238
---
Apache Atlas Update!
https://dsrealtime.wordpress.com/2017/11/16/apache-atlas-update-have-you-been-watching/

Open IGC is here!
https://dsrealtime.wordpress.com/2015/07/29/open-igc-is-here/


[jira] [Updated] (ATLAS-2441) UI : DSL Search : type select __guid doesn't display result though the result has GUID response

2018-02-14 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2441:
-
Attachment: ATLAS-2441.1.patch

> UI : DSL Search : type select __guid doesn't display result though the result 
> has GUID response
> ---
>
> Key: ATLAS-2441
> URL: https://issues.apache.org/jira/browse/ATLAS-2441
> Project: Atlas
>  Issue Type: Bug
>Reporter: pratik pandey
>Assignee: pratik pandey
>Priority: Major
> Fix For: 0.8.2, 1.0.0
>
> Attachments: ATLAS-2441.1.patch, ATLAS-2441.patch
>
>
> DSL query 
> hive_table select __guid
> results all the guids. But the UI doesn't display them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 65633: ATLAS-2440 : UI , select on "date" attribute results value in long format instead of formatted date

2018-02-14 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65633/
---

(Updated Feb. 14, 2018, 9:49 a.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Changes
---

review request comment handled.


Bugs: ATLAS-2440
https://issues.apache.org/jira/browse/ATLAS-2440


Repository: atlas


Description
---

query :

hive_table select createTime 
lists the createTime in long format.

On detailsPage or results page of basic search , the value is formatted date 
and not long value.


Diffs (updated)
-

  dashboardv2/public/js/utils/CommonViewFunction.js 6a5fe25 


Diff: https://reviews.apache.org/r/65633/diff/2/

Changes: https://reviews.apache.org/r/65633/diff/1-2/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



Jenkins build is back to normal : Atlas-master-IntegrationTests #515

2018-02-14 Thread Apache Jenkins Server
See 




Build failed in Jenkins: Atlas-0.8-IntegrationTests #170

2018-02-14 Thread Apache Jenkins Server
See 


Changes:

[madhan] ATLAS-2439: updated Sqoop hook to use V2 notifications (#2)

--
[...truncated 442.78 KB...]
INFO: Registering Spring bean, typesResource, of type 
org.apache.atlas.web.resources.TypesResource as a root resource class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, taxonomyService, of type 
org.apache.atlas.web.resources.TaxonomyService as a root resource class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, metadataDiscoveryResource, of type 
org.apache.atlas.web.resources.MetadataDiscoveryResource as a root resource 
class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, adminResource, of type 
org.apache.atlas.web.resources.AdminResource as a root resource class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, lineageResource, of type 
org.apache.atlas.web.resources.LineageResource as a root resource class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, entityResource, of type 
org.apache.atlas.web.resources.EntityResource as a root resource class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, dataSetLineageResource, of type 
org.apache.atlas.web.resources.DataSetLineageResource as a root resource class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, entityService, of type 
org.apache.atlas.web.resources.EntityService as a root resource class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, atlasBaseExceptionMapper, of type 
org.apache.atlas.web.errors.AtlasBaseExceptionMapper as a provider class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, allExceptionMapper, of type 
org.apache.atlas.web.errors.AllExceptionMapper as a provider class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, notFoundExceptionMapper, of type 
org.apache.atlas.web.errors.NotFoundExceptionMapper as a provider class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, typesREST, of type 
org.apache.atlas.web.rest.TypesREST as a root resource class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, entityREST, of type 
org.apache.atlas.web.rest.EntityREST as a root resource class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, lineageREST, of type 
org.apache.atlas.web.rest.LineageREST as a root resource class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.spi.spring.container.SpringComponentProviderFactory 
registerSpringBeans
INFO: Registering Spring bean, discoveryREST, of type 
org.apache.atlas.web.rest.DiscoveryREST as a root resource class
Feb 14, 2018 8:46:45 AM 
com.sun.jersey.server.impl.application.WebApplicationImpl _initiate
INFO: Initiating Jersey application, version 'Jersey: 1.19 02/11/2015 03:25 AM'
[INFO] Started 
o.e.j.m.p.JettyWebAppContext@7565348b{/,
[INFO] Started ServerConnector@52ad0e4f{HTTP/1.1}{0.0.0.0:31000}
[INFO] Started @438761ms
[INFO] Started Jetty Server
[INFO] 
[INFO] --- maven-failsafe-plugin:2.18.1:integration-test (integration-test) @ 
atlas-webapp ---
[WARNING] useSystemClassloader setting has no effect when not forking
[INFO] Failsafe report directory: 

Running TestSuite
127.0.0.1 - - [14/Feb/2018:08:46:54 +] "GET 
/api/atlas/v2/types/typedef/name/tableType HTTP/1.1" 404 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:08:46:54 +] "GET 
/api/atlas/v2/types/typedef/name/serdeType HTTP/1.1" 404 - "-" "Java/1.8.0_152"
127.0.0.1 - - [14/Feb/2018:08:46:54 +] "GET 

Jenkins build is back to normal : Atlas-0.8-NoTests #170

2018-02-14 Thread Apache Jenkins Server
See