Re: Review Request 69133: ATLAS-2934: utility to detect and repair incorrect entity state

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69133/#review209948
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
Lines 255 (patched)


can we overload checkState() to take List, this will help 
avoid fetching vertex again from guid ? 

* checkState(vertices, request.getFixIssues(), ret);
* checkState(guids, request.getFixIssues(), ret);


- Sarath Subramanian


On Oct. 23, 2018, 6:25 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69133/
> ---
> 
> (Updated Oct. 23, 2018, 6:25 p.m.)
> 
> 
> Review request for atlas, Abhishek Kadam, Apoorv Naik, Ashutosh Mestry, keval 
> bhatt, Kapildeo Nayak, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2934
> https://issues.apache.org/jira/browse/ATLAS-2934
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch adds a REST API to scan specified entities for inconsistency of 
> __traitNames property value and fix it. If the property value does not match 
> the classification vertices associated with the entity, the value will be 
> updated to reflect the associated vertices.
> 
> 
> Diffs
> -
> 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasCheckStateRequest.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasCheckStateResult.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  6a1a88f4f 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  449a9588e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  0445e2798 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> b53ac69c4 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
> 2f4b3d9bb 
> 
> 
> Diff: https://reviews.apache.org/r/69133/diff/1/
> 
> 
> Testing
> ---
> 
> Verified that the new API detects and fixes __traitNames property, for the 
> inconsistencies introduced. Here is a sample response from the call:
> 
> {
> "state":   "FIXED",
> "entitiesScanned":   19021,
> "entitiesFixed": 1,
> "entitiesNotFixed":  0,
> "entitiesOk":19020,
> "entitiesPartiallyFixed":0,
> "entities": {
> "e87a1236-eeb4-4474-8cfd-a82117b8d1cd": {
> "guid": "e87a1236-eeb4-4474-8cfd-a82117b8d1cd",
> "name": "testDb.testTable@myCluster",
> "state":"FIXED",
> "status":   "ACTIVE",
> "typeName": "hive_table",
> "issues": [
> "incorrect property: __traitNames has missing 
> classifications: [DATA_QUALITY]",
> "incorrect property: __traitNames has unassigned 
> classifications: [UNKNOWN_TAG2, UNKNOWN_TAG]"
> ]
> }
> }
> }
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[jira] [Updated] (ATLAS-2930) UI changes to handle error message based on softReference attribute.

[Abhishek Kadam (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kadam updated ATLAS-2930:
--
Attachment: ATLAS-2930_isSoftReference_master.patch
ATLAS-2930_isSoftReference_branch-0.8.patch

> UI changes to handle error message based on softReference attribute.
> 
>
> Key: ATLAS-2930
> URL: https://issues.apache.org/jira/browse/ATLAS-2930
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 0.8.2
>Reporter: Abhishek Kadam
>Assignee: Abhishek Kadam
>Priority: Major
> Fix For: 0.8.3, 2.0.0, 1.2.0
>
> Attachments: ATLAS-2930_isSoftReference_branch-0.8.patch, 
> ATLAS-2930_isSoftReference_master.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2930) UI changes to handle error message based on softReference attribute.

[Abhishek Kadam (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kadam updated ATLAS-2930:
--
Attachment: (was: ATLAS-2930_branch-0.8.patch)

> UI changes to handle error message based on softReference attribute.
> 
>
> Key: ATLAS-2930
> URL: https://issues.apache.org/jira/browse/ATLAS-2930
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 0.8.2
>Reporter: Abhishek Kadam
>Assignee: Abhishek Kadam
>Priority: Major
> Fix For: 0.8.3, 2.0.0, 1.2.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2930) UI changes to handle error message based on softReference attribute.

[Abhishek Kadam (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kadam updated ATLAS-2930:
--
Attachment: (was: ATLAS-2930_isSoftReference_master.patch)

> UI changes to handle error message based on softReference attribute.
> 
>
> Key: ATLAS-2930
> URL: https://issues.apache.org/jira/browse/ATLAS-2930
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 0.8.2
>Reporter: Abhishek Kadam
>Assignee: Abhishek Kadam
>Priority: Major
> Fix For: 0.8.3, 2.0.0, 1.2.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2930) UI changes to handle error message based on softReference attribute.

[Abhishek Kadam (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kadam updated ATLAS-2930:
--
Attachment: (was: ATLAS-2930_isSoftReference_branch-0.8.patch)

> UI changes to handle error message based on softReference attribute.
> 
>
> Key: ATLAS-2930
> URL: https://issues.apache.org/jira/browse/ATLAS-2930
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 0.8.2
>Reporter: Abhishek Kadam
>Assignee: Abhishek Kadam
>Priority: Major
> Fix For: 0.8.3, 2.0.0, 1.2.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2930) UI changes to handle error message based on softReference attribute.

[Abhishek Kadam (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kadam updated ATLAS-2930:
--
Attachment: (was: ATLAS-2930_master.patch)

> UI changes to handle error message based on softReference attribute.
> 
>
> Key: ATLAS-2930
> URL: https://issues.apache.org/jira/browse/ATLAS-2930
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 0.8.2
>Reporter: Abhishek Kadam
>Assignee: Abhishek Kadam
>Priority: Major
> Fix For: 0.8.3, 2.0.0, 1.2.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 69133: ATLAS-2934: utility to detect and repair incorrect entity state

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69133/#review209947
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
Lines 259 (patched)


Same multi-responsibility concept is being applied here. 

I feel it's better to break this down into checkState and fixState methods.



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
Lines 866 (patched)


This method is performing two different actions. Ideally a method should 
only perform one action.

Also when I look at checkState method signature, the initial impression I 
get is that this would perform a diagnostic kind of operation, but internally 
it does some corrections as well on the basis of the boolean flag. If possible, 
please make separate methods to address these actions.



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
Lines 872 (patched)


Can't we get the EntityGraphRetriever object using injection at class level 
?

Here for each guid a new object gets created.


- Apoorv Naik


On Oct. 24, 2018, 1:25 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69133/
> ---
> 
> (Updated Oct. 24, 2018, 1:25 a.m.)
> 
> 
> Review request for atlas, Abhishek Kadam, Apoorv Naik, Ashutosh Mestry, keval 
> bhatt, Kapildeo Nayak, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2934
> https://issues.apache.org/jira/browse/ATLAS-2934
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch adds a REST API to scan specified entities for inconsistency of 
> __traitNames property value and fix it. If the property value does not match 
> the classification vertices associated with the entity, the value will be 
> updated to reflect the associated vertices.
> 
> 
> Diffs
> -
> 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasCheckStateRequest.java
>  PRE-CREATION 
>   
> intg/src/main/java/org/apache/atlas/model/instance/AtlasCheckStateResult.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  6a1a88f4f 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  449a9588e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  0445e2798 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> b53ac69c4 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
> 2f4b3d9bb 
> 
> 
> Diff: https://reviews.apache.org/r/69133/diff/1/
> 
> 
> Testing
> ---
> 
> Verified that the new API detects and fixes __traitNames property, for the 
> inconsistencies introduced. Here is a sample response from the call:
> 
> {
> "state":   "FIXED",
> "entitiesScanned":   19021,
> "entitiesFixed": 1,
> "entitiesNotFixed":  0,
> "entitiesOk":19020,
> "entitiesPartiallyFixed":0,
> "entities": {
> "e87a1236-eeb4-4474-8cfd-a82117b8d1cd": {
> "guid": "e87a1236-eeb4-4474-8cfd-a82117b8d1cd",
> "name": "testDb.testTable@myCluster",
> "state":"FIXED",
> "status":   "ACTIVE",
> "typeName": "hive_table",
> "issues": [
> "incorrect property: __traitNames has missing 
> classifications: [DATA_QUALITY]",
> "incorrect property: __traitNames has unassigned 
> classifications: [UNKNOWN_TAG2, UNKNOWN_TAG]"
> ]
> }
> }
> }
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Review Request 69133: ATLAS-2934: utility to detect and repair incorrect entity state

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69133/
---

Review request for atlas, Abhishek Kadam, Apoorv Naik, Ashutosh Mestry, keval 
bhatt, Kapildeo Nayak, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-2934
https://issues.apache.org/jira/browse/ATLAS-2934


Repository: atlas


Description
---

This patch adds a REST API to scan specified entities for inconsistency of 
__traitNames property value and fix it. If the property value does not match 
the classification vertices associated with the entity, the value will be 
updated to reflect the associated vertices.


Diffs
-

  
intg/src/main/java/org/apache/atlas/model/instance/AtlasCheckStateRequest.java 
PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasCheckStateResult.java 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 6a1a88f4f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 449a9588e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
 0445e2798 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
b53ac69c4 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
2f4b3d9bb 


Diff: https://reviews.apache.org/r/69133/diff/1/


Testing
---

Verified that the new API detects and fixes __traitNames property, for the 
inconsistencies introduced. Here is a sample response from the call:

{
"state":   "FIXED",
"entitiesScanned":   19021,
"entitiesFixed": 1,
"entitiesNotFixed":  0,
"entitiesOk":19020,
"entitiesPartiallyFixed":0,
"entities": {
"e87a1236-eeb4-4474-8cfd-a82117b8d1cd": {
"guid": "e87a1236-eeb4-4474-8cfd-a82117b8d1cd",
"name": "testDb.testTable@myCluster",
"state":"FIXED",
"status":   "ACTIVE",
"typeName": "hive_table",
"issues": [
"incorrect property: __traitNames has missing classifications: 
[DATA_QUALITY]",
"incorrect property: __traitNames has unassigned 
classifications: [UNKNOWN_TAG2, UNKNOWN_TAG]"
]
}
}
}


Thanks,

Madhan Neethiraj

[jira] [Created] (ATLAS-2934) Utility to detect incorrect entity state

[Madhan Neethiraj (JIRA)]

Madhan Neethiraj created ATLAS-2934:
---

 Summary: Utility to detect incorrect entity state
 Key: ATLAS-2934
 URL: https://issues.apache.org/jira/browse/ATLAS-2934
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Affects Versions: 1.0.0, 0.8.2, 1.1.0
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj


Data of an Atlas entity data is stored in one or more graph vertices, connected 
by edges. In addition to vertices for each entity classification, Atlas has 
classification-names cached in a entity vertex property as well - for use in 
entity-searches. An utility to detect and repair any inconsistencies of this 
cached data will be handy in troubleshooting and fixing issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ATLAS-2933) Empty array attributes are returned as null instead of an empty list

[Cade Parker (JIRA)]

Cade Parker created ATLAS-2933:
--

 Summary: Empty array attributes are returned as null instead of an 
empty list
 Key: ATLAS-2933
 URL: https://issues.apache.org/jira/browse/ATLAS-2933
 Project: Atlas
  Issue Type: Bug
Affects Versions: 1.1.0
Reporter: Cade Parker


 

Given the following entity def:
{code:java}
{
 "entityDefs": [
   {
 "name": "ExampleType",
 "superTypes": [],
 "typeVersion": "0.1",
 "attributeDefs": [
   {
 "name": "things",
 "typeName": "array",
 "cardinality": "SINGLE",
 "isIndexable": false,
 "isOptional": false,
 "isUnique": false
   }
 ]
   }
 ]
}
{code}

I can POST a new entity with an empty array for the things attribute 
successfully:
{code:java}
POST /api/atlas/v2/entity

{
 "entity":{
 "typeName":"ExampleType",
 "attributes":{
   "things": []
 },
 "guid":"-thing",
 "version":1
 }
}
{code}

But when i GET the entity by guid, the attribute is null instead of the empty 
list:
{code:java}
GET /api/atlas/v2/entity/guid/d5e33187-3293-4206-bcb8-807dc87c1440

{
 "referredEntities": {},
 "entity": {
 "typeName": "ExampleType",
 "attributes": {
   "things": null
 },
 "guid": "d5e33187-3293-4206-bcb8-807dc87c1440",
 "status": "ACTIVE",
 "createdBy": "admin",
 "updatedBy": "admin",
 "createTime": 1540335741854,
 "updateTime": 1540335741854,
 "version": 1
 }
}
{code}

Atlas should preserve the original value of the create request as an empty 
list. Returning null here causes further confusion, because the attribute is 
defined with `isOptional: false` so any consumer of the entity would reasonably 
expect a non-null value.

I tested this behavior against Atlas versions 1.0.0 and 1.1.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2932) Update DSL to use Java Traversal API

[Apoorv Naik (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apoorv Naik updated ATLAS-2932:
---
Attachment: 0002-ATLAS-2932-Update-DSL-to-use-Tinkerpop-Java-APIs-ins.patch

> Update DSL to use Java Traversal API
> 
>
> Key: ATLAS-2932
> URL: https://issues.apache.org/jira/browse/ATLAS-2932
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0, trunk
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.1.0
>
> Attachments: 
> 0002-ATLAS-2932-Update-DSL-to-use-Tinkerpop-Java-APIs-ins.patch
>
>
> Change DSL code to use Java Tinkerpop Traversals instead of 
> GremlinScriptEngine



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 69131: ATLAS-2932: Update DSL to use Tinkerpop APIs instead of GremlinScriptEngine

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69131/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-2932
https://issues.apache.org/jira/browse/ATLAS-2932


Repository: atlas


Description
---

Updated code runs a lot faster.

Existing: 91s (best case)
Updated:  25s (best case)


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
2378d6bb3 
  repository/src/main/java/org/apache/atlas/query/AtlasDSL.java b8a744b35 
  repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f 
  repository/src/main/java/org/apache/atlas/query/GremlinClauseList.java 
71179772a 
  repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
17c837bb3 
  repository/src/main/java/org/apache/atlas/query/GremlinTraversal.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 
e74c0f5a0 
  repository/src/main/java/org/apache/atlas/query/Lookup.java ec95f5d89 
  repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java 
e0fb4d821 
  repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java 
999fe5c8b 
  repository/src/main/java/org/apache/atlas/query/SelectClauseMetadata.java 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 f03262faa 
  
repository/src/main/java/org/apache/atlas/util/AtlasNumericTypeComparator.java 
PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java
 bf16145a3 
  repository/src/main/java/org/apache/atlas/util/DSLProjectionUtil.java 
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 36ec3d255 
  repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 
568667054 


Diff: https://reviews.apache.org/r/69131/diff/1/


Testing
---

Existing DSL tests run successfully.


Thanks,

Apoorv Naik

[jira] [Updated] (ATLAS-2520) Use JanusGraph traversal over gremlin script

[Apoorv Naik (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apoorv Naik updated ATLAS-2520:
---
Attachment: (was: 0001-DSL-using-graph-traversal.patch)

> Use JanusGraph traversal over gremlin script 
> -
>
> Key: ATLAS-2520
> URL: https://issues.apache.org/jira/browse/ATLAS-2520
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0-alpha
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.1.0
>
> Attachments: 
> 0001-ATLAS-2520-Introduce-JanusGraphTraversal-to-deprecat.patch, Screen Shot 
> 2018-06-05 at 6.16.42 PM.png, Screen Shot 2018-06-05 at 6.19.33 PM.png
>
>
> Currently lot of code in Atlas follow a concept of GremlinQueryProvider which 
> gives TP2 and TP3 queries depending on the graph backend being used. Since 
> Atlas 1.0 is primarily going to rely on JanusGraph, it makes a more sense to 
> remove TP2 related queries/abstractions and use the GraphTraversal Java API 
> provided by JanusGraph.
>  
> PRO: Lot of unused code can be removed, more expressive Graph 
> querying/traversal.
> CONS: Decommissioning TP2 completely is a major engineering effort



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2520) Use JanusGraph traversal over gremlin script

[Apoorv Naik (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apoorv Naik updated ATLAS-2520:
---
Attachment: 0001-ATLAS-2520-Introduce-JanusGraphTraversal-to-deprecat.patch

> Use JanusGraph traversal over gremlin script 
> -
>
> Key: ATLAS-2520
> URL: https://issues.apache.org/jira/browse/ATLAS-2520
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 1.0.0-alpha
>Reporter: Apoorv Naik
>Assignee: Apoorv Naik
>Priority: Major
> Fix For: 1.1.0
>
> Attachments: 
> 0001-ATLAS-2520-Introduce-JanusGraphTraversal-to-deprecat.patch, Screen Shot 
> 2018-06-05 at 6.16.42 PM.png, Screen Shot 2018-06-05 at 6.19.33 PM.png
>
>
> Currently lot of code in Atlas follow a concept of GremlinQueryProvider which 
> gives TP2 and TP3 queries depending on the graph backend being used. Since 
> Atlas 1.0 is primarily going to rely on JanusGraph, it makes a more sense to 
> remove TP2 related queries/abstractions and use the GraphTraversal Java API 
> provided by JanusGraph.
>  
> PRO: Lot of unused code can be removed, more expressive Graph 
> querying/traversal.
> CONS: Decommissioning TP2 completely is a major engineering effort



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ATLAS-2932) Update DSL to use Java Traversal API

[Apoorv Naik (JIRA)]

Apoorv Naik created ATLAS-2932:
--

 Summary: Update DSL to use Java Traversal API
 Key: ATLAS-2932
 URL: https://issues.apache.org/jira/browse/ATLAS-2932
 Project: Atlas
  Issue Type: Bug
Affects Versions: 1.0.0, trunk
Reporter: Apoorv Naik
Assignee: Apoorv Naik
 Fix For: 1.1.0


Change DSL code to use Java Tinkerpop Traversals instead of GremlinScriptEngine



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ATLAS-2927) Update lineage query for Process entities

[Sarath Subramanian (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661354#comment-16661354
 ] 

Sarath Subramanian commented on ATLAS-2927:
---

branch-0.8 review: https://reviews.apache.org/r/69130/

> Update lineage query for Process entities
> -
>
> Key: ATLAS-2927
> URL: https://issues.apache.org/jira/browse/ATLAS-2927
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Fix For: 1.1.0
>
> Attachments: 
> 0001-ATLAS-2927-Update-lineage-query-for-Process-entities-branch-0.8.patch
>
>
> Currently lineage query for process entities generates lineage based on the 
> number of hops on process entities. Lineage should be generated based on the 
> hops on DataSet entities.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ATLAS-2927) Update lineage query for Process entities

[Sarath Subramanian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-2927:
--
Attachment: 
0001-ATLAS-2927-Update-lineage-query-for-Process-entities-branch-0.8.patch

> Update lineage query for Process entities
> -
>
> Key: ATLAS-2927
> URL: https://issues.apache.org/jira/browse/ATLAS-2927
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 1.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Fix For: 1.1.0
>
> Attachments: 
> 0001-ATLAS-2927-Update-lineage-query-for-Process-entities-branch-0.8.patch
>
>
> Currently lineage query for process entities generates lineage based on the 
> number of hops on process entities. Lineage should be generated based on the 
> hops on DataSet entities.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 69130: ATLAS:2927: Update lineage query for Process entities

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69130/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Bugs: ATLAS-2927
https://issues.apache.org/jira/browse/ATLAS-2927


Repository: atlas


Description
---

Currently lineage query for process entities generates lineage based on the 
number of hops on process entities. Lineage should be generated based on the 
hops on DataSet entities.


Diffs
-

  repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
c928d353b 
  
repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 
2278aefb7 


Diff: https://reviews.apache.org/r/69130/diff/1/


Testing
---

Validated it manually. Lineage for Process and DataSet entities are rendered 
correctly.

Pre-commit in progress.


Thanks,

Sarath Subramanian

[jira] [Updated] (ATLAS-2930) UI changes to handle error message based on softReference attribute.

[Abhishek Kadam (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhishek Kadam updated ATLAS-2930:
--
Attachment: ATLAS-2930_isSoftReference_branch-0.8.patch
ATLAS-2930_isSoftReference_master.patch

> UI changes to handle error message based on softReference attribute.
> 
>
> Key: ATLAS-2930
> URL: https://issues.apache.org/jira/browse/ATLAS-2930
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 0.8.2
>Reporter: Abhishek Kadam
>Assignee: Abhishek Kadam
>Priority: Major
> Fix For: 0.8.3, 2.0.0, 1.2.0
>
> Attachments: ATLAS-2930_branch-0.8.patch, 
> ATLAS-2930_isSoftReference_branch-0.8.patch, 
> ATLAS-2930_isSoftReference_master.patch, ATLAS-2930_master.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)