Re: Review Request 71282: Expose total count of index searches

2019-09-14 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71282/#review217742
---




intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java
Line 82 (original), 84 (patched)


approximateCount should initialized in this constructor as well. It might 
be simpler to initialize in line #55.



repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
Lines 356 (patched)


Shouldn't the return value be "-1", since the processor wouldn't know the 
result-count for non-index query case.



repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 320 (patched)


Shouldn't the return value be "-1", since the processor wouldn't know the 
result-count for non-index query case.


- Madhan Neethiraj


On Sept. 14, 2019, 6:03 p.m., Bolke de Bruin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71282/
> ---
> 
> (Updated Sept. 14, 2019, 6:03 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/ATLAS-3367
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3367
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Both ElasticSearch and SOLR can expose the total count
> of results without returning all results. This is useful
> to give the user or client an idea how many results there are.
> 
> This patch ensures the total is returned if available. This total
> is an approximate as scrubbing of the results still needs to happen.
> Therefore, one should not only rely on this information to provide
> ,for example, pagination.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
> d274cc07e 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  479ddfd89 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  f667aa399 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  f7d8f08c7 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  1dd1afaa3 
>   
> repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java
>  0ffd61c07 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> f7847edff 
>   
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 
> c253d544b 
> 
> 
> Diff: https://reviews.apache.org/r/71282/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bolke de Bruin
> 
>



Re: Review Request 71431: Add indexed order by (sort) to basic search

2019-09-14 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71431/#review217738
---




repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Line 50 (original), 57 (patched)


ClassificationSearchProcessor needs to be updated as well to support 
sortBy. Please review and update.



repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 205 (patched)


graphQuery requires 'qualifiedName' of the attribute (i.e. Asset.name, 
Asset.owner) -  refer to SearchProcessor.toGraphFilterQuery(). Is 'sortBy' here 
qualifiedName of the attribute?



repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 233 (patched)


Is line #233 needed? Please review.



repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 287 (patched)


lines  #275 - #288 can be executed before entering the 'for' loop at #263; 
consider moving these lines to #254.


- Madhan Neethiraj


On Sept. 14, 2019, 12:45 p.m., Bolke de Bruin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71431/
> ---
> 
> (Updated Sept. 14, 2019, 12:45 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/ATLAS-3399
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3399
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add indexed order by to basic search.
> 
> 
> Diffs
> -
> 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  f3722b827 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusIndexQuery.java
>  7c258b7a3 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> e457866af 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
> aac6b5aa3 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  f7d8f08c7 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java e6b338b84 
>   webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java 
> 06931b38c 
>   webapp/src/test/resources/json/search-parameters/entity-filters.json 
> f4b2efe63 
> 
> 
> Diff: https://reviews.apache.org/r/71431/diff/2/
> 
> 
> Testing
> ---
> 
> - production and tests added
> 
> 
> Thanks,
> 
> Bolke de Bruin
> 
>



Re: Review Request 71282: Expose total count of index searches

2019-09-14 Thread Bolke de Bruin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71282/
---

(Updated Sept. 14, 2019, 6:03 p.m.)


Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
Madhan Neethiraj, and Nixon Rodrigues.


Changes
---

Use -1 to initialize


Bugs: https://issues.apache.org/jira/browse/ATLAS-3367

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3367


Repository: atlas


Description
---

Both ElasticSearch and SOLR can expose the total count
of results without returning all results. This is useful
to give the user or client an idea how many results there are.

This patch ensures the total is returned if available. This total
is an approximate as scrubbing of the results still needs to happen.
Therefore, one should not only rely on this information to provide
,for example, pagination.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
d274cc07e 
  
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
 479ddfd89 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
f667aa399 
  
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 
f7d8f08c7 
  
repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
 1dd1afaa3 
  
repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java
 0ffd61c07 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
f7847edff 
  repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 
c253d544b 


Diff: https://reviews.apache.org/r/71282/diff/4/

Changes: https://reviews.apache.org/r/71282/diff/3-4/


Testing
---


Thanks,

Bolke de Bruin



Re: Review Request 71282: Expose total count of index searches

2019-09-14 Thread Bolke de Bruin


> On Sept. 14, 2019, 4:53 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java
> > Lines 71 (patched)
> > 
> >
> > I suggest to initialize approximateCount to "-1", to enable 
> > distinguishing "empty results" from "unavailability of approximate count".

Will do.


> On Sept. 14, 2019, 4:53 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
> > Lines 131 (patched)
> > 
> >
> > - given "getResultCount()" can only return approximate count, that too 
> > not in all cases, consider renaming this to "getApproximateResultCount()"
> > - and the implementations should return "-1" when approximate count is 
> > not available

That's not true in this case although maybe a bit semantic. This call does get 
the total result count from the search backend scrubbing happens only after the 
API call. I suggest leaving it as it might be used in different circumstances 
in the future (hypothetical: if it would become possible to do scrubbing in the 
search engine for example).


- Bolke


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71282/#review217737
---


On Sept. 14, 2019, 12:46 p.m., Bolke de Bruin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71282/
> ---
> 
> (Updated Sept. 14, 2019, 12:46 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/ATLAS-3367
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3367
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Both ElasticSearch and SOLR can expose the total count
> of results without returning all results. This is useful
> to give the user or client an idea how many results there are.
> 
> This patch ensures the total is returned if available. This total
> is an approximate as scrubbing of the results still needs to happen.
> Therefore, one should not only rely on this information to provide
> ,for example, pagination.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
> d274cc07e 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  479ddfd89 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  c67e34772 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  f7d8f08c7 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  1dd1afaa3 
>   
> repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java
>  0ffd61c07 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> a7ccaebc8 
>   
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 
> c253d544b 
> 
> 
> Diff: https://reviews.apache.org/r/71282/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bolke de Bruin
> 
>



Re: Review Request 71282: Expose total count of index searches

2019-09-14 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71282/#review217737
---




intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java
Lines 71 (patched)


I suggest to initialize approximateCount to "-1", to enable distinguishing 
"empty results" from "unavailability of approximate count".



repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Lines 131 (patched)


- given "getResultCount()" can only return approximate count, that too not 
in all cases, consider renaming this to "getApproximateResultCount()"
- and the implementations should return "-1" when approximate count is not 
available


- Madhan Neethiraj


On Sept. 14, 2019, 12:46 p.m., Bolke de Bruin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71282/
> ---
> 
> (Updated Sept. 14, 2019, 12:46 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/ATLAS-3367
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3367
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Both ElasticSearch and SOLR can expose the total count
> of results without returning all results. This is useful
> to give the user or client an idea how many results there are.
> 
> This patch ensures the total is returned if available. This total
> is an approximate as scrubbing of the results still needs to happen.
> Therefore, one should not only rely on this information to provide
> ,for example, pagination.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
> d274cc07e 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  479ddfd89 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  c67e34772 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  f7d8f08c7 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  1dd1afaa3 
>   
> repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java
>  0ffd61c07 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> a7ccaebc8 
>   
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 
> c253d544b 
> 
> 
> Diff: https://reviews.apache.org/r/71282/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bolke de Bruin
> 
>



[jira] [Commented] (ATLAS-3368) Very slow creation of entities with referred entities without relationshipDef

2019-09-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929787#comment-16929787
 ] 

ASF subversion and git services commented on ATLAS-3368:


Commit 7a472f704719f0ab762b556f8b701ab4951d38b1 in atlas's branch 
refs/heads/branch-2.0 from Bolke de Bruin
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=7a472f7 ]

ATLAS-3368: log warning for references without relationship-def

Signed-off-by: Madhan Neethiraj 
(cherry picked from commit 3eadf7e875f810713b3a11a8e49ab2054128ac93)


> Very slow creation of entities with referred entities without relationshipDef
> -
>
> Key: ATLAS-3368
> URL: https://issues.apache.org/jira/browse/ATLAS-3368
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Bolke de Bruin
>Priority: Major
>  Labels: performance
> Attachments: 
> 0001-ATLAS-3368-Set-log-level-to-warn-for-relationships-w.patch
>
>
> If an entity is created that has a definition with a reference to a non built 
> in type, e.g.
> {code:java}
> ,{
> "name" : "server",
> "typeName" : "server",
> "isOptional" : false,
> "cardinality" : "SINGLE",
> "valuesMinCount" : 1,
> "valuesMaxCount" : 1,
> "isUnique" : false,
> "isIndexable" : true
> }{code}
> It will trigger a legacy code path in EntityGraphMapper. This path can take 
> excessive amounts of time:
> {code}2019-08-12 12:10:23,323 DEBUG - [NotificationHookConsumer thread-0:] ~ 
> No RelationshipDef defined between rokku_client and server on attribute: 
> server (EntityGraphMapper:907)
> 2019-08-12 12:10:23,323 DEBUG - [NotificationHookConsumer thread-0:] ~ ==> 
> mapObjectIdValue(org.apache.atlas.repository.store.graph.v2.AttributeMutationContext@3f7c5b66)
>  (EntityGraphMapper:791)
> 2019-08-12 12:10:28,825 DEBUG - [NotificationHookConsumer thread-0:] ~ ==> 
> setProperty(edge[id=v6kwld-biutqg-xel1-x8oqg label=__rokku_client.server from 
> vertex[id=696799240 type=rokku_client 
> guid=30db90a8-8236-41c6-9438-4fa2ec14f349] -> to vertex[id=55832632 
> type=server guid=9144e224-089f-4ae3-83bd-3472175d92a4]], __state, ACTIVE) 
> (AtlasGraphUtilsV2:212)
> 2019-08-12 12:10:23,323 DEBUG - [NotificationHookConsumer thread-0:] ~ ==> 
> mapObjectIdValue(org.apache.atlas.repository.store.graph.v2.AttributeMutationContext@3f7c5b66)
>  (EntityGraphMapper:791)
> 2019-08-12 12:10:28,825 DEBUG - [NotificationHookConsumer thread-0:] ~ ==> 
> setProperty(edge[id=v6kwld-biutqg-xel1-x8oqg label=__rokku_client.server from 
> vertex[id=696799240 type=rokku_client 
> guid=30db90a8-8236-41c6-9438-4fa2ec14f349] -> to vertex[id=55832632 
> type=server guid=9144e224-089f-4ae3-83bd-3472175d92a4]], __state, ACTIVE) 
> (AtlasGraphUtilsV2:212)
> {code}
> Notice the 5 second(!) jump between the last two log lines. At a minimum the 
> log about triggering the legacy code path should be at WARN level and 
> extended with a suggestion to update the definition for better performance.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (ATLAS-3356) Atlas UI with new theme (Beta version)

2019-09-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929786#comment-16929786
 ] 

ASF subversion and git services commented on ATLAS-3356:


Commit 086aff79ebb741ff04d6fef697c8f97214370e38 in atlas's branch 
refs/heads/branch-2.0 from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=086aff7 ]

ATLAS-3356: fixed incorrect parent version - for branch-2.0


> Atlas UI with new theme (Beta version)
> --
>
> Key: ATLAS-3356
> URL: https://issues.apache.org/jira/browse/ATLAS-3356
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Minor
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3356-1.patch, ATLAS-3356.patch
>
>
> All the components are rearranged and color schema is changed in this version.
> Improvements.
>  * New and prominent *Global Search*.
>  * Left resizeable pane with classification, entity, glossary and custom 
> filter management along with expand/collapse button.
>  * Advanced search is moved to the new *Global Search* dropdown.
>  * Basic Search actions are more simplified than before.
>  * Classification management is integrated with basic search UI actions for 
> ease of access.
>  * Glossary management is integrated with basic search UI actions for ease of 
> access.
>  * Improved ease of access to the filters during a search.
>  * Allows user to switch between new and old UI
> For more, try the new UI by click on the "*Switch to New UI*" button from the 
> bottom of the old ui.
>  
> Note: This is Beta version.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (ATLAS-3368) Very slow creation of entities with referred entities without relationshipDef

2019-09-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929783#comment-16929783
 ] 

ASF subversion and git services commented on ATLAS-3368:


Commit 3eadf7e875f810713b3a11a8e49ab2054128ac93 in atlas's branch 
refs/heads/master from Bolke de Bruin
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=3eadf7e ]

ATLAS-3368: log warning for references without relationship-def

Signed-off-by: Madhan Neethiraj 


> Very slow creation of entities with referred entities without relationshipDef
> -
>
> Key: ATLAS-3368
> URL: https://issues.apache.org/jira/browse/ATLAS-3368
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Bolke de Bruin
>Priority: Major
>  Labels: performance
> Attachments: 
> 0001-ATLAS-3368-Set-log-level-to-warn-for-relationships-w.patch
>
>
> If an entity is created that has a definition with a reference to a non built 
> in type, e.g.
> {code:java}
> ,{
> "name" : "server",
> "typeName" : "server",
> "isOptional" : false,
> "cardinality" : "SINGLE",
> "valuesMinCount" : 1,
> "valuesMaxCount" : 1,
> "isUnique" : false,
> "isIndexable" : true
> }{code}
> It will trigger a legacy code path in EntityGraphMapper. This path can take 
> excessive amounts of time:
> {code}2019-08-12 12:10:23,323 DEBUG - [NotificationHookConsumer thread-0:] ~ 
> No RelationshipDef defined between rokku_client and server on attribute: 
> server (EntityGraphMapper:907)
> 2019-08-12 12:10:23,323 DEBUG - [NotificationHookConsumer thread-0:] ~ ==> 
> mapObjectIdValue(org.apache.atlas.repository.store.graph.v2.AttributeMutationContext@3f7c5b66)
>  (EntityGraphMapper:791)
> 2019-08-12 12:10:28,825 DEBUG - [NotificationHookConsumer thread-0:] ~ ==> 
> setProperty(edge[id=v6kwld-biutqg-xel1-x8oqg label=__rokku_client.server from 
> vertex[id=696799240 type=rokku_client 
> guid=30db90a8-8236-41c6-9438-4fa2ec14f349] -> to vertex[id=55832632 
> type=server guid=9144e224-089f-4ae3-83bd-3472175d92a4]], __state, ACTIVE) 
> (AtlasGraphUtilsV2:212)
> 2019-08-12 12:10:23,323 DEBUG - [NotificationHookConsumer thread-0:] ~ ==> 
> mapObjectIdValue(org.apache.atlas.repository.store.graph.v2.AttributeMutationContext@3f7c5b66)
>  (EntityGraphMapper:791)
> 2019-08-12 12:10:28,825 DEBUG - [NotificationHookConsumer thread-0:] ~ ==> 
> setProperty(edge[id=v6kwld-biutqg-xel1-x8oqg label=__rokku_client.server from 
> vertex[id=696799240 type=rokku_client 
> guid=30db90a8-8236-41c6-9438-4fa2ec14f349] -> to vertex[id=55832632 
> type=server guid=9144e224-089f-4ae3-83bd-3472175d92a4]], __state, ACTIVE) 
> (AtlasGraphUtilsV2:212)
> {code}
> Notice the 5 second(!) jump between the last two log lines. At a minimum the 
> log about triggering the legacy code path should be at WARN level and 
> extended with a suggestion to update the definition for better performance.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


Re: Review Request 71278: Set log level to warn for relationships without relationship definition

2019-09-14 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71278/#review217736
---


Ship it!




Ship It!

- Madhan Neethiraj


On Sept. 14, 2019, 1:10 p.m., Bolke de Bruin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71278/
> ---
> 
> (Updated Sept. 14, 2019, 1:10 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Nixon Rodrigues, and Saqeeb Shaikh.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/ATLAS-3368
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3368
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> If an entity is created that has a definition with a reference to a
> non built in type, it will trigger a legacy code path in 
> EntityGraphMapper.
> This path can take excessive amounts of time (>5s per commit), but 
> operators
> can be caught unaware as the log message for this is at debug
> level and explain the portential issue.
> 
> 
> Diffs
> -
> 
>   docs/src/site/twiki/Configuration.twiki 6190a7c5f 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 345b105ff 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  c02f80905 
> 
> 
> Diff: https://reviews.apache.org/r/71278/diff/2/
> 
> 
> Testing
> ---
> 
> - reviewed patch logging to warn
> 
> 
> Thanks,
> 
> Bolke de Bruin
> 
>



Re: Review Request 71278: Set log level to warn for relationships without relationship definition

2019-09-14 Thread Bolke de Bruin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71278/
---

(Updated Sept. 14, 2019, 1:09 p.m.)


Review request for atlas, Nixon Rodrigues and Saqeeb Shaikh.


Changes
---

Addressed comments


Bugs: https://issues.apache.org/jira/browse/ATLAS-3368

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3368


Repository: atlas


Description
---

If an entity is created that has a definition with a reference to a
non built in type, it will trigger a legacy code path in EntityGraphMapper.
This path can take excessive amounts of time (>5s per commit), but operators
can be caught unaware as the log message for this is at debug
level and explain the portential issue.


Diffs (updated)
-

  docs/src/site/twiki/Configuration.twiki 6190a7c5f 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 345b105ff 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 c02f80905 


Diff: https://reviews.apache.org/r/71278/diff/2/

Changes: https://reviews.apache.org/r/71278/diff/1-2/


Testing
---

- reviewed patch logging to warn


Thanks,

Bolke de Bruin