Review Request 71796: ATLAS-3530: Retrieve entityDefinition for '_ALL_ENTITY_TYPES' in /api/atlas/v2/types/entitydef/name/{name}
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71796/ --- Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, Mandar Ambawane, Nikhil Bonte, Nixon Rodrigues, Sameer Shaikh, and Sidharth Mishra. Bugs: ATLAS-3530 https://issues.apache.org/jira/browse/ATLAS-3530 Repository: atlas Description --- '_ALL_ENTITY_TYPES' is a new system type with all system attributes of an entity in ATLAS-3482. A new TypesREST endpoint to retrieve definition of '_ALL_ENTITY_TYPES' is necessary to render system attributes in UI. GET /api/atlas/v2/types/entitydef/name/ALL_ENTITY_TYPES should return entityDef. Diffs - intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 557ef74a9 repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 2e2ab1a66 repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 51dd16b85 Diff: https://reviews.apache.org/r/71796/diff/1/ Testing --- Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/ Added unit test to check if 'ALL_ENTITY_TYPES' definition is returned correctly. Thanks, Sarath Subramanian
[jira] [Updated] (ATLAS-3530) Retrieve entityDefinition for '_ALL_ENTITY_TYPES' in /api/atlas/v2/types/entitydef/name/{name}
[
https://issues.apache.org/jira/browse/ATLAS-3530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarath Subramanian updated ATLAS-3530:
--
Attachment: 0001-ATLAS-3530-Retrieve-entityDefinition-for-_ALL_ENTITY.patch
> Retrieve entityDefinition for '_ALL_ENTITY_TYPES' in
> /api/atlas/v2/types/entitydef/name/{name}
> --
>
> Key: ATLAS-3530
> URL: https://issues.apache.org/jira/browse/ATLAS-3530
> Project: Atlas
> Issue Type: Improvement
> Components: atlas-core
>Affects Versions: 2.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Fix For: 2.1.0
>
> Attachments:
> 0001-ATLAS-3530-Retrieve-entityDefinition-for-_ALL_ENTITY.patch
>
>
> '_ALL_ENTITY_TYPES' is a new system type with all system attributes of an
> entity in ATLAS-3482.
> A new TypesREST endpoint to retrieve definition of '_ALL_ENTITY_TYPES' is
> necessary to render system attributes in UI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ATLAS-3530) Retrieve entityDefinition for '_ALL_ENTITY_TYPES' in /api/atlas/v2/types/entitydef/name/{name}
Sarath Subramanian created ATLAS-3530:
-
Summary: Retrieve entityDefinition for '_ALL_ENTITY_TYPES' in
/api/atlas/v2/types/entitydef/name/{name}
Key: ATLAS-3530
URL: https://issues.apache.org/jira/browse/ATLAS-3530
Project: Atlas
Issue Type: Improvement
Components: atlas-core
Affects Versions: 2.0.0
Reporter: Sarath Subramanian
Assignee: Sarath Subramanian
Fix For: 2.1.0
'_ALL_ENTITY_TYPES' is a new system type with all system attributes of an
entity in ATLAS-3482.
A new TypesREST endpoint to retrieve definition of '_ALL_ENTITY_TYPES' is
necessary to render system attributes in UI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: Review Request 71649: ATLAS-3486 Define Data Models For Namespaces and Namespace Attributes in Atlas and also the corresponding type registry changes for the same
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71649/ --- (Updated Nov. 21, 2019, 3:03 a.m.) Review request for atlas, Ashutosh Mestry, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian. Changes --- Rebased Bugs: ATLAS-3486 https://issues.apache.org/jira/browse/ATLAS-3486 Repository: atlas Description --- This change is the first part of the bigger task defined as part of ATLAS-3485. This adds the data model needed for supporting namespaces and namespace attributes and also updates the type registry to include the applicable namespace attributes for every entity type Diffs (updated) - intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 7a2aae2e9ae8174c5309164f3e41c940cbf3ddf8 intg/src/main/java/org/apache/atlas/model/TypeCategory.java f06f64f450f407e3f9a0e742726ff4dd12ccc695 intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java PRE-CREATION intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java bb7ead0f9f8bab3094eb82e9e286dd58e8a6e3de intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 3634fdfd313639eb97b3c4698e091487b0e44a80 intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java 4ee68a936f99bb4c819b5335da2cc8bf7d539397 intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 557ef74a95c2a939b4b89cd1db8fa4c73d52dd51 intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java PRE-CREATION intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java b071dc9d664cee9e1ffc54726ffbf15f4f602d30 intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 0883d54f490e22c6510e6fc0cb804b87713a7ecb intg/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java dba2d88146eff314191ae6bb24ad7337b0ea10ae intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 02613b5f7250b14324ed294c22de079b74d55b08 intg/src/test/java/org/apache/atlas/TestUtilsV2.java ff79994c519702e90b2e478d00cae0008889f956 intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasNamespaceDef.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 2e2ab1a664171555c57560e1c0b4cbdbc20c0f6f repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java a5ccfb5b2055c88f596312f4033bc0034d3d165c repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 51dd16b8518c9a16088547f3e95c0ef401695895 repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java PRE-CREATION webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 6cd0ee331b7ae24757b58e76ec47bf556106846a Diff: https://reviews.apache.org/r/71649/diff/7/ Changes: https://reviews.apache.org/r/71649/diff/6-7/ Testing --- Added unit tests Thanks, Aadarsh Jajodia
Review Request 71795: DSL Queries: LIKE Clause with Special Characters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71795/ --- Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3520 https://issues.apache.org/jira/browse/ATLAS-3520 Repository: atlas Description --- **Background** Please refer to the bug description for details. **Approach** - Detect special chacters in the right-hand-side of LIKE clause. - Use textRegex instead of textContainsRegex. Diffs - repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 294dc00e5 repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 724ae9f7a repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java ca32ffc99 Diff: https://reviews.apache.org/r/71795/diff/1/ Testing --- **Unit tests** - _DSLQueriesTest_ updated to handle this case. - _GremlinQueryComposerTest_ updated to handle this case. **Functional tests** Via UI. Thanks, Ashutosh Mestry
[jira] [Updated] (ATLAS-3520) Regression: DSL query with "like" clause with "_" and "AND" returns unexpected entities.
[
https://issues.apache.org/jira/browse/ATLAS-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Mestry updated ATLAS-3520:
---
Description:
*Problem*
Dataset:
Created a hive_table with name "sample_01" under hive_db having name as
"default".
Query:
{code:java}
hive_table db.name="default" and qualifiedName like "*sample_01*"
{code}
It is expected that above query should return 1 hive_table entity having
qualifiedName = default.sample_01@cluster, but it doesn't return any entity.
Other queries like following work and return expected results:
{code:java}
hive_table where db.name = "default" (only first part of query)
hive_table qualifiedName like "*sample_01*" (only second part of query)
hive_table where db.name = "default" and name like "sample_01" (updating only
second part of query)
hive_table db.name="default" and qualifiedName = "default.sample_01@cluster"
(using "=" instead of "like" with full qualifiedName)
{code}
*Additional Information*
For the type of queries mentioned above,
_org.janusgraph.core.attribute.Text.textContainsRegex_ is used to perform
comparison. This method within _JanusGraph_ is done in 2 steps:
* Tokenize the incoming stream.
* Perform regex match on the tokens from the step above.
The tokenization routine aggregates by treating '_' as a delimiter. Thereby
failing to match a string containing '_'.
*Solution*
Within _GreamlinQueryComposer_, detect presence of '_' within the value and
resort to using _textRegex_ to match.
was:
*Problem*
Dataset:
Created a hive_table with name "sample_01" under hive_db having name as
"default".
Query:
{code:java}
hive_table db.name="default" and qualifiedName like "*sample_01*"
{code}
It is expected that above query should return 1 hive_table entity having
qualifiedName = default.sample_01@cluster, but it doesn't return any entity.
Other queries like following work and return expected results:
{code:java}
hive_table where db.name = "default" (only first part of query)
hive_table qualifiedName like "*sample_01*" (only second part of query)
hive_table where db.name = "default" and name like "sample_01" (updating only
second part of query)
hive_table db.name="default" and qualifiedName = "default.sample_01@cluster"
(using "=" instead of "like" with full qualifiedName)
{code}
> Regression: DSL query with "like" clause with "_" and "AND" returns
> unexpected entities.
>
>
> Key: ATLAS-3520
> URL: https://issues.apache.org/jira/browse/ATLAS-3520
> Project: Atlas
> Issue Type: Bug
>Reporter: Nikhil Bonte
>Assignee: Ashutosh Mestry
>Priority: Major
>
> *Problem*
> Dataset:
> Created a hive_table with name "sample_01" under hive_db having name as
> "default".
> Query:
> {code:java}
> hive_table db.name="default" and qualifiedName like "*sample_01*"
> {code}
> It is expected that above query should return 1 hive_table entity having
> qualifiedName = default.sample_01@cluster, but it doesn't return any entity.
>
> Other queries like following work and return expected results:
> {code:java}
> hive_table where db.name = "default" (only first part of query)
> hive_table qualifiedName like "*sample_01*" (only second part of query)
> hive_table where db.name = "default" and name like "sample_01" (updating only
> second part of query)
> hive_table db.name="default" and qualifiedName = "default.sample_01@cluster"
> (using "=" instead of "like" with full qualifiedName)
> {code}
>
> *Additional Information*
> For the type of queries mentioned above,
> _org.janusgraph.core.attribute.Text.textContainsRegex_ is used to perform
> comparison. This method within _JanusGraph_ is done in 2 steps:
> * Tokenize the incoming stream.
> * Perform regex match on the tokens from the step above.
> The tokenization routine aggregates by treating '_' as a delimiter. Thereby
> failing to match a string containing '_'.
> *Solution*
> Within _GreamlinQueryComposer_, detect presence of '_' within the value and
> resort to using _textRegex_ to match.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (ATLAS-3520) Regression: DSL query with "like" clause with "_" and "AND" returns unexpected entities.
[
https://issues.apache.org/jira/browse/ATLAS-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashutosh Mestry reassigned ATLAS-3520:
--
Assignee: Ashutosh Mestry (was: Nikhil Bonte)
> Regression: DSL query with "like" clause with "_" and "AND" returns
> unexpected entities.
>
>
> Key: ATLAS-3520
> URL: https://issues.apache.org/jira/browse/ATLAS-3520
> Project: Atlas
> Issue Type: Bug
>Reporter: Nikhil Bonte
>Assignee: Ashutosh Mestry
>Priority: Major
>
> *Problem*
> Dataset:
> Created a hive_table with name "sample_01" under hive_db having name as
> "default".
> Query:
> {code:java}
> hive_table db.name="default" and qualifiedName like "*sample_01*"
> {code}
> It is expected that above query should return 1 hive_table entity having
> qualifiedName = default.sample_01@cluster, but it doesn't return any entity.
>
> Other queries like following work and return expected results:
> {code:java}
> hive_table where db.name = "default" (only first part of query)
> hive_table qualifiedName like "*sample_01*" (only second part of query)
> hive_table where db.name = "default" and name like "sample_01" (updating only
> second part of query)
> hive_table db.name="default" and qualifiedName = "default.sample_01@cluster"
> (using "=" instead of "like" with full qualifiedName)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Review Request 71794: ATLAS-3233 Relationships, Export & Import : Issue with ACTIVE and DELETED relationship-def instances
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71794/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3233 https://issues.apache.org/jira/browse/ATLAS-3233 Repository: atlas Description --- Here I have handled deletion part of relationship in case of import. Diffs - repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java a114d25 Diff: https://reviews.apache.org/r/71794/diff/1/ Testing --- Basic testing is done. UT/ITs pending. Thanks, Mandar Ambawane
[jira] [Commented] (ATLAS-3529) Bug in Atlas Website
[ https://issues.apache.org/jira/browse/ATLAS-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978414#comment-16978414 ] Nixon Rodrigues commented on ATLAS-3529: The website is update, please find correct link. [https://atlas.apache.org/#QuickStart] > Bug in Atlas Website > > > Key: ATLAS-3529 > URL: https://issues.apache.org/jira/browse/ATLAS-3529 > Project: Atlas > Issue Type: Bug >Reporter: Michael Aubertin >Priority: Major > Labels: website > > This bug is not in Atlas itself. It is on Atlas public website. > > The page [https://atlas.apache.org/QuickStart] is currently in 404. It means > new users are no longer able to read the quickstart documentation. > > Hope it helps, -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3529) Bug in Atlas Website
Michael Aubertin created ATLAS-3529: --- Summary: Bug in Atlas Website Key: ATLAS-3529 URL: https://issues.apache.org/jira/browse/ATLAS-3529 Project: Atlas Issue Type: Bug Reporter: Michael Aubertin This bug is not in Atlas itself. It is on Atlas public website. The page [https://atlas.apache.org/QuickStart] is currently in 404. It means new users are no longer able to read the quickstart documentation. Hope it helps, -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3528) UI: Support basic search to search with System attributes only for entity
Sameer Shaikh created ATLAS-3528: Summary: UI: Support basic search to search with System attributes only for entity Key: ATLAS-3528 URL: https://issues.apache.org/jira/browse/ATLAS-3528 Project: Atlas Issue Type: Improvement Reporter: Sameer Shaikh Assignee: Sameer Shaikh Fix For: 2.1.0, 3.0.0 Support basic search to search with System attributes only for entity: __guid, __historicalGuids, __labels, __customAttributes, __classificationsText, __classificationNames, __propagatedClassificationNames, __isIncomplete -- This message was sent by Atlassian Jira (v8.3.4#803005)
