[jira] [Commented] (ATLAS-3701) Performance improvements in writing audit logs - Classification dissociation

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072189#comment-17072189
 ] 

ASF subversion and git services commented on ATLAS-3701:


Commit 1c38f71a6b8090e7ba0b368aa826201bf8e01d2a in atlas's branch 
refs/heads/branch-2.0 from Nikhil Bonte
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=1c38f71 ]

ATLAS-3701: performance improvements in classification-dissociation

Signed-off-by: Madhan Neethiraj 
(cherry picked from commit 36956bc0c4747c93d1b0c6e234168f18bdbaebb2)


> Performance improvements in writing audit logs - Classification dissociation
> 
>
> Key: ATLAS-3701
> URL: https://issues.apache.org/jira/browse/ATLAS-3701
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
>
> Further to ATLAS-3568, 
> this will improve audit writing in case of classfication dissociation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3701) Performance improvements in writing audit logs - Classification dissociation

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072181#comment-17072181
 ] 

ASF subversion and git services commented on ATLAS-3701:


Commit 36956bc0c4747c93d1b0c6e234168f18bdbaebb2 in atlas's branch 
refs/heads/master from Nikhil Bonte
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=36956bc ]

ATLAS-3701: performance improvements in classification-dissociation

Signed-off-by: Madhan Neethiraj 


> Performance improvements in writing audit logs - Classification dissociation
> 
>
> Key: ATLAS-3701
> URL: https://issues.apache.org/jira/browse/ATLAS-3701
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
>
> Further to ATLAS-3568, 
> this will improve audit writing in case of classfication dissociation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72294: ATLAS-3712: Add 'isAppendOnPartialUpdate' option in ML model to append updates

[Karthik Manamcheri via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72294/#review220160
---


Ship it!




Ship It!

- Karthik Manamcheri


On March 31, 2020, 7:47 p.m., Na Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72294/
> ---
> 
> (Updated March 31, 2020, 7:47 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Karthik Manamcheri, Sridhar K, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: atlas-3712
> https://issues.apache.org/jira/browse/atlas-3712
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> add 'isAppendOnPartialUpdate' option in ML model at 
> https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json
>  to append updates using this new feature introduced in ATLAS-3700.
> 
> 
> Diffs
> -
> 
>   addons/models/4000-MachineLearning/4010-ml_model.json 
> c4ba729b87cf581e7f9b23925968b275ae4a688b 
> 
> 
> Diff: https://reviews.apache.org/r/72294/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Na Li
> 
>

[jira] [Resolved] (ATLAS-3712) Add 'isAppendOnPartialUpdate' option in ML model to append updates

[Na Li (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Na Li resolved ATLAS-3712.
--
Resolution: Fixed

> Add 'isAppendOnPartialUpdate' option in ML model to append updates
> --
>
> Key: ATLAS-3712
> URL: https://issues.apache.org/jira/browse/ATLAS-3712
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
>
> Atlas adds a new feature to allow client to append attributes during 
> partial-update operation in ATLAS-3700.
> We need to add 'isAppendOnPartialUpdate' option in ML model at 
> [https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json]
>  to append updates using this new feature.
> Example:
> {code:java}
> {
> "name":"metadata",
> "typeName":"map",
> "isIndexable": false,
> "isOptional":  true,
> "isUnique":false,
> "options": {
>   "isAppendOnPartialUpdate": "true"
> }
>   } {code}
> The value specified for this attribute in partial-update API calls will be 
> appended to existing value - if present.
> Full-update API calls will overwrite the value of the attribute, as it does 
> currently; there is no change in full-update behavior.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3712) Add 'isAppendOnPartialUpdate' option in ML model to append updates

[Na Li (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072137#comment-17072137
 ] 

Na Li commented on ATLAS-3712:
--

[~amestry] Do we need to commit this to branch 2.0 as well? ATLAS-3700 was 
committed to both master and 2.0 branch. 
[https://github.com/apache/atlas/commits/branch-2.0.] Thanks!

> Add 'isAppendOnPartialUpdate' option in ML model to append updates
> --
>
> Key: ATLAS-3712
> URL: https://issues.apache.org/jira/browse/ATLAS-3712
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
>
> Atlas adds a new feature to allow client to append attributes during 
> partial-update operation in ATLAS-3700.
> We need to add 'isAppendOnPartialUpdate' option in ML model at 
> [https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json]
>  to append updates using this new feature.
> Example:
> {code:java}
> {
> "name":"metadata",
> "typeName":"map",
> "isIndexable": false,
> "isOptional":  true,
> "isUnique":false,
> "options": {
>   "isAppendOnPartialUpdate": "true"
> }
>   } {code}
> The value specified for this attribute in partial-update API calls will be 
> appended to existing value - if present.
> Full-update API calls will overwrite the value of the attribute, as it does 
> currently; there is no change in full-update behavior.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3712) Add 'isAppendOnPartialUpdate' option in ML model to append updates

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072126#comment-17072126
 ] 

ASF subversion and git services commented on ATLAS-3712:


Commit 6b7837028c671334dd2e44f03e6d464b9812778b in atlas's branch 
refs/heads/master from Na Li
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=6b78370 ]

ATLAS-3712: Add 'isAppendOnPartialUpdate' option in ML model to append updates.

Signed-off-by: Ashutosh Mestry 


> Add 'isAppendOnPartialUpdate' option in ML model to append updates
> --
>
> Key: ATLAS-3712
> URL: https://issues.apache.org/jira/browse/ATLAS-3712
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
>
> Atlas adds a new feature to allow client to append attributes during 
> partial-update operation in ATLAS-3700.
> We need to add 'isAppendOnPartialUpdate' option in ML model at 
> [https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json]
>  to append updates using this new feature.
> Example:
> {code:java}
> {
> "name":"metadata",
> "typeName":"map",
> "isIndexable": false,
> "isOptional":  true,
> "isUnique":false,
> "options": {
>   "isAppendOnPartialUpdate": "true"
> }
>   } {code}
> The value specified for this attribute in partial-update API calls will be 
> appended to existing value - if present.
> Full-update API calls will overwrite the value of the attribute, as it does 
> currently; there is no change in full-update behavior.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72294: ATLAS-3712: Add 'isAppendOnPartialUpdate' option in ML model to append updates

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72294/#review220159
---


Ship it!




Ship It!

- Ashutosh Mestry


On March 31, 2020, 7:47 p.m., Na Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72294/
> ---
> 
> (Updated March 31, 2020, 7:47 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Karthik Manamcheri, Sridhar K, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: atlas-3712
> https://issues.apache.org/jira/browse/atlas-3712
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> add 'isAppendOnPartialUpdate' option in ML model at 
> https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json
>  to append updates using this new feature introduced in ATLAS-3700.
> 
> 
> Diffs
> -
> 
>   addons/models/4000-MachineLearning/4010-ml_model.json 
> c4ba729b87cf581e7f9b23925968b275ae4a688b 
> 
> 
> Diff: https://reviews.apache.org/r/72294/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Na Li
> 
>

Review Request 72294: ATLAS-3712: Add 'isAppendOnPartialUpdate' option in ML model to append updates

[Na Li via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72294/
---

Review request for atlas, Ashutosh Mestry, Karthik Manamcheri, Sridhar K, 
Madhan Neethiraj, and Sarath Subramanian.


Bugs: atlas-3712
https://issues.apache.org/jira/browse/atlas-3712


Repository: atlas


Description
---

add 'isAppendOnPartialUpdate' option in ML model at 
https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json
 to append updates using this new feature introduced in ATLAS-3700.


Diffs
-

  addons/models/4000-MachineLearning/4010-ml_model.json 
c4ba729b87cf581e7f9b23925968b275ae4a688b 


Diff: https://reviews.apache.org/r/72294/diff/1/


Testing
---


Thanks,

Na Li

[jira] [Updated] (ATLAS-3700) added option to append value to array, map type attributes

[Na Li (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Na Li updated ATLAS-3700:
-
Summary: added option to append value to array, map type attributes  (was: 
Partial update to Atlas overwrite map entry with different keys)

> added option to append value to array, map type attributes
> --
>
> Key: ATLAS-3700
> URL: https://issues.apache.org/jira/browse/ATLAS-3700
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3700.003.patch, ATLAS-3700.004.patch, 
> ATLAS-3700.patch
>
>
> *Details:*
> 1) The model definition is in 
> "https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json#L90";
> 2) I created a request of type EntityCreateRequestV2. It contains an entity 
> of type ml_model_build with an attribute "metadata", which is a map, and 
> contains key-value entries for "engineImageTag" and "engineImageName".
> 3) Then I created a request of type EntityPartialUpdateRequestV2. It contains 
> an entity of type ml_model_build with an attribute "metadata", which is a 
> map, and contains key-value entry for "updated_at".
> 4) In the properties of the entity ml_model_build, the * attribute 
> "*metadata" only contains key-value entry for "updated_at".
> *Desired behavior:*
> The attribute "metadata" should contains key-value entries for 
> "engineImageTag", "engineImageName" and "updated_at".
> Current behavior:
> the attribute "metadata" only contains key-value entry for "updated_at".
>  
>  Added 'isAppendOnPartialUpdate' option in attribute-def, to enable appending 
> of values to array/map type attributes during partial-update operation.
> Example:
> {code:java}
> {
> "name":"metadata",
> "typeName":"map",
> "isIndexable": false,
> "isOptional":  true,
> "isUnique":false,
> "options": {
>   "isAppendOnPartialUpdate": "true"
> }
>   }{code}
>  
> The value specified for this attribute in partial-update API calls will be 
> appended to existing value - if present. Full-update API calls will overwrite 
> the value of the attribute, as it does currently; there is no change in 
> full-update behavior.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3712) Add 'isAppendOnPartialUpdate' option in ML model to append updates

[Na Li (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Na Li updated ATLAS-3712:
-
Summary: Add 'isAppendOnPartialUpdate' option in ML model to append updates 
 (was: Added 'isAppendOnPartialUpdate' option in ML model to append updates)

> Add 'isAppendOnPartialUpdate' option in ML model to append updates
> --
>
> Key: ATLAS-3712
> URL: https://issues.apache.org/jira/browse/ATLAS-3712
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
>
> Atlas adds a new feature to allow client to append attributes during 
> partial-update operation in ATLAS-3700.
> We need to add 'isAppendOnPartialUpdate' option in ML model at 
> [https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json]
>  to append updates using this new feature.
> Example:
> {code:java}
> {
> "name":"metadata",
> "typeName":"map",
> "isIndexable": false,
> "isOptional":  true,
> "isUnique":false,
> "options": {
>   "isAppendOnPartialUpdate": "true"
> }
>   } {code}
> The value specified for this attribute in partial-update API calls will be 
> appended to existing value - if present.
> Full-update API calls will overwrite the value of the attribute, as it does 
> currently; there is no change in full-update behavior.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3712) Added 'isAppendOnPartialUpdate' option in ML model to append updates

[Na Li (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Na Li updated ATLAS-3712:
-
Summary: Added 'isAppendOnPartialUpdate' option in ML model to append 
updates  (was: Added 'isAppendOnPartialUpdate' option in ML model to attend 
updates)

> Added 'isAppendOnPartialUpdate' option in ML model to append updates
> 
>
> Key: ATLAS-3712
> URL: https://issues.apache.org/jira/browse/ATLAS-3712
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
>
> Atlas adds a new feature to allow client to append attributes during 
> partial-update operation in ATLAS-3700.
> We need to add 'isAppendOnPartialUpdate' option in ML model at 
> [https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json]
>  to append updates using this new feature.
> Example:
> {code:java}
> {
> "name":"metadata",
> "typeName":"map",
> "isIndexable": false,
> "isOptional":  true,
> "isUnique":false,
> "options": {
>   "isAppendOnPartialUpdate": "true"
> }
>   } {code}
> The value specified for this attribute in partial-update API calls will be 
> appended to existing value - if present.
> Full-update API calls will overwrite the value of the attribute, as it does 
> currently; there is no change in full-update behavior.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3712) Added 'isAppendOnPartialUpdate' option in ML model to attend updates

[Na Li (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Na Li updated ATLAS-3712:
-
Description: 
Atlas adds a new feature to allow client to append attributes during 
partial-update operation in ATLAS-3700.

We need to add 'isAppendOnPartialUpdate' option in ML model at 
[https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json]
 to append updates using this new feature.

Example:
{code:java}
{
"name":"metadata",
"typeName":"map",
"isIndexable": false,
"isOptional":  true,
"isUnique":false,
"options": {
  "isAppendOnPartialUpdate": "true"
}
  } {code}
The value specified for this attribute in partial-update API calls will be 
appended to existing value - if present.

Full-update API calls will overwrite the value of the attribute, as it does 
currently; there is no change in full-update behavior.

  was:
Atlas adds a new feature to allow client to append attributes during 
partial-update operation in ATLAS-3700.

We need to add 'isAppendOnPartialUpdate' option in ML model at 
https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json
 to append updates using this new feature.

Example:

{
"name":"metadata",
"typeName":"map",
"isIndexable": false,
"isOptional":  true,
"isUnique":false,
"options": \{
  "isAppendOnPartialUpdate": "true" <-- add this option
}
  }

The value specified for this attribute in partial-update API calls will be 
appended to existing value - if present. 

Full-update API calls will overwrite the value of the attribute, as it does 
currently; there is no change in full-update behavior.


> Added 'isAppendOnPartialUpdate' option in ML model to attend updates
> 
>
> Key: ATLAS-3712
> URL: https://issues.apache.org/jira/browse/ATLAS-3712
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
>
> Atlas adds a new feature to allow client to append attributes during 
> partial-update operation in ATLAS-3700.
> We need to add 'isAppendOnPartialUpdate' option in ML model at 
> [https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json]
>  to append updates using this new feature.
> Example:
> {code:java}
> {
> "name":"metadata",
> "typeName":"map",
> "isIndexable": false,
> "isOptional":  true,
> "isUnique":false,
> "options": {
>   "isAppendOnPartialUpdate": "true"
> }
>   } {code}
> The value specified for this attribute in partial-update API calls will be 
> appended to existing value - if present.
> Full-update API calls will overwrite the value of the attribute, as it does 
> currently; there is no change in full-update behavior.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3700) Partial update to Atlas overwrite map entry with different keys

[Na Li (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Na Li updated ATLAS-3700:
-
Description: 
*Details:*

1) The model definition is in 
"https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json#L90";

2) I created a request of type EntityCreateRequestV2. It contains an entity of 
type ml_model_build with an attribute "metadata", which is a map, and contains 
key-value entries for "engineImageTag" and "engineImageName".

3) Then I created a request of type EntityPartialUpdateRequestV2. It contains 
an entity of type ml_model_build with an attribute "metadata", which is a map, 
and contains key-value entry for "updated_at".

4) In the properties of the entity ml_model_build, the * attribute "*metadata" 
only contains key-value entry for "updated_at".

*Desired behavior:*

The attribute "metadata" should contains key-value entries for 
"engineImageTag", "engineImageName" and "updated_at".

Current behavior:

the attribute "metadata" only contains key-value entry for "updated_at".

 
 Added 'isAppendOnPartialUpdate' option in attribute-def, to enable appending 
of values to array/map type attributes during partial-update operation.

Example:
{code:java}
{
"name":"metadata",
"typeName":"map",
"isIndexable": false,
"isOptional":  true,
"isUnique":false,
"options": {
  "isAppendOnPartialUpdate": "true"
}
  }{code}
 

The value specified for this attribute in partial-update API calls will be 
appended to existing value - if present. Full-update API calls will overwrite 
the value of the attribute, as it does currently; there is no change in 
full-update behavior.

  was:
*Details:*

1) The model definition is in 
"https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json#L90";

2) I created a request of type EntityCreateRequestV2. It contains an entity of 
type ml_model_build with an attribute "metadata", which is a map, and contains 
key-value entries for "engineImageTag" and "engineImageName".

3) Then I created a request of type EntityPartialUpdateRequestV2. It contains 
an entity of type ml_model_build with an attribute "metadata", which is a map, 
and contains key-value entry for "updated_at".

4) In the properties of the entity ml_model_build, the * attribute "*metadata" 
only contains key-value entry for "updated_at".

*Desired behavior:*

The attribute "metadata" should contains key-value entries for 
"engineImageTag", "engineImageName" and "updated_at".

Current behavior:

the attribute "metadata" only contains key-value entry for "updated_at".

 
Added 'isAppendOnPartialUpdate' option in attribute-def, to enable appending of 
values to array/map type attributes during partial-update operation. Example:

{
"name":"metadata",
"typeName":"map",
"isIndexable": false,
"isOptional":  true,
"isUnique":false,
"options": \{
  "isAppendOnPartialUpdate": "true"
}
  }

The value specified for this attribute in partial-update API calls will be 
appended to existing value - if present. Full-update API calls will overwrite 
the value of the attribute, as it does currently; there is no change in 
full-update behavior.


> Partial update to Atlas overwrite map entry with different keys
> ---
>
> Key: ATLAS-3700
> URL: https://issues.apache.org/jira/browse/ATLAS-3700
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3700.003.patch, ATLAS-3700.004.patch, 
> ATLAS-3700.patch
>
>
> *Details:*
> 1) The model definition is in 
> "https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json#L90";
> 2) I created a request of type EntityCreateRequestV2. It contains an entity 
> of type ml_model_build with an attribute "metadata", which is a map, and 
> contains key-value entries for "engineImageTag" and "engineImageName".
> 3) Then I created a request of type EntityPartialUpdateRequestV2. It contains 
> an entity of type ml_model_build with an attribute "metadata", which is a 
> map, and contains key-value entry for "updated_at".
> 4) In the properties of the entity ml_model_build, the * attribute 
> "*metadata" only contains key-value entry for "updated_at".
> *Desired behavior:*
> The attribute "metadata" should contains key-value entries for 
> "engineImageTag", "engineImageName" and "updated_at".
> Current behavior:
> the attribute "metadata" only contains key-value entry for "updated_at".
>  
>  Added 'isAppendOnPartialUpdate' option in attribute-def, to enable appending 
> of values to arr

[jira] [Updated] (ATLAS-3700) Partial update to Atlas overwrite map entry with different keys

[Na Li (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Na Li updated ATLAS-3700:
-
Description: 
*Details:*

1) The model definition is in 
"https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json#L90";

2) I created a request of type EntityCreateRequestV2. It contains an entity of 
type ml_model_build with an attribute "metadata", which is a map, and contains 
key-value entries for "engineImageTag" and "engineImageName".

3) Then I created a request of type EntityPartialUpdateRequestV2. It contains 
an entity of type ml_model_build with an attribute "metadata", which is a map, 
and contains key-value entry for "updated_at".

4) In the properties of the entity ml_model_build, the * attribute "*metadata" 
only contains key-value entry for "updated_at".

*Desired behavior:*

The attribute "metadata" should contains key-value entries for 
"engineImageTag", "engineImageName" and "updated_at".

Current behavior:

the attribute "metadata" only contains key-value entry for "updated_at".

 
Added 'isAppendOnPartialUpdate' option in attribute-def, to enable appending of 
values to array/map type attributes during partial-update operation. Example:

{
"name":"metadata",
"typeName":"map",
"isIndexable": false,
"isOptional":  true,
"isUnique":false,
"options": \{
  "isAppendOnPartialUpdate": "true"
}
  }

The value specified for this attribute in partial-update API calls will be 
appended to existing value - if present. Full-update API calls will overwrite 
the value of the attribute, as it does currently; there is no change in 
full-update behavior.

  was:
*Details:*

1) The model definition is in 
"https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json#L90";

2) I created a request of type EntityCreateRequestV2. It contains an entity of 
type ml_model_build with an attribute "metadata", which is a map, and contains 
key-value entries for "engineImageTag" and "engineImageName".

3) Then I created a request of type EntityPartialUpdateRequestV2. It contains 
an entity of type ml_model_build with an attribute "metadata", which is a map, 
and contains key-value entry for "updated_at".

4) In the properties of the entity ml_model_build, the * attribute "*metadata" 
only contains key-value entry for "updated_at".

*Desired behavior:*

The attribute "metadata" should contains key-value entries for 
"engineImageTag", "engineImageName" and "updated_at".

Current behavior:

the attribute "metadata" only contains key-value entry for "updated_at".


> Partial update to Atlas overwrite map entry with different keys
> ---
>
> Key: ATLAS-3700
> URL: https://issues.apache.org/jira/browse/ATLAS-3700
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3700.003.patch, ATLAS-3700.004.patch, 
> ATLAS-3700.patch
>
>
> *Details:*
> 1) The model definition is in 
> "https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json#L90";
> 2) I created a request of type EntityCreateRequestV2. It contains an entity 
> of type ml_model_build with an attribute "metadata", which is a map, and 
> contains key-value entries for "engineImageTag" and "engineImageName".
> 3) Then I created a request of type EntityPartialUpdateRequestV2. It contains 
> an entity of type ml_model_build with an attribute "metadata", which is a 
> map, and contains key-value entry for "updated_at".
> 4) In the properties of the entity ml_model_build, the * attribute 
> "*metadata" only contains key-value entry for "updated_at".
> *Desired behavior:*
> The attribute "metadata" should contains key-value entries for 
> "engineImageTag", "engineImageName" and "updated_at".
> Current behavior:
> the attribute "metadata" only contains key-value entry for "updated_at".
>  
> Added 'isAppendOnPartialUpdate' option in attribute-def, to enable appending 
> of values to array/map type attributes during partial-update operation. 
> Example:
> {
> "name":"metadata",
> "typeName":"map",
> "isIndexable": false,
> "isOptional":  true,
> "isUnique":false,
> "options": \{
>   "isAppendOnPartialUpdate": "true"
> }
>   }
> The value specified for this attribute in partial-update API calls will be 
> appended to existing value - if present. Full-update API calls will overwrite 
> the value of the attribute, as it does currently; there is no change in 
> full-update behavior.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3712) Added 'isAppendOnPartialUpdate' option in ML model to attend updates

[Na Li (Jira)]

Na Li created ATLAS-3712:


 Summary: Added 'isAppendOnPartialUpdate' option in ML model to 
attend updates
 Key: ATLAS-3712
 URL: https://issues.apache.org/jira/browse/ATLAS-3712
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Affects Versions: 3.0.0
Reporter: Na Li
Assignee: Na Li


Atlas adds a new feature to allow client to append attributes during 
partial-update operation in ATLAS-3700.

We need to add 'isAppendOnPartialUpdate' option in ML model at 
https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json
 to append updates using this new feature.

Example:

{
"name":"metadata",
"typeName":"map",
"isIndexable": false,
"isOptional":  true,
"isUnique":false,
"options": \{
  "isAppendOnPartialUpdate": "true" <-- add this option
}
  }

The value specified for this attribute in partial-update API calls will be 
appended to existing value - if present. 

Full-update API calls will overwrite the value of the attribute, as it does 
currently; there is no change in full-update behavior.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3708) displayName field AtlasAttributeDef is not persisted

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072084#comment-17072084
 ] 

ASF subversion and git services commented on ATLAS-3708:


Commit af67bff30594f54efe5784a99024ee900ad8680c in atlas's branch 
refs/heads/branch-2.0 from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=af67bff ]

ATLAS-3708: fix to persist displayName field in AtlasAttributeDef

(cherry picked from commit 521118c82585d959cd22262d0012eb8c6b17c05a)


> displayName field AtlasAttributeDef is not persisted
> 
>
> Key: ATLAS-3708
> URL: https://issues.apache.org/jira/browse/ATLAS-3708
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0, 3.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3708.patch
>
>
> AtlasAttributeDef.displayName field was recently introduced in ATLAS-3486, 
> however this field is not persisted in the graph store hence is not populated 
> in the types loaded from graph store. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3700) Partial update to Atlas overwrite map entry with different keys

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072085#comment-17072085
 ] 

ASF subversion and git services commented on ATLAS-3700:


Commit 9e17881ae092141a6656c78c14cab6ea19728b03 in atlas's branch 
refs/heads/branch-2.0 from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=9e17881 ]

ATLAS-3700: added option to append value to array, map type attributes

(cherry picked from commit f5cd728d561a3e58a6b69c8b635e04769103a67f)


> Partial update to Atlas overwrite map entry with different keys
> ---
>
> Key: ATLAS-3700
> URL: https://issues.apache.org/jira/browse/ATLAS-3700
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3700.003.patch, ATLAS-3700.004.patch, 
> ATLAS-3700.patch
>
>
> *Details:*
> 1) The model definition is in 
> "https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json#L90";
> 2) I created a request of type EntityCreateRequestV2. It contains an entity 
> of type ml_model_build with an attribute "metadata", which is a map, and 
> contains key-value entries for "engineImageTag" and "engineImageName".
> 3) Then I created a request of type EntityPartialUpdateRequestV2. It contains 
> an entity of type ml_model_build with an attribute "metadata", which is a 
> map, and contains key-value entry for "updated_at".
> 4) In the properties of the entity ml_model_build, the * attribute 
> "*metadata" only contains key-value entry for "updated_at".
> *Desired behavior:*
> The attribute "metadata" should contains key-value entries for 
> "engineImageTag", "engineImageName" and "updated_at".
> Current behavior:
> the attribute "metadata" only contains key-value entry for "updated_at".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3700) Partial update to Atlas overwrite map entry with different keys

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072077#comment-17072077
 ] 

ASF subversion and git services commented on ATLAS-3700:


Commit f5cd728d561a3e58a6b69c8b635e04769103a67f in atlas's branch 
refs/heads/master from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f5cd728 ]

ATLAS-3700: added option to append value to array, map type attributes


> Partial update to Atlas overwrite map entry with different keys
> ---
>
> Key: ATLAS-3700
> URL: https://issues.apache.org/jira/browse/ATLAS-3700
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3700.003.patch, ATLAS-3700.004.patch, 
> ATLAS-3700.patch
>
>
> *Details:*
> 1) The model definition is in 
> "https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json#L90";
> 2) I created a request of type EntityCreateRequestV2. It contains an entity 
> of type ml_model_build with an attribute "metadata", which is a map, and 
> contains key-value entries for "engineImageTag" and "engineImageName".
> 3) Then I created a request of type EntityPartialUpdateRequestV2. It contains 
> an entity of type ml_model_build with an attribute "metadata", which is a 
> map, and contains key-value entry for "updated_at".
> 4) In the properties of the entity ml_model_build, the * attribute 
> "*metadata" only contains key-value entry for "updated_at".
> *Desired behavior:*
> The attribute "metadata" should contains key-value entries for 
> "engineImageTag", "engineImageName" and "updated_at".
> Current behavior:
> the attribute "metadata" only contains key-value entry for "updated_at".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3708) displayName field AtlasAttributeDef is not persisted

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072076#comment-17072076
 ] 

ASF subversion and git services commented on ATLAS-3708:


Commit 521118c82585d959cd22262d0012eb8c6b17c05a in atlas's branch 
refs/heads/master from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=521118c ]

ATLAS-3708: fix to persist displayName field in AtlasAttributeDef


> displayName field AtlasAttributeDef is not persisted
> 
>
> Key: ATLAS-3708
> URL: https://issues.apache.org/jira/browse/ATLAS-3708
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0, 3.0.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3708.patch
>
>
> AtlasAttributeDef.displayName field was recently introduced in ATLAS-3486, 
> however this field is not persisted in the graph store hence is not populated 
> in the types loaded from graph store. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72288: ATLAS-3700: updated attribute-def with an option to append value (instead of overwrite) during partial-updates

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72288/#review220157
---


Ship it!




Ship It!

- Sarath Subramanian


On March 31, 2020, 1:13 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72288/
> ---
> 
> (Updated March 31, 2020, 1:13 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Na Li, Mandar Ambawane, mayank, 
> Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth 
> Mishra.
> 
> 
> Bugs: ATLAS-3700
> https://issues.apache.org/jira/browse/ATLAS-3700
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added 'isAppendOnPartialUpdate' option in attribute-def, to enable appending 
> of values to array/map type attributes during partial-update operation. 
> Example:
> 
>   {
> "name":"metadata",
> "typeName":"map",
> "isIndexable": false,
> "isOptional":  true,
> "isUnique":false,
> "options": {
>   "isAppendOnPartialUpdate": "true"
> }
>   }
> 
> The value specified for this attribute in partial-update API calls will be 
> appended to existing value - if present. Full-update API calls will overwrite 
> the value of the attribute, as it does currently; there is no change in 
> full-update behavior.
> 
> 
> Diffs
> -
> 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  1434a2459 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> 1d4e37b05 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 7ec2b87e3 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  75b016cca 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasComplexAttributesTest.java
>  b682e8673 
> 
> 
> Diff: https://reviews.apache.org/r/72288/diff/1/
> 
> 
> Testing
> ---
> 
> - added tests to cover the new scenarios introduced by the new option:
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1779/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 72288: ATLAS-3700: updated attribute-def with an option to append value (instead of overwrite) during partial-updates

[Na Li via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72288/#review220156
---


Ship it!




Ship It!

- Na Li


On March 31, 2020, 8:13 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72288/
> ---
> 
> (Updated March 31, 2020, 8:13 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Na Li, Mandar Ambawane, mayank, 
> Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth 
> Mishra.
> 
> 
> Bugs: ATLAS-3700
> https://issues.apache.org/jira/browse/ATLAS-3700
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added 'isAppendOnPartialUpdate' option in attribute-def, to enable appending 
> of values to array/map type attributes during partial-update operation. 
> Example:
> 
>   {
> "name":"metadata",
> "typeName":"map",
> "isIndexable": false,
> "isOptional":  true,
> "isUnique":false,
> "options": {
>   "isAppendOnPartialUpdate": "true"
> }
>   }
> 
> The value specified for this attribute in partial-update API calls will be 
> appended to existing value - if present. Full-update API calls will overwrite 
> the value of the attribute, as it does currently; there is no change in 
> full-update behavior.
> 
> 
> Diffs
> -
> 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  1434a2459 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> 1d4e37b05 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 7ec2b87e3 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  75b016cca 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasComplexAttributesTest.java
>  b682e8673 
> 
> 
> Diff: https://reviews.apache.org/r/72288/diff/1/
> 
> 
> Testing
> ---
> 
> - added tests to cover the new scenarios introduced by the new option:
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1779/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 72288: ATLAS-3700: updated attribute-def with an option to append value (instead of overwrite) during partial-updates

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72288/#review220155
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 1357 (patched)


Duplicates will be removed if 'cardinality' is SET -  see below line #1369.


- Madhan Neethiraj


On March 31, 2020, 8:13 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72288/
> ---
> 
> (Updated March 31, 2020, 8:13 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Na Li, Mandar Ambawane, mayank, 
> Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth 
> Mishra.
> 
> 
> Bugs: ATLAS-3700
> https://issues.apache.org/jira/browse/ATLAS-3700
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added 'isAppendOnPartialUpdate' option in attribute-def, to enable appending 
> of values to array/map type attributes during partial-update operation. 
> Example:
> 
>   {
> "name":"metadata",
> "typeName":"map",
> "isIndexable": false,
> "isOptional":  true,
> "isUnique":false,
> "options": {
>   "isAppendOnPartialUpdate": "true"
> }
>   }
> 
> The value specified for this attribute in partial-update API calls will be 
> appended to existing value - if present. Full-update API calls will overwrite 
> the value of the attribute, as it does currently; there is no change in 
> full-update behavior.
> 
> 
> Diffs
> -
> 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  1434a2459 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> 1d4e37b05 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 7ec2b87e3 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  75b016cca 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasComplexAttributesTest.java
>  b682e8673 
> 
> 
> Diff: https://reviews.apache.org/r/72288/diff/1/
> 
> 
> Testing
> ---
> 
> - added tests to cover the new scenarios introduced by the new option:
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1779/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 72288: ATLAS-3700: updated attribute-def with an option to append value (instead of overwrite) during partial-updates

[Na Li via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72288/#review220154
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 1357 (patched)


do we want to remove duplication?


- Na Li


On March 31, 2020, 8:13 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72288/
> ---
> 
> (Updated March 31, 2020, 8:13 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Na Li, Mandar Ambawane, mayank, 
> Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth 
> Mishra.
> 
> 
> Bugs: ATLAS-3700
> https://issues.apache.org/jira/browse/ATLAS-3700
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added 'isAppendOnPartialUpdate' option in attribute-def, to enable appending 
> of values to array/map type attributes during partial-update operation. 
> Example:
> 
>   {
> "name":"metadata",
> "typeName":"map",
> "isIndexable": false,
> "isOptional":  true,
> "isUnique":false,
> "options": {
>   "isAppendOnPartialUpdate": "true"
> }
>   }
> 
> The value specified for this attribute in partial-update API calls will be 
> appended to existing value - if present. Full-update API calls will overwrite 
> the value of the attribute, as it does currently; there is no change in 
> full-update behavior.
> 
> 
> Diffs
> -
> 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  1434a2459 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> 1d4e37b05 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 7ec2b87e3 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  75b016cca 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasComplexAttributesTest.java
>  b682e8673 
> 
> 
> Diff: https://reviews.apache.org/r/72288/diff/1/
> 
> 
> Testing
> ---
> 
> - added tests to cover the new scenarios introduced by the new option:
> - pre-commit tests run: 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1779/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[jira] [Assigned] (ATLAS-3710) [Business Metadata] Missing Business Metadata attribute info in list view

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt reassigned ATLAS-3710:
--

Assignee: Keval Bhatt

> [Business Metadata] Missing Business Metadata attribute info in list view
> -
>
> Key: ATLAS-3710
> URL: https://issues.apache.org/jira/browse/ATLAS-3710
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Umesh Padashetty
>Assignee: Keval Bhatt
>Priority: Minor
> Fix For: 2.1.0, 3.0.0
>
> Attachments: Screenshot 2020-03-31 at 7.28.48 PM.png, Screenshot 
> 2020-03-31 at 7.29.39 PM.png
>
>
> Currently only Attribute Name, Type and Applicable Type(s) are listed in the 
> UI. Need to list Search Weight, Enable Multi values and Max length too. 
> Currently, the only way to know these attributes is to click on edit. Tedious 
> when the user wants to track multiple attributes.
> Screenshots attached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3711) UI: Classification/Term modal should close after "create/update/delete" response

[Keval Bhatt (Jira)]

Keval Bhatt created ATLAS-3711:
--

 Summary: UI: Classification/Term modal should close after 
"create/update/delete"  response
 Key: ATLAS-3711
 URL: https://issues.apache.org/jira/browse/ATLAS-3711
 Project: Atlas
  Issue Type: Improvement
Reporter: Keval Bhatt
Assignee: Keval Bhatt






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3710) [Business Metadata] Missing Business Metadata attribute info in list view

[Umesh Padashetty (Jira)]

Umesh Padashetty created ATLAS-3710:
---

 Summary: [Business Metadata] Missing Business Metadata attribute 
info in list view
 Key: ATLAS-3710
 URL: https://issues.apache.org/jira/browse/ATLAS-3710
 Project: Atlas
  Issue Type: Bug
  Components: atlas-webui
Reporter: Umesh Padashetty
 Fix For: 2.1.0, 3.0.0
 Attachments: Screenshot 2020-03-31 at 7.28.48 PM.png, Screenshot 
2020-03-31 at 7.29.39 PM.png

Currently only Attribute Name, Type and Applicable Type(s) are listed in the 
UI. Need to list Search Weight, Enable Multi values and Max length too. 

Currently, the only way to know these attributes is to click on edit. Tedious 
when the user wants to track multiple attributes.

Screenshots attached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3709) [Business Metadata] Issues with quick search/suggestions in conjunction with Business Metadata attributes

[Umesh Padashetty (Jira)]

Umesh Padashetty created ATLAS-3709:
---

 Summary: [Business Metadata] Issues with quick search/suggestions 
in conjunction with Business Metadata attributes
 Key: ATLAS-3709
 URL: https://issues.apache.org/jira/browse/ATLAS-3709
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 2.1.0, 3.0.0
Reporter: Umesh Padashetty
 Attachments: Screenshot 2020-03-31 at 6.10.14 PM.png, Screenshot 
2020-03-31 at 6.15.51 PM.png

Quick search and suggestions has been enabled on Business metadata attriibutes 
as per ATLAS-3675. But they don't seem to work as expected.

For instance, we can define search weight for each business metadatda 
attributes. And once these attributes are assigned to entities, attribute 
values should be listed in suggestions dorp down and the entities should be 
listed in quick search results.

Issues observed:
 # Under a single Business Metadata
 ## When multiple attributes are defined and added to entities (with the same 
search weight), quick search and suggestion is working only on the first 
attribute which is added to the entity. Any attributes (with same weight) which 
are added to entity later are not listed in suggestions or quick search
 ## When multiple attributes are defined and added to entities (with the 
different search weight), quick search and suggestion is working only on the 
attributes with search weight 10. Even if we first add an attribute to an 
entity which has search weight=9
 # Under 2 different Business Metadata
 ## Quick search and suggestions stops working completely on all the previous 
attributes as soon as a new Business Metadata is defined.
 ## Once I assign this newly defined business metadata, it starts working (but 
again, only for this attribute value)

Screenshots attached.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (ATLAS-3699) Update authorization for Update-Entity for audit logs for DENY policy when user-defined attributes are added.

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole resolved ATLAS-3699.

Resolution: Fixed

>  Update authorization for Update-Entity for audit logs for DENY policy when 
> user-defined attributes are added.
> --
>
> Key: ATLAS-3699
> URL: https://issues.apache.org/jira/browse/ATLAS-3699
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: chaitali borole
>Priority: Major
>
> Issue : No audit-logs are seen for Entity-update when deny policy is 
> configured in Ranger when user-defined attributes are added..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (ATLAS-3696) [Business Metadata] No option to check/uncheck Business Metadata field in search results

[Pinal (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal reassigned ATLAS-3696:


Assignee: Pinal

> [Business Metadata] No option to check/uncheck Business Metadata field in 
> search results
> 
>
> Key: ATLAS-3696
> URL: https://issues.apache.org/jira/browse/ATLAS-3696
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Umesh Padashetty
>Assignee: Pinal
>Priority: Major
> Attachments: Screenshot 2020-03-26 at 9.00.55 PM.png, Screenshot 
> 2020-03-26 at 9.04.22 PM.png
>
>
> For instance, there is no way to show "Business Metadata" column if Business 
> Metadata attribute filter is not applied while searching. Attached screenshots



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (ATLAS-3672) Search with Classification without filters and Entity with filters doesn't fetch expected results.

[Pinal (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal resolved ATLAS-3672.
--
Fix Version/s: 3.0.0
   2.1.0
   Resolution: Fixed

> Search with Classification without filters and Entity with filters doesn't 
> fetch expected results.
> --
>
> Key: ATLAS-3672
> URL: https://issues.apache.org/jira/browse/ATLAS-3672
> Project: Atlas
>  Issue Type: Bug
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: entity_filter_no_tag_filter.png, 
> no_tag_filter_no_entity_filter.png, tag_filters_no_entity_filter.png, 
> tag_filters_with_entity_filters.png
>
>
> Attached screenshots for different scenarios:
> 1 . tag filters with entity filters - works
>  2. tag filters without entity filters - works
>  3. no tag filters with entity filters - doesn't work
>  3. no tag filters no entity filters - works



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (ATLAS-3703) BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

[Pinal (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal resolved ATLAS-3703.
--
Fix Version/s: 3.0.0
   2.1.0
   Resolution: Fixed

> BasicSearch: Search by terms/Search by text in combination of Classification 
> filter, filter doesn't work
> 
>
> Key: ATLAS-3703
> URL: https://issues.apache.org/jira/browse/ATLAS-3703
> Project: Atlas
>  Issue Type: Bug
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: filter doesn't work.png, filter works.png
>
>
> Example of cases where Filters of classification doesn't work
> ClassificationType + Classification Filter + Term
> ClassificationType + Classification Filter + Text
> EntityType + Entity Filter + ClassificationType + Classification Filter + Term



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3699) Update authorization for Update-Entity for audit logs for DENY policy when user-defined attributes are added.

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071705#comment-17071705
 ] 

ASF subversion and git services commented on ATLAS-3699:


Commit f15a569626a853398ca8438f83b1fa8d5f3a36f3 in atlas's branch 
refs/heads/branch-2.0 from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f15a569 ]

ATLAS-3699 : Update authorization for Update-Entity for audit logs for DENY 
policy

Signed-off-by: nixonrodrigues 
(cherry picked from commit 37d64be5c3f88de935919b806baafa5d8e250f5b)


>  Update authorization for Update-Entity for audit logs for DENY policy when 
> user-defined attributes are added.
> --
>
> Key: ATLAS-3699
> URL: https://issues.apache.org/jira/browse/ATLAS-3699
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: chaitali borole
>Priority: Major
>
> Issue : No audit-logs are seen for Entity-update when deny policy is 
> configured in Ranger when user-defined attributes are added..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3699) Update authorization for Update-Entity for audit logs for DENY policy when user-defined attributes are added.

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071704#comment-17071704
 ] 

ASF subversion and git services commented on ATLAS-3699:


Commit 37d64be5c3f88de935919b806baafa5d8e250f5b in atlas's branch 
refs/heads/master from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=37d64be ]

ATLAS-3699 : Update authorization for Update-Entity for audit logs for DENY 
policy

Signed-off-by: nixonrodrigues 


>  Update authorization for Update-Entity for audit logs for DENY policy when 
> user-defined attributes are added.
> --
>
> Key: ATLAS-3699
> URL: https://issues.apache.org/jira/browse/ATLAS-3699
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: chaitali borole
>Priority: Major
>
> Issue : No audit-logs are seen for Entity-update when deny policy is 
> configured in Ranger when user-defined attributes are added..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3703) BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071686#comment-17071686
 ] 

ASF subversion and git services commented on ATLAS-3703:


Commit 4a3ac0020d867026859c7b4c394f9417e544dce0 in atlas's branch 
refs/heads/branch-2.0 from Pinal Shah
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=4a3ac00 ]

ATLAS-3703 : BasicSearch: Search by terms/Search by text in combination of 
Classification filter, filter doesn't work

Signed-off-by: nixonrodrigues 
(cherry picked from commit 61c2fe3ebeb7a71620bc9d0a231710d2b42aa800)


> BasicSearch: Search by terms/Search by text in combination of Classification 
> filter, filter doesn't work
> 
>
> Key: ATLAS-3703
> URL: https://issues.apache.org/jira/browse/ATLAS-3703
> Project: Atlas
>  Issue Type: Bug
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
> Attachments: filter doesn't work.png, filter works.png
>
>
> Example of cases where Filters of classification doesn't work
> ClassificationType + Classification Filter + Term
> ClassificationType + Classification Filter + Text
> EntityType + Entity Filter + ClassificationType + Classification Filter + Term



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3672) Search with Classification without filters and Entity with filters doesn't fetch expected results.

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071687#comment-17071687
 ] 

ASF subversion and git services commented on ATLAS-3672:


Commit 0bd819a9142446aa031c981fc76f27b75c1b2e58 in atlas's branch 
refs/heads/branch-2.0 from Pinal Shah
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=0bd819a ]

ATLAS-3672 : Search with Classification without filters and Entity with filters 
doesn't fetch expected results.

Signed-off-by: nixonrodrigues 
(cherry picked from commit 4d0f5ce213a49fcd8509a2ea5f6a0bb733c0c186)


> Search with Classification without filters and Entity with filters doesn't 
> fetch expected results.
> --
>
> Key: ATLAS-3672
> URL: https://issues.apache.org/jira/browse/ATLAS-3672
> Project: Atlas
>  Issue Type: Bug
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
> Attachments: entity_filter_no_tag_filter.png, 
> no_tag_filter_no_entity_filter.png, tag_filters_no_entity_filter.png, 
> tag_filters_with_entity_filters.png
>
>
> Attached screenshots for different scenarios:
> 1 . tag filters with entity filters - works
>  2. tag filters without entity filters - works
>  3. no tag filters with entity filters - doesn't work
>  3. no tag filters no entity filters - works



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3672) Search with Classification without filters and Entity with filters doesn't fetch expected results.

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071684#comment-17071684
 ] 

ASF subversion and git services commented on ATLAS-3672:


Commit 4d0f5ce213a49fcd8509a2ea5f6a0bb733c0c186 in atlas's branch 
refs/heads/master from Pinal Shah
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=4d0f5ce ]

ATLAS-3672 : Search with Classification without filters and Entity with filters 
doesn't fetch expected results.

Signed-off-by: nixonrodrigues 


> Search with Classification without filters and Entity with filters doesn't 
> fetch expected results.
> --
>
> Key: ATLAS-3672
> URL: https://issues.apache.org/jira/browse/ATLAS-3672
> Project: Atlas
>  Issue Type: Bug
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
> Attachments: entity_filter_no_tag_filter.png, 
> no_tag_filter_no_entity_filter.png, tag_filters_no_entity_filter.png, 
> tag_filters_with_entity_filters.png
>
>
> Attached screenshots for different scenarios:
> 1 . tag filters with entity filters - works
>  2. tag filters without entity filters - works
>  3. no tag filters with entity filters - doesn't work
>  3. no tag filters no entity filters - works



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3703) BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071683#comment-17071683
 ] 

ASF subversion and git services commented on ATLAS-3703:


Commit 61c2fe3ebeb7a71620bc9d0a231710d2b42aa800 in atlas's branch 
refs/heads/master from Pinal Shah
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=61c2fe3 ]

ATLAS-3703 : BasicSearch: Search by terms/Search by text in combination of 
Classification filter, filter doesn't work

Signed-off-by: nixonrodrigues 


> BasicSearch: Search by terms/Search by text in combination of Classification 
> filter, filter doesn't work
> 
>
> Key: ATLAS-3703
> URL: https://issues.apache.org/jira/browse/ATLAS-3703
> Project: Atlas
>  Issue Type: Bug
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
> Attachments: filter doesn't work.png, filter works.png
>
>
> Example of cases where Filters of classification doesn't work
> ClassificationType + Classification Filter + Term
> ClassificationType + Classification Filter + Text
> EntityType + Entity Filter + ClassificationType + Classification Filter + Term



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72280: ATLAS-3703 : BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72280/#review220149
---


Ship it!




Ship It!

- Nixon Rodrigues


On March 31, 2020, 10:49 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72280/
> ---
> 
> (Updated March 31, 2020, 10:49 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3703
> https://issues.apache.org/jira/browse/ATLAS-3703
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Example of cases where Filters of classification doesn't work
> ClassificationType + Classification Filter + Term
> ClassificationType + Classification Filter + Text
> EntityType + Entity Filter + ClassificationType + Classification Filter + Term
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  1343c9b96 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> ddd3e60d2 
> 
> 
> Diff: https://reviews.apache.org/r/72280/diff/3/
> 
> 
> Testing
> ---
> 
> Manually tested all above cases, except case where attributes are non indexed
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72253/#review220148
---


Ship it!




Ship It!

- Nixon Rodrigues


On March 31, 2020, 10:45 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72253/
> ---
> 
> (Updated March 31, 2020, 10:45 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3672
> https://issues.apache.org/jira/browse/ATLAS-3672
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' 
> for graphdb
> During fetching it was taking qualifiedName .name as the propertyKey
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> ddd3e60d2 
> 
> 
> Diff: https://reviews.apache.org/r/72253/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested below scenario:
> 1) add Entity and Entity Filters
> 2) add classification
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72280: ATLAS-3703 : BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72280/
---

(Updated March 31, 2020, 10:49 a.m.)


Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
Subramanian.


Summary (updated)
-

ATLAS-3703 : BasicSearch: Search by terms/Search by text in combination of 
Classification filter, filter doesn't work


Bugs: ATLAS-3703
https://issues.apache.org/jira/browse/ATLAS-3703


Repository: atlas


Description
---

Example of cases where Filters of classification doesn't work
ClassificationType + Classification Filter + Term
ClassificationType + Classification Filter + Text
EntityType + Entity Filter + ClassificationType + Classification Filter + Term


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
 1343c9b96 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
ddd3e60d2 


Diff: https://reviews.apache.org/r/72280/diff/3/


Testing
---

Manually tested all above cases, except case where attributes are non indexed


Thanks,

Pinal Shah

Re: Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72253/
---

(Updated March 31, 2020, 10:45 a.m.)


Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
Subramanian.


Changes
---

removed unwanted check


Bugs: ATLAS-3672
https://issues.apache.org/jira/browse/ATLAS-3672


Repository: atlas


Description
---

As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' 
for graphdb
During fetching it was taking qualifiedName .name as the propertyKey


Diffs (updated)
-

  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
ddd3e60d2 


Diff: https://reviews.apache.org/r/72253/diff/2/

Changes: https://reviews.apache.org/r/72253/diff/1-2/


Testing
---

Manually tested below scenario:
1) add Entity and Entity Filters
2) add classification


Thanks,

Pinal Shah

Re: Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

[Pinal Shah]

> On March 31, 2020, 9:12 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
> > Line 737 (original), 737 (patched)
> > 
> >
> > attr.getVertexPropertyName()  will not be null for any attribute; so no 
> > need to check and fall back to attr.getQualifiedName().

As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' 
for graphdb
attr.getQualifiedName() will not solve purpose.


- Pinal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72253/#review220143
---


On March 20, 2020, 9:37 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72253/
> ---
> 
> (Updated March 20, 2020, 9:37 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3672
> https://issues.apache.org/jira/browse/ATLAS-3672
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' 
> for graphdb
> During fetching it was taking qualifiedName .name as the propertyKey
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> ddd3e60d2 
> 
> 
> Diff: https://reviews.apache.org/r/72253/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested below scenario:
> 1) add Entity and Entity Filters
> 2) add classification
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72253/#review220143
---




repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Line 737 (original), 737 (patched)


attr.getVertexPropertyName()  will not be null for any attribute; so no 
need to check and fall back to attr.getQualifiedName().


- Madhan Neethiraj


On March 20, 2020, 9:37 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72253/
> ---
> 
> (Updated March 20, 2020, 9:37 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3672
> https://issues.apache.org/jira/browse/ATLAS-3672
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' 
> for graphdb
> During fetching it was taking qualifiedName .name as the propertyKey
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> ddd3e60d2 
> 
> 
> Diff: https://reviews.apache.org/r/72253/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested below scenario:
> 1) add Entity and Entity Filters
> 2) add classification
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72253/#review220144
---


Ship it!




Ship It!

- Madhan Neethiraj


On March 20, 2020, 9:37 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72253/
> ---
> 
> (Updated March 20, 2020, 9:37 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3672
> https://issues.apache.org/jira/browse/ATLAS-3672
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' 
> for graphdb
> During fetching it was taking qualifiedName .name as the propertyKey
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> ddd3e60d2 
> 
> 
> Diff: https://reviews.apache.org/r/72253/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested below scenario:
> 1) add Entity and Entity Filters
> 2) add classification
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72280: BasicSearch: Search by terms/Search by text in combination of Classification filter, filter doesn't work

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72280/#review220142
---


Ship it!




Ship It!

- Madhan Neethiraj


On March 31, 2020, 5:12 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72280/
> ---
> 
> (Updated March 31, 2020, 5:12 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3703
> https://issues.apache.org/jira/browse/ATLAS-3703
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Example of cases where Filters of classification doesn't work
> ClassificationType + Classification Filter + Term
> ClassificationType + Classification Filter + Text
> EntityType + Entity Filter + ClassificationType + Classification Filter + Term
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  1343c9b96 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> ddd3e60d2 
> 
> 
> Diff: https://reviews.apache.org/r/72280/diff/3/
> 
> 
> Testing
> ---
> 
> Manually tested all above cases, except case where attributes are non indexed
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

[jira] [Commented] (ATLAS-3700) Partial update to Atlas overwrite map entry with different keys

[Madhan Neethiraj (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071584#comment-17071584
 ] 

Madhan Neethiraj commented on ATLAS-3700:
-

[~linaataustin] - the ability to append to existing array/map attribute value 
is useful for other attributes as well - for example: 
{{hive_process.recentQueries}}, where the hook knows only of the current query. 
Thanks for the patch to add this capability. I think a more generic approach 
would be helpful - to allow control on specific attributes for which the value 
should be appended  (vs existing behavior of replacing the value). Please 
review this patch in the [review board|https://reviews.apache.org/r/72288/].

> Partial update to Atlas overwrite map entry with different keys
> ---
>
> Key: ATLAS-3700
> URL: https://issues.apache.org/jira/browse/ATLAS-3700
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3700.003.patch, ATLAS-3700.004.patch, 
> ATLAS-3700.patch
>
>
> *Details:*
> 1) The model definition is in 
> "https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json#L90";
> 2) I created a request of type EntityCreateRequestV2. It contains an entity 
> of type ml_model_build with an attribute "metadata", which is a map, and 
> contains key-value entries for "engineImageTag" and "engineImageName".
> 3) Then I created a request of type EntityPartialUpdateRequestV2. It contains 
> an entity of type ml_model_build with an attribute "metadata", which is a 
> map, and contains key-value entry for "updated_at".
> 4) In the properties of the entity ml_model_build, the * attribute 
> "*metadata" only contains key-value entry for "updated_at".
> *Desired behavior:*
> The attribute "metadata" should contains key-value entries for 
> "engineImageTag", "engineImageName" and "updated_at".
> Current behavior:
> the attribute "metadata" only contains key-value entry for "updated_at".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (ATLAS-3700) Partial update to Atlas overwrite map entry with different keys

[Madhan Neethiraj (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj reassigned ATLAS-3700:
---

Assignee: Madhan Neethiraj  (was: Sarath Subramanian)

> Partial update to Atlas overwrite map entry with different keys
> ---
>
> Key: ATLAS-3700
> URL: https://issues.apache.org/jira/browse/ATLAS-3700
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Na Li
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3700.003.patch, ATLAS-3700.004.patch, 
> ATLAS-3700.patch
>
>
> *Details:*
> 1) The model definition is in 
> "https://github.com/apache/atlas/blob/master/addons/models/4000-MachineLearning/4010-ml_model.json#L90";
> 2) I created a request of type EntityCreateRequestV2. It contains an entity 
> of type ml_model_build with an attribute "metadata", which is a map, and 
> contains key-value entries for "engineImageTag" and "engineImageName".
> 3) Then I created a request of type EntityPartialUpdateRequestV2. It contains 
> an entity of type ml_model_build with an attribute "metadata", which is a 
> map, and contains key-value entry for "updated_at".
> 4) In the properties of the entity ml_model_build, the * attribute 
> "*metadata" only contains key-value entry for "updated_at".
> *Desired behavior:*
> The attribute "metadata" should contains key-value entries for 
> "engineImageTag", "engineImageName" and "updated_at".
> Current behavior:
> the attribute "metadata" only contains key-value entry for "updated_at".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 72288: ATLAS-3700: updated attribute-def with an option to append value (instead of overwrite) during partial-updates

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72288/
---

Review request for atlas, Ashutosh Mestry, Na Li, Mandar Ambawane, mayank, 
Nikhil Bonte, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth 
Mishra.


Bugs: ATLAS-3700
https://issues.apache.org/jira/browse/ATLAS-3700


Repository: atlas


Description
---

Added 'isAppendOnPartialUpdate' option in attribute-def, to enable appending of 
values to array/map type attributes during partial-update operation. Example:

  {
"name":"metadata",
"typeName":"map",
"isIndexable": false,
"isOptional":  true,
"isUnique":false,
"options": {
  "isAppendOnPartialUpdate": "true"
}
  }

The value specified for this attribute in partial-update API calls will be 
appended to existing value - if present. Full-update API calls will overwrite 
the value of the attribute, as it does currently; there is no change in 
full-update behavior.


Diffs
-

  
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 
1434a2459 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
1d4e37b05 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 7ec2b87e3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 75b016cca 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasComplexAttributesTest.java
 b682e8673 


Diff: https://reviews.apache.org/r/72288/diff/1/


Testing
---

- added tests to cover the new scenarios introduced by the new option:
- pre-commit tests run: 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1779/


Thanks,

Madhan Neethiraj

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/
---

(Updated March 31, 2020, 7:28 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3689
https://issues.apache.org/jira/browse/ATLAS-3689


Repository: atlas


Description
---

Add audits entries when Namespace Attributes are added/updated/deleted to an 
entity


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
2394a12 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
9301e21 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 590f7a0 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 cab4e1e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 00c0114 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 75b016c 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
 c4dc5a1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
 2943ea9 
  
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
 6d64fec 


Diff: https://reviews.apache.org/r/72270/diff/2/

Changes: https://reviews.apache.org/r/72270/diff/1-2/


Testing
---

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console

Basic testing is done.


Thanks,

Mandar Ambawane