Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72270/#review220294 --- Ship it! Ship It! - Sarath Subramanian On April 12, 2020, 1:04 a.m., Mandar Ambawane wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72270/ > --- > > (Updated April 12, 2020, 1:04 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3689 > https://issues.apache.org/jira/browse/ATLAS-3689 > > > Repository: atlas > > > Description > --- > > Add audits entries when Namespace Attributes are added/updated/deleted to an > entity > > > Diffs > - > > dashboardv2/public/js/utils/Enums.js e2d8cd2 > dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js a820616 > intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java > 2394a12 > intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java > 9301e21 > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java > cab4e1e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java > 00c0114 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 8819688 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java > c4dc5a1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java > 2943ea9 > > webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java > 6d64fec > > > Diff: https://reviews.apache.org/r/72270/diff/6/ > > > Testing > --- > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1804/console > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1805/console > > Basic testing is done. > > > Thanks, > > Mandar Ambawane > >
[jira] [Resolved] (ATLAS-3689) Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity
[ https://issues.apache.org/jira/browse/ATLAS-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj resolved ATLAS-3689. - Fix Version/s: 3.0.0 2.1.0 Resolution: Fixed [Patch in review board.|https://reviews.apache.org/r/72270/] > Add audits entries when Business Metadata Attributes are > added/updated/deleted to an entity > --- > > Key: ATLAS-3689 > URL: https://issues.apache.org/jira/browse/ATLAS-3689 > Project: Atlas > Issue Type: Bug >Reporter: Mandar Ambawane >Assignee: Mandar Ambawane >Priority: Major > Fix For: 2.1.0, 3.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3689) Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity
[ https://issues.apache.org/jira/browse/ATLAS-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081942#comment-17081942 ] ASF subversion and git services commented on ATLAS-3689: Commit 48b056689bc19ac01f253898c37a7f444c0c6852 in atlas's branch refs/heads/branch-2.0 from Mandar Ambawane [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=48b0566 ] ATLAS-3689: added entity-audit entries on business attributes add/update/delete to an entity Signed-off-by: Madhan Neethiraj (cherry picked from commit 80135a8dbedfbaff444267681aa13d958e867c7e) > Add audits entries when Business Metadata Attributes are > added/updated/deleted to an entity > --- > > Key: ATLAS-3689 > URL: https://issues.apache.org/jira/browse/ATLAS-3689 > Project: Atlas > Issue Type: Bug >Reporter: Mandar Ambawane >Assignee: Mandar Ambawane >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3689) Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity
[ https://issues.apache.org/jira/browse/ATLAS-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081875#comment-17081875 ] ASF subversion and git services commented on ATLAS-3689: Commit 80135a8dbedfbaff444267681aa13d958e867c7e in atlas's branch refs/heads/master from Mandar Ambawane [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=80135a8 ] ATLAS-3689: added entity-audit entries on business attributes add/update/delete to an entity Signed-off-by: Madhan Neethiraj > Add audits entries when Business Metadata Attributes are > added/updated/deleted to an entity > --- > > Key: ATLAS-3689 > URL: https://issues.apache.org/jira/browse/ATLAS-3689 > Project: Atlas > Issue Type: Bug >Reporter: Mandar Ambawane >Assignee: Mandar Ambawane >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72270/#review220291 --- Ship it! Ship It! - Madhan Neethiraj On April 12, 2020, 8:04 a.m., Mandar Ambawane wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72270/ > --- > > (Updated April 12, 2020, 8:04 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3689 > https://issues.apache.org/jira/browse/ATLAS-3689 > > > Repository: atlas > > > Description > --- > > Add audits entries when Namespace Attributes are added/updated/deleted to an > entity > > > Diffs > - > > dashboardv2/public/js/utils/Enums.js e2d8cd2 > dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js a820616 > intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java > 2394a12 > intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java > 9301e21 > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java > cab4e1e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java > 00c0114 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 8819688 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java > c4dc5a1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java > 2943ea9 > > webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java > 6d64fec > > > Diff: https://reviews.apache.org/r/72270/diff/6/ > > > Testing > --- > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1804/console > > Pre-commit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1805/console > > Basic testing is done. > > > Thanks, > > Mandar Ambawane > >
Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72270/ --- (Updated April 12, 2020, 8:04 a.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra. Changes --- Addressed review comments Bugs: ATLAS-3689 https://issues.apache.org/jira/browse/ATLAS-3689 Repository: atlas Description --- Add audits entries when Namespace Attributes are added/updated/deleted to an entity Diffs (updated) - dashboardv2/public/js/utils/Enums.js e2d8cd2 dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js a820616 intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 2394a12 intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 9301e21 repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java cab4e1e repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 00c0114 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 8819688 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java c4dc5a1 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java 2943ea9 webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 6d64fec Diff: https://reviews.apache.org/r/72270/diff/6/ Changes: https://reviews.apache.org/r/72270/diff/5-6/ Testing (updated) --- Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1804/console Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1805/console Basic testing is done. Thanks, Mandar Ambawane
