Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-21 Thread Ashutosh Mestry via Review Board 


> On April 19, 2020, 11:39 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java
> > Line 272 (original), 272 (patched)
> > 
> >
> > It seems most callers of AtlasGraphUtilsV2 static methods have 
> > reference to EntityGraphRetriever. Consider moving these static methods to 
> > EntityGraphRetriever instance method, and avoid having to pass around 
> > AtlasGraph as parameter.
> > 
> > Alternatively, GraphHelper might be suitable place for these methods. I 
> > suggest to take this opportunity to get rid of static methods from here.

I attempted refactoring, but this leads to changes to few different classes. 
Hence dropping it for now.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72384/#review220362
---


On April 21, 2020, 10:33 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72384/
> ---
> 
> (Updated April 21, 2020, 10:33 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3737
> https://issues.apache.org/jira/browse/ATLAS-3737
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Please refer to JIRA for details.
> 
> **Benefits with this Approach**
> - Memory usage remains constant.
> - Cores, based on numWorkers, are utilized.
> 
> **Changes to Migration Import**
> - Instantiates 2 _EntityStoreV2_, one with non-bulk _AtlasGraph_ and other 
> with bulk loading _AtlasGraph_.
> - For entities that causes schema change (handled by _IllegalStateException_ 
> or _IllegalArgumentException_), the same entity is attempted with non-bulk 
> instantiated _EntityStoreV2_.
> 
> 
> Diffs
> -
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
>  0176ba705 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
>  24859389b 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  25042c19c 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
> 5548740d0 
>   
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java
>  172e187e4 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java
>  417c96cd8 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  bff54ede3 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> dfaa739e8 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  9c57d54de 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerDelegate.java
>  512eb4636 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  540defca9 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
>  a32b67124 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
>  e614a4e41 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  d3d9367fb 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  379150b7b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java
>  f393e515b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
>  7425ac601 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
>  a4d732af0 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java
>  05878f405 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  04da41e1a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  36bee301d 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityStateChecker.java
>  2718a0627 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
>  3b9694851 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/UniqAttrBasedEntityResolver.java
>  14ddc5d7a 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
>  ff55e40eb 
>   
>

Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-21 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72384/
---

(Updated April 22, 2020, 4:58 a.m.)


Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
---

Updates include: Addressed review comments.


Bugs: ATLAS-3737
https://issues.apache.org/jira/browse/ATLAS-3737


Repository: atlas


Description
---

**Approach**
Please refer to JIRA for details.

**Benefits with this Approach**
- Memory usage remains constant.
- Cores, based on numWorkers, are utilized.

**Changes to Migration Import**
- Instantiates 2 _EntityStoreV2_, one with non-bulk _AtlasGraph_ and other with 
bulk loading _AtlasGraph_.
- For entities that causes schema change (handled by _IllegalStateException_ or 
_IllegalArgumentException_), the same entity is attempted with non-bulk 
instantiated _EntityStoreV2_.


Diffs (updated)
-

  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
 0176ba705 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
 24859389b 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
25042c19c 
  repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
5548740d0 
  
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java
 172e187e4 
  
repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java
 417c96cd8 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 bff54ede3 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
dfaa739e8 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
9c57d54de 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerDelegate.java
 512eb4636 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 540defca9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
 a32b67124 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
 e614a4e41 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 d3d9367fb 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 379150b7b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java
 f393e515b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 7425ac601 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
 a4d732af0 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java
 05878f405 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 04da41e1a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 36bee301d 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityStateChecker.java
 2718a0627 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
 3b9694851 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/UniqAttrBasedEntityResolver.java
 14ddc5d7a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
 ff55e40eb 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/RegularImport.java
 ecce1b0e7 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java
 e0a457334 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumerBuilder.java
 69d33b21e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityCreationManager.java
 734add6d7 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ExportSkipLineageTest.java
 f8b7eda71 
  
repository/src/test/java/org/apache/atlas/repository/migration/HiveParititionTest.java
 7567daa8f 
  
repository/src/test/java/org/apache/atlas/repository/migration/HiveStocksTest.java
 90e714cb5 
  
repository/src/test/java/org/apache/atlas/repository/migration/MigrationBaseAsserts.java
 ce9056b54 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 38228a8ec 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityTestBase.java
 368951dfc 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2Test.java
 a40cf85a1

Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-21 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72384/#review220410
---




repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 215 (patched)


consider moving all private methods towards end of the class.



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 229 (patched)


createLabelsForRelationshipDefs() => createEdgeLabels(), relationDef is 
implied from the parameter type.



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 230 (patched)


I suggest to get the relationship-label from AtlasRelationshipType, as this 
may not be set in the  relationship-def.



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 242 (patched)


createLabelsForAttributesWithStructTypes() => createEdgeLabels(), entityDef 
is implied from the parameter type.



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 246 (patched)


Please verify the type-category for array<> type attributes, like 
array.



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 248 (patched)


I suggest to get relationship-label from 
AtlasAttribute.getRelationshipEdgeLabel(), instead of formatting here.



repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Line 105 (original), 101 (patched)


Please initialize maxRetries/retrySleepTimeMillis/removePropagations to 
3/1000/false respectively - in case initial assignment fails in the constructor.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
Lines 49 (patched)


atlasGraphProvider => graphProvider


- Madhan Neethiraj


On April 21, 2020, 10:33 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72384/
> ---
> 
> (Updated April 21, 2020, 10:33 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3737
> https://issues.apache.org/jira/browse/ATLAS-3737
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Please refer to JIRA for details.
> 
> **Benefits with this Approach**
> - Memory usage remains constant.
> - Cores, based on numWorkers, are utilized.
> 
> **Changes to Migration Import**
> - Instantiates 2 _EntityStoreV2_, one with non-bulk _AtlasGraph_ and other 
> with bulk loading _AtlasGraph_.
> - For entities that causes schema change (handled by _IllegalStateException_ 
> or _IllegalArgumentException_), the same entity is attempted with non-bulk 
> instantiated _EntityStoreV2_.
> 
> 
> Diffs
> -
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
>  0176ba705 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
>  24859389b 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  25042c19c 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
> 5548740d0 
>   
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java
>  172e187e4 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java
>  417c96cd8 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  bff54ede3 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> dfaa739e8 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  9c57d54de 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerDelegate.java
>  512eb4636 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  540defca9 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
>  a32b67124 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
>  e614a4e41 
>   
>

Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-21 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72384/
---

(Updated April 21, 2020, 10:33 p.m.)


Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
---

Updates include: Addressed review comments.


Bugs: ATLAS-3737
https://issues.apache.org/jira/browse/ATLAS-3737


Repository: atlas


Description
---

**Approach**
Please refer to JIRA for details.

**Benefits with this Approach**
- Memory usage remains constant.
- Cores, based on numWorkers, are utilized.

**Changes to Migration Import**
- Instantiates 2 _EntityStoreV2_, one with non-bulk _AtlasGraph_ and other with 
bulk loading _AtlasGraph_.
- For entities that causes schema change (handled by _IllegalStateException_ or 
_IllegalArgumentException_), the same entity is attempted with non-bulk 
instantiated _EntityStoreV2_.


Diffs
-

  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
 0176ba705 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
 24859389b 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
25042c19c 
  repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
5548740d0 
  
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java
 172e187e4 
  
repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java
 417c96cd8 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 bff54ede3 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
dfaa739e8 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
9c57d54de 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerDelegate.java
 512eb4636 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 540defca9 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
 a32b67124 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
 e614a4e41 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 d3d9367fb 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 379150b7b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java
 f393e515b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java
 7425ac601 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
 a4d732af0 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/ClassificationAssociator.java
 05878f405 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 04da41e1a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 36bee301d 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityStateChecker.java
 2718a0627 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
 3b9694851 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/UniqAttrBasedEntityResolver.java
 14ddc5d7a 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
 ff55e40eb 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/RegularImport.java
 ecce1b0e7 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java
 e0a457334 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumerBuilder.java
 69d33b21e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityCreationManager.java
 734add6d7 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ExportSkipLineageTest.java
 f8b7eda71 
  
repository/src/test/java/org/apache/atlas/repository/migration/HiveParititionTest.java
 7567daa8f 
  
repository/src/test/java/org/apache/atlas/repository/migration/HiveStocksTest.java
 90e714cb5 
  
repository/src/test/java/org/apache/atlas/repository/migration/MigrationBaseAsserts.java
 ce9056b54 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 38228a8ec 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityTestBase.java
 368951dfc 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2Test.java
 a40cf85a1

[jira] [Updated] (ATLAS-3747) Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sarath Subramanian (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3747:
--
Component/s:  atlas-core

> Atlas Admin Purge API should take list of guids as body with operation Put 
> instead of Delete
> 
>
> Key: ATLAS-3747
> URL: https://issues.apache.org/jira/browse/ATLAS-3747
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 2.0.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: ATLAS-3747.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3747) Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sarath Subramanian (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3747:
--
Fix Version/s: 2.1.0

> Atlas Admin Purge API should take list of guids as body with operation Put 
> instead of Delete
> 
>
> Key: ATLAS-3747
> URL: https://issues.apache.org/jira/browse/ATLAS-3747
> Project: Atlas
>  Issue Type: New Feature
>Affects Versions: 2.0.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Fix For: 2.1.0
>
> Attachments: ATLAS-3747.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3747) Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sarath Subramanian (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-3747:
--
Affects Version/s: 2.0.0

> Atlas Admin Purge API should take list of guids as body with operation Put 
> instead of Delete
> 
>
> Key: ATLAS-3747
> URL: https://issues.apache.org/jira/browse/ATLAS-3747
> Project: Atlas
>  Issue Type: New Feature
>Affects Versions: 2.0.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Attachments: ATLAS-3747.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3747) Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089108#comment-17089108
 ] 

ASF subversion and git services commented on ATLAS-3747:


Commit 5afa572376ec0204371903263ba43073ee12ea1b in atlas's branch 
refs/heads/master from sidmishra
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=5afa572 ]

ATLAS-3747: Atlas Admin Purge API will take list of guids as query param 
instead of body

Signed-off-by: Sarath Subramanian 


> Atlas Admin Purge API should take list of guids as body with operation Put 
> instead of Delete
> 
>
> Key: ATLAS-3747
> URL: https://issues.apache.org/jira/browse/ATLAS-3747
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Attachments: ATLAS-3747.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3747) Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089109#comment-17089109
 ] 

ASF subversion and git services commented on ATLAS-3747:


Commit eb5c21fa2181ced8210310a2452f86619c011930 in atlas's branch 
refs/heads/branch-2.0 from sidmishra
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=eb5c21f ]

ATLAS-3747: Atlas Admin Purge API will take list of guids as query param 
instead of body

Signed-off-by: Sarath Subramanian 
(cherry picked from commit 5afa572376ec0204371903263ba43073ee12ea1b)


> Atlas Admin Purge API should take list of guids as body with operation Put 
> instead of Delete
> 
>
> Key: ATLAS-3747
> URL: https://issues.apache.org/jira/browse/ATLAS-3747
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Attachments: ATLAS-3747.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72411: ATLAS-3747: Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72411/#review220409
---


Ship it!




Ship It!

- Sarath Subramanian


On April 21, 2020, 2:45 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72411/
> ---
> 
> (Updated April 21, 2020, 2:45 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3747
> https://issues.apache.org/jira/browse/ATLAS-3747
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3747: Atlas Admin Purge API should take list of guids as query param 
> instead of body
> 
> 
> Diffs
> -
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 
> 5a19a0b0e 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> a7d554a36 
> 
> 
> Diff: https://reviews.apache.org/r/72411/diff/2/
> 
> 
> Testing
> ---
> 
> Manual Testing:
> 
> curl -u admin:admin123 --location --request PUT 
> 'http://sid-ycloud-atlas2-1.sid-ycloud-atlas2.root.hwx.site:31000/api/atlas/admin/purge/'
>  \
> --header 'Content-Type: application/json' \
> --header 'Content-Type: application/json' \
> --header 'Cookie: ATLASSESSIONID=node0g7w7rpfe6o0a1e4e7hk5cth4d2.node0' \
> --data-raw '["bd7262f6-fed5-40f3-9f72-f57fba6b1193", 
> "24c4df6e-b27a-4c60-b85a-67ed20210446", 
> "24c4df6e-b27a-4c60-b85a-67ed20210446"]'
> 
> Note: As local jetty was failing for couple of times, I was not able to run 
> EntityV2JerseyResourceIT. precommit run will ensure if this passes.
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 72411: ATLAS-3747: Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72411/#review220408
---


Ship it!




Ship It!

- Madhan Neethiraj


On April 21, 2020, 9:45 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72411/
> ---
> 
> (Updated April 21, 2020, 9:45 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3747
> https://issues.apache.org/jira/browse/ATLAS-3747
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3747: Atlas Admin Purge API should take list of guids as query param 
> instead of body
> 
> 
> Diffs
> -
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 
> 5a19a0b0e 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> a7d554a36 
> 
> 
> Diff: https://reviews.apache.org/r/72411/diff/2/
> 
> 
> Testing
> ---
> 
> Manual Testing:
> 
> curl -u admin:admin123 --location --request PUT 
> 'http://sid-ycloud-atlas2-1.sid-ycloud-atlas2.root.hwx.site:31000/api/atlas/admin/purge/'
>  \
> --header 'Content-Type: application/json' \
> --header 'Content-Type: application/json' \
> --header 'Cookie: ATLASSESSIONID=node0g7w7rpfe6o0a1e4e7hk5cth4d2.node0' \
> --data-raw '["bd7262f6-fed5-40f3-9f72-f57fba6b1193", 
> "24c4df6e-b27a-4c60-b85a-67ed20210446", 
> "24c4df6e-b27a-4c60-b85a-67ed20210446"]'
> 
> Note: As local jetty was failing for couple of times, I was not able to run 
> EntityV2JerseyResourceIT. precommit run will ensure if this passes.
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

[jira] [Updated] (ATLAS-3747) Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sidharth Kumar Mishra (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sidharth Kumar Mishra updated ATLAS-3747:
-
Summary: Atlas Admin Purge API should take list of guids as body with 
operation Put instead of Delete  (was: Atlas Admin Purge API should take list 
of guids as query param instead of body)

> Atlas Admin Purge API should take list of guids as body with operation Put 
> instead of Delete
> 
>
> Key: ATLAS-3747
> URL: https://issues.apache.org/jira/browse/ATLAS-3747
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Attachments: ATLAS-3747.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72411: ATLAS-3747: Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72411/
---

(Updated April 21, 2020, 9:45 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Summary (updated)
-

ATLAS-3747: Atlas Admin Purge API should take list of guids as body with 
operation Put instead of Delete


Bugs: ATLAS-3747
https://issues.apache.org/jira/browse/ATLAS-3747


Repository: atlas


Description
---

ATLAS-3747: Atlas Admin Purge API should take list of guids as query param 
instead of body


Diffs
-

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 5a19a0b0e 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
a7d554a36 


Diff: https://reviews.apache.org/r/72411/diff/1/


Testing (updated)
---

Manual Testing:

curl -u admin:admin123 --location --request PUT 
'http://sid-ycloud-atlas2-1.sid-ycloud-atlas2.root.hwx.site:31000/api/atlas/admin/purge/'
 \
--header 'Content-Type: application/json' \
--header 'Content-Type: application/json' \
--header 'Cookie: ATLASSESSIONID=node0g7w7rpfe6o0a1e4e7hk5cth4d2.node0' \
--data-raw '["bd7262f6-fed5-40f3-9f72-f57fba6b1193", 
"24c4df6e-b27a-4c60-b85a-67ed20210446", "24c4df6e-b27a-4c60-b85a-67ed20210446"]'

Note: As local jetty was failing for couple of times, I was not able to run 
EntityV2JerseyResourceIT. precommit run will ensure if this passes.


Thanks,

Sidharth Mishra

Re: Review Request 72411: ATLAS-3747: Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72411/
---

(Updated April 21, 2020, 9:45 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-3747
https://issues.apache.org/jira/browse/ATLAS-3747


Repository: atlas


Description
---

ATLAS-3747: Atlas Admin Purge API should take list of guids as query param 
instead of body


Diffs (updated)
-

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 5a19a0b0e 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
a7d554a36 


Diff: https://reviews.apache.org/r/72411/diff/2/

Changes: https://reviews.apache.org/r/72411/diff/1-2/


Testing
---

Manual Testing:

curl -u admin:admin123 --location --request PUT 
'http://sid-ycloud-atlas2-1.sid-ycloud-atlas2.root.hwx.site:31000/api/atlas/admin/purge/'
 \
--header 'Content-Type: application/json' \
--header 'Content-Type: application/json' \
--header 'Cookie: ATLASSESSIONID=node0g7w7rpfe6o0a1e4e7hk5cth4d2.node0' \
--data-raw '["bd7262f6-fed5-40f3-9f72-f57fba6b1193", 
"24c4df6e-b27a-4c60-b85a-67ed20210446", "24c4df6e-b27a-4c60-b85a-67ed20210446"]'

Note: As local jetty was failing for couple of times, I was not able to run 
EntityV2JerseyResourceIT. precommit run will ensure if this passes.


Thanks,

Sidharth Mishra

Re: Review Request 72411: ATLAS-3747: Atlas Admin Purge API should take list of guids as query param instead of body

2020-04-21 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72411/#review220405
---




webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Line 465 (original), 465 (patched)


consider using @PUT with body of guids instead of guids in QueryParam, you 
are restricted with the number of guids you can supply in the query params (url 
length is limited). 

Reference: GlossaryRest:disassociateTermAssignmentFromEntities()


- Sarath Subramanian


On April 21, 2020, 1:22 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72411/
> ---
> 
> (Updated April 21, 2020, 1:22 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3747
> https://issues.apache.org/jira/browse/ATLAS-3747
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3747: Atlas Admin Purge API should take list of guids as query param 
> instead of body
> 
> 
> Diffs
> -
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 
> 5a19a0b0e 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> a7d554a36 
> 
> 
> Diff: https://reviews.apache.org/r/72411/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing:
> curl -u admin:admin123 --location --request DELETE 
> 'http://sid-ycloud-atlas2-1.sid-ycloud-atlas2.root.hwx.site:31000/api/atlas/admin/purge/?guid=82785128-778a-4e0d-aac0-8327b4ca1e87=f0cc9cfd-71af-47fc-9321-2970dfa5825f=f0cc9cfd-71af-47fc-9321-2970dfa5825f'
>  --header 'Content-Type: application/json'
> 
> Note: As local jetty was failing for couple of times, I was not able to run 
> EntityV2JerseyResourceIT. precommit run will ensure if this passes.
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 72411: ATLAS-3747: Atlas Admin Purge API should take list of guids as query param instead of body

2020-04-21 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72411/#review220404
---


Fix it, then Ship it!





client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
Line 378 (original), 378 (patched)


Consider updating callAPI() to replace List with 
Collection.  This will help avoid having to instantiate a list here.


- Madhan Neethiraj


On April 21, 2020, 8:22 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72411/
> ---
> 
> (Updated April 21, 2020, 8:22 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3747
> https://issues.apache.org/jira/browse/ATLAS-3747
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3747: Atlas Admin Purge API should take list of guids as query param 
> instead of body
> 
> 
> Diffs
> -
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 
> 5a19a0b0e 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> a7d554a36 
> 
> 
> Diff: https://reviews.apache.org/r/72411/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing:
> curl -u admin:admin123 --location --request DELETE 
> 'http://sid-ycloud-atlas2-1.sid-ycloud-atlas2.root.hwx.site:31000/api/atlas/admin/purge/?guid=82785128-778a-4e0d-aac0-8327b4ca1e87=f0cc9cfd-71af-47fc-9321-2970dfa5825f=f0cc9cfd-71af-47fc-9321-2970dfa5825f'
>  --header 'Content-Type: application/json'
> 
> Note: As local jetty was failing for couple of times, I was not able to run 
> EntityV2JerseyResourceIT. precommit run will ensure if this passes.
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Review Request 72411: ATLAS-3747: Atlas Admin Purge API should take list of guids as query param instead of body

2020-04-21 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72411/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-3747
https://issues.apache.org/jira/browse/ATLAS-3747


Repository: atlas


Description
---

ATLAS-3747: Atlas Admin Purge API should take list of guids as query param 
instead of body


Diffs
-

  client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 5a19a0b0e 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
a7d554a36 


Diff: https://reviews.apache.org/r/72411/diff/1/


Testing
---

Manual Testing:
curl -u admin:admin123 --location --request DELETE 
'http://sid-ycloud-atlas2-1.sid-ycloud-atlas2.root.hwx.site:31000/api/atlas/admin/purge/?guid=82785128-778a-4e0d-aac0-8327b4ca1e87=f0cc9cfd-71af-47fc-9321-2970dfa5825f=f0cc9cfd-71af-47fc-9321-2970dfa5825f'
 --header 'Content-Type: application/json'

Note: As local jetty was failing for couple of times, I was not able to run 
EntityV2JerseyResourceIT. precommit run will ensure if this passes.


Thanks,

Sidharth Mishra

[jira] [Created] (ATLAS-3747) Atlas Admin Purge API should take list of guids as query param instead of body

2020-04-21 Thread Sidharth Kumar Mishra (Jira) 
Sidharth Kumar Mishra created ATLAS-3747:


 Summary: Atlas Admin Purge API should take list of guids as query 
param instead of body
 Key: ATLAS-3747
 URL: https://issues.apache.org/jira/browse/ATLAS-3747
 Project: Atlas
  Issue Type: New Feature
Reporter: Sidharth Kumar Mishra






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (ATLAS-3747) Atlas Admin Purge API should take list of guids as query param instead of body

2020-04-21 Thread Sidharth Kumar Mishra (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sidharth Kumar Mishra reassigned ATLAS-3747:


Assignee: Sidharth Kumar Mishra

> Atlas Admin Purge API should take list of guids as query param instead of body
> --
>
> Key: ATLAS-3747
> URL: https://issues.apache.org/jira/browse/ATLAS-3747
> Project: Atlas
>  Issue Type: New Feature
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3746) _NOT_CLASSIFIED doesn't fetch right results

2020-04-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088938#comment-17088938
 ] 

ASF subversion and git services commented on ATLAS-3746:


Commit 887251e22ac5723c48a1eb07cbd8166bab37cd8b in atlas's branch 
refs/heads/branch-2.0 from Pinal Shah
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=887251e ]

ATLAS-3746: search for _NOT_CLASSIFIED, without typeName doesn't fetch right 
results

Signed-off-by: Madhan Neethiraj 
(cherry picked from commit 8ed641a785d42ea4d7fa2872486a6bac08b473a3)


> _NOT_CLASSIFIED doesn't fetch right results
> ---
>
> Key: ATLAS-3746
> URL: https://issues.apache.org/jira/browse/ATLAS-3746
> Project: Atlas
>  Issue Type: Bug
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>
> typename = hive_table
> classification = _NOT_CLASSIFIED
> fetches right results.
> But
> just classification = _NOT_CLASSIFIED
> doesn't fetch right results.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3746) _NOT_CLASSIFIED doesn't fetch right results

2020-04-21 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088931#comment-17088931
 ] 

ASF subversion and git services commented on ATLAS-3746:


Commit 8ed641a785d42ea4d7fa2872486a6bac08b473a3 in atlas's branch 
refs/heads/master from Pinal Shah
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=8ed641a ]

ATLAS-3746: search for _NOT_CLASSIFIED, without typeName doesn't fetch right 
results

Signed-off-by: Madhan Neethiraj 


> _NOT_CLASSIFIED doesn't fetch right results
> ---
>
> Key: ATLAS-3746
> URL: https://issues.apache.org/jira/browse/ATLAS-3746
> Project: Atlas
>  Issue Type: Bug
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>
> typename = hive_table
> classification = _NOT_CLASSIFIED
> fetches right results.
> But
> just classification = _NOT_CLASSIFIED
> doesn't fetch right results.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72396: ATLAS-3746 : _NOT_CLASSIFIED doesn't fetch right results

2020-04-21 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72396/#review220402
---


Ship it!




Ship It!

- Madhan Neethiraj


On April 21, 2020, 11:54 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72396/
> ---
> 
> (Updated April 21, 2020, 11:54 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3746
> https://issues.apache.org/jira/browse/ATLAS-3746
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> typename = hive_table
> 
> classification = _NOT_CLASSIFIED
> 
> fetches right results.
> 
> But
> 
> just classification = _NOT_CLASSIFIED
> 
> doesn't fetch any results.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/GraphIndexQueryBuilder.java
>  3f58acb9c 
> 
> 
> Diff: https://reviews.apache.org/r/72396/diff/1/
> 
> 
> Testing
> ---
> 
> Tested below combination manually
> 
> 1) classification = _NOT_CLASSIFIED -> working
> 2) typeName = hive_table, classification = _NOT_CLASSIFIED -> working
> 3) typeName = hive_table, Entity Filters, classification = _NOT_CLASSIFIED -> 
> working
> 4) typeName = hive_table, classification = _NOT_CLASSIFIED, 
> classificationFilters -> **results will not show up because classification 
> filter on _NOT_CLASSIFIED classification doesn't make sense**
> 5) classification = _NOT_CLASSIFIED, classificationFilters -> **results will 
> not show up because classification filter on _NOT_CLASSIFIED classification 
> doesn't make sense**
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Review Request 72396: ATLAS-3746 : _NOT_CLASSIFIED doesn't fetch right results

2020-04-21 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72396/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3746
https://issues.apache.org/jira/browse/ATLAS-3746


Repository: atlas


Description
---

typename = hive_table

classification = _NOT_CLASSIFIED

fetches right results.

But

just classification = _NOT_CLASSIFIED

doesn't fetch any results.


Diffs
-

  
repository/src/main/java/org/apache/atlas/discovery/GraphIndexQueryBuilder.java 
3f58acb9c 


Diff: https://reviews.apache.org/r/72396/diff/1/


Testing
---

Tested below combination manually

1) classification = _NOT_CLASSIFIED -> working
2) typeName = hive_table, classification = _NOT_CLASSIFIED -> working
3) typeName = hive_table, Entity Filters, classification = _NOT_CLASSIFIED -> 
working
4) typeName = hive_table, classification = _NOT_CLASSIFIED, 
classificationFilters -> **results will not show up because classification 
filter on _NOT_CLASSIFIED classification doesn't make sense**
5) classification = _NOT_CLASSIFIED, classificationFilters -> **results will 
not show up because classification filter on _NOT_CLASSIFIED classification 
doesn't make sense**


Thanks,

Pinal Shah

[jira] [Created] (ATLAS-3746) _NOT_CLASSIFIED doesn't fetch right results

2020-04-21 Thread Pinal (Jira) 
Pinal created ATLAS-3746:


 Summary: _NOT_CLASSIFIED doesn't fetch right results
 Key: ATLAS-3746
 URL: https://issues.apache.org/jira/browse/ATLAS-3746
 Project: Atlas
  Issue Type: Bug
Reporter: Pinal
Assignee: Pinal


typename = hive_table

classification = _NOT_CLASSIFIED

fetches right results.

But

just classification = _NOT_CLASSIFIED

doesn't fetch right results.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (ATLAS-3744) [Beta UI] Long entity type filter load time

2020-04-21 Thread Madhan Neethiraj (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj reassigned ATLAS-3744:
---

Assignee: Keval Bhatt

> [Beta UI] Long entity type filter load time 
> 
>
> Key: ATLAS-3744
> URL: https://issues.apache.org/jira/browse/ATLAS-3744
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Umesh Padashetty
>Assignee: Keval Bhatt
>Priority: Major
> Attachments: Screenshot 2020-04-20 at 12.57.05 PM.png, Screenshot 
> 2020-04-20 at 12.57.16 PM.png
>
>
> Sometimes, we are taking around 15-20 seconds to load the entity type filters 
> in the new Beta UI when the user clicks on Filters drop down. Once the user 
> clicks on Filters, the UI just freezes there, while the content is loaded in 
> the background. This gives a feeling to the end-user that nothing is 
> happening and the UI is stuck, while in reality it isnt. This is pretty 
> confusing.
> I think it is a good idea to introduce a loading icon while the data is being 
> loaded in the backend.
> Attached screenshots. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)